public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Peter Kjellerstedt" <peter.kjellerstedt@axis.com>
To: Kory Maincent <kory.maincent@bootlin.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Cc: "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>
Subject: Re: [OE-core] [PATCH v2] ltp: fix rpc build error
Date: Thu, 17 Dec 2020 16:21:20 +0000	[thread overview]
Message-ID: <ce781b6c4aa644f3ba1f322396065bcb@XBOX03.axis.com> (raw)
In-Reply-To: <20201217140756.30688-1-kory.maincent@bootlin.com>

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Kory Maincent
> Sent: den 17 december 2020 15:08
> To: openembedded-core@lists.openembedded.org
> Cc: thomas.petazzoni@bootlin.com
> Subject: [OE-core] [PATCH v2] ltp: fix rpc build error
> 
> Add support to tirpc tests build.
> Export incdir and libdir to have the right path.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change since v1:
>  - Use PACKAGECONFIG to enable rpc tests
>  - Improve ${libdir} and ${incdir} export
> 
> 
>  meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb b/meta/recipes-
> extended/ltp/ltp_20200930.bb
> index 7acf15b360..9da5d90353 100644
> --- a/meta/recipes-extended/ltp/ltp_20200930.bb
> +++ b/meta/recipes-extended/ltp/ltp_20200930.bb
> @@ -42,14 +42,14 @@ inherit autotools-brokensep pkgconfig
> 
>  TARGET_CC_ARCH += "${LDFLAGS}"
> 
> +export libdir := "${exec_prefix}/${baselib}"
> +export incdir := "${exec_prefix}/include"

This should be a little bit better:

export libdir := "${libdir}"
export incdir := "${incdir}"

>  export prefix = "/opt/${PN}"
> -export exec_prefix = "/opt/${PN}"
> 
>  PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
> +PACKAGECONFIG[rpc] = ", --without-tirpc, virtual/librpc,"

I assume there is a --with-tirpc as well, so this should be:

PACKAGECONFIG[rpc] = "--with-tirpc, --without-tirpc, virtual/librpc,"

>  EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"
>  EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "
> -# ltp network/rpc test cases ftbfs when libtirpc is found
> -EXTRA_OECONF += " --without-tirpc "
> 
>  do_install(){
>      install -d ${D}${prefix}/
> --
> 2.17.1

//Peter


  reply	other threads:[~2020-12-17 16:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 14:07 [PATCH v2] ltp: fix rpc build error Kory Maincent
2020-12-17 16:21 ` Peter Kjellerstedt [this message]
2020-12-18  8:52   ` [OE-core] " Kory Maincent
2020-12-18 12:06     ` Peter Kjellerstedt
2020-12-18 14:07       ` Kory Maincent
2020-12-18 18:59         ` Peter Kjellerstedt
2020-12-18 13:36 ` Richard Purdie
2020-12-19 11:03   ` Kory Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce781b6c4aa644f3ba1f322396065bcb@XBOX03.axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=kory.maincent@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox