* [PATCH] core-image-basic.bb: Allow user extensions
@ 2013-10-30 14:22 Gary Thomas
2013-10-30 14:47 ` Paul Eggleton
0 siblings, 1 reply; 6+ messages in thread
From: Gary Thomas @ 2013-10-30 14:22 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Allow the user to provide additional packages to this image.
This lets core-image-basic behave like all other core-image*
recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
as match the documentation which suggests this as the mode to
extend any core-image* image.
Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
meta/recipes-extended/images/core-image-basic.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta/recipes-extended/images/core-image-basic.bb b/meta/recipes-extended/images/core-image-basic.bb
index 091f57d..e393a28 100644
--- a/meta/recipes-extended/images/core-image-basic.bb
+++ b/meta/recipes-extended/images/core-image-basic.bb
@@ -3,9 +3,12 @@ functionality installed."
IMAGE_FEATURES += "splash ssh-server-openssh"
+CORE_IMAGE_EXTRA_INSTALL ?= ""
+
IMAGE_INSTALL = "\
packagegroup-core-boot \
packagegroup-core-basic \
+ ${CORE_IMAGE_EXTRA_INSTALL} \
"
inherit core-image
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] core-image-basic.bb: Allow user extensions
2013-10-30 14:22 [PATCH] core-image-basic.bb: Allow user extensions Gary Thomas
@ 2013-10-30 14:47 ` Paul Eggleton
2013-10-30 14:55 ` Gary Thomas
0 siblings, 1 reply; 6+ messages in thread
From: Paul Eggleton @ 2013-10-30 14:47 UTC (permalink / raw)
To: Gary Thomas; +Cc: openembedded-core
Hi Gary,
On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
> Allow the user to provide additional packages to this image.
> This lets core-image-basic behave like all other core-image*
> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
> as match the documentation which suggests this as the mode to
> extend any core-image* image.
>
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
> meta/recipes-extended/images/core-image-basic.bb | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-extended/images/core-image-basic.bb
> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
> 100644
> --- a/meta/recipes-extended/images/core-image-basic.bb
> +++ b/meta/recipes-extended/images/core-image-basic.bb
> @@ -3,9 +3,12 @@ functionality installed."
> IMAGE_FEATURES += "splash ssh-server-openssh"
> +CORE_IMAGE_EXTRA_INSTALL ?= ""
> +
Not sure if it's my mail client but the above looks slightly mangled; in any
case the above addition shouldn't be needed because core-image.bbclass already
does this.
> IMAGE_INSTALL = "\
> packagegroup-core-boot \
> packagegroup-core-basic \
> + ${CORE_IMAGE_EXTRA_INSTALL} \
> "
> inherit core-image
Good catch on this one though.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] core-image-basic.bb: Allow user extensions
2013-10-30 14:47 ` Paul Eggleton
@ 2013-10-30 14:55 ` Gary Thomas
2013-10-30 15:33 ` Paul Eggleton
0 siblings, 1 reply; 6+ messages in thread
From: Gary Thomas @ 2013-10-30 14:55 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
On 2013-10-30 08:47, Paul Eggleton wrote:
> Hi Gary,
>
> On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
>> Allow the user to provide additional packages to this image.
>> This lets core-image-basic behave like all other core-image*
>> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
>> as match the documentation which suggests this as the mode to
>> extend any core-image* image.
>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>> ---
>> meta/recipes-extended/images/core-image-basic.bb | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/meta/recipes-extended/images/core-image-basic.bb
>> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
>> 100644
>> --- a/meta/recipes-extended/images/core-image-basic.bb
>> +++ b/meta/recipes-extended/images/core-image-basic.bb
>> @@ -3,9 +3,12 @@ functionality installed."
>> IMAGE_FEATURES += "splash ssh-server-openssh"
>> +CORE_IMAGE_EXTRA_INSTALL ?= ""
>> +
>
> Not sure if it's my mail client but the above looks slightly mangled; in any
> case the above addition shouldn't be needed because core-image.bbclass already
> does this.
Are you sure it counts? core-image.bbclass is included after this would be evaluated,
or does that not matter?
>
>> IMAGE_INSTALL = "\
>> packagegroup-core-boot \
>> packagegroup-core-basic \
>> + ${CORE_IMAGE_EXTRA_INSTALL} \
>> "
>> inherit core-image
>
> Good catch on this one though.
>
> Cheers,
> Paul
>
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] core-image-basic.bb: Allow user extensions
2013-10-30 14:55 ` Gary Thomas
@ 2013-10-30 15:33 ` Paul Eggleton
2013-10-30 15:40 ` Gary Thomas
0 siblings, 1 reply; 6+ messages in thread
From: Paul Eggleton @ 2013-10-30 15:33 UTC (permalink / raw)
To: Gary Thomas; +Cc: openembedded-core
On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote:
> On 2013-10-30 08:47, Paul Eggleton wrote:
> > On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
> >> Allow the user to provide additional packages to this image.
> >> This lets core-image-basic behave like all other core-image*
> >> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
> >> as match the documentation which suggests this as the mode to
> >> extend any core-image* image.
> >>
> >> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> >> ---
> >>
> >> meta/recipes-extended/images/core-image-basic.bb | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/meta/recipes-extended/images/core-image-basic.bb
> >> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
> >> 100644
> >> --- a/meta/recipes-extended/images/core-image-basic.bb
> >> +++ b/meta/recipes-extended/images/core-image-basic.bb
> >> @@ -3,9 +3,12 @@ functionality installed."
> >>
> >> IMAGE_FEATURES += "splash ssh-server-openssh"
> >>
> >> +CORE_IMAGE_EXTRA_INSTALL ?= ""
> >>
> >> +
> >
> > Not sure if it's my mail client but the above looks slightly mangled; in
> > any case the above addition shouldn't be needed because
> > core-image.bbclass already does this.
>
> Are you sure it counts? core-image.bbclass is included after this would be
> evaluated, or does that not matter?
It doesn't matter in most cases, because the value won't actually be expanded
until later. Values aren't expanded unless you use immediate expansion (the :=
operator) or you d.getVar("SOMEVAR", True) is called from python code to
return the expanded value.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] core-image-basic.bb: Allow user extensions
2013-10-30 15:33 ` Paul Eggleton
@ 2013-10-30 15:40 ` Gary Thomas
2013-10-30 15:42 ` Paul Eggleton
0 siblings, 1 reply; 6+ messages in thread
From: Gary Thomas @ 2013-10-30 15:40 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
On 2013-10-30 09:33, Paul Eggleton wrote:
> On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote:
>> On 2013-10-30 08:47, Paul Eggleton wrote:
>>> On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
>>>> Allow the user to provide additional packages to this image.
>>>> This lets core-image-basic behave like all other core-image*
>>>> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
>>>> as match the documentation which suggests this as the mode to
>>>> extend any core-image* image.
>>>>
>>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>>>> ---
>>>>
>>>> meta/recipes-extended/images/core-image-basic.bb | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/meta/recipes-extended/images/core-image-basic.bb
>>>> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
>>>> 100644
>>>> --- a/meta/recipes-extended/images/core-image-basic.bb
>>>> +++ b/meta/recipes-extended/images/core-image-basic.bb
>>>> @@ -3,9 +3,12 @@ functionality installed."
>>>>
>>>> IMAGE_FEATURES += "splash ssh-server-openssh"
>>>>
>>>> +CORE_IMAGE_EXTRA_INSTALL ?= ""
>>>>
>>>> +
>>>
>>> Not sure if it's my mail client but the above looks slightly mangled; in
>>> any case the above addition shouldn't be needed because
>>> core-image.bbclass already does this.
>>
>> Are you sure it counts? core-image.bbclass is included after this would be
>> evaluated, or does that not matter?
>
> It doesn't matter in most cases, because the value won't actually be expanded
> until later. Values aren't expanded unless you use immediate expansion (the :=
> operator) or you d.getVar("SOMEVAR", True) is called from python code to
> return the expanded value.
Understood, thanks.
Should I send another patch with that line removed?
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] core-image-basic.bb: Allow user extensions
2013-10-30 15:40 ` Gary Thomas
@ 2013-10-30 15:42 ` Paul Eggleton
0 siblings, 0 replies; 6+ messages in thread
From: Paul Eggleton @ 2013-10-30 15:42 UTC (permalink / raw)
To: Gary Thomas; +Cc: openembedded-core
On Wednesday 30 October 2013 09:40:09 Gary Thomas wrote:
> On 2013-10-30 09:33, Paul Eggleton wrote:
> > On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote:
> >> On 2013-10-30 08:47, Paul Eggleton wrote:
> >>> On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
> >>>> Allow the user to provide additional packages to this image.
> >>>> This lets core-image-basic behave like all other core-image*
> >>>> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
> >>>> as match the documentation which suggests this as the mode to
> >>>> extend any core-image* image.
> >>>>
> >>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> >>>> ---
> >>>>
> >>>> meta/recipes-extended/images/core-image-basic.bb | 3 +++
> >>>> 1 file changed, 3 insertions(+)
> >>>>
> >>>> diff --git a/meta/recipes-extended/images/core-image-basic.bb
> >>>> b/meta/recipes-extended/images/core-image-basic.bb index
> >>>> 091f57d..e393a28
> >>>> 100644
> >>>> --- a/meta/recipes-extended/images/core-image-basic.bb
> >>>> +++ b/meta/recipes-extended/images/core-image-basic.bb
> >>>> @@ -3,9 +3,12 @@ functionality installed."
> >>>>
> >>>> IMAGE_FEATURES += "splash ssh-server-openssh"
> >>>>
> >>>> +CORE_IMAGE_EXTRA_INSTALL ?= ""
> >>>>
> >>>> +
> >>>
> >>> Not sure if it's my mail client but the above looks slightly mangled; in
> >>> any case the above addition shouldn't be needed because
> >>> core-image.bbclass already does this.
> >>
> >> Are you sure it counts? core-image.bbclass is included after this would
> >> be evaluated, or does that not matter?
> >
> > It doesn't matter in most cases, because the value won't actually be
> > expanded until later. Values aren't expanded unless you use immediate
> > expansion (the := operator) or you d.getVar("SOMEVAR", True) is called
> > from python code to return the expanded value.
>
> Understood, thanks.
>
> Should I send another patch with that line removed?
Yes please.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-30 15:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-30 14:22 [PATCH] core-image-basic.bb: Allow user extensions Gary Thomas
2013-10-30 14:47 ` Paul Eggleton
2013-10-30 14:55 ` Gary Thomas
2013-10-30 15:33 ` Paul Eggleton
2013-10-30 15:40 ` Gary Thomas
2013-10-30 15:42 ` Paul Eggleton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox