* [PATCH 0/1] Small create-pull-request fix
@ 2011-05-31 15:48 Martin Jansa
2011-05-31 15:48 ` [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://' Martin Jansa
2011-06-03 0:05 ` [PATCH 0/1] Small create-pull-request fix Saul Wold
0 siblings, 2 replies; 6+ messages in thread
From: Martin Jansa @ 2011-05-31 15:48 UTC (permalink / raw)
To: openembedded-core
The following changes since commit 26e5e5feb695864b11e47e24017e254c28f14494:
Improve handling of 'all' architecture recipes and their interaction with sstate (2011-05-31 12:56:38 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib jansa/pull
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/pull
Martin Jansa (1):
create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://'
scripts/create-pull-request | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
1.7.5.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://'
2011-05-31 15:48 [PATCH 0/1] Small create-pull-request fix Martin Jansa
@ 2011-05-31 15:48 ` Martin Jansa
2011-06-03 5:38 ` Darren Hart
2011-06-03 0:05 ` [PATCH 0/1] Small create-pull-request fix Saul Wold
1 sibling, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2011-05-31 15:48 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
scripts/create-pull-request | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/create-pull-request b/scripts/create-pull-request
index 19b640f..d52098e 100755
--- a/scripts/create-pull-request
+++ b/scripts/create-pull-request
@@ -102,7 +102,7 @@ while getopts "b:chi:m:o:p:r:s:u:" OPT; do
case "$REMOTE_URL" in
*@*)
USER_RE="[A-Za-z0-9_.@][A-Za-z0-9_.@-]*\$\?"
- PROTO_RE="[a-z][a-z]*://"
+ PROTO_RE="[a-z][a-z+]*://"
GIT_RE="\(^\($PROTO_RE\)\?$USER_RE@\)\([^:/]*\)[:/]\(.*\)"
REMOTE_URL=${REMOTE_URL%.git}
REMOTE_REPO=$(echo $REMOTE_URL | sed "s#$GIT_RE#\4#")
--
1.7.5.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/1] Small create-pull-request fix
2011-05-31 15:48 [PATCH 0/1] Small create-pull-request fix Martin Jansa
2011-05-31 15:48 ` [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://' Martin Jansa
@ 2011-06-03 0:05 ` Saul Wold
1 sibling, 0 replies; 6+ messages in thread
From: Saul Wold @ 2011-06-03 0:05 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Martin Jansa
On 05/31/2011 08:48 AM, Martin Jansa wrote:
> The following changes since commit 26e5e5feb695864b11e47e24017e254c28f14494:
>
> Improve handling of 'all' architecture recipes and their interaction with sstate (2011-05-31 12:56:38 +0100)
>
> are available in the git repository at:
> git://git.openembedded.org/openembedded-core-contrib jansa/pull
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/pull
>
> Martin Jansa (1):
> create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://'
>
> scripts/create-pull-request | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Merged into oe-core
Thanks
Sau!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://'
2011-05-31 15:48 ` [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://' Martin Jansa
@ 2011-06-03 5:38 ` Darren Hart
2011-06-03 6:03 ` Martin Jansa
0 siblings, 1 reply; 6+ messages in thread
From: Darren Hart @ 2011-06-03 5:38 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Martin Jansa
Hi Martin,
No objection if this is a valid URL. I didn't include this because 1) I
didn't know about it and 2) it isn't listed in the git pull man page,
which is what I developed to. Is git+ssh... equivalent to ssh:// ?
As a minor nit, please include a body message for anything more
complicated than whitespace or typographical fixes.
Thanks,
--
Darren
On 05/31/2011 08:48 AM, Martin Jansa wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> scripts/create-pull-request | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/create-pull-request b/scripts/create-pull-request
> index 19b640f..d52098e 100755
> --- a/scripts/create-pull-request
> +++ b/scripts/create-pull-request
> @@ -102,7 +102,7 @@ while getopts "b:chi:m:o:p:r:s:u:" OPT; do
> case "$REMOTE_URL" in
> *@*)
> USER_RE="[A-Za-z0-9_.@][A-Za-z0-9_.@-]*\$\?"
> - PROTO_RE="[a-z][a-z]*://"
> + PROTO_RE="[a-z][a-z+]*://"
> GIT_RE="\(^\($PROTO_RE\)\?$USER_RE@\)\([^:/]*\)[:/]\(.*\)"
> REMOTE_URL=${REMOTE_URL%.git}
> REMOTE_REPO=$(echo $REMOTE_URL | sed "s#$GIT_RE#\4#")
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://'
2011-06-03 5:38 ` Darren Hart
@ 2011-06-03 6:03 ` Martin Jansa
2011-06-03 6:40 ` Darren Hart
0 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2011-06-03 6:03 UTC (permalink / raw)
To: Darren Hart; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]
On Thu, Jun 02, 2011 at 10:38:11PM -0700, Darren Hart wrote:
> Hi Martin,
Hi Darren,
> No objection if this is a valid URL. I didn't include this because 1) I
> didn't know about it and 2) it isn't listed in the git pull man page,
> which is what I developed to. Is git+ssh... equivalent to ssh:// ?
before this change my pull requests had url like this
are available in the git repository at:
git+ssh://git@git.openembedded.org/meta-openembedded-contrib jansa/meta-oe
http://cgit.openembedded.org/cgit.cgi/git+ssh://git@git.openembedded.org/meta-openembedded-contrib/log/?h=jansa/meta-oe
because RE wasn't matching my URL at all
OE @ ~/shr-core/openembedded-core $ git config remote.contrib.url
git+ssh://git@git.openembedded.org/openembedded-core-contrib
IMHO this is equivalent to ssh:// or git@ without protocol but haven't
checked documentation to be sure. But I'm sure this is valid and that
this works right (as I'm able to push to contrib).
> As a minor nit, please include a body message for anything more
> complicated than whitespace or typographical fixes.
I use git+ssh:// for many projects so I'm used to it, so I expected that
this is widely used and this patch would be clear enough.
Regards,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://'
2011-06-03 6:03 ` Martin Jansa
@ 2011-06-03 6:40 ` Darren Hart
0 siblings, 0 replies; 6+ messages in thread
From: Darren Hart @ 2011-06-03 6:40 UTC (permalink / raw)
To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer
On 06/02/2011 11:03 PM, Martin Jansa wrote:
> On Thu, Jun 02, 2011 at 10:38:11PM -0700, Darren Hart wrote:
>> Hi Martin,
>
> Hi Darren,
>
>> No objection if this is a valid URL. I didn't include this because 1) I
>> didn't know about it and 2) it isn't listed in the git pull man page,
>> which is what I developed to. Is git+ssh... equivalent to ssh:// ?
>
> before this change my pull requests had url like this
> are available in the git repository at:
> git+ssh://git@git.openembedded.org/meta-openembedded-contrib jansa/meta-oe
> http://cgit.openembedded.org/cgit.cgi/git+ssh://git@git.openembedded.org/meta-openembedded-contrib/log/?h=jansa/meta-oe
>
> because RE wasn't matching my URL at all
>
> OE @ ~/shr-core/openembedded-core $ git config remote.contrib.url
> git+ssh://git@git.openembedded.org/openembedded-core-contrib
>
> IMHO this is equivalent to ssh:// or git@ without protocol but haven't
> checked documentation to be sure. But I'm sure this is valid and that
> this works right (as I'm able to push to contrib).
>
I'm sure the patch is fine - I was just surprised git pull didn't
document the URL. It's already been pulled as well I believe.
>> As a minor nit, please include a body message for anything more
>> complicated than whitespace or typographical fixes.
>
> I use git+ssh:// for many projects so I'm used to it, so I expected that
> this is widely used and this patch would be clear enough.
As I said, it's a nit, but it is consistent with guidelines used in many
other projects. Cramming too much into the subject line makes the git
log hard to read - especially as git doesn't wrap long lines - perhaps
due to the prejudices of the authors ;-) Yours doesn't truncate,
but it comes close. Anyway, dead horse and all that.
Thanks for the fix.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-03 6:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-31 15:48 [PATCH 0/1] Small create-pull-request fix Martin Jansa
2011-05-31 15:48 ` [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://' Martin Jansa
2011-06-03 5:38 ` Darren Hart
2011-06-03 6:03 ` Martin Jansa
2011-06-03 6:40 ` Darren Hart
2011-06-03 0:05 ` [PATCH 0/1] Small create-pull-request fix Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox