[PATCH 0/2] perf recipe update

[PATCH 0/2] perf recipe update

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@linux.intel.com>

With the 3.8 kernel update, we need a new perf recipe to match.   Well,
not really, because there's nothing 3.4-specific about the current one,
and there's nothing tying it to a specific version of the kernel.

This acknowledges that by getting rid fo the version number.  It also
adds a minor cleanup to rename the current include file to something
more appropriate.

The following changes since commit d823759b4594143d522eae0b2a2498436a6dcb1e:

  core-image.bbclass: support read-only rootfs (2013-03-07 11:20:02 +0000)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib.git tzanussi/rename-perf-v0
  http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/rename-perf-v0

Tom Zanussi (2):
  perf: rename perf.inc to perf-features.inc
  perf: rename perf_3.4 to perf

 meta/recipes-kernel/perf/{perf.inc => perf-features.inc} | 0
 meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb}        | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-kernel/perf/{perf.inc => perf-features.inc} (100%)
 rename meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} (99%)

-- 
1.7.11.4

[PATCH 1/2] perf: rename perf.inc to perf-features.inc

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@linux.intel.com>

The contents of perf.inc are really specific to perf features and
shouldn't use the generic perf.inc name, which implies common recipe
code.  It's always confusing to open up this file and find out that's
not what it is.

Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
 meta/recipes-kernel/perf/{perf.inc => perf-features.inc} | 0
 meta/recipes-kernel/perf/perf_3.4.bb                     | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-kernel/perf/{perf.inc => perf-features.inc} (100%)

diff --git a/meta/recipes-kernel/perf/perf.inc b/meta/recipes-kernel/perf/perf-features.inc
similarity index 100%
rename from meta/recipes-kernel/perf/perf.inc
rename to meta/recipes-kernel/perf/perf-features.inc
diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb
index 22feb46..3c49922 100644
--- a/meta/recipes-kernel/perf/perf_3.4.bb
+++ b/meta/recipes-kernel/perf/perf_3.4.bb
@@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
 PR = "r8"
 
-require perf.inc
+require perf-features.inc
 
 BUILDPERF_libc-uclibc = "no"
 
-- 
1.7.11.4

[PATCH 2/2] perf: rename perf_3.4 to perf

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@linux.intel.com>

There's nothing kernel-version-specific about the perf_3.4 recipe, so
it's actually misnamed and misleading now that it also gets used with
the 3.8 kernel.

Since the recipe isn't tied to a specific PV, and simply uses
whatever's in STAGING_KERNEL_DIR, there's no reason to add anything
else either to the bare PN, so just use that as the recipe name.

Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
 meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} (100%)

diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf.bb
similarity index 100%
rename from meta/recipes-kernel/perf/perf_3.4.bb
rename to meta/recipes-kernel/perf/perf.bb
-- 
1.7.11.4

Re: [PATCH 0/2] perf recipe update

[Bruce Ashfield]

On Thu, Mar 7, 2013 at 7:38 PM,  <tom.zanussi@linux.intel.com> wrote:
> From: Tom Zanussi <tom.zanussi@linux.intel.com>
>
> With the 3.8 kernel update, we need a new perf recipe to match.   Well,
> not really, because there's nothing 3.4-specific about the current one,
> and there's nothing tying it to a specific version of the kernel.
>
> This acknowledges that by getting rid fo the version number.  It also
> adds a minor cleanup to rename the current include file to something
> more appropriate.

Looks good Tom. Thanks for taking care of this.

Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

>
> The following changes since commit d823759b4594143d522eae0b2a2498436a6dcb1e:
>
>   core-image.bbclass: support read-only rootfs (2013-03-07 11:20:02 +0000)
>
> are available in the git repository at:
>
>   git://git.yoctoproject.org/poky-contrib.git tzanussi/rename-perf-v0
>   http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/rename-perf-v0
>
> Tom Zanussi (2):
>   perf: rename perf.inc to perf-features.inc
>   perf: rename perf_3.4 to perf
>
>  meta/recipes-kernel/perf/{perf.inc => perf-features.inc} | 0
>  meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb}        | 2 +-
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename meta/recipes-kernel/perf/{perf.inc => perf-features.inc} (100%)
>  rename meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} (99%)
>
> --
> 1.7.11.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Re: [PATCH 0/2] perf recipe update

[Darren Hart]

On 03/07/2013 05:06 PM, Bruce Ashfield wrote:
> On Thu, Mar 7, 2013 at 7:38 PM,  <tom.zanussi@linux.intel.com> wrote:
>> From: Tom Zanussi <tom.zanussi@linux.intel.com>
>>
>> With the 3.8 kernel update, we need a new perf recipe to match.   Well,
>> not really, because there's nothing 3.4-specific about the current one,
>> and there's nothing tying it to a specific version of the kernel.
>>
>> This acknowledges that by getting rid fo the version number.  It also
>> adds a minor cleanup to rename the current include file to something
>> more appropriate.
> 
> Looks good Tom. Thanks for taking care of this.
> 
> Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

Acked-by: Darren Hart <dvhart@linux.intel.com>

> 
>>
>> The following changes since commit d823759b4594143d522eae0b2a2498436a6dcb1e:
>>
>>   core-image.bbclass: support read-only rootfs (2013-03-07 11:20:02 +0000)
>>
>> are available in the git repository at:
>>
>>   git://git.yoctoproject.org/poky-contrib.git tzanussi/rename-perf-v0
>>   http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/rename-perf-v0
>>
>> Tom Zanussi (2):
>>   perf: rename perf.inc to perf-features.inc
>>   perf: rename perf_3.4 to perf
>>
>>  meta/recipes-kernel/perf/{perf.inc => perf-features.inc} | 0
>>  meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb}        | 2 +-
>>  2 files changed, 1 insertion(+), 1 deletion(-)
>>  rename meta/recipes-kernel/perf/{perf.inc => perf-features.inc} (100%)
>>  rename meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} (99%)
>>
>> --
>> 1.7.11.4
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 2/2] perf: rename perf_3.4 to perf

[Saul Wold]

On 03/07/2013 04:39 PM, tom.zanussi@linux.intel.com wrote:
> From: Tom Zanussi <tom.zanussi@linux.intel.com>
>
> There's nothing kernel-version-specific about the perf_3.4 recipe, so
> it's actually misnamed and misleading now that it also gets used with
> the 3.8 kernel.
>
> Since the recipe isn't tied to a specific PV, and simply uses
> whatever's in STAGING_KERNEL_DIR, there's no reason to add anything
> else either to the bare PN, so just use that as the recipe name.
>
This did not quite work out correctly, since the package name has now 
gone backwards since the default PV for a recipe is 1.0 when nothing is 
set on the recipe file name.

Is there a way to sort this out such that it picks up an incrementing PV 
from the kernel recipe?

As it stands now, the PV has gone from 3.4 -> 1.0.

Thanks for looking after this.

Sau!

> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> ---
>   meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} | 0
>   1 file changed, 0 insertions(+), 0 deletions(-)
>   rename meta/recipes-kernel/perf/{perf_3.4.bb => perf.bb} (100%)
>
> diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf.bb
> similarity index 100%
> rename from meta/recipes-kernel/perf/perf_3.4.bb
> rename to meta/recipes-kernel/perf/perf.bb
>

Re: [PATCH 2/2] perf: rename perf_3.4 to perf

[Richard Purdie]

On Mon, 2013-03-11 at 16:54 -0700, Saul Wold wrote:
> On 03/07/2013 04:39 PM, tom.zanussi@linux.intel.com wrote:
> > From: Tom Zanussi <tom.zanussi@linux.intel.com>
> >
> > There's nothing kernel-version-specific about the perf_3.4 recipe, so
> > it's actually misnamed and misleading now that it also gets used with
> > the 3.8 kernel.
> >
> > Since the recipe isn't tied to a specific PV, and simply uses
> > whatever's in STAGING_KERNEL_DIR, there's no reason to add anything
> > else either to the bare PN, so just use that as the recipe name.
> >
> This did not quite work out correctly, since the package name has now 
> gone backwards since the default PV for a recipe is 1.0 when nothing is 
> set on the recipe file name.
> 
> Is there a way to sort this out such that it picks up an incrementing PV 
> from the kernel recipe?
> 
> As it stands now, the PV has gone from 3.4 -> 1.0.
> 
> Thanks for looking after this.

As a hint on how to do this we need to read the kernel version and then
set PKGV just prior to or at the start of do_package time.

The logs will show 1.0 as the version but the final packages will have
the kernel version.

Cheers,

Richard

Re: [PATCH 2/2] perf: rename perf_3.4 to perf

[Darren Hart]

On 03/11/2013 04:54 PM, Saul Wold wrote:
> On 03/07/2013 04:39 PM, tom.zanussi@linux.intel.com wrote:
>> From: Tom Zanussi <tom.zanussi@linux.intel.com>
>>
>> There's nothing kernel-version-specific about the perf_3.4 recipe, so
>> it's actually misnamed and misleading now that it also gets used with
>> the 3.8 kernel.
>>
>> Since the recipe isn't tied to a specific PV, and simply uses
>> whatever's in STAGING_KERNEL_DIR, there's no reason to add anything
>> else either to the bare PN, so just use that as the recipe name.
>>
> This did not quite work out correctly, since the package name has now 
> gone backwards since the default PV for a recipe is 1.0 when nothing is 
> set on the recipe file name.
> 
> Is there a way to sort this out such that it picks up an incrementing PV 
> from the kernel recipe?
> 
> As it stands now, the PV has gone from 3.4 -> 1.0.
> 
> Thanks for looking after this.

This is what PE is for right? Sounds like we need an epoch bump.

--
Darren hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel