Openembedded Devel Discussions
 help / color / mirror / Atom feed
* [PATCH][meta-networking 1/2] netperf: import recipe
@ 2012-11-01  1:42 Xin Ouyang
  2012-11-01  1:42 ` [PATCH][meta-networking 2/2] netperf: uprev to 2.6.0 Xin Ouyang
  2012-11-02 10:52 ` [PATCH][meta-networking 1/2] netperf: import recipe Koen Kooi
  0 siblings, 2 replies; 7+ messages in thread
From: Xin Ouyang @ 2012-11-01  1:42 UTC (permalink / raw)
  To: openembedded-devel

Git-Url:
 - http://git.openembedded.org/openembedded/tree/recipes/netperf/

Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>
---
 .../recipes-support/netperf/files/cpu_set.patch    |   24 +++++++++
 meta-networking/recipes-support/netperf/files/init |   51 ++++++++++++++++++++
 .../recipes-support/netperf/files/vfork.patch      |   26 ++++++++++
 .../recipes-support/netperf/netperf_2.4.4.bb       |   45 +++++++++++++++++
 4 files changed, 146 insertions(+), 0 deletions(-)
 create mode 100644 meta-networking/recipes-support/netperf/files/cpu_set.patch
 create mode 100644 meta-networking/recipes-support/netperf/files/init
 create mode 100644 meta-networking/recipes-support/netperf/files/vfork.patch
 create mode 100644 meta-networking/recipes-support/netperf/netperf_2.4.4.bb

diff --git a/meta-networking/recipes-support/netperf/files/cpu_set.patch b/meta-networking/recipes-support/netperf/files/cpu_set.patch
new file mode 100644
index 0000000..b2b95c7
--- /dev/null
+++ b/meta-networking/recipes-support/netperf/files/cpu_set.patch
@@ -0,0 +1,24 @@
+Index: netperf-2.4.4/src/netlib.c
+===================================================================
+--- netperf-2.4.4.orig/src/netlib.c	2007-10-17 23:16:02.000000000 +0200
++++ netperf-2.4.4/src/netlib.c	2008-12-03 17:56:32.000000000 +0100
+@@ -1988,10 +1988,15 @@
+      fall-back on what we had before, which is to use just the size of
+      an unsigned long. raj 2006-09-14 */
+ 
+-#if defined(__CPU_SETSIZE)
+-#define NETPERF_CPU_SETSIZE __CPU_SETSIZE
+-#define NETPERF_CPU_SET(cpu, cpusetp)  __CPU_SET(cpu, cpusetp)
+-#define NETPERF_CPU_ZERO(cpusetp)      __CPU_ZERO (cpusetp)
++#if defined(CPU_SETSIZE)
++#define NETPERF_CPU_SETSIZE CPU_SETSIZE
++#define NETPERF_CPU_SET(cpu, cpusetp)  CPU_SET(cpu, cpusetp)
++#define NETPERF_CPU_ZERO(cpusetp)      CPU_ZERO (cpusetp)
++  typedef cpu_set_t netperf_cpu_set_t;
++#elif defined(__CPU_SETSIZE)
++#define NETPERF_CPU_SETSIZE __CPU_SETSIZE
++#define NETPERF_CPU_SET(cpu, cpusetp)  __CPU_SET (cpu, cpusetp)
++#define NETPERF_CPU_ZERO(cpusetp)      __CPU_ZERO (cpusetp)
+   typedef cpu_set_t netperf_cpu_set_t;
+ #else
+ #define NETPERF_CPU_SETSIZE sizeof(unsigned long)
diff --git a/meta-networking/recipes-support/netperf/files/init b/meta-networking/recipes-support/netperf/files/init
new file mode 100644
index 0000000..7cc053a
--- /dev/null
+++ b/meta-networking/recipes-support/netperf/files/init
@@ -0,0 +1,51 @@
+#!/bin/sh
+#
+#
+# Written by Miquel van Smoorenburg <miquels@cistron.nl>.
+# Modified for Debian GNU/Linux by Ian Murdock <imurdock@gnu.org>.
+# Modified for Debian by Christoph Lameter <clameter@debian.org>
+# Modified for openembedded by Bruno Randolf <bruno.randolf@4g-systems.biz>
+
+PATH=/bin:/usr/bin:/sbin:/usr/sbin
+DAEMON=/usr/sbin/netserver
+
+test -f $DAEMON || exit 0
+
+case "$1" in
+  start)
+		echo -n "Starting network benchmark server: netserver"
+    start-stop-daemon -S -x $DAEMON > /dev/null 2>&1 
+		echo "."
+    ;;
+  stop)
+		echo -n "Stopping network benchmark server: netserver"
+    start-stop-daemon -K -x $DAEMON
+		echo "."
+    ;;
+  #reload)
+    #
+    # If the daemon can reload its config files on the fly
+    # for example by sending it SIGHUP, do it here.
+    #
+    # If the daemon responds to changes in its config file
+    # directly anyway, make this a do-nothing entry.
+    #
+    # start-stop-daemon --stop --signal 1 --verbose --exec $DAEMON
+    # ;;
+  restart|force-reload)
+  #
+  # If the "reload" option is implemented, move the "force-reload"
+  # option to the "reload" entry above. If not, "force-reload" is
+  # just the same as "restart".
+  #
+    start-stop-daemon -K -x $DAEMON
+    sleep 1
+    start-stop-daemon -S -x $DAEMON
+    ;;
+  *)
+    echo "Usage: /etc/init.d/netperf {start|stop|restart|force-reload}"
+    exit 1
+    ;;
+esac
+
+exit 0
diff --git a/meta-networking/recipes-support/netperf/files/vfork.patch b/meta-networking/recipes-support/netperf/files/vfork.patch
new file mode 100644
index 0000000..a40c96f
--- /dev/null
+++ b/meta-networking/recipes-support/netperf/files/vfork.patch
@@ -0,0 +1,26 @@
+--- netperf-2.4.4/src/netserver.c	2007-10-17 17:09:12.000000000 -0400
++++ netperf-2.4.4.new/src/netserver.c	2011-01-23 12:26:39.000000000 -0500
+@@ -567,7 +567,11 @@
+   fflush (stdin);
+   fflush (stdout);
+   fflush (stderr);
++#if defined(HAVE_FORK)
+   switch (fork())
++#else
++  switch (vfork())
++#endif
+     {
+     case -1:  	
+       perror("netperf server error");
+@@ -712,7 +716,11 @@
+ #else
+       signal(SIGCLD, SIG_IGN);
+ 	  
++#if defined(HAVE_FORK)
+ 	  switch (fork())
++#else
++	  switch (vfork())
++#endif
+ 	    {
+ 	    case -1:
+ 	      /* something went wrong */
diff --git a/meta-networking/recipes-support/netperf/netperf_2.4.4.bb b/meta-networking/recipes-support/netperf/netperf_2.4.4.bb
new file mode 100644
index 0000000..4ffa822
--- /dev/null
+++ b/meta-networking/recipes-support/netperf/netperf_2.4.4.bb
@@ -0,0 +1,45 @@
+DESCRIPTION="Network performance benchmark including tests for TCP, UDP, sockets, ATM and more."
+SECTION = "console/network"
+HOMEPAGE = "http://www.netperf.org/"
+LICENSE = "netperf"
+PR = "r3"
+
+SRC_URI="ftp://ftp.netperf.org/netperf/archive/netperf-${PV}.tar.bz2 \
+         file://cpu_set.patch \
+         file://vfork.patch \
+         file://init"
+
+inherit update-rc.d autotools
+
+S = "${WORKDIR}/netperf-${PV}"
+
+# cpu_set.patch plus _GNU_SOURCE makes src/netlib.c compile with CPU_ macros
+CFLAGS_append = " -DDO_UNIX -DDO_IPV6 -D_GNU_SOURCE"
+
+do_install() {
+        install -d ${D}${sbindir} ${D}${bindir} ${D}${sysconfdir}/init.d
+        install -m 4755 src/netperf ${D}${bindir}
+        install -m 4755 src/netserver ${D}${sbindir}
+        install -m 0755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/netperf
+
+        # man
+        install -d ${D}${mandir}/man1/
+        install -m 0644 doc/netserver.man ${D}${mandir}/man1/netserver.1
+        install -m 0644 doc/netperf.man ${D}${mandir}/man1/netperf.1
+
+        # move scripts to examples directory
+        install -d ${D}${docdir}/netperf/examples
+        install -m 0644 doc/examples/*_script ${D}${docdir}/netperf/examples/
+
+        # docs ..
+        install -m 0644 COPYING ${D}${docdir}/netperf
+        install -m 0644 Release_Notes ${D}${docdir}/netperf
+        install -m 0644 README ${D}${docdir}/netperf
+        install -m 0644 doc/netperf_old.ps ${D}${docdir}/netperf
+}
+
+INITSCRIPT_NAME="netperf"
+INITSCRIPT_PARAMS="defaults"
+
+SRC_URI[md5sum] = "0e942f22864e601406a994420231075b"
+SRC_URI[sha256sum] = "28e76af491ea3696885e4558ae2f5628a4b9ebdbefc2f1d9cf1b35db2813e497"
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH][meta-networking 2/2] netperf: uprev to 2.6.0
  2012-11-01  1:42 [PATCH][meta-networking 1/2] netperf: import recipe Xin Ouyang
@ 2012-11-01  1:42 ` Xin Ouyang
  2012-11-01 10:04   ` Paul Eggleton
  2012-11-02 10:52 ` [PATCH][meta-networking 1/2] netperf: import recipe Koen Kooi
  1 sibling, 1 reply; 7+ messages in thread
From: Xin Ouyang @ 2012-11-01  1:42 UTC (permalink / raw)
  To: openembedded-devel

Also fix license, summary and patches.

Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>
---
 .../recipes-support/netperf/files/cpu_set.patch    |   34 ++++++----
 .../recipes-support/netperf/files/vfork.patch      |   72 ++++++++++++++------
 .../netperf/{netperf_2.4.4.bb => netperf_2.6.0.bb} |   23 +++++--
 3 files changed, 89 insertions(+), 40 deletions(-)
 rename meta-networking/recipes-support/netperf/{netperf_2.4.4.bb => netperf_2.6.0.bb} (65%)

diff --git a/meta-networking/recipes-support/netperf/files/cpu_set.patch b/meta-networking/recipes-support/netperf/files/cpu_set.patch
index b2b95c7..434b790 100644
--- a/meta-networking/recipes-support/netperf/files/cpu_set.patch
+++ b/meta-networking/recipes-support/netperf/files/cpu_set.patch
@@ -1,24 +1,30 @@
-Index: netperf-2.4.4/src/netlib.c
-===================================================================
---- netperf-2.4.4.orig/src/netlib.c	2007-10-17 23:16:02.000000000 +0200
-+++ netperf-2.4.4/src/netlib.c	2008-12-03 17:56:32.000000000 +0100
-@@ -1988,10 +1988,15 @@
+Subject: [PATCH] netperf: fix CPU_SETSIZE to build with eglibc
+
+Upstream-Status: Pending
+
+Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>
+---
+ src/netlib.c |    7 ++++++-
+ 1 files changed, 6 insertions(+), 1 deletions(-)
+
+diff --git a/src/netlib.c b/src/netlib.c
+index 206e002..e33aae6 100644
+--- a/src/netlib.c
++++ b/src/netlib.c
+@@ -2265,7 +2265,12 @@ bind_to_specific_processor(int processor_affinity, int use_cpu_map)
       fall-back on what we had before, which is to use just the size of
       an unsigned long. raj 2006-09-14 */
  
 -#if defined(__CPU_SETSIZE)
--#define NETPERF_CPU_SETSIZE __CPU_SETSIZE
--#define NETPERF_CPU_SET(cpu, cpusetp)  __CPU_SET(cpu, cpusetp)
--#define NETPERF_CPU_ZERO(cpusetp)      __CPU_ZERO (cpusetp)
 +#if defined(CPU_SETSIZE)
 +#define NETPERF_CPU_SETSIZE CPU_SETSIZE
 +#define NETPERF_CPU_SET(cpu, cpusetp)  CPU_SET(cpu, cpusetp)
 +#define NETPERF_CPU_ZERO(cpusetp)      CPU_ZERO (cpusetp)
 +  typedef cpu_set_t netperf_cpu_set_t;
 +#elif defined(__CPU_SETSIZE)
-+#define NETPERF_CPU_SETSIZE __CPU_SETSIZE
-+#define NETPERF_CPU_SET(cpu, cpusetp)  __CPU_SET (cpu, cpusetp)
-+#define NETPERF_CPU_ZERO(cpusetp)      __CPU_ZERO (cpusetp)
-   typedef cpu_set_t netperf_cpu_set_t;
- #else
- #define NETPERF_CPU_SETSIZE sizeof(unsigned long)
+ #define NETPERF_CPU_SETSIZE __CPU_SETSIZE
+ #if defined(__CPU_SET_S)
+ #define NETPERF_CPU_SET(cpu, cpusetp)  __CPU_SET_S(cpu, sizeof (cpu_set_t), cpusetp)
+-- 
+1.7.1.1
+
diff --git a/meta-networking/recipes-support/netperf/files/vfork.patch b/meta-networking/recipes-support/netperf/files/vfork.patch
index a40c96f..eff98bf 100644
--- a/meta-networking/recipes-support/netperf/files/vfork.patch
+++ b/meta-networking/recipes-support/netperf/files/vfork.patch
@@ -1,26 +1,58 @@
---- netperf-2.4.4/src/netserver.c	2007-10-17 17:09:12.000000000 -0400
-+++ netperf-2.4.4.new/src/netserver.c	2011-01-23 12:26:39.000000000 -0500
-@@ -567,7 +567,11 @@
-   fflush (stdin);
-   fflush (stdout);
-   fflush (stderr);
+Subject: [PATCH] netperf: fix vfork/fork
+
+Upstream-Status: Pending
+
+Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>
+---
+ src/netserver.c |   12 ++++++++++--
+ 1 files changed, 10 insertions(+), 2 deletions(-)
+
+diff --git a/src/netserver.c b/src/netserver.c
+index 379a106..f6a8b09 100644
+--- a/src/netserver.c
++++ b/src/netserver.c
+@@ -1020,7 +1020,7 @@ process_requests()
+ void
+ spawn_child() {
+ 
+-#if defined(HAVE_FORK)
++#if defined(HAVE_FORK) || defined(HAVE_VFORK)
+ 
+   if (debug) {
+     fprintf(where,
+@@ -1038,7 +1038,11 @@ spawn_child() {
+ 
+   signal(SIGCLD,SIG_IGN);
+ 
 +#if defined(HAVE_FORK)
-   switch (fork())
+   switch (fork()) {
 +#else
-+  switch (vfork())
++  switch (vfork()) {
 +#endif
-     {
-     case -1:  	
-       perror("netperf server error");
-@@ -712,7 +716,11 @@
- #else
-       signal(SIGCLD, SIG_IGN);
- 	  
+   case -1:
+     fprintf(where,
+ 	    "%s: fork() error %s (errno %d)\n",
+@@ -1405,7 +1409,7 @@ scan_netserver_args(int argc, char *argv[]) {
+ 
+ void
+ daemonize() {
+-#if defined(HAVE_FORK)
++#if defined(HAVE_FORK) || defined(HAVE_VFORK)
+ 
+   if (debug) {
+     fprintf(where,
+@@ -1419,7 +1423,11 @@ daemonize() {
+   fflush(stdout);
+   fflush(stderr);
+ 
 +#if defined(HAVE_FORK)
- 	  switch (fork())
+   switch (fork()) {
 +#else
-+	  switch (vfork())
++  switch (vfork()) {
 +#endif
- 	    {
- 	    case -1:
- 	      /* something went wrong */
+   case -1:
+     fprintf(stderr,
+ 	    "%s: fork() error %s (errno %d)\n",
+-- 
+1.7.1.1
+
diff --git a/meta-networking/recipes-support/netperf/netperf_2.4.4.bb b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
similarity index 65%
rename from meta-networking/recipes-support/netperf/netperf_2.4.4.bb
rename to meta-networking/recipes-support/netperf/netperf_2.6.0.bb
index 4ffa822..8b57a46 100644
--- a/meta-networking/recipes-support/netperf/netperf_2.4.4.bb
+++ b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
@@ -1,14 +1,19 @@
-DESCRIPTION="Network performance benchmark including tests for TCP, UDP, sockets, ATM and more."
+SUMMARY = "A networking benchmarking tool"
+DESCRIPTION = "Network performance benchmark including tests for TCP, UDP, sockets, ATM and more."
 SECTION = "console/network"
 HOMEPAGE = "http://www.netperf.org/"
-LICENSE = "netperf"
-PR = "r3"
+LICENSE = "HP"
+LICENSE_FLAGS = "commercial"
 
-SRC_URI="ftp://ftp.netperf.org/netperf/archive/netperf-${PV}.tar.bz2 \
+PR = "r0"
+
+SRC_URI="ftp://ftp.netperf.org/netperf/netperf-${PV}.tar.bz2 \
          file://cpu_set.patch \
          file://vfork.patch \
          file://init"
 
+LIC_FILES_CHKSUM = "file://COPYING;md5=a0ab17253e7a3f318da85382c7d5d5d6"
+
 inherit update-rc.d autotools
 
 S = "${WORKDIR}/netperf-${PV}"
@@ -16,6 +21,12 @@ S = "${WORKDIR}/netperf-${PV}"
 # cpu_set.patch plus _GNU_SOURCE makes src/netlib.c compile with CPU_ macros
 CFLAGS_append = " -DDO_UNIX -DDO_IPV6 -D_GNU_SOURCE"
 
+# autotools.bbclass attends to include m4 files with path depth <= 2 by 
+# "find ${S} -maxdepth 2 -name \*.m4", so move m4 files from m4/m4.
+do_configure_prepend() {
+	test -d m4/m4 && mv -f m4/m4 m4-files
+}
+
 do_install() {
         install -d ${D}${sbindir} ${D}${bindir} ${D}${sysconfdir}/init.d
         install -m 4755 src/netperf ${D}${bindir}
@@ -41,5 +52,5 @@ do_install() {
 INITSCRIPT_NAME="netperf"
 INITSCRIPT_PARAMS="defaults"
 
-SRC_URI[md5sum] = "0e942f22864e601406a994420231075b"
-SRC_URI[sha256sum] = "28e76af491ea3696885e4558ae2f5628a4b9ebdbefc2f1d9cf1b35db2813e497"
+SRC_URI[md5sum] = "9654ffdfd4c4f2c93ce3733cd9ed9236"
+SRC_URI[sha256sum] = "cd8dac710d4273d29f70e8dbd09353a6362ac58a11926e0822233c0cb230323a"
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH][meta-networking 2/2] netperf: uprev to 2.6.0
  2012-11-01  1:42 ` [PATCH][meta-networking 2/2] netperf: uprev to 2.6.0 Xin Ouyang
@ 2012-11-01 10:04   ` Paul Eggleton
  2012-11-06  8:22     ` Pascal Ouyang
  0 siblings, 1 reply; 7+ messages in thread
From: Paul Eggleton @ 2012-11-01 10:04 UTC (permalink / raw)
  To: Xin Ouyang; +Cc: openembedded-devel

On Thursday 01 November 2012 09:42:46 Xin Ouyang wrote:
> Also fix license, summary and patches.
> 
> Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>

These two patches should really be squashed into one - this is the convention 
we've established for importing recipes from OE-Classic (as long as "Import 
from OE-Classic" or similar is mentioned somewhere in the commit message).

> --- a/meta-networking/recipes-support/netperf/netperf_2.4.4.bb
> +++ b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> @@ -1,14 +1,19 @@
> -DESCRIPTION="Network performance benchmark including tests for TCP, UDP,
> sockets, ATM and more."
> +SUMMARY = "A networking benchmarking tool"
> +DESCRIPTION = "Network performance benchmark including tests for TCP, UDP,
> sockets, ATM and more."
> SECTION = "console/network"
>  HOMEPAGE = "http://www.netperf.org/"
> -LICENSE = "netperf"
> -PR = "r3"
> +LICENSE = "HP"

There's no standard license known as "HP" so "netperf" for LICENSE is correct 
- it means it's a license specific to the netperf software package.

> +LICENSE_FLAGS = "commercial"

Good point - I think many would miss the non-commercial use only clause in the 
license otherwise.

> +SRC_URI[md5sum] = "9654ffdfd4c4f2c93ce3733cd9ed9236"
> +SRC_URI[sha256sum] =
> "cd8dac710d4273d29f70e8dbd09353a6362ac58a11926e0822233c0cb230323a"

I think we prefer to put these next to SRC_URI these days (or at least I do).

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH][meta-networking 1/2] netperf: import recipe
  2012-11-01  1:42 [PATCH][meta-networking 1/2] netperf: import recipe Xin Ouyang
  2012-11-01  1:42 ` [PATCH][meta-networking 2/2] netperf: uprev to 2.6.0 Xin Ouyang
@ 2012-11-02 10:52 ` Koen Kooi
  2012-11-06  8:25   ` Pascal Ouyang
  1 sibling, 1 reply; 7+ messages in thread
From: Koen Kooi @ 2012-11-02 10:52 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 01-11-12 02:42, Xin Ouyang schreef:
> Git-Url: -
> http://git.openembedded.org/openembedded/tree/recipes/netperf/
> 
> Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com> --- 
> .../recipes-support/netperf/files/cpu_set.patch    |   24 +++++++++ 
> meta-networking/recipes-support/netperf/files/init |   51
> ++++++++++++++++++++

The initscript is missing LSB headers and hardcodes $sbindir to /usr/sbin.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQk6XuMkyGM64RGpERApMQAJ0f0YMb53j54pjbXUpl7b6RCjWm7gCgrbd/
8Ainle5y7zDc8tFdcr9gCsQ=
=K3FI
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH][meta-networking 2/2] netperf: uprev to 2.6.0
  2012-11-01 10:04   ` Paul Eggleton
@ 2012-11-06  8:22     ` Pascal Ouyang
  0 siblings, 0 replies; 7+ messages in thread
From: Pascal Ouyang @ 2012-11-06  8:22 UTC (permalink / raw)
  To: Paul Eggleton; +Cc: openembedded-devel

于 2012年11月01日 18:04, Paul Eggleton 写道:
> On Thursday 01 November 2012 09:42:46 Xin Ouyang wrote:
>> Also fix license, summary and patches.
>>
>> Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>
>
> These two patches should really be squashed into one - this is the convention
> we've established for importing recipes from OE-Classic (as long as "Import
> from OE-Classic" or similar is mentioned somewhere in the commit message).
>
>> --- a/meta-networking/recipes-support/netperf/netperf_2.4.4.bb
>> +++ b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
>> @@ -1,14 +1,19 @@
>> -DESCRIPTION="Network performance benchmark including tests for TCP, UDP,
>> sockets, ATM and more."
>> +SUMMARY = "A networking benchmarking tool"
>> +DESCRIPTION = "Network performance benchmark including tests for TCP, UDP,
>> sockets, ATM and more."
>> SECTION = "console/network"
>>   HOMEPAGE = "http://www.netperf.org/"
>> -LICENSE = "netperf"
>> -PR = "r3"
>> +LICENSE = "HP"
>
> There's no standard license known as "HP" so "netperf" for LICENSE is correct
> - it means it's a license specific to the netperf software package.
>
>> +LICENSE_FLAGS = "commercial"
>
> Good point - I think many would miss the non-commercial use only clause in the
> license otherwise.
>
>> +SRC_URI[md5sum] = "9654ffdfd4c4f2c93ce3733cd9ed9236"
>> +SRC_URI[sha256sum] =
>> "cd8dac710d4273d29f70e8dbd09353a6362ac58a11926e0822233c0cb230323a"
>
> I think we prefer to put these next to SRC_URI these days (or at least I do).

OK, a V2 will be sent with these fixes.

Thanks.

- Pascal

>
> Cheers,
> Paul
>


-- 
- Pascal



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH][meta-networking 1/2] netperf: import recipe
  2012-11-02 10:52 ` [PATCH][meta-networking 1/2] netperf: import recipe Koen Kooi
@ 2012-11-06  8:25   ` Pascal Ouyang
  2012-11-06 15:27     ` Koen Kooi
  0 siblings, 1 reply; 7+ messages in thread
From: Pascal Ouyang @ 2012-11-06  8:25 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Koen Kooi

于 2012年11月02日 18:52, Koen Kooi 写道:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 01-11-12 02:42, Xin Ouyang schreef:
>> Git-Url: -
>> http://git.openembedded.org/openembedded/tree/recipes/netperf/
>>
>> Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com> ---
>> .../recipes-support/netperf/files/cpu_set.patch    |   24 +++++++++
>> meta-networking/recipes-support/netperf/files/init |   51
>> ++++++++++++++++++++
>
> The initscript is missing LSB headers and hardcodes $sbindir to /usr/sbin.

The hardcodes would be fixed in V2.

But I think we do not need lsb headers, since no lsb init function used 
in the initscript.

Thanks.

- Pascal

>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iD8DBQFQk6XuMkyGM64RGpERApMQAJ0f0YMb53j54pjbXUpl7b6RCjWm7gCgrbd/
> 8Ainle5y7zDc8tFdcr9gCsQ=
> =K3FI
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>


-- 
- Pascal



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH][meta-networking 1/2] netperf: import recipe
  2012-11-06  8:25   ` Pascal Ouyang
@ 2012-11-06 15:27     ` Koen Kooi
  0 siblings, 0 replies; 7+ messages in thread
From: Koen Kooi @ 2012-11-06 15:27 UTC (permalink / raw)
  To: Pascal Ouyang; +Cc: <openembedded-devel@lists.openembedded.org>



Op 6 nov. 2012 om 09:25 heeft Pascal Ouyang <xin.ouyang@windriver.com> het volgende geschreven:

> 于 2012年11月02日 18:52, Koen Kooi 写道:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> 
>> Op 01-11-12 02:42, Xin Ouyang schreef:
>>> Git-Url: -
>>> http://git.openembedded.org/openembedded/tree/recipes/netperf/
>>> 
>>> Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com> ---
>>> .../recipes-support/netperf/files/cpu_set.patch    |   24 +++++++++
>>> meta-networking/recipes-support/netperf/files/init |   51
>>> ++++++++++++++++++++
>> 
>> The initscript is missing LSB headers and hardcodes $sbindir to /usr/sbin.
> 
> The hardcodes would be fixed in V2.
> 
> But I think we do not need lsb headers, since no lsb init function used in the initscript.

You still need them for depency resolving and lsb compliance 


> 
> Thanks.
> 
> - Pascal
> 
>> 
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.5 (Darwin)
>> Comment: GPGTools - http://gpgtools.org
>> 
>> iD8DBQFQk6XuMkyGM64RGpERApMQAJ0f0YMb53j54pjbXUpl7b6RCjWm7gCgrbd/
>> 8Ainle5y7zDc8tFdcr9gCsQ=
>> =K3FI
>> -----END PGP SIGNATURE-----
>> 
>> 
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> 
> 
> -- 
> - Pascal



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2012-11-06 15:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-01  1:42 [PATCH][meta-networking 1/2] netperf: import recipe Xin Ouyang
2012-11-01  1:42 ` [PATCH][meta-networking 2/2] netperf: uprev to 2.6.0 Xin Ouyang
2012-11-01 10:04   ` Paul Eggleton
2012-11-06  8:22     ` Pascal Ouyang
2012-11-02 10:52 ` [PATCH][meta-networking 1/2] netperf: import recipe Koen Kooi
2012-11-06  8:25   ` Pascal Ouyang
2012-11-06 15:27     ` Koen Kooi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox