From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hansg@kernel.org>,
platform-driver-x86@vger.kernel.org, Patil.Reddy@amd.com,
mario.limonciello@amd.com, lizhi.hou@amd.com
Subject: Re: [PATCH v2 2/5] platform/x86/amd/pmf: Use explicit SET_CMD/GET_CMD flags in amd_pmf_send_cmd()
Date: Tue, 18 Nov 2025 22:33:41 +0530 [thread overview]
Message-ID: <1eef31c8-bd50-4ad7-aabe-539992ae3719@amd.com> (raw)
In-Reply-To: <2e640a82-eb91-14dc-3f34-5e862df14e59@linux.intel.com>
On 11/18/2025 21:11, Ilpo Järvinen wrote:
> On Tue, 11 Nov 2025, Shyam Sundar S K wrote:
>
>> Add SET_CMD and GET_CMD constants and replace boolean values passed as the
>> get/set argument to amd_pmf_send_cmd() with the new explicit flags. This
>> improves readability, avoids ambiguity around true/false and 0/1 usage.
>> There is no functional change.
>>
>> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
>> Co-developed-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
>> Signed-off-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
>> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
>> ---
>> drivers/platform/x86/amd/pmf/auto-mode.c | 14 ++++-----
>> drivers/platform/x86/amd/pmf/cnqf.c | 14 ++++-----
>> drivers/platform/x86/amd/pmf/core.c | 6 ++--
>> drivers/platform/x86/amd/pmf/pmf.h | 3 ++
>> drivers/platform/x86/amd/pmf/spc.c | 2 +-
>> drivers/platform/x86/amd/pmf/sps.c | 38 ++++++++++++------------
>> drivers/platform/x86/amd/pmf/tee-if.c | 20 ++++++-------
>> 7 files changed, 50 insertions(+), 47 deletions(-)
>>
>> diff --git a/drivers/platform/x86/amd/pmf/auto-mode.c b/drivers/platform/x86/amd/pmf/auto-mode.c
>> index a184922bba8d..faf15a8f74bb 100644
>> --- a/drivers/platform/x86/amd/pmf/auto-mode.c
>> +++ b/drivers/platform/x86/amd/pmf/auto-mode.c
>> @@ -114,14 +114,14 @@ static void amd_pmf_set_automode(struct amd_pmf_dev *dev, int idx,
>> {
>> struct power_table_control *pwr_ctrl = &config_store.mode_set[idx].power_control;
>>
>> - amd_pmf_send_cmd(dev, SET_SPL, false, pwr_ctrl->spl, NULL);
>> - amd_pmf_send_cmd(dev, SET_FPPT, false, pwr_ctrl->fppt, NULL);
>> - amd_pmf_send_cmd(dev, SET_SPPT, false, pwr_ctrl->sppt, NULL);
>> - amd_pmf_send_cmd(dev, SET_SPPT_APU_ONLY, false, pwr_ctrl->sppt_apu_only, NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_MIN_LIMIT, false, pwr_ctrl->stt_min, NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_LIMIT_APU, false,
>> + amd_pmf_send_cmd(dev, SET_SPL, SET_CMD, pwr_ctrl->spl, NULL);
>> + amd_pmf_send_cmd(dev, SET_FPPT, SET_CMD, pwr_ctrl->fppt, NULL);
>> + amd_pmf_send_cmd(dev, SET_SPPT, SET_CMD, pwr_ctrl->sppt, NULL);
>> + amd_pmf_send_cmd(dev, SET_SPPT_APU_ONLY, SET_CMD, pwr_ctrl->sppt_apu_only, NULL);
>> + amd_pmf_send_cmd(dev, SET_STT_MIN_LIMIT, SET_CMD, pwr_ctrl->stt_min, NULL);
>> + amd_pmf_send_cmd(dev, SET_STT_LIMIT_APU, SET_CMD,
>> fixp_q88_fromint(pwr_ctrl->stt_skin_temp[STT_TEMP_APU]), NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_LIMIT_HS2, false,
>> + amd_pmf_send_cmd(dev, SET_STT_LIMIT_HS2, SET_CMD,
>> fixp_q88_fromint(pwr_ctrl->stt_skin_temp[STT_TEMP_HS2]), NULL);
>>
>> if (is_apmf_func_supported(dev, APMF_FUNC_SET_FAN_IDX))
>> diff --git a/drivers/platform/x86/amd/pmf/cnqf.c b/drivers/platform/x86/amd/pmf/cnqf.c
>> index 207a0b33d8d3..5469fefb6001 100644
>> --- a/drivers/platform/x86/amd/pmf/cnqf.c
>> +++ b/drivers/platform/x86/amd/pmf/cnqf.c
>> @@ -76,14 +76,14 @@ static int amd_pmf_set_cnqf(struct amd_pmf_dev *dev, int src, int idx,
>>
>> pc = &config_store.mode_set[src][idx].power_control;
>>
>> - amd_pmf_send_cmd(dev, SET_SPL, false, pc->spl, NULL);
>> - amd_pmf_send_cmd(dev, SET_FPPT, false, pc->fppt, NULL);
>> - amd_pmf_send_cmd(dev, SET_SPPT, false, pc->sppt, NULL);
>> - amd_pmf_send_cmd(dev, SET_SPPT_APU_ONLY, false, pc->sppt_apu_only, NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_MIN_LIMIT, false, pc->stt_min, NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_LIMIT_APU, false,
>> + amd_pmf_send_cmd(dev, SET_SPL, SET_CMD, pc->spl, NULL);
>> + amd_pmf_send_cmd(dev, SET_FPPT, SET_CMD, pc->fppt, NULL);
>> + amd_pmf_send_cmd(dev, SET_SPPT, SET_CMD, pc->sppt, NULL);
>> + amd_pmf_send_cmd(dev, SET_SPPT_APU_ONLY, SET_CMD, pc->sppt_apu_only, NULL);
>> + amd_pmf_send_cmd(dev, SET_STT_MIN_LIMIT, SET_CMD, pc->stt_min, NULL);
>> + amd_pmf_send_cmd(dev, SET_STT_LIMIT_APU, SET_CMD,
>> fixp_q88_fromint(pc->stt_skin_temp[STT_TEMP_APU]), NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_LIMIT_HS2, false,
>> + amd_pmf_send_cmd(dev, SET_STT_LIMIT_HS2, SET_CMD,
>> fixp_q88_fromint(pc->stt_skin_temp[STT_TEMP_HS2]), NULL);
>>
>> if (is_apmf_func_supported(dev, APMF_FUNC_SET_FAN_IDX))
>> diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
>> index bc544a4a5266..a659cedc4533 100644
>> --- a/drivers/platform/x86/amd/pmf/core.c
>> +++ b/drivers/platform/x86/amd/pmf/core.c
>> @@ -131,7 +131,7 @@ static void amd_pmf_get_metrics(struct work_struct *work)
>>
>> /* Transfer table contents */
>> memset(dev->buf, 0, sizeof(dev->m_table));
>> - amd_pmf_send_cmd(dev, SET_TRANSFER_TABLE, 0, 7, NULL);
>> + amd_pmf_send_cmd(dev, SET_TRANSFER_TABLE, SET_CMD, 7, NULL);
>> memcpy(&dev->m_table, dev->buf, sizeof(dev->m_table));
>>
>> time_elapsed_ms = ktime_to_ms(ktime_get()) - dev->start_time;
>> @@ -289,8 +289,8 @@ int amd_pmf_set_dram_addr(struct amd_pmf_dev *dev, bool alloc_buffer)
>> hi = phys_addr >> 32;
>> low = phys_addr & GENMASK(31, 0);
>>
>> - amd_pmf_send_cmd(dev, SET_DRAM_ADDR_HIGH, 0, hi, NULL);
>> - amd_pmf_send_cmd(dev, SET_DRAM_ADDR_LOW, 0, low, NULL);
>> + amd_pmf_send_cmd(dev, SET_DRAM_ADDR_HIGH, SET_CMD, hi, NULL);
>> + amd_pmf_send_cmd(dev, SET_DRAM_ADDR_LOW, SET_CMD, low, NULL);
>>
>> return 0;
>> }
>> diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h
>> index 6ea5380f3b23..19e413bd89bc 100644
>> --- a/drivers/platform/x86/amd/pmf/pmf.h
>> +++ b/drivers/platform/x86/amd/pmf/pmf.h
>> @@ -120,6 +120,9 @@ struct cookie_header {
>> #define APTS_MAX_STATES 16
>> #define CUSTOM_BIOS_INPUT_BITS GENMASK(16, 7)
>>
>> +#define SET_CMD 0
>> +#define GET_CMD 1
>
> amd_pmf_send_cmd() takes bool so I don't know why these are defined as
> numbers?
The signature of amd_pmf_send_cmd() is:
amd_pmf_send_cmd(struct amd_pmf_dev *dev, u8 message, bool get, u32
arg, u32 *data);
However, in the code it’s called with mixed values for the get parameter:
amd_pmf_send_cmd(…, …, true, …, …);
amd_pmf_send_cmd(…, …, false, …, …);
amd_pmf_send_cmd(…, …, 0, …, …);
That inconsistency makes it harder to read. So, I think adding those
two macros would be useful so callers can use explicit names instead
of 0/1/true/false, which should improve clarity.
If you don’t think this is worth doing, I’m fine dropping the change
from this series.
Thanks,
Shyam
>
> Other than that, things look much better than before this change.
>
> --
> i.
>
>> typedef void (*apmf_event_handler_t)(acpi_handle handle, u32 event, void *data);
>>
>> /* APTS PMF BIOS Interface */
>> diff --git a/drivers/platform/x86/amd/pmf/spc.c b/drivers/platform/x86/amd/pmf/spc.c
>> index 85192c7536b8..b10229def18a 100644
>> --- a/drivers/platform/x86/amd/pmf/spc.c
>> +++ b/drivers/platform/x86/amd/pmf/spc.c
>> @@ -202,7 +202,7 @@ static void amd_pmf_get_smu_info(struct amd_pmf_dev *dev, struct ta_pmf_enact_ta
>> {
>> /* Get the updated metrics table data */
>> memset(dev->buf, 0, dev->mtable_size);
>> - amd_pmf_send_cmd(dev, SET_TRANSFER_TABLE, 0, 7, NULL);
>> + amd_pmf_send_cmd(dev, SET_TRANSFER_TABLE, SET_CMD, 7, NULL);
>>
>> switch (dev->cpu_id) {
>> case AMD_CPU_ID_PS:
>> diff --git a/drivers/platform/x86/amd/pmf/sps.c b/drivers/platform/x86/amd/pmf/sps.c
>> index c28f3c5744c2..0b70a5153f46 100644
>> --- a/drivers/platform/x86/amd/pmf/sps.c
>> +++ b/drivers/platform/x86/amd/pmf/sps.c
>> @@ -192,15 +192,15 @@ static void amd_pmf_load_defaults_sps(struct amd_pmf_dev *dev)
>>
>> static void amd_pmf_update_slider_v2(struct amd_pmf_dev *dev, int idx)
>> {
>> - amd_pmf_send_cmd(dev, SET_PMF_PPT, false, apts_config_store.val[idx].pmf_ppt, NULL);
>> - amd_pmf_send_cmd(dev, SET_PMF_PPT_APU_ONLY, false,
>> + amd_pmf_send_cmd(dev, SET_PMF_PPT, SET_CMD, apts_config_store.val[idx].pmf_ppt, NULL);
>> + amd_pmf_send_cmd(dev, SET_PMF_PPT_APU_ONLY, SET_CMD,
>> apts_config_store.val[idx].ppt_pmf_apu_only, NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_MIN_LIMIT, false,
>> + amd_pmf_send_cmd(dev, SET_STT_MIN_LIMIT, SET_CMD,
>> apts_config_store.val[idx].stt_min_limit, NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_LIMIT_APU, false,
>> + amd_pmf_send_cmd(dev, SET_STT_LIMIT_APU, SET_CMD,
>> fixp_q88_fromint(apts_config_store.val[idx].stt_skin_temp_limit_apu),
>> NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_LIMIT_HS2, false,
>> + amd_pmf_send_cmd(dev, SET_STT_LIMIT_HS2, SET_CMD,
>> fixp_q88_fromint(apts_config_store.val[idx].stt_skin_temp_limit_hs2),
>> NULL);
>> }
>> @@ -211,30 +211,30 @@ void amd_pmf_update_slider(struct amd_pmf_dev *dev, bool op, int idx,
>> int src = amd_pmf_get_power_source();
>>
>> if (op == SLIDER_OP_SET) {
>> - amd_pmf_send_cmd(dev, SET_SPL, false, config_store.prop[src][idx].spl, NULL);
>> - amd_pmf_send_cmd(dev, SET_FPPT, false, config_store.prop[src][idx].fppt, NULL);
>> - amd_pmf_send_cmd(dev, SET_SPPT, false, config_store.prop[src][idx].sppt, NULL);
>> - amd_pmf_send_cmd(dev, SET_SPPT_APU_ONLY, false,
>> + amd_pmf_send_cmd(dev, SET_SPL, SET_CMD, config_store.prop[src][idx].spl, NULL);
>> + amd_pmf_send_cmd(dev, SET_FPPT, SET_CMD, config_store.prop[src][idx].fppt, NULL);
>> + amd_pmf_send_cmd(dev, SET_SPPT, SET_CMD, config_store.prop[src][idx].sppt, NULL);
>> + amd_pmf_send_cmd(dev, SET_SPPT_APU_ONLY, SET_CMD,
>> config_store.prop[src][idx].sppt_apu_only, NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_MIN_LIMIT, false,
>> + amd_pmf_send_cmd(dev, SET_STT_MIN_LIMIT, SET_CMD,
>> config_store.prop[src][idx].stt_min, NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_LIMIT_APU, false,
>> + amd_pmf_send_cmd(dev, SET_STT_LIMIT_APU, SET_CMD,
>> fixp_q88_fromint(config_store.prop[src][idx].stt_skin_temp[STT_TEMP_APU]),
>> NULL);
>> - amd_pmf_send_cmd(dev, SET_STT_LIMIT_HS2, false,
>> + amd_pmf_send_cmd(dev, SET_STT_LIMIT_HS2, SET_CMD,
>> fixp_q88_fromint(config_store.prop[src][idx].stt_skin_temp[STT_TEMP_HS2]),
>> NULL);
>> } else if (op == SLIDER_OP_GET) {
>> - amd_pmf_send_cmd(dev, GET_SPL, true, ARG_NONE, &table->prop[src][idx].spl);
>> - amd_pmf_send_cmd(dev, GET_FPPT, true, ARG_NONE, &table->prop[src][idx].fppt);
>> - amd_pmf_send_cmd(dev, GET_SPPT, true, ARG_NONE, &table->prop[src][idx].sppt);
>> - amd_pmf_send_cmd(dev, GET_SPPT_APU_ONLY, true, ARG_NONE,
>> + amd_pmf_send_cmd(dev, GET_SPL, GET_CMD, ARG_NONE, &table->prop[src][idx].spl);
>> + amd_pmf_send_cmd(dev, GET_FPPT, GET_CMD, ARG_NONE, &table->prop[src][idx].fppt);
>> + amd_pmf_send_cmd(dev, GET_SPPT, GET_CMD, ARG_NONE, &table->prop[src][idx].sppt);
>> + amd_pmf_send_cmd(dev, GET_SPPT_APU_ONLY, GET_CMD, ARG_NONE,
>> &table->prop[src][idx].sppt_apu_only);
>> - amd_pmf_send_cmd(dev, GET_STT_MIN_LIMIT, true, ARG_NONE,
>> + amd_pmf_send_cmd(dev, GET_STT_MIN_LIMIT, GET_CMD, ARG_NONE,
>> &table->prop[src][idx].stt_min);
>> - amd_pmf_send_cmd(dev, GET_STT_LIMIT_APU, true, ARG_NONE,
>> + amd_pmf_send_cmd(dev, GET_STT_LIMIT_APU, GET_CMD, ARG_NONE,
>> (u32 *)&table->prop[src][idx].stt_skin_temp[STT_TEMP_APU]);
>> - amd_pmf_send_cmd(dev, GET_STT_LIMIT_HS2, true, ARG_NONE,
>> + amd_pmf_send_cmd(dev, GET_STT_LIMIT_HS2, GET_CMD, ARG_NONE,
>> (u32 *)&table->prop[src][idx].stt_skin_temp[STT_TEMP_HS2]);
>> }
>> }
>> diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c
>> index 6e8116bef4f6..44fc69cfe10e 100644
>> --- a/drivers/platform/x86/amd/pmf/tee-if.c
>> +++ b/drivers/platform/x86/amd/pmf/tee-if.c
>> @@ -83,7 +83,7 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>> switch (out->actions_list[idx].action_index) {
>> case PMF_POLICY_SPL:
>> if (dev->prev_data->spl != val) {
>> - amd_pmf_send_cmd(dev, SET_SPL, false, val, NULL);
>> + amd_pmf_send_cmd(dev, SET_SPL, SET_CMD, val, NULL);
>> dev_dbg(dev->dev, "update SPL: %u\n", val);
>> dev->prev_data->spl = val;
>> }
>> @@ -91,7 +91,7 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>>
>> case PMF_POLICY_SPPT:
>> if (dev->prev_data->sppt != val) {
>> - amd_pmf_send_cmd(dev, SET_SPPT, false, val, NULL);
>> + amd_pmf_send_cmd(dev, SET_SPPT, SET_CMD, val, NULL);
>> dev_dbg(dev->dev, "update SPPT: %u\n", val);
>> dev->prev_data->sppt = val;
>> }
>> @@ -99,7 +99,7 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>>
>> case PMF_POLICY_FPPT:
>> if (dev->prev_data->fppt != val) {
>> - amd_pmf_send_cmd(dev, SET_FPPT, false, val, NULL);
>> + amd_pmf_send_cmd(dev, SET_FPPT, SET_CMD, val, NULL);
>> dev_dbg(dev->dev, "update FPPT: %u\n", val);
>> dev->prev_data->fppt = val;
>> }
>> @@ -107,7 +107,7 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>>
>> case PMF_POLICY_SPPT_APU_ONLY:
>> if (dev->prev_data->sppt_apuonly != val) {
>> - amd_pmf_send_cmd(dev, SET_SPPT_APU_ONLY, false, val, NULL);
>> + amd_pmf_send_cmd(dev, SET_SPPT_APU_ONLY, SET_CMD, val, NULL);
>> dev_dbg(dev->dev, "update SPPT_APU_ONLY: %u\n", val);
>> dev->prev_data->sppt_apuonly = val;
>> }
>> @@ -115,7 +115,7 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>>
>> case PMF_POLICY_STT_MIN:
>> if (dev->prev_data->stt_minlimit != val) {
>> - amd_pmf_send_cmd(dev, SET_STT_MIN_LIMIT, false, val, NULL);
>> + amd_pmf_send_cmd(dev, SET_STT_MIN_LIMIT, SET_CMD, val, NULL);
>> dev_dbg(dev->dev, "update STT_MIN: %u\n", val);
>> dev->prev_data->stt_minlimit = val;
>> }
>> @@ -123,7 +123,7 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>>
>> case PMF_POLICY_STT_SKINTEMP_APU:
>> if (dev->prev_data->stt_skintemp_apu != val) {
>> - amd_pmf_send_cmd(dev, SET_STT_LIMIT_APU, false,
>> + amd_pmf_send_cmd(dev, SET_STT_LIMIT_APU, SET_CMD,
>> fixp_q88_fromint(val), NULL);
>> dev_dbg(dev->dev, "update STT_SKINTEMP_APU: %u\n", val);
>> dev->prev_data->stt_skintemp_apu = val;
>> @@ -132,7 +132,7 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>>
>> case PMF_POLICY_STT_SKINTEMP_HS2:
>> if (dev->prev_data->stt_skintemp_hs2 != val) {
>> - amd_pmf_send_cmd(dev, SET_STT_LIMIT_HS2, false,
>> + amd_pmf_send_cmd(dev, SET_STT_LIMIT_HS2, SET_CMD,
>> fixp_q88_fromint(val), NULL);
>> dev_dbg(dev->dev, "update STT_SKINTEMP_HS2: %u\n", val);
>> dev->prev_data->stt_skintemp_hs2 = val;
>> @@ -141,7 +141,7 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>>
>> case PMF_POLICY_P3T:
>> if (dev->prev_data->p3t_limit != val) {
>> - amd_pmf_send_cmd(dev, SET_P3T, false, val, NULL);
>> + amd_pmf_send_cmd(dev, SET_P3T, SET_CMD, val, NULL);
>> dev_dbg(dev->dev, "update P3T: %u\n", val);
>> dev->prev_data->p3t_limit = val;
>> }
>> @@ -149,7 +149,7 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>>
>> case PMF_POLICY_PMF_PPT:
>> if (dev->prev_data->pmf_ppt != val) {
>> - amd_pmf_send_cmd(dev, SET_PMF_PPT, false, val, NULL);
>> + amd_pmf_send_cmd(dev, SET_PMF_PPT, SET_CMD, val, NULL);
>> dev_dbg(dev->dev, "update PMF PPT: %u\n", val);
>> dev->prev_data->pmf_ppt = val;
>> }
>> @@ -157,7 +157,7 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>>
>> case PMF_POLICY_PMF_PPT_APU_ONLY:
>> if (dev->prev_data->pmf_ppt_apu_only != val) {
>> - amd_pmf_send_cmd(dev, SET_PMF_PPT_APU_ONLY, false, val, NULL);
>> + amd_pmf_send_cmd(dev, SET_PMF_PPT_APU_ONLY, SET_CMD, val, NULL);
>> dev_dbg(dev->dev, "update PMF PPT APU ONLY: %u\n", val);
>> dev->prev_data->pmf_ppt_apu_only = val;
>> }
>>
next prev parent reply other threads:[~2025-11-18 17:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 6:37 [PATCH v2 0/5] PMF NPU metrics cleanup, command flag cleanup, and amdxdna integration Shyam Sundar S K
2025-11-11 6:37 ` [PATCH v2 1/5] platform/x86/amd/pmf: Rename IPU metrics fields to NPU for consistency Shyam Sundar S K
2025-11-18 15:36 ` Ilpo Järvinen
2025-11-11 6:37 ` [PATCH v2 2/5] platform/x86/amd/pmf: Use explicit SET_CMD/GET_CMD flags in amd_pmf_send_cmd() Shyam Sundar S K
2025-11-18 15:41 ` Ilpo Järvinen
2025-11-18 17:03 ` Shyam Sundar S K [this message]
2025-11-18 17:08 ` Ilpo Järvinen
2025-11-11 6:37 ` [PATCH v2 3/5] platform/x86/amd/pmf: replace magic table id with METRICS_TABLE_ID Shyam Sundar S K
2025-11-18 15:44 ` Ilpo Järvinen
2025-11-11 6:37 ` [PATCH v2 4/5] platform/x86/amd/pmf: Introduce new interface to export NPU metrics Shyam Sundar S K
2025-11-18 15:54 ` Ilpo Järvinen
2025-11-11 6:37 ` [PATCH v2 5/5] accel/amdxdna: Provide real-time NPU power estimate via AMD PMF Shyam Sundar S K
2025-11-12 18:03 ` Mario Limonciello
2025-11-13 7:33 ` Shyam Sundar S K
2025-11-14 16:56 ` Mario Limonciello
2025-11-18 15:59 ` Ilpo Järvinen
2025-11-18 16:01 ` Ilpo Järvinen
2025-11-18 16:46 ` Shyam Sundar S K
2025-11-19 12:44 ` Ilpo Järvinen
2025-11-20 10:55 ` Shyam Sundar S K
2025-11-12 17:21 ` [PATCH v2 0/5] PMF NPU metrics cleanup, command flag cleanup, and amdxdna integration Mario Limonciello
2025-11-13 7:37 ` Shyam Sundar S K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eef31c8-bd50-4ad7-aabe-539992ae3719@amd.com \
--to=shyam-sundar.s-k@amd.com \
--cc=Patil.Reddy@amd.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lizhi.hou@amd.com \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox