Re: [PATCH v2 5/5] accel/amdxdna: Provide real-time NPU power estimate via AMD PMF

[Shyam Sundar S K <Shyam-sundar.S-k@amd.com>]

On 11/12/2025 23:33, Mario Limonciello wrote:
> On 11/11/25 12:37 AM, Shyam Sundar S K wrote:
>> From: VinitKumar Shukla <VinitKumar.Shukla@amd.com>
>>
>> Add aie2_smu_get_power_estimate() to obtain NPU power readings from the
>> AMD PMF driver. This xdna interface enables user space to reflect
>> current
>> workload power consumption in real time.
> 
> But.. it doesn't.  It just adds a new function that could potentially
> do this job.  The actual gluing it to userspace in some way to use
> this function will be another patch.

For now, yes.. that's right. XDNA team will add more support on it
that goes via the accel tree. But this patch is meant to have a
minimal change on the xdna side so that there is a  consumer of the
pmf symbol that is getting exported to the kernel.

So, there is more support coming on the way. If you think, its worth
to rephrase the commit?

Thanks,
Shyam
> 
>>
>> Signed-off-by: VinitKumar Shukla <VinitKumar.Shukla@amd.com>
>> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
>> ---
>>   drivers/accel/amdxdna/aie2_pci.h |  2 ++
>>   drivers/accel/amdxdna/aie2_smu.c | 12 ++++++++++++
>>   2 files changed, 14 insertions(+)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_pci.h b/drivers/accel/
>> amdxdna/aie2_pci.h
>> index 91a8e948f82a..5601de841b5b 100644
>> --- a/drivers/accel/amdxdna/aie2_pci.h
>> +++ b/drivers/accel/amdxdna/aie2_pci.h
>> @@ -8,6 +8,7 @@
>>     #include <drm/amdxdna_accel.h>
>>   #include <linux/semaphore.h>
>> +#include <linux/amd-pmf-io.h>
>>     #include "amdxdna_mailbox.h"
>>   @@ -240,6 +241,7 @@ int aie2_smu_init(struct amdxdna_dev_hdl *ndev);
>>   void aie2_smu_fini(struct amdxdna_dev_hdl *ndev);
>>   int npu1_set_dpm(struct amdxdna_dev_hdl *ndev, u32 dpm_level);
>>   int npu4_set_dpm(struct amdxdna_dev_hdl *ndev, u32 dpm_level);
>> +int aie2_smu_get_power_estimate(void);
>>     /* aie2_pm.c */
>>   int aie2_pm_init(struct amdxdna_dev_hdl *ndev);
>> diff --git a/drivers/accel/amdxdna/aie2_smu.c b/drivers/accel/
>> amdxdna/aie2_smu.c
>> index d303701b0ded..7b5e2c383dd3 100644
>> --- a/drivers/accel/amdxdna/aie2_smu.c
>> +++ b/drivers/accel/amdxdna/aie2_smu.c
>> @@ -54,6 +54,18 @@ static int aie2_smu_exec(struct amdxdna_dev_hdl
>> *ndev, u32 reg_cmd,
>>       return 0;
>>   }
>>   +int aie2_smu_get_power_estimate(void)
>> +{
>> +    struct amd_pmf_npu_metrics npu_metrics;
>> +    int ret;
>> +
>> +    ret = amd_pmf_get_npu_data(&npu_metrics);
>> +    if (ret)
>> +        return ret;
>> +
>> +    return npu_metrics.npu_power;
>> +}
>> +
>>   int npu1_set_dpm(struct amdxdna_dev_hdl *ndev, u32 dpm_level)
>>   {
>>       u32 freq;
>