Re: [PATCH v2 3/5] platform/x86/amd/pmf: replace magic table id with METRICS_TABLE_ID

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2572 bytes --]

On Tue, 11 Nov 2025, Shyam Sundar S K wrote:

> Add METRICS_TABLE_ID (7) and use it when requesting the metrics
> transfer table instead of the hard-coded literal. This clarifies the
> meaning of the argument to amd_pmf_send_cmd() and centralizes the table
> ID definition for easier maintenance.
> 
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Co-developed-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
> Signed-off-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
>  drivers/platform/x86/amd/pmf/core.c | 2 +-
>  drivers/platform/x86/amd/pmf/pmf.h  | 1 +
>  drivers/platform/x86/amd/pmf/spc.c  | 2 +-
>  3 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
> index a659cedc4533..a6a5d416edf9 100644
> --- a/drivers/platform/x86/amd/pmf/core.c
> +++ b/drivers/platform/x86/amd/pmf/core.c
> @@ -131,7 +131,7 @@ static void amd_pmf_get_metrics(struct work_struct *work)
>  
>  	/* Transfer table contents */
>  	memset(dev->buf, 0, sizeof(dev->m_table));
> -	amd_pmf_send_cmd(dev, SET_TRANSFER_TABLE, SET_CMD, 7, NULL);
> +	amd_pmf_send_cmd(dev, SET_TRANSFER_TABLE, SET_CMD, METRICS_TABLE_ID, NULL);
>  	memcpy(&dev->m_table, dev->buf, sizeof(dev->m_table));
>  
>  	time_elapsed_ms = ktime_to_ms(ktime_get()) - dev->start_time;
> diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h
> index 19e413bd89bc..561919b9f671 100644
> --- a/drivers/platform/x86/amd/pmf/pmf.h
> +++ b/drivers/platform/x86/amd/pmf/pmf.h
> @@ -122,6 +122,7 @@ struct cookie_header {
>  
>  #define SET_CMD		0
>  #define GET_CMD		1
> +#define METRICS_TABLE_ID	7
>  
>  typedef void (*apmf_event_handler_t)(acpi_handle handle, u32 event, void *data);
>  
> diff --git a/drivers/platform/x86/amd/pmf/spc.c b/drivers/platform/x86/amd/pmf/spc.c
> index b10229def18a..0a37dc6a7950 100644
> --- a/drivers/platform/x86/amd/pmf/spc.c
> +++ b/drivers/platform/x86/amd/pmf/spc.c
> @@ -202,7 +202,7 @@ static void amd_pmf_get_smu_info(struct amd_pmf_dev *dev, struct ta_pmf_enact_ta
>  {
>  	/* Get the updated metrics table data */
>  	memset(dev->buf, 0, dev->mtable_size);
> -	amd_pmf_send_cmd(dev, SET_TRANSFER_TABLE, SET_CMD, 7, NULL);
> +	amd_pmf_send_cmd(dev, SET_TRANSFER_TABLE, SET_CMD, METRICS_TABLE_ID, NULL);
>  
>  	switch (dev->cpu_id) {
>  	case AMD_CPU_ID_PS:
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>


-- 
 i.