Re: [PATCH v4 01/20] platform/x86: x86-android-tablets: convert Goodix devices to GPIO references

[Hans de Goede <hansg@kernel.org>]

Hi Yauhen,

Thank you for bringing this problem to our attention.

On 10-Feb-26 00:13, Yauhen Kharuzhy wrote:

...

> OK, but what about additional GPIO chips?

You could look those up by label and then manually
attach the swnode to the GPIO-controller device before
using the properties.

But since you are then still doing matching by label that
would be a bit silly and for now at least we are going with
restoring name based GPIO-controller swnode matching as
a fallback:

https://lore.kernel.org/linux-gpio/20260210094806.38146-1-bartosz.golaszewski@oss.qualcomm.com/

> For example, on Lenovo YB1-X9*,
> sound codec controls additional signals like speaker amplifier
> enablling. I did such trick but it looks very... weird: codec device
> properties reference fake node for gpiochip which will be created at
> driver instantiation (these properties are used by ASoC machine driver
> actually):
> 
> static const struct property_entry lenovo_yb1_x9x_rt5677_props[] = {
> ...
> 	PROPERTY_ENTRY_GPIO("realtek,reset-gpios", &cherryview_gpiochip_nodes[3], 25, GPIO_ACTIVE_LOW),
> 	PROPERTY_ENTRY_GPIO("realtek,pow-ldo2-gpios", &cherryview_gpiochip_nodes[3], 18, GPIO_ACTIVE_HIGH),
> 	PROPERTY_ENTRY_GPIO("speaker-enable-gpios", &cherryview_gpiochip_nodes[3], 48, GPIO_ACTIVE_HIGH),
> 	PROPERTY_ENTRY_GPIO("speaker-enable2-gpios", &lenovo_yb1_rt5677_gpiochip_node, 2, GPIO_ACTIVE_HIGH),
> 	PROPERTY_ENTRY_GPIO("headphone-enable-gpios", &lenovo_yb1_rt5677_gpiochip_node, 4, GPIO_ACTIVE_HIGH),
> 	{}
> };
> 
> static const struct software_node lenovo_yb1_x90_rt5677_node = {
> 	.properties = lenovo_yb1_x9x_rt5677_props,
> };
> 
> ...
> 		.board_info = {
> 			.type = "rt5677",
> 			.addr = 0x2c,
> 			.dev_name = "rt5677",
> 			.swnode = &lenovo_yb1_x90_rt5677_node,
> 		},
> ...
> 
> https://github.com/jekhor/yogabook-linux-kernel/commit/538313b69483c23afc455571ef638efcea767031#diff-282276fa1330b08656b929c6e956308a122423888b8f07a1d1045e61a813d8c2R159

Oh nice you've patches for sound now :)

Is this working ?  Any plans to upstream this ?

Regards,

Hans