Re: [PATCH v4 01/20] platform/x86: x86-android-tablets: convert Goodix devices to GPIO references

[Yauhen Kharuzhy <jekhor@gmail.com>]

On Sat, Sep 20, 2025 at 10:06:54PM +0200, Hans de Goede wrote:
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Now that gpiolib supports software nodes to describe GPIOs, switch the
> driver away from using GPIO lookup tables for Goodix touchscreens to
> using PROPERTY_ENTRY_GPIO() to keep all touchscreen properties together.
> 
> Since the tablets are using either Baytrail or Cherryview GPIO
> controllers x86_dev_info structure has been extended to carry gpiochip
> type information so that the code can instantiate correct set of
> software nodes representing the GPIO chip.
> 

Hi, it seems that the mechanism for looking up GPIOs using software
node names is broken now (checked on next-20260503) by commit
e5d527be7e6984882306b49c067f1fec18920735 "gpio: swnode: don't use the swnode's name as the key for GPIO lookup".

As I understand, some of the issues caused by it were addressed in the
series [1], but not for the x86-android-tablets driver. Now any GPIO
belonging to SoC's gpiochips cannot be found by drivers. For example,
for the Lenovo YB1-X90F keyboard touchpad:

[   27.297279] i2c i2c-goodix_ts: bus: 'i2c': __driver_probe_device: matched device with driver Goodix-TS
[   27.297285] i2c i2c-goodix_ts: bus: 'i2c': really_probe: probing driver Goodix-TS with device
[   27.297291] Goodix-TS i2c-goodix_ts: no default pinctrl state
[   27.297330] Goodix-TS i2c-goodix_ts: supply AVDD28 not found, using dummy regulator
[   27.297359] device: 'regulator:regulator.0--i2c:i2c-goodix_ts': device_add
[   27.297454] devices_kset: Moving i2c-goodix_ts to end of list
[   27.297459] PM: Moving i2c:i2c-goodix_ts to end of list
[   27.297463] Goodix-TS i2c-goodix_ts: Linked as a consumer to regulator.0
[   27.297472] Goodix-TS i2c-goodix_ts: supply VDDIO not found, using dummy regulator
[   27.297492] Goodix-TS i2c-goodix_ts: using swnode 'node11' for 'irq' GPIO lookup
[   27.297505] Goodix-TS i2c-goodix_ts: No GPIO consumer irq found
[   27.297511] Goodix-TS i2c-goodix_ts: error -EPROBE_DEFER: Failed to get irq GPIO
[   27.297552] Goodix-TS i2c-goodix_ts: Dropping the link to regulator.0
[   27.297558] device: 'regulator:regulator.0--i2c:i2c-goodix_ts': device_unregister
[   27.297612] Goodix-TS i2c-goodix_ts: Driver Goodix-TS requests probe deferral
[   27.297624] i2c i2c-goodix_ts: Added to deferred list

Could somebody advise on how to fix this, or does a fix already exist? I am
not familiar with the swnode/fwnode framework but can do some investigation to
resolve this.

1. https://lore.kernel.org/linux-sound/20251120-reset-gpios-swnodes-v7-0-a100493a0f4b@linaro.org/

-- 
Yauhen Kharuzhy