Re: [PATCH v4 01/20] platform/x86: x86-android-tablets: convert Goodix devices to GPIO references

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, Feb 12, 2026 at 06:07:32PM +0100, Bartosz Golaszewski wrote:
> On Thu, Feb 12, 2026 at 5:50 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > On Thu, Feb 12, 2026 at 06:14:28PM +0200, Andy Shevchenko wrote:
> > > On Thu, Feb 12, 2026 at 06:12:56PM +0200, Andy Shevchenko wrote:
> > > > On Thu, Feb 12, 2026 at 07:49:31AM -0800, Dmitry Torokhov wrote:
> > > > > On Thu, Feb 12, 2026 at 12:28:41PM +0200, Andy Shevchenko wrote:
> > > > > > On Thu, Feb 12, 2026 at 02:01:02AM -0800, Bartosz Golaszewski wrote:
> > > > > > > On Thu, 12 Feb 2026 04:44:05 +0100, Dmitry Torokhov
> > > > > > > <dmitry.torokhov@gmail.com> said:
> > >
> > > ...
> > >
> > > > > > > +const struct software_node lpc_ich_gpio_swnode = { };
> > > > > >
> > > > > > (With name, please!)
> > > > >
> > > > > That we could match against... /duck
> > > >
> > > > :-)
> > > > No, it's for the /sys/kernel/software_nodes/ to help with debugging, et cetera.
> > >
> > > OTOH, if there are more than one of a such controllers in the system...
> > > And it can be found by reading the links that one of them related to
> > > a certain GPIO device. So no insisting on this.
> >
> > If there are multiple such controllers we cannot use a static software
> > node anyway as it should not be shared between them.
> >
> 
> In such case they should do what OF nodes do (and I'm sure ACPI too):
> use some ID to tell them apart.

You are missing the point. You will not be able to use a static node and
export it. You will need to create a dedicated software node per
instance and the provide a lookup mechanism for whoever wants to use
them to locate the right one.

That is inherent weakness in identity matching - the rigid coupling -
and that is why I originally implemented name matching which allows for
weak references.

Thanks.

-- 
Dmitry