Re: [PATCH v4 01/20] platform/x86: x86-android-tablets: convert Goodix devices to GPIO references

[Hans de Goede <hansg@kernel.org>]

On 9-Feb-26 15:00, Hans de Goede wrote:

...

> For the drivers/platform/x86/x86-android-tablets/* I think the following
> fix is both the easiest as well as the best solution is to modify:
> 
> drivers/pinctrl/intel/pinctrl-baytrail.c
> drivers/pinctrl/intel/pinctrl-cherryview.c 
> 
> To register a swnode for each GPIO controller and
> then EXPORT_SYMBOL_GPL an array of fwnode pointers
> which can then be used in the PROPERTY_ENTRY_GPIO()
> entries replacing e.g.:
> 
> PROPERTY_ENTRY_GPIO("reset-gpios", &cherryview_gpiochip_nodes[1], 53, GPIO_ACTIVE_HIGH)
> 
> with:
> 
> PROPERTY_ENTRY_GPIO("reset-gpios", cherryview_gpiochip_fwnodes[1], 53, GPIO_ACTIVE_HIGH)
> 
> (these 2 covers pinctrl for the Bay Trail and Cherry Trail x86
> SoC based Android tablets which x86-android-tablets is for).
> 
> This should all be pretty straight forward. Assuming we are allowed
> to dereference an external symbol for the property initialization
> if not then this becomes significantly more complex.

Looking at how the current code works, it does not use an array
of swnode pointers, it just uses an array of swnodes, and then
takes the address of the n-th member:

PROPERTY_ENTRY_GPIO("reset-gpios", &cherryview_gpiochip_nodes[1], 53, GPIO_ACTIVE_HIGH)

so if we just move the:

extern const struct software_node baytrail_gpiochip_nodes[];
extern const struct software_node cherryview_gpiochip_nodes[];

arrays to the 2 pinctrl drivers and actually associate them
with / attach them to the GPIO controllers in the pinctrl
drivers then I think that we will be set for all the references
to the main SoC GPIO controllers (at the cost of a dependency
on the pinctrl driver, but that is ok).

That just leaves the non main SoC GPIOs used in combination
with the WM5102 codec and as mentioned I think for those it
would be best to just switch back to GPIO lookups by reverting:

[PATCH v4 10/20] platform/x86: x86-android-tablets: remove support for GPIO lookup tables
[PATCH v4 07/20] platform/x86: x86-android-tablets: convert wm1502

Regards,

Hans