Re: [PATCH v4 01/20] platform/x86: x86-android-tablets: convert Goodix devices to GPIO references

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Mon, Feb 09, 2026 at 10:30:25AM -0600, Bartosz Golaszewski wrote:
> On Mon, 9 Feb 2026 15:46:55 +0100, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> said:
> > On Mon, Feb 09, 2026 at 08:36:01AM -0600, Bartosz Golaszewski wrote:
> >> On Mon, 9 Feb 2026 15:00:40 +0100, Hans de Goede <hansg@kernel.org> said:
> >> >
> >> > For the drivers/platform/x86/x86-android-tablets/* I think the following
> >> > fix is both the easiest as well as the best solution is to modify:
> >> >
> >> > drivers/pinctrl/intel/pinctrl-baytrail.c
> >> > drivers/pinctrl/intel/pinctrl-cherryview.c
> >> >
> >> > To register a swnode for each GPIO controller and
> >> > then EXPORT_SYMBOL_GPL an array of fwnode pointers
> >> > which can then be used in the PROPERTY_ENTRY_GPIO()
> >> > entries replacing e.g.:
> >> >
> >> > PROPERTY_ENTRY_GPIO("reset-gpios", &cherryview_gpiochip_nodes[1], 53, GPIO_ACTIVE_HIGH)
> >> >
> >> > with:
> >> >
> >> > PROPERTY_ENTRY_GPIO("reset-gpios", cherryview_gpiochip_fwnodes[1], 53, GPIO_ACTIVE_HIGH)
> >> >
> >> > (these 2 covers pinctrl for the Bay Trail and Cherry Trail x86
> >> > SoC based Android tablets which x86-android-tablets is for).
> >> >
> >> > This should all be pretty straight forward. Assuming we are allowed
> >> > to dereference an external symbol for the property initialization
> >> > if not then this becomes significantly more complex.
> >> >
> >> > I'm not even sure if we need to add swnodes, we can probably
> >> > just use the existing ACPI fwnodes for matching even and then
> >> > we just need an array with the ACPI fwnode pointers.
> >> >
> >>
> >> Yes, we can now reference fwnodes from property entries. The entity that
> >> creates these devices should be able to retrieve the firmware nodes of
> >> the GPIO controllers (e.g.: via gpio_device_find_by_label() - finding it by
> >> labek is what it effectively tried to do now).
> >
> > How do you do that when your code happens to run first, before the
> > controller is instantiated? gpio_device_find_by_label() will not
> > find it, so what will you use as fwnode in that case?
> >
> 
> The device that calls gpio_device_find_by_label() (most likely a "real"
> device with an OF or ACPI node) should return -EPROBE_DEFER if that's the
> case and not create children with software nodes.

There is no real OF or ACPI node in case of old legacy boards that have
not been converted to device tree. In many cases there is not even a
device that you can defer a probe for, and returning random errors
will likely cause the boot to fail.

Thanks.

-- 
Dmitry