public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <ttabi@nvidia.com>
To: Joel Fernandes <joelagnelf@nvidia.com>,
	"dakr@kernel.org" <dakr@kernel.org>,
	Eliot Courtney <ecourtney@nvidia.com>,
	Alexandre Courbot <acourbot@nvidia.com>,
	John Hubbard <jhubbard@nvidia.com>,
	"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v2 5/6] gpu: nova-core: skip the IFR header if present
Date: Wed, 15 Apr 2026 21:08:52 +0000	[thread overview]
Message-ID: <025756bb7dab3527b3070a94f8b4f70b5ba5622d.camel@nvidia.com> (raw)
In-Reply-To: <DHTH70U5666G.1ZGXQJ5TSNN7Y@nvidia.com>

On Wed, 2026-04-15 at 14:23 +0900, Eliot Courtney wrote:
>  var:NV2080_CTRL_CMD_INTERNAL_DEVICE_INFO_MAX_ENTRIES
> +var:NV_PBUS_IFR_FMT_FIXED0
> +var:NV_PBUS_IFR_FMT_FIXED1
> +var:NV_PBUS_IFR_FMT_FIXED2
> +var:NV_PBUS_IFR_FMT_FIXED0_SIGNATURE_VALUE

I converted the _FIXED macros to register! entries, and now the only thing I need now is:

/// IFR signature: ASCII "NVGI" as a little-endian u32.
const NV_PBUS_IFR_FMT_FIXED0_SIGNATURE_VALUE: u32 = 0x4947564E;
/// ROM directory signature: ASCII "RFRD" as a little-endian u32.
const NV_ROM_DIRECTORY_IDENTIFIER: u32 = 0x44524652;
/// Offset of the NV_PMGR_ROM_ADDR_OFFSET register in IFR Extended section
const IFR_SW_EXT_ROM_ADDR_OFFSET: usize = 4;
/// Size of Redundant Firmware Flash Status section
const RFW_FLASH_STATUS_SIZE: usize = 4096;

The second two I made up, so they can't be imported.  NV_PBUS_IFR_FMT_FIXED0_SIGNATURE_VALUE comes
from dev_bus.h as you said, but NV_ROM_DIRECTORY_IDENTIFIER comes from kernel_gsp_vbios_tu102.c, so
I don't think it can be imported either.

Also, what tree is your DIFF for?  

  reply	other threads:[~2026-04-15 21:08 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 23:50 [PATCH v2 0/6] gpu: nova-core: add GA100 support Timur Tabi
2026-04-14 23:50 ` [PATCH v2 1/6] gpu: nova-core: use correct fwsignature for GA100 Timur Tabi
2026-04-15 13:45   ` Gary Guo
2026-04-15 16:45     ` Timur Tabi
2026-04-15 16:55       ` Gary Guo
2026-04-15 16:58         ` Timur Tabi
2026-04-14 23:50 ` [PATCH v2 2/6] gpu: nova-core: do not consider 0xBB77 as a valid PCI ROM header signature Timur Tabi
2026-04-14 23:50 ` [PATCH v2 3/6] gpu: nova-core: only boot FRTS if its region is allocated Timur Tabi
2026-04-15  4:33   ` Eliot Courtney
2026-04-14 23:50 ` [PATCH v2 4/6] gpu: nova-core: add FbHal::frts_size() for GA100 support Timur Tabi
2026-04-15  4:36   ` Eliot Courtney
2026-04-15  6:55   ` Alexandre Courbot
2026-04-15 13:48   ` Gary Guo
2026-04-15 13:57     ` Alexandre Courbot
2026-04-15 16:57       ` Gary Guo
2026-04-15 16:59         ` Timur Tabi
2026-04-14 23:50 ` [PATCH v2 5/6] gpu: nova-core: skip the IFR header if present Timur Tabi
2026-04-15  5:23   ` Eliot Courtney
2026-04-15 21:08     ` Timur Tabi [this message]
2026-04-16  0:00       ` Timur Tabi
2026-04-17  4:09         ` Alexandre Courbot
2026-04-15  6:54   ` Alexandre Courbot
2026-04-15 13:49   ` Gary Guo
2026-04-15 14:00   ` Alexandre Courbot
2026-04-14 23:50 ` [PATCH v2 6/6] gpu: nova-core: enable GA100 Timur Tabi
2026-04-15 13:51   ` Gary Guo
2026-04-15 16:43     ` Timur Tabi
2026-04-15 16:58       ` Gary Guo
2026-04-15 17:01         ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=025756bb7dab3527b3070a94f8b4f70b5ba5622d.camel@nvidia.com \
    --to=ttabi@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=ecourtney@nvidia.com \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox