public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: "Timur Tabi" <ttabi@nvidia.com>,
	"gary@garyguo.net" <gary@garyguo.net>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"dakr@kernel.org" <dakr@kernel.org>,
	"Eliot Courtney" <ecourtney@nvidia.com>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v2 1/6] gpu: nova-core: use correct fwsignature for GA100
Date: Wed, 15 Apr 2026 17:55:19 +0100	[thread overview]
Message-ID: <DHTVWYLLMFFM.286A2CN2A13S0@garyguo.net> (raw)
In-Reply-To: <fa185d19ea0e43a55a32af1e76fc1a29534a264a.camel@nvidia.com>

On Wed Apr 15, 2026 at 5:45 PM BST, Timur Tabi wrote:
> On Wed, 2026-04-15 at 14:45 +0100, Gary Guo wrote:
>> >                           Architecture::Turing => ".fwsignature_tu10x",
>> >                           // GA100 uses the same firmware as Turing
>> 
>> This comment should be removed.
>
> This is relevant because GA102 does not, even though both GA100 and GA102 are Amperes.
>
> I could word it better, but it's an important factoid.

It's an important factoid, but it's not relevant here for fwsignature, right?
It doesn't use `fwsignature_tu...` so the factoid does not belong here.

Best,
Gary

  reply	other threads:[~2026-04-15 16:55 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 23:50 [PATCH v2 0/6] gpu: nova-core: add GA100 support Timur Tabi
2026-04-14 23:50 ` [PATCH v2 1/6] gpu: nova-core: use correct fwsignature for GA100 Timur Tabi
2026-04-15 13:45   ` Gary Guo
2026-04-15 16:45     ` Timur Tabi
2026-04-15 16:55       ` Gary Guo [this message]
2026-04-15 16:58         ` Timur Tabi
2026-04-14 23:50 ` [PATCH v2 2/6] gpu: nova-core: do not consider 0xBB77 as a valid PCI ROM header signature Timur Tabi
2026-04-14 23:50 ` [PATCH v2 3/6] gpu: nova-core: only boot FRTS if its region is allocated Timur Tabi
2026-04-15  4:33   ` Eliot Courtney
2026-04-14 23:50 ` [PATCH v2 4/6] gpu: nova-core: add FbHal::frts_size() for GA100 support Timur Tabi
2026-04-15  4:36   ` Eliot Courtney
2026-04-15  6:55   ` Alexandre Courbot
2026-04-15 13:48   ` Gary Guo
2026-04-15 13:57     ` Alexandre Courbot
2026-04-15 16:57       ` Gary Guo
2026-04-15 16:59         ` Timur Tabi
2026-04-14 23:50 ` [PATCH v2 5/6] gpu: nova-core: skip the IFR header if present Timur Tabi
2026-04-15  5:23   ` Eliot Courtney
2026-04-15 21:08     ` Timur Tabi
2026-04-16  0:00       ` Timur Tabi
2026-04-17  4:09         ` Alexandre Courbot
2026-04-15  6:54   ` Alexandre Courbot
2026-04-15 13:49   ` Gary Guo
2026-04-15 14:00   ` Alexandre Courbot
2026-04-14 23:50 ` [PATCH v2 6/6] gpu: nova-core: enable GA100 Timur Tabi
2026-04-15 13:51   ` Gary Guo
2026-04-15 16:43     ` Timur Tabi
2026-04-15 16:58       ` Gary Guo
2026-04-15 17:01         ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHTVWYLLMFFM.286A2CN2A13S0@garyguo.net \
    --to=gary@garyguo.net \
    --cc=acourbot@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=ecourtney@nvidia.com \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=ttabi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox