From: "Gary Guo" <gary@garyguo.net>
To: "Timur Tabi" <ttabi@nvidia.com>,
"gary@garyguo.net" <gary@garyguo.net>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"dakr@kernel.org" <dakr@kernel.org>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v2 6/6] gpu: nova-core: enable GA100
Date: Wed, 15 Apr 2026 17:58:50 +0100 [thread overview]
Message-ID: <DHTVZNMKLJ9Y.1WSQK2H2JC6I1@garyguo.net> (raw)
In-Reply-To: <ec32b84b55ddaa91e347d8152b10f9fcd53a46b2.camel@nvidia.com>
On Wed Apr 15, 2026 at 5:43 PM BST, Timur Tabi wrote:
> On Wed, 2026-04-15 at 14:51 +0100, Gary Guo wrote:
>> > GA100 is a compute-only variant of GA102 that boots GSP-RM like a
>> > Turing, although it also has its own unique requirements.
>> >
>> > Now that all the pieces are in place, we can enable GA100 support.
>> > Although architecturally like an Ampere, GA100 uses the same GSP-RM
>> > firmware files as Turing, and therefore must boot it like Turing does.
>> > However, as a compute-only part, GA100 has no display engine.
>>
>> This should go into the code as a comment.
>
> We don't describe any other GPU in the code. Where exactly do you think this comment should go?
Something like
GA100 | // GA100 boots like Turing so use Turing HAL
TU102 | TU104 | TU106 | TU116 | TU117 => {
? Otherwise it just looks like broken code for those unaware of the details,
given it goes and use TU HAL despite being GA.
Best,
Gary
next prev parent reply other threads:[~2026-04-15 16:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 23:50 [PATCH v2 0/6] gpu: nova-core: add GA100 support Timur Tabi
2026-04-14 23:50 ` [PATCH v2 1/6] gpu: nova-core: use correct fwsignature for GA100 Timur Tabi
2026-04-15 13:45 ` Gary Guo
2026-04-15 16:45 ` Timur Tabi
2026-04-15 16:55 ` Gary Guo
2026-04-15 16:58 ` Timur Tabi
2026-04-14 23:50 ` [PATCH v2 2/6] gpu: nova-core: do not consider 0xBB77 as a valid PCI ROM header signature Timur Tabi
2026-04-14 23:50 ` [PATCH v2 3/6] gpu: nova-core: only boot FRTS if its region is allocated Timur Tabi
2026-04-15 4:33 ` Eliot Courtney
2026-04-14 23:50 ` [PATCH v2 4/6] gpu: nova-core: add FbHal::frts_size() for GA100 support Timur Tabi
2026-04-15 4:36 ` Eliot Courtney
2026-04-15 6:55 ` Alexandre Courbot
2026-04-15 13:48 ` Gary Guo
2026-04-15 13:57 ` Alexandre Courbot
2026-04-15 16:57 ` Gary Guo
2026-04-15 16:59 ` Timur Tabi
2026-04-14 23:50 ` [PATCH v2 5/6] gpu: nova-core: skip the IFR header if present Timur Tabi
2026-04-15 5:23 ` Eliot Courtney
2026-04-15 21:08 ` Timur Tabi
2026-04-16 0:00 ` Timur Tabi
2026-04-17 4:09 ` Alexandre Courbot
2026-04-15 6:54 ` Alexandre Courbot
2026-04-15 13:49 ` Gary Guo
2026-04-15 14:00 ` Alexandre Courbot
2026-04-14 23:50 ` [PATCH v2 6/6] gpu: nova-core: enable GA100 Timur Tabi
2026-04-15 13:51 ` Gary Guo
2026-04-15 16:43 ` Timur Tabi
2026-04-15 16:58 ` Gary Guo [this message]
2026-04-15 17:01 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHTVZNMKLJ9Y.1WSQK2H2JC6I1@garyguo.net \
--to=gary@garyguo.net \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox