[U-Boot-Users] [PATCH] Add support for Atmel flash

[U-Boot-Users] [PATCH] Add support for Atmel flash

[Ulf Samuelsson]

Add ID codes for most recent Atmel NOR flashes

Signed-off-by: Ulf Samuelsson <ulf@atmel.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: atmel-flash.patch
Type: text/x-patch
Size: 1841 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080412/72ec5660/attachment.bin 

[U-Boot-Users] [PATCH] Add support for Atmel flash

[Stelian Pop]

Le samedi 12 avril 2008 ? 21:03 +0200, Ulf Samuelsson a ?crit :
> Add ID codes for most recent Atmel NOR flashes

Is there any added value on using the atmel flash driver instead of the
standard CFI driver ? It surely doesn't have any on the SAM9/CAP9
boards, but I'm not sure of the older AT91RM9200.

Thanks,
-- 
Stelian Pop <stelian@popies.net>

[U-Boot-Users] [PATCH] Add support for Atmel flash

[Ulf Samuelsson]

> Le samedi 12 avril 2008 ? 21:03 +0200, Ulf Samuelsson a ?crit :
>> Add ID codes for most recent Atmel NOR flashes
> 
> Is there any added value on using the atmel flash driver instead of the
> standard CFI driver ? It surely doesn't have any on the SAM9/CAP9
> boards, but I'm not sure of the older AT91RM9200.
> 
> Thanks,
> -- 
> Stelian Pop <stelian@popies.net>
> 


It is mainly time related.
This flash driver is well tested on the AT91RM9200EK.
The standard CFI driver is not.
While CFI should work, I do not have time to make a thorough test.

Best Regards
Ulf Samuelsson

[U-Boot-Users] [PATCH] Add support for Atmel flash

[Stelian Pop]

Le lundi 14 avril 2008 ? 08:00 +0200, Ulf Samuelsson a ?crit :
> > Le samedi 12 avril 2008 ? 21:03 +0200, Ulf Samuelsson a ?crit :
> >> Add ID codes for most recent Atmel NOR flashes
> > 
> > Is there any added value on using the atmel flash driver instead of the
> > standard CFI driver ? It surely doesn't have any on the SAM9/CAP9
> > boards, but I'm not sure of the older AT91RM9200.
> > 
> > Thanks,
> > -- 
> > Stelian Pop <stelian@popies.net>
> > 
> 
> 
> It is mainly time related.
> This flash driver is well tested on the AT91RM9200EK.
> The standard CFI driver is not.
> While CFI should work, I do not have time to make a thorough test.

Linux seems to use the CFI driver, just like every other SAM/CAP board,
so it should be safe to switch to the standard CFI driver.

The only remaining issue is testing, and I was hoping you could do this
as part of the new board porting. :)

Thanks,

-- 
Stelian Pop <stelian@popies.net>

[U-Boot-Users] [PATCH] Add support for Atmel flash

[Ulf Samuelsson]

> 
> Le lundi 14 avril 2008 ? 08:00 +0200, Ulf Samuelsson a ?crit :
>> > Le samedi 12 avril 2008 ? 21:03 +0200, Ulf Samuelsson a ?crit :
>> >> Add ID codes for most recent Atmel NOR flashes
>> > 
>> > Is there any added value on using the atmel flash driver instead of the
>> > standard CFI driver ? It surely doesn't have any on the SAM9/CAP9
>> > boards, but I'm not sure of the older AT91RM9200.
>> > 
>> > Thanks,
>> > -- 
>> > Stelian Pop <stelian@popies.net>
>> > 
>> 
>> 
>> It is mainly time related.
>> This flash driver is well tested on the AT91RM9200EK.
>> The standard CFI driver is not.
>> While CFI should work, I do not have time to make a thorough test.
> 
> Linux seems to use the CFI driver, just like every other SAM/CAP board,
> so it should be safe to switch to the standard CFI driver.
> 
> The only remaining issue is testing, and I was hoping you could do this
> as part of the new board porting. :)
> 


This is not "porting of a new board".
This board support has existed for 3-4 years in the Atmel U-Boot.

Best Regards
Ulf Samuelsson

[U-Boot-Users] [PATCH] Add support for Atmel flash

[Jean-Christophe PLAGNIOL-VILLARD]

On 11:19 Mon 14 Apr     , Stelian Pop wrote:
> 
> Le lundi 14 avril 2008 ? 08:00 +0200, Ulf Samuelsson a ?crit :
> > > Le samedi 12 avril 2008 ? 21:03 +0200, Ulf Samuelsson a ?crit :
> > >> Add ID codes for most recent Atmel NOR flashes
> > > 
> > > Is there any added value on using the atmel flash driver instead of the
> > > standard CFI driver ? It surely doesn't have any on the SAM9/CAP9
> > > boards, but I'm not sure of the older AT91RM9200.
> > > 
> > > Thanks,
> > > -- 
> > > Stelian Pop <stelian@popies.net>
> > > 
> > 
> > 
> > It is mainly time related.
> > This flash driver is well tested on the AT91RM9200EK.
> > The standard CFI driver is not.
> > While CFI should work, I do not have time to make a thorough test.
> 
> Linux seems to use the CFI driver, just like every other SAM/CAP board,
> so it should be safe to switch to the standard CFI driver.

I agree with Stelian, I prefer you use the CFI driver, but I known that
there is somme difference between then. Untill you've test and qualify the CFI
driver for the AT91RM9200EK. I'll ack your patch.

Best Regards,
J.

[U-Boot-Users] [PATCH] Add support for Atmel flash

[Wolfgang Denk]

In message <1208093818.23686.11.camel@voyager.dsnet> you wrote:
> 
> Le samedi 12 avril 2008 =E0 21:03 +0200, Ulf Samuelsson a =E9crit :
> > Add ID codes for most recent Atmel NOR flashes
> 
> Is there any added value on using the atmel flash driver instead of the
> standard CFI driver ? It surely doesn't have any on the SAM9/CAP9
> boards, but I'm not sure of the older AT91RM9200.

I don't think there is.

For the existing boards, the already exisitng values should be
sufficient, and for new boards we should use the CFI driver.

I intend to NAK new boards with CFI conformant flashes that don't use
the CFI driver unless thay have very good reasons.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The more data I punch in this card,  the lighter it becomes, and the
lower the mailing cost."
                     - Stan Kelly-Bootle, "The Devil's DP Dictionary"

[U-Boot-Users] [PATCH] Add support for Atmel flash

[Wolfgang Denk]

In message <1208027002.23686.7.camel@elrond.atmel.sweden> you wrote:
> 
> Add ID codes for most recent Atmel NOR flashes
> 
> Signed-off-by: Ulf Samuelsson <ulf@atmel.com>

Rejected. Please use the CFI driver for newly added code. For this,
such defines are not needed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There is such a fine line between genius and stupidity."
- David St. Hubbins, "Spinal Tap"