public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH 0/5] Fix FIT hash algos in SPL (Fixes v2021.10-rc2)
@ 2021-08-24  0:53 Alexandru Gagniuc
  2021-08-24  0:53 ` [PATCH 1/5] common: Remove unused CONFIG_FIT_SHAxxx selectors Alexandru Gagniuc
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Alexandru Gagniuc @ 2021-08-24  0:53 UTC (permalink / raw)
  To: trini, u-boot; +Cc: sjg, Alexandru Gagniuc

Simon and I recently worked on killing a bunch extra definitions. One
of the side-effects is that certain hash algorithms won't work in SPL
when used in the context of FIT verification.

For example, in FIT verification, CONFIG_IS_ENABLED(SHA256) is used
(good), but there is no corresponding CONFIG_SPL_SHA256 (bad). This
will always be false for SPL, hence certain "hash" algos are broken.

This series resolves the selection by replacing the broken selection
with hash_lookup_algo(), which does not have the aforementioned
problem. This at the very least allows 'algo = "sha256"' FIT nodes to
work in SPL.

This series does not attempt to add individual SHA/CRC/MD5 configs for
SPL. Hash algo selection for SPL has been problematic even before. This
series is meant as an emergency fix, so it does not attempt to tackle
general refactoring issues.

Alexandru Gagniuc (5):
  common: Remove unused CONFIG_FIT_SHAxxx selectors
  lib: Drop SHA512_ALGO in lieu of SHA512
  common/spl: Drop SPL_HASH_SUPPORT in favor of SPL_HASH
  image: Drop if/elseif hash selection in calculate_hash()
  image: Drop IMAGE_ENABLE_{MD5, CRC32} #defines

 arch/arm/mach-socfpga/Kconfig                 |  2 +-
 common/Kconfig.boot                           | 32 ++---------
 common/Makefile                               |  3 +-
 common/image-fit.c                            | 45 +++++++---------
 common/spl/Kconfig                            | 54 +------------------
 ...s1021atwr_sdcard_ifc_SECURE_BOOT_defconfig |  2 +-
 configs/ls1043ardb_nand_SECURE_BOOT_defconfig |  2 +-
 .../ls1043ardb_sdcard_SECURE_BOOT_defconfig   |  2 +-
 .../ls1046ardb_sdcard_SECURE_BOOT_defconfig   |  2 +-
 ...1088ardb_sdcard_qspi_SECURE_BOOT_defconfig |  2 +-
 configs/mt8516_pumpkin_defconfig              |  2 +-
 include/configs/xilinx_zynqmp.h               |  2 +-
 include/image.h                               | 23 --------
 lib/Kconfig                                   | 12 ++---
 lib/Makefile                                  |  2 +-
 lib/crypt/Kconfig                             |  2 +-
 lib/efi_loader/Kconfig                        |  2 +-
 lib/sha512.c                                  |  2 -
 18 files changed, 39 insertions(+), 154 deletions(-)

-- 
2.31.1


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-08-30 16:19 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-24  0:53 [PATCH 0/5] Fix FIT hash algos in SPL (Fixes v2021.10-rc2) Alexandru Gagniuc
2021-08-24  0:53 ` [PATCH 1/5] common: Remove unused CONFIG_FIT_SHAxxx selectors Alexandru Gagniuc
2021-08-24  0:53 ` [PATCH 2/5] lib: Drop SHA512_ALGO in lieu of SHA512 Alexandru Gagniuc
2021-08-24  0:53 ` [PATCH 3/5] common/spl: Drop SPL_HASH_SUPPORT in favor of SPL_HASH Alexandru Gagniuc
2021-08-30 13:58   ` Tom Rini
2021-08-30 16:02   ` Tom Rini
2021-08-30 16:19   ` Tom Rini
2021-08-24  0:53 ` [PATCH 4/5] image: Drop if/elseif hash selection in calculate_hash() Alexandru Gagniuc
2021-08-30 16:01   ` Tom Rini
2021-08-24  0:53 ` [PATCH 5/5] image: Drop IMAGE_ENABLE_{MD5, CRC32} #defines Alexandru Gagniuc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox