* [PATCH v3 01/19] bootstd: Move bootflow-adding to bootstd
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
@ 2024-11-04 17:50 ` Simon Glass
2024-11-04 22:02 ` Heinrich Schuchardt
2024-11-04 17:50 ` [PATCH v3 02/19] bootstd: Move bootflow-clearing " Simon Glass
` (18 subsequent siblings)
19 siblings, 1 reply; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:50 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Caleb Connolly, Dragan Simic,
Heinrich Schuchardt, Ilias Apalodimas, Nam Cao, Peter Robinson,
Thomas Weißschuh, Tony Dinh
This relates to more than just the bootdev, since there is a global list
of bootflows. Move the function to the bootstd file and rename it.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
(no changes since v1)
boot/bootdev-uclass.c | 25 -------------------------
boot/bootstd-uclass.c | 25 +++++++++++++++++++++++++
cmd/bootflow.c | 2 +-
include/bootdev.h | 15 ---------------
include/bootstd.h | 17 +++++++++++++++++
5 files changed, 43 insertions(+), 41 deletions(-)
diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c
index 64ec4fde493..eddbf60600c 100644
--- a/boot/bootdev-uclass.c
+++ b/boot/bootdev-uclass.c
@@ -32,31 +32,6 @@ enum {
BOOT_TARGETS_MAX_LEN = 100,
};
-int bootdev_add_bootflow(struct bootflow *bflow)
-{
- struct bootstd_priv *std;
- struct bootflow *new;
- int ret;
-
- ret = bootstd_get_priv(&std);
- if (ret)
- return ret;
-
- new = malloc(sizeof(*bflow));
- if (!new)
- return log_msg_ret("bflow", -ENOMEM);
- memcpy(new, bflow, sizeof(*bflow));
-
- list_add_tail(&new->glob_node, &std->glob_head);
- if (bflow->dev) {
- struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
-
- list_add_tail(&new->bm_node, &ucp->bootflow_head);
- }
-
- return 0;
-}
-
int bootdev_first_bootflow(struct udevice *dev, struct bootflow **bflowp)
{
struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c
index fdb8d69e320..bf6e49ad97a 100644
--- a/boot/bootstd-uclass.c
+++ b/boot/bootstd-uclass.c
@@ -61,6 +61,31 @@ void bootstd_clear_glob(void)
bootstd_clear_glob_(std);
}
+int bootstd_add_bootflow(struct bootflow *bflow)
+{
+ struct bootstd_priv *std;
+ struct bootflow *new;
+ int ret;
+
+ ret = bootstd_get_priv(&std);
+ if (ret)
+ return ret;
+
+ new = malloc(sizeof(*bflow));
+ if (!new)
+ return log_msg_ret("bflow", -ENOMEM);
+ memcpy(new, bflow, sizeof(*bflow));
+
+ list_add_tail(&new->glob_node, &std->glob_head);
+ if (bflow->dev) {
+ struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
+
+ list_add_tail(&new->bm_node, &ucp->bootflow_head);
+ }
+
+ return 0;
+}
+
static int bootstd_remove(struct udevice *dev)
{
struct bootstd_priv *priv = dev_get_priv(dev);
diff --git a/cmd/bootflow.c b/cmd/bootflow.c
index f67948d7368..8962464bbf8 100644
--- a/cmd/bootflow.c
+++ b/cmd/bootflow.c
@@ -207,7 +207,7 @@ static int do_bootflow_scan(struct cmd_tbl *cmdtp, int flag, int argc,
bflow.err = ret;
if (!ret)
num_valid++;
- ret = bootdev_add_bootflow(&bflow);
+ ret = bootstd_add_bootflow(&bflow);
if (ret) {
printf("Out of memory\n");
return CMD_RET_FAILURE;
diff --git a/include/bootdev.h b/include/bootdev.h
index ad4af0d1310..8db198dd56b 100644
--- a/include/bootdev.h
+++ b/include/bootdev.h
@@ -195,21 +195,6 @@ void bootdev_list(bool probe);
*/
void bootdev_clear_bootflows(struct udevice *dev);
-/**
- * bootdev_add_bootflow() - Add a bootflow to the bootdev's list
- *
- * All fields in @bflow must be set up. Note that @bflow->dev is used to add the
- * bootflow to that device.
- *
- * @dev: Bootdev device to add to
- * @bflow: Bootflow to add. Note that fields within bflow must be allocated
- * since this function takes over ownership of these. This functions makes
- * a copy of @bflow itself (without allocating its fields again), so the
- * caller must dispose of the memory used by the @bflow pointer itself
- * Return: 0 if OK, -ENOMEM if out of memory
- */
-int bootdev_add_bootflow(struct bootflow *bflow);
-
/**
* bootdev_first_bootflow() - Get the first bootflow from a bootdev
*
diff --git a/include/bootstd.h b/include/bootstd.h
index ac756e98d84..3fc93a4ec2e 100644
--- a/include/bootstd.h
+++ b/include/bootstd.h
@@ -105,4 +105,21 @@ void bootstd_clear_glob(void);
*/
int bootstd_prog_boot(void);
+/**
+ * bootstd_add_bootflow() - Add a bootflow to the bootdev's and global list
+ *
+ * All fields in @bflow must be set up. Note that @bflow->dev is used to add the
+ * bootflow to that device.
+ *
+ * The bootflow is also added to the global list of all bootflows
+ *
+ * @dev: Bootdev device to add to
+ * @bflow: Bootflow to add. Note that fields within bflow must be allocated
+ * since this function takes over ownership of these. This functions makes
+ * a copy of @bflow itself (without allocating its fields again), so the
+ * caller must dispose of the memory used by the @bflow pointer itself
+ * Return: 0 if OK, -ENOMEM if out of memory
+ */
+int bootstd_add_bootflow(struct bootflow *bflow);
+
#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v3 01/19] bootstd: Move bootflow-adding to bootstd
2024-11-04 17:50 ` [PATCH v3 01/19] bootstd: Move bootflow-adding to bootstd Simon Glass
@ 2024-11-04 22:02 ` Heinrich Schuchardt
2024-11-05 15:13 ` Simon Glass
0 siblings, 1 reply; 41+ messages in thread
From: Heinrich Schuchardt @ 2024-11-04 22:02 UTC (permalink / raw)
To: Simon Glass
Cc: Tom Rini, Caleb Connolly, Dragan Simic, Ilias Apalodimas, Nam Cao,
Peter Robinson, Thomas Weißschuh, Tony Dinh,
U-Boot Mailing List
On 11/4/24 18:50, Simon Glass wrote:
> This relates to more than just the bootdev, since there is a global list
> of bootflows. Move the function to the bootstd file and rename it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v1)
>
> boot/bootdev-uclass.c | 25 -------------------------
> boot/bootstd-uclass.c | 25 +++++++++++++++++++++++++
> cmd/bootflow.c | 2 +-
> include/bootdev.h | 15 ---------------
> include/bootstd.h | 17 +++++++++++++++++
> 5 files changed, 43 insertions(+), 41 deletions(-)
>
> diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c
> index 64ec4fde493..eddbf60600c 100644
> --- a/boot/bootdev-uclass.c
> +++ b/boot/bootdev-uclass.c
> @@ -32,31 +32,6 @@ enum {
> BOOT_TARGETS_MAX_LEN = 100,
> };
>
> -int bootdev_add_bootflow(struct bootflow *bflow)
> -{
> - struct bootstd_priv *std;
> - struct bootflow *new;
> - int ret;
> -
> - ret = bootstd_get_priv(&std);
> - if (ret)
> - return ret;
> -
> - new = malloc(sizeof(*bflow));
> - if (!new)
> - return log_msg_ret("bflow", -ENOMEM);
> - memcpy(new, bflow, sizeof(*bflow));
> -
> - list_add_tail(&new->glob_node, &std->glob_head);
> - if (bflow->dev) {
> - struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
> -
> - list_add_tail(&new->bm_node, &ucp->bootflow_head);
> - }
> -
> - return 0;
> -}
> -
> int bootdev_first_bootflow(struct udevice *dev, struct bootflow **bflowp)
> {
> struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
> diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c
> index fdb8d69e320..bf6e49ad97a 100644
> --- a/boot/bootstd-uclass.c
> +++ b/boot/bootstd-uclass.c
> @@ -61,6 +61,31 @@ void bootstd_clear_glob(void)
> bootstd_clear_glob_(std);
> }
>
> +int bootstd_add_bootflow(struct bootflow *bflow)
> +{
> + struct bootstd_priv *std;
> + struct bootflow *new;
> + int ret;
> +
> + ret = bootstd_get_priv(&std);
> + if (ret)
> + return ret;
> +
> + new = malloc(sizeof(*bflow));
> + if (!new)
> + return log_msg_ret("bflow", -ENOMEM);
> + memcpy(new, bflow, sizeof(*bflow));
> +
> + list_add_tail(&new->glob_node, &std->glob_head);
> + if (bflow->dev) {
> + struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
> +
> + list_add_tail(&new->bm_node, &ucp->bootflow_head);
> + }
> +
> + return 0;
> +}
> +
> static int bootstd_remove(struct udevice *dev)
> {
> struct bootstd_priv *priv = dev_get_priv(dev);
> diff --git a/cmd/bootflow.c b/cmd/bootflow.c
> index f67948d7368..8962464bbf8 100644
> --- a/cmd/bootflow.c
> +++ b/cmd/bootflow.c
> @@ -207,7 +207,7 @@ static int do_bootflow_scan(struct cmd_tbl *cmdtp, int flag, int argc,
> bflow.err = ret;
> if (!ret)
> num_valid++;
> - ret = bootdev_add_bootflow(&bflow);
> + ret = bootstd_add_bootflow(&bflow);
> if (ret) {
> printf("Out of memory\n");
> return CMD_RET_FAILURE;
> diff --git a/include/bootdev.h b/include/bootdev.h
> index ad4af0d1310..8db198dd56b 100644
> --- a/include/bootdev.h
> +++ b/include/bootdev.h
> @@ -195,21 +195,6 @@ void bootdev_list(bool probe);
> */
> void bootdev_clear_bootflows(struct udevice *dev);
>
> -/**
> - * bootdev_add_bootflow() - Add a bootflow to the bootdev's list
> - *
> - * All fields in @bflow must be set up. Note that @bflow->dev is used to add the
> - * bootflow to that device.
> - *
> - * @dev: Bootdev device to add to
> - * @bflow: Bootflow to add. Note that fields within bflow must be allocated
> - * since this function takes over ownership of these. This functions makes
> - * a copy of @bflow itself (without allocating its fields again), so the
> - * caller must dispose of the memory used by the @bflow pointer itself
> - * Return: 0 if OK, -ENOMEM if out of memory
> - */
> -int bootdev_add_bootflow(struct bootflow *bflow);
> -
> /**
> * bootdev_first_bootflow() - Get the first bootflow from a bootdev
> *
> diff --git a/include/bootstd.h b/include/bootstd.h
> index ac756e98d84..3fc93a4ec2e 100644
> --- a/include/bootstd.h
> +++ b/include/bootstd.h
> @@ -105,4 +105,21 @@ void bootstd_clear_glob(void);
> */
> int bootstd_prog_boot(void);
>
> +/**
> + * bootstd_add_bootflow() - Add a bootflow to the bootdev's and global list
> + *
> + * All fields in @bflow must be set up. Note that @bflow->dev is used to add the
> + * bootflow to that device.
> + *
> + * The bootflow is also added to the global list of all bootflows
> + *
> + * @dev: Bootdev device to add to
This parameter does not exist.
> + * @bflow: Bootflow to add. Note that fields within bflow must be allocated
> + * since this function takes over ownership of these. This functions makes
> + * a copy of @bflow itself (without allocating its fields again), so the
> + * caller must dispose of the memory used by the @bflow pointer itself
Please, add the headers to the API documentation and fix the numerous
documentation issues like:
./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_0_NONE' not
described in enum 'bootdev_prio_t'
./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_1_PRE_SCAN' not
described in enum 'bootdev_prio_t'
./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_COUNT' not
described in enum 'bootdev_prio_t'
./include/bootdev.h:57: warning: Excess enum value 'BOOTDEVP_6_PRE_SCAN'
description in 'bootdev_prio_t'
./include/bootdev.h:118: warning: Function parameter or member
'bootflow_head' not described in 'bootdev_uc_plat'
./include/bootdev.h:118: warning: Function parameter or member 'prio'
not described in 'bootdev_uc_plat'
./include/bootdev.h:412: warning: Function parameter or member 'blk' not
described in 'bootdev_setup_for_sibling_blk'
./include/bootdev.h:412: warning: Excess function parameter 'parent'
description in 'bootdev_setup_for_sibling_blk'
Best regards
Heinrich
> + * Return: 0 if OK, -ENOMEM if out of memory
> + */
> +int bootstd_add_bootflow(struct bootflow *bflow);
> +
> #endif
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH v3 01/19] bootstd: Move bootflow-adding to bootstd
2024-11-04 22:02 ` Heinrich Schuchardt
@ 2024-11-05 15:13 ` Simon Glass
2024-11-05 15:39 ` Tom Rini
0 siblings, 1 reply; 41+ messages in thread
From: Simon Glass @ 2024-11-05 15:13 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Tom Rini, Caleb Connolly, Dragan Simic, Ilias Apalodimas, Nam Cao,
Peter Robinson, Thomas Weißschuh, Tony Dinh,
U-Boot Mailing List
Hi Heinrich,
On Mon, 4 Nov 2024 at 15:15, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 11/4/24 18:50, Simon Glass wrote:
> > This relates to more than just the bootdev, since there is a global list
> > of bootflows. Move the function to the bootstd file and rename it.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> > (no changes since v1)
> >
> > boot/bootdev-uclass.c | 25 -------------------------
> > boot/bootstd-uclass.c | 25 +++++++++++++++++++++++++
> > cmd/bootflow.c | 2 +-
> > include/bootdev.h | 15 ---------------
> > include/bootstd.h | 17 +++++++++++++++++
> > 5 files changed, 43 insertions(+), 41 deletions(-)
> >
> > diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c
> > index 64ec4fde493..eddbf60600c 100644
> > --- a/boot/bootdev-uclass.c
> > +++ b/boot/bootdev-uclass.c
> > @@ -32,31 +32,6 @@ enum {
> > BOOT_TARGETS_MAX_LEN = 100,
> > };
> >
> > -int bootdev_add_bootflow(struct bootflow *bflow)
> > -{
> > - struct bootstd_priv *std;
> > - struct bootflow *new;
> > - int ret;
> > -
> > - ret = bootstd_get_priv(&std);
> > - if (ret)
> > - return ret;
> > -
> > - new = malloc(sizeof(*bflow));
> > - if (!new)
> > - return log_msg_ret("bflow", -ENOMEM);
> > - memcpy(new, bflow, sizeof(*bflow));
> > -
> > - list_add_tail(&new->glob_node, &std->glob_head);
> > - if (bflow->dev) {
> > - struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
> > -
> > - list_add_tail(&new->bm_node, &ucp->bootflow_head);
> > - }
> > -
> > - return 0;
> > -}
> > -
> > int bootdev_first_bootflow(struct udevice *dev, struct bootflow **bflowp)
> > {
> > struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
> > diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c
> > index fdb8d69e320..bf6e49ad97a 100644
> > --- a/boot/bootstd-uclass.c
> > +++ b/boot/bootstd-uclass.c
> > @@ -61,6 +61,31 @@ void bootstd_clear_glob(void)
> > bootstd_clear_glob_(std);
> > }
> >
> > +int bootstd_add_bootflow(struct bootflow *bflow)
> > +{
> > + struct bootstd_priv *std;
> > + struct bootflow *new;
> > + int ret;
> > +
> > + ret = bootstd_get_priv(&std);
> > + if (ret)
> > + return ret;
> > +
> > + new = malloc(sizeof(*bflow));
> > + if (!new)
> > + return log_msg_ret("bflow", -ENOMEM);
> > + memcpy(new, bflow, sizeof(*bflow));
> > +
> > + list_add_tail(&new->glob_node, &std->glob_head);
> > + if (bflow->dev) {
> > + struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
> > +
> > + list_add_tail(&new->bm_node, &ucp->bootflow_head);
> > + }
> > +
> > + return 0;
> > +}
> > +
> > static int bootstd_remove(struct udevice *dev)
> > {
> > struct bootstd_priv *priv = dev_get_priv(dev);
> > diff --git a/cmd/bootflow.c b/cmd/bootflow.c
> > index f67948d7368..8962464bbf8 100644
> > --- a/cmd/bootflow.c
> > +++ b/cmd/bootflow.c
> > @@ -207,7 +207,7 @@ static int do_bootflow_scan(struct cmd_tbl *cmdtp, int flag, int argc,
> > bflow.err = ret;
> > if (!ret)
> > num_valid++;
> > - ret = bootdev_add_bootflow(&bflow);
> > + ret = bootstd_add_bootflow(&bflow);
> > if (ret) {
> > printf("Out of memory\n");
> > return CMD_RET_FAILURE;
> > diff --git a/include/bootdev.h b/include/bootdev.h
> > index ad4af0d1310..8db198dd56b 100644
> > --- a/include/bootdev.h
> > +++ b/include/bootdev.h
> > @@ -195,21 +195,6 @@ void bootdev_list(bool probe);
> > */
> > void bootdev_clear_bootflows(struct udevice *dev);
> >
> > -/**
> > - * bootdev_add_bootflow() - Add a bootflow to the bootdev's list
> > - *
> > - * All fields in @bflow must be set up. Note that @bflow->dev is used to add the
> > - * bootflow to that device.
> > - *
> > - * @dev: Bootdev device to add to
> > - * @bflow: Bootflow to add. Note that fields within bflow must be allocated
> > - * since this function takes over ownership of these. This functions makes
> > - * a copy of @bflow itself (without allocating its fields again), so the
> > - * caller must dispose of the memory used by the @bflow pointer itself
> > - * Return: 0 if OK, -ENOMEM if out of memory
> > - */
> > -int bootdev_add_bootflow(struct bootflow *bflow);
> > -
> > /**
> > * bootdev_first_bootflow() - Get the first bootflow from a bootdev
> > *
> > diff --git a/include/bootstd.h b/include/bootstd.h
> > index ac756e98d84..3fc93a4ec2e 100644
> > --- a/include/bootstd.h
> > +++ b/include/bootstd.h
> > @@ -105,4 +105,21 @@ void bootstd_clear_glob(void);
> > */
> > int bootstd_prog_boot(void);
> >
> > +/**
> > + * bootstd_add_bootflow() - Add a bootflow to the bootdev's and global list
> > + *
> > + * All fields in @bflow must be set up. Note that @bflow->dev is used to add the
> > + * bootflow to that device.
> > + *
> > + * The bootflow is also added to the global list of all bootflows
> > + *
> > + * @dev: Bootdev device to add to
>
> This parameter does not exist.
>
> > + * @bflow: Bootflow to add. Note that fields within bflow must be allocated
> > + * since this function takes over ownership of these. This functions makes
> > + * a copy of @bflow itself (without allocating its fields again), so the
> > + * caller must dispose of the memory used by the @bflow pointer itself
>
> Please, add the headers to the API documentation and fix the numerous
> documentation issues like:
>
> ./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_0_NONE' not
> described in enum 'bootdev_prio_t'
> ./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_1_PRE_SCAN' not
> described in enum 'bootdev_prio_t'
> ./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_COUNT' not
> described in enum 'bootdev_prio_t'
> ./include/bootdev.h:57: warning: Excess enum value 'BOOTDEVP_6_PRE_SCAN'
> description in 'bootdev_prio_t'
> ./include/bootdev.h:118: warning: Function parameter or member
> 'bootflow_head' not described in 'bootdev_uc_plat'
> ./include/bootdev.h:118: warning: Function parameter or member 'prio'
> not described in 'bootdev_uc_plat'
> ./include/bootdev.h:412: warning: Function parameter or member 'blk' not
> described in 'bootdev_setup_for_sibling_blk'
> ./include/bootdev.h:412: warning: Excess function parameter 'parent'
> description in 'bootdev_setup_for_sibling_blk'
I don't mind doing that in a follow-up once this series is in, but it
is out-of-scope here.
Regards,
Simon
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH v3 01/19] bootstd: Move bootflow-adding to bootstd
2024-11-05 15:13 ` Simon Glass
@ 2024-11-05 15:39 ` Tom Rini
2024-11-05 16:07 ` Simon Glass
0 siblings, 1 reply; 41+ messages in thread
From: Tom Rini @ 2024-11-05 15:39 UTC (permalink / raw)
To: Simon Glass
Cc: Heinrich Schuchardt, Caleb Connolly, Dragan Simic,
Ilias Apalodimas, Nam Cao, Peter Robinson, Thomas Weißschuh,
Tony Dinh, U-Boot Mailing List
[-- Attachment #1: Type: text/plain, Size: 7415 bytes --]
On Tue, Nov 05, 2024 at 08:13:04AM -0700, Simon Glass wrote:
> Hi Heinrich,
>
> On Mon, 4 Nov 2024 at 15:15, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> > On 11/4/24 18:50, Simon Glass wrote:
> > > This relates to more than just the bootdev, since there is a global list
> > > of bootflows. Move the function to the bootstd file and rename it.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > > boot/bootdev-uclass.c | 25 -------------------------
> > > boot/bootstd-uclass.c | 25 +++++++++++++++++++++++++
> > > cmd/bootflow.c | 2 +-
> > > include/bootdev.h | 15 ---------------
> > > include/bootstd.h | 17 +++++++++++++++++
> > > 5 files changed, 43 insertions(+), 41 deletions(-)
> > >
> > > diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c
> > > index 64ec4fde493..eddbf60600c 100644
> > > --- a/boot/bootdev-uclass.c
> > > +++ b/boot/bootdev-uclass.c
> > > @@ -32,31 +32,6 @@ enum {
> > > BOOT_TARGETS_MAX_LEN = 100,
> > > };
> > >
> > > -int bootdev_add_bootflow(struct bootflow *bflow)
> > > -{
> > > - struct bootstd_priv *std;
> > > - struct bootflow *new;
> > > - int ret;
> > > -
> > > - ret = bootstd_get_priv(&std);
> > > - if (ret)
> > > - return ret;
> > > -
> > > - new = malloc(sizeof(*bflow));
> > > - if (!new)
> > > - return log_msg_ret("bflow", -ENOMEM);
> > > - memcpy(new, bflow, sizeof(*bflow));
> > > -
> > > - list_add_tail(&new->glob_node, &std->glob_head);
> > > - if (bflow->dev) {
> > > - struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
> > > -
> > > - list_add_tail(&new->bm_node, &ucp->bootflow_head);
> > > - }
> > > -
> > > - return 0;
> > > -}
> > > -
> > > int bootdev_first_bootflow(struct udevice *dev, struct bootflow **bflowp)
> > > {
> > > struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
> > > diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c
> > > index fdb8d69e320..bf6e49ad97a 100644
> > > --- a/boot/bootstd-uclass.c
> > > +++ b/boot/bootstd-uclass.c
> > > @@ -61,6 +61,31 @@ void bootstd_clear_glob(void)
> > > bootstd_clear_glob_(std);
> > > }
> > >
> > > +int bootstd_add_bootflow(struct bootflow *bflow)
> > > +{
> > > + struct bootstd_priv *std;
> > > + struct bootflow *new;
> > > + int ret;
> > > +
> > > + ret = bootstd_get_priv(&std);
> > > + if (ret)
> > > + return ret;
> > > +
> > > + new = malloc(sizeof(*bflow));
> > > + if (!new)
> > > + return log_msg_ret("bflow", -ENOMEM);
> > > + memcpy(new, bflow, sizeof(*bflow));
> > > +
> > > + list_add_tail(&new->glob_node, &std->glob_head);
> > > + if (bflow->dev) {
> > > + struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
> > > +
> > > + list_add_tail(&new->bm_node, &ucp->bootflow_head);
> > > + }
> > > +
> > > + return 0;
> > > +}
> > > +
> > > static int bootstd_remove(struct udevice *dev)
> > > {
> > > struct bootstd_priv *priv = dev_get_priv(dev);
> > > diff --git a/cmd/bootflow.c b/cmd/bootflow.c
> > > index f67948d7368..8962464bbf8 100644
> > > --- a/cmd/bootflow.c
> > > +++ b/cmd/bootflow.c
> > > @@ -207,7 +207,7 @@ static int do_bootflow_scan(struct cmd_tbl *cmdtp, int flag, int argc,
> > > bflow.err = ret;
> > > if (!ret)
> > > num_valid++;
> > > - ret = bootdev_add_bootflow(&bflow);
> > > + ret = bootstd_add_bootflow(&bflow);
> > > if (ret) {
> > > printf("Out of memory\n");
> > > return CMD_RET_FAILURE;
> > > diff --git a/include/bootdev.h b/include/bootdev.h
> > > index ad4af0d1310..8db198dd56b 100644
> > > --- a/include/bootdev.h
> > > +++ b/include/bootdev.h
> > > @@ -195,21 +195,6 @@ void bootdev_list(bool probe);
> > > */
> > > void bootdev_clear_bootflows(struct udevice *dev);
> > >
> > > -/**
> > > - * bootdev_add_bootflow() - Add a bootflow to the bootdev's list
> > > - *
> > > - * All fields in @bflow must be set up. Note that @bflow->dev is used to add the
> > > - * bootflow to that device.
> > > - *
> > > - * @dev: Bootdev device to add to
> > > - * @bflow: Bootflow to add. Note that fields within bflow must be allocated
> > > - * since this function takes over ownership of these. This functions makes
> > > - * a copy of @bflow itself (without allocating its fields again), so the
> > > - * caller must dispose of the memory used by the @bflow pointer itself
> > > - * Return: 0 if OK, -ENOMEM if out of memory
> > > - */
> > > -int bootdev_add_bootflow(struct bootflow *bflow);
> > > -
> > > /**
> > > * bootdev_first_bootflow() - Get the first bootflow from a bootdev
> > > *
> > > diff --git a/include/bootstd.h b/include/bootstd.h
> > > index ac756e98d84..3fc93a4ec2e 100644
> > > --- a/include/bootstd.h
> > > +++ b/include/bootstd.h
> > > @@ -105,4 +105,21 @@ void bootstd_clear_glob(void);
> > > */
> > > int bootstd_prog_boot(void);
> > >
> > > +/**
> > > + * bootstd_add_bootflow() - Add a bootflow to the bootdev's and global list
> > > + *
> > > + * All fields in @bflow must be set up. Note that @bflow->dev is used to add the
> > > + * bootflow to that device.
> > > + *
> > > + * The bootflow is also added to the global list of all bootflows
> > > + *
> > > + * @dev: Bootdev device to add to
> >
> > This parameter does not exist.
> >
> > > + * @bflow: Bootflow to add. Note that fields within bflow must be allocated
> > > + * since this function takes over ownership of these. This functions makes
> > > + * a copy of @bflow itself (without allocating its fields again), so the
> > > + * caller must dispose of the memory used by the @bflow pointer itself
> >
> > Please, add the headers to the API documentation and fix the numerous
> > documentation issues like:
> >
> > ./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_0_NONE' not
> > described in enum 'bootdev_prio_t'
> > ./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_1_PRE_SCAN' not
> > described in enum 'bootdev_prio_t'
> > ./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_COUNT' not
> > described in enum 'bootdev_prio_t'
> > ./include/bootdev.h:57: warning: Excess enum value 'BOOTDEVP_6_PRE_SCAN'
> > description in 'bootdev_prio_t'
> > ./include/bootdev.h:118: warning: Function parameter or member
> > 'bootflow_head' not described in 'bootdev_uc_plat'
> > ./include/bootdev.h:118: warning: Function parameter or member 'prio'
> > not described in 'bootdev_uc_plat'
> > ./include/bootdev.h:412: warning: Function parameter or member 'blk' not
> > described in 'bootdev_setup_for_sibling_blk'
> > ./include/bootdev.h:412: warning: Excess function parameter 'parent'
> > description in 'bootdev_setup_for_sibling_blk'
>
> I don't mind doing that in a follow-up once this series is in, but it
> is out-of-scope here.
I think that's flipping the priorities. Documenting what all of this is
supposed to be doing will help explain to the rest of us what you're
intending to do and why it's a good idea and so forth.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH v3 01/19] bootstd: Move bootflow-adding to bootstd
2024-11-05 15:39 ` Tom Rini
@ 2024-11-05 16:07 ` Simon Glass
0 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-05 16:07 UTC (permalink / raw)
To: Tom Rini
Cc: Heinrich Schuchardt, Caleb Connolly, Dragan Simic,
Ilias Apalodimas, Nam Cao, Peter Robinson, Thomas Weißschuh,
Tony Dinh, U-Boot Mailing List
Hi Tom,
On Tue, 5 Nov 2024 at 08:39, Tom Rini <trini@konsulko.com> wrote:
>
> On Tue, Nov 05, 2024 at 08:13:04AM -0700, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Mon, 4 Nov 2024 at 15:15, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> > >
> > > On 11/4/24 18:50, Simon Glass wrote:
> > > > This relates to more than just the bootdev, since there is a global list
> > > > of bootflows. Move the function to the bootstd file and rename it.
> > > >
> > > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > > ---
> > > >
> > > > (no changes since v1)
> > > >
> > > > boot/bootdev-uclass.c | 25 -------------------------
> > > > boot/bootstd-uclass.c | 25 +++++++++++++++++++++++++
> > > > cmd/bootflow.c | 2 +-
> > > > include/bootdev.h | 15 ---------------
> > > > include/bootstd.h | 17 +++++++++++++++++
> > > > 5 files changed, 43 insertions(+), 41 deletions(-)
> > > >
> > > > diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c
> > > > index 64ec4fde493..eddbf60600c 100644
> > > > --- a/boot/bootdev-uclass.c
> > > > +++ b/boot/bootdev-uclass.c
> > > > @@ -32,31 +32,6 @@ enum {
> > > > BOOT_TARGETS_MAX_LEN = 100,
> > > > };
> > > >
> > > > -int bootdev_add_bootflow(struct bootflow *bflow)
> > > > -{
> > > > - struct bootstd_priv *std;
> > > > - struct bootflow *new;
> > > > - int ret;
> > > > -
> > > > - ret = bootstd_get_priv(&std);
> > > > - if (ret)
> > > > - return ret;
> > > > -
> > > > - new = malloc(sizeof(*bflow));
> > > > - if (!new)
> > > > - return log_msg_ret("bflow", -ENOMEM);
> > > > - memcpy(new, bflow, sizeof(*bflow));
> > > > -
> > > > - list_add_tail(&new->glob_node, &std->glob_head);
> > > > - if (bflow->dev) {
> > > > - struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
> > > > -
> > > > - list_add_tail(&new->bm_node, &ucp->bootflow_head);
> > > > - }
> > > > -
> > > > - return 0;
> > > > -}
> > > > -
> > > > int bootdev_first_bootflow(struct udevice *dev, struct bootflow **bflowp)
> > > > {
> > > > struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
> > > > diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c
> > > > index fdb8d69e320..bf6e49ad97a 100644
> > > > --- a/boot/bootstd-uclass.c
> > > > +++ b/boot/bootstd-uclass.c
> > > > @@ -61,6 +61,31 @@ void bootstd_clear_glob(void)
> > > > bootstd_clear_glob_(std);
> > > > }
> > > >
> > > > +int bootstd_add_bootflow(struct bootflow *bflow)
> > > > +{
> > > > + struct bootstd_priv *std;
> > > > + struct bootflow *new;
> > > > + int ret;
> > > > +
> > > > + ret = bootstd_get_priv(&std);
> > > > + if (ret)
> > > > + return ret;
> > > > +
> > > > + new = malloc(sizeof(*bflow));
> > > > + if (!new)
> > > > + return log_msg_ret("bflow", -ENOMEM);
> > > > + memcpy(new, bflow, sizeof(*bflow));
> > > > +
> > > > + list_add_tail(&new->glob_node, &std->glob_head);
> > > > + if (bflow->dev) {
> > > > + struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
> > > > +
> > > > + list_add_tail(&new->bm_node, &ucp->bootflow_head);
> > > > + }
> > > > +
> > > > + return 0;
> > > > +}
> > > > +
> > > > static int bootstd_remove(struct udevice *dev)
> > > > {
> > > > struct bootstd_priv *priv = dev_get_priv(dev);
> > > > diff --git a/cmd/bootflow.c b/cmd/bootflow.c
> > > > index f67948d7368..8962464bbf8 100644
> > > > --- a/cmd/bootflow.c
> > > > +++ b/cmd/bootflow.c
> > > > @@ -207,7 +207,7 @@ static int do_bootflow_scan(struct cmd_tbl *cmdtp, int flag, int argc,
> > > > bflow.err = ret;
> > > > if (!ret)
> > > > num_valid++;
> > > > - ret = bootdev_add_bootflow(&bflow);
> > > > + ret = bootstd_add_bootflow(&bflow);
> > > > if (ret) {
> > > > printf("Out of memory\n");
> > > > return CMD_RET_FAILURE;
> > > > diff --git a/include/bootdev.h b/include/bootdev.h
> > > > index ad4af0d1310..8db198dd56b 100644
> > > > --- a/include/bootdev.h
> > > > +++ b/include/bootdev.h
> > > > @@ -195,21 +195,6 @@ void bootdev_list(bool probe);
> > > > */
> > > > void bootdev_clear_bootflows(struct udevice *dev);
> > > >
> > > > -/**
> > > > - * bootdev_add_bootflow() - Add a bootflow to the bootdev's list
> > > > - *
> > > > - * All fields in @bflow must be set up. Note that @bflow->dev is used to add the
> > > > - * bootflow to that device.
> > > > - *
> > > > - * @dev: Bootdev device to add to
> > > > - * @bflow: Bootflow to add. Note that fields within bflow must be allocated
> > > > - * since this function takes over ownership of these. This functions makes
> > > > - * a copy of @bflow itself (without allocating its fields again), so the
> > > > - * caller must dispose of the memory used by the @bflow pointer itself
> > > > - * Return: 0 if OK, -ENOMEM if out of memory
> > > > - */
> > > > -int bootdev_add_bootflow(struct bootflow *bflow);
> > > > -
> > > > /**
> > > > * bootdev_first_bootflow() - Get the first bootflow from a bootdev
> > > > *
> > > > diff --git a/include/bootstd.h b/include/bootstd.h
> > > > index ac756e98d84..3fc93a4ec2e 100644
> > > > --- a/include/bootstd.h
> > > > +++ b/include/bootstd.h
> > > > @@ -105,4 +105,21 @@ void bootstd_clear_glob(void);
> > > > */
> > > > int bootstd_prog_boot(void);
> > > >
> > > > +/**
> > > > + * bootstd_add_bootflow() - Add a bootflow to the bootdev's and global list
> > > > + *
> > > > + * All fields in @bflow must be set up. Note that @bflow->dev is used to add the
> > > > + * bootflow to that device.
> > > > + *
> > > > + * The bootflow is also added to the global list of all bootflows
> > > > + *
> > > > + * @dev: Bootdev device to add to
> > >
> > > This parameter does not exist.
> > >
> > > > + * @bflow: Bootflow to add. Note that fields within bflow must be allocated
> > > > + * since this function takes over ownership of these. This functions makes
> > > > + * a copy of @bflow itself (without allocating its fields again), so the
> > > > + * caller must dispose of the memory used by the @bflow pointer itself
> > >
> > > Please, add the headers to the API documentation and fix the numerous
> > > documentation issues like:
> > >
> > > ./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_0_NONE' not
> > > described in enum 'bootdev_prio_t'
> > > ./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_1_PRE_SCAN' not
> > > described in enum 'bootdev_prio_t'
> > > ./include/bootdev.h:57: warning: Enum value 'BOOTDEVP_COUNT' not
> > > described in enum 'bootdev_prio_t'
> > > ./include/bootdev.h:57: warning: Excess enum value 'BOOTDEVP_6_PRE_SCAN'
> > > description in 'bootdev_prio_t'
> > > ./include/bootdev.h:118: warning: Function parameter or member
> > > 'bootflow_head' not described in 'bootdev_uc_plat'
> > > ./include/bootdev.h:118: warning: Function parameter or member 'prio'
> > > not described in 'bootdev_uc_plat'
> > > ./include/bootdev.h:412: warning: Function parameter or member 'blk' not
> > > described in 'bootdev_setup_for_sibling_blk'
> > > ./include/bootdev.h:412: warning: Excess function parameter 'parent'
> > > description in 'bootdev_setup_for_sibling_blk'
> >
> > I don't mind doing that in a follow-up once this series is in, but it
> > is out-of-scope here.
>
> I think that's flipping the priorities. Documenting what all of this is
> supposed to be doing will help explain to the rest of us what you're
> intending to do and why it's a good idea and so forth.
The request was to add the header file into sphinx, which is certainly
out of scope for this series. Do you agree?
This series is documented in doc. and bootstd is extremely well
documented. I'm happy of course to fix up the problem introduced by
this patch, but bringing all the headers (there are at least 4) into
Sphinx should be a separate task.
Regards,
Simon
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v3 02/19] bootstd: Move bootflow-clearing to bootstd
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
2024-11-04 17:50 ` [PATCH v3 01/19] bootstd: Move bootflow-adding to bootstd Simon Glass
@ 2024-11-04 17:50 ` Simon Glass
2024-11-04 22:04 ` Heinrich Schuchardt
2024-11-04 17:50 ` [PATCH v3 03/19] bootstd: Add a function to get bootstd only if available Simon Glass
` (17 subsequent siblings)
19 siblings, 1 reply; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:50 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Caleb Connolly, Dragan Simic,
Heinrich Schuchardt, Ilias Apalodimas, Nam Cao, Peter Robinson,
Thomas Weißschuh, Tony Dinh
This relates to more than just the bootdev, since there is a global list
of bootflows. Move the function to the bootstd file and rename it.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
(no changes since v1)
boot/bootdev-uclass.c | 19 +++++--------------
boot/bootstd-uclass.c | 15 +++++++++++++++
cmd/bootflow.c | 2 +-
include/bootdev.h | 10 ----------
include/bootstd.h | 10 ++++++++++
5 files changed, 31 insertions(+), 25 deletions(-)
diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c
index eddbf60600c..26b003427ec 100644
--- a/boot/bootdev-uclass.c
+++ b/boot/bootdev-uclass.c
@@ -557,19 +557,6 @@ int bootdev_get_bootflow(struct udevice *dev, struct bootflow_iter *iter,
return ops->get_bootflow(dev, iter, bflow);
}
-void bootdev_clear_bootflows(struct udevice *dev)
-{
- struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
-
- while (!list_empty(&ucp->bootflow_head)) {
- struct bootflow *bflow;
-
- bflow = list_first_entry(&ucp->bootflow_head, struct bootflow,
- bm_node);
- bootflow_remove(bflow);
- }
-}
-
int bootdev_next_label(struct bootflow_iter *iter, struct udevice **devp,
int *method_flagsp)
{
@@ -935,7 +922,11 @@ static int bootdev_post_bind(struct udevice *dev)
static int bootdev_pre_unbind(struct udevice *dev)
{
- bootdev_clear_bootflows(dev);
+ int ret;
+
+ ret = bootstd_clear_bootflows_for_bootdev(dev);
+ if (ret)
+ return log_msg_ret("bun", ret);
return 0;
}
diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c
index bf6e49ad97a..596d3e5e41d 100644
--- a/boot/bootstd-uclass.c
+++ b/boot/bootstd-uclass.c
@@ -86,6 +86,21 @@ int bootstd_add_bootflow(struct bootflow *bflow)
return 0;
}
+int bootstd_clear_bootflows_for_bootdev(struct udevice *dev)
+{
+ struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
+
+ while (!list_empty(&ucp->bootflow_head)) {
+ struct bootflow *bflow;
+
+ bflow = list_first_entry(&ucp->bootflow_head, struct bootflow,
+ bm_node);
+ bootflow_remove(bflow);
+ }
+
+ return 0;
+}
+
static int bootstd_remove(struct udevice *dev)
{
struct bootstd_priv *priv = dev_get_priv(dev);
diff --git a/cmd/bootflow.c b/cmd/bootflow.c
index 8962464bbf8..1c1146ce11e 100644
--- a/cmd/bootflow.c
+++ b/cmd/bootflow.c
@@ -197,7 +197,7 @@ static int do_bootflow_scan(struct cmd_tbl *cmdtp, int flag, int argc,
show_header();
}
if (dev)
- bootdev_clear_bootflows(dev);
+ bootstd_clear_bootflows_for_bootdev(dev);
else
bootstd_clear_glob();
for (i = 0,
diff --git a/include/bootdev.h b/include/bootdev.h
index 8db198dd56b..f9cae2fd1fd 100644
--- a/include/bootdev.h
+++ b/include/bootdev.h
@@ -185,16 +185,6 @@ int bootdev_find_in_blk(struct udevice *dev, struct udevice *blk,
*/
void bootdev_list(bool probe);
-/**
- * bootdev_clear_bootflows() - Clear bootflows from a bootdev
- *
- * Each bootdev maintains a list of discovered bootflows. This provides a
- * way to clear it. These bootflows are removed from the global list too.
- *
- * @dev: bootdev device to update
- */
-void bootdev_clear_bootflows(struct udevice *dev);
-
/**
* bootdev_first_bootflow() - Get the first bootflow from a bootdev
*
diff --git a/include/bootstd.h b/include/bootstd.h
index 3fc93a4ec2e..4220ece785d 100644
--- a/include/bootstd.h
+++ b/include/bootstd.h
@@ -122,4 +122,14 @@ int bootstd_prog_boot(void);
*/
int bootstd_add_bootflow(struct bootflow *bflow);
+/**
+ * bootstd_clear_bootflows_for_bootdev() - Clear bootflows from a bootdev
+ *
+ * Each bootdev maintains a list of discovered bootflows. This provides a
+ * way to clear it. These bootflows are removed from the global list too.
+ *
+ * @dev: bootdev device to update
+ */
+int bootstd_clear_bootflows_for_bootdev(struct udevice *dev);
+
#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v3 02/19] bootstd: Move bootflow-clearing to bootstd
2024-11-04 17:50 ` [PATCH v3 02/19] bootstd: Move bootflow-clearing " Simon Glass
@ 2024-11-04 22:04 ` Heinrich Schuchardt
0 siblings, 0 replies; 41+ messages in thread
From: Heinrich Schuchardt @ 2024-11-04 22:04 UTC (permalink / raw)
To: Simon Glass
Cc: Tom Rini, Caleb Connolly, Dragan Simic, Ilias Apalodimas, Nam Cao,
Peter Robinson, Thomas Weißschuh, Tony Dinh,
U-Boot Mailing List
On 11/4/24 18:50, Simon Glass wrote:
> This relates to more than just the bootdev, since there is a global list
> of bootflows. Move the function to the bootstd file and rename it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>
> (no changes since v1)
>
> boot/bootdev-uclass.c | 19 +++++--------------
> boot/bootstd-uclass.c | 15 +++++++++++++++
> cmd/bootflow.c | 2 +-
> include/bootdev.h | 10 ----------
> include/bootstd.h | 10 ++++++++++
> 5 files changed, 31 insertions(+), 25 deletions(-)
>
> diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c
> index eddbf60600c..26b003427ec 100644
> --- a/boot/bootdev-uclass.c
> +++ b/boot/bootdev-uclass.c
> @@ -557,19 +557,6 @@ int bootdev_get_bootflow(struct udevice *dev, struct bootflow_iter *iter,
> return ops->get_bootflow(dev, iter, bflow);
> }
>
> -void bootdev_clear_bootflows(struct udevice *dev)
> -{
> - struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
> -
> - while (!list_empty(&ucp->bootflow_head)) {
> - struct bootflow *bflow;
> -
> - bflow = list_first_entry(&ucp->bootflow_head, struct bootflow,
> - bm_node);
> - bootflow_remove(bflow);
> - }
> -}
> -
> int bootdev_next_label(struct bootflow_iter *iter, struct udevice **devp,
> int *method_flagsp)
> {
> @@ -935,7 +922,11 @@ static int bootdev_post_bind(struct udevice *dev)
>
> static int bootdev_pre_unbind(struct udevice *dev)
> {
> - bootdev_clear_bootflows(dev);
> + int ret;
> +
> + ret = bootstd_clear_bootflows_for_bootdev(dev);
> + if (ret)
> + return log_msg_ret("bun", ret);
>
> return 0;
> }
> diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c
> index bf6e49ad97a..596d3e5e41d 100644
> --- a/boot/bootstd-uclass.c
> +++ b/boot/bootstd-uclass.c
> @@ -86,6 +86,21 @@ int bootstd_add_bootflow(struct bootflow *bflow)
> return 0;
> }
>
> +int bootstd_clear_bootflows_for_bootdev(struct udevice *dev)
> +{
> + struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
> +
> + while (!list_empty(&ucp->bootflow_head)) {
> + struct bootflow *bflow;
> +
> + bflow = list_first_entry(&ucp->bootflow_head, struct bootflow,
> + bm_node);
> + bootflow_remove(bflow);
> + }
> +
> + return 0;
> +}
> +
> static int bootstd_remove(struct udevice *dev)
> {
> struct bootstd_priv *priv = dev_get_priv(dev);
> diff --git a/cmd/bootflow.c b/cmd/bootflow.c
> index 8962464bbf8..1c1146ce11e 100644
> --- a/cmd/bootflow.c
> +++ b/cmd/bootflow.c
> @@ -197,7 +197,7 @@ static int do_bootflow_scan(struct cmd_tbl *cmdtp, int flag, int argc,
> show_header();
> }
> if (dev)
> - bootdev_clear_bootflows(dev);
> + bootstd_clear_bootflows_for_bootdev(dev);
> else
> bootstd_clear_glob();
> for (i = 0,
> diff --git a/include/bootdev.h b/include/bootdev.h
> index 8db198dd56b..f9cae2fd1fd 100644
> --- a/include/bootdev.h
> +++ b/include/bootdev.h
> @@ -185,16 +185,6 @@ int bootdev_find_in_blk(struct udevice *dev, struct udevice *blk,
> */
> void bootdev_list(bool probe);
>
> -/**
> - * bootdev_clear_bootflows() - Clear bootflows from a bootdev
> - *
> - * Each bootdev maintains a list of discovered bootflows. This provides a
> - * way to clear it. These bootflows are removed from the global list too.
> - *
> - * @dev: bootdev device to update
> - */
> -void bootdev_clear_bootflows(struct udevice *dev);
> -
> /**
> * bootdev_first_bootflow() - Get the first bootflow from a bootdev
> *
> diff --git a/include/bootstd.h b/include/bootstd.h
> index 3fc93a4ec2e..4220ece785d 100644
> --- a/include/bootstd.h
> +++ b/include/bootstd.h
> @@ -122,4 +122,14 @@ int bootstd_prog_boot(void);
> */
> int bootstd_add_bootflow(struct bootflow *bflow);
>
> +/**
> + * bootstd_clear_bootflows_for_bootdev() - Clear bootflows from a bootdev
> + *
> + * Each bootdev maintains a list of discovered bootflows. This provides a
> + * way to clear it. These bootflows are removed from the global list too.
> + *
> + * @dev: bootdev device to update
> + */
> +int bootstd_clear_bootflows_for_bootdev(struct udevice *dev);
> +
> #endif
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v3 03/19] bootstd: Add a function to get bootstd only if available
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
2024-11-04 17:50 ` [PATCH v3 01/19] bootstd: Move bootflow-adding to bootstd Simon Glass
2024-11-04 17:50 ` [PATCH v3 02/19] bootstd: Move bootflow-clearing " Simon Glass
@ 2024-11-04 17:50 ` Simon Glass
2024-11-04 17:50 ` [PATCH v3 04/19] bootstd: Drop the bootdev-specific list of bootflows Simon Glass
` (16 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:50 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Heinrich Schuchardt, Peter Robinson
Provide a function which is safe to call in the 'unbind' path, which
returns the bootstd priv data if available.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
(no changes since v1)
boot/bootstd-uclass.c | 11 +++++++++++
include/bootstd.h | 17 +++++++++++++++++
2 files changed, 28 insertions(+)
diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c
index 596d3e5e41d..b2f80808c85 100644
--- a/boot/bootstd-uclass.c
+++ b/boot/bootstd-uclass.c
@@ -140,6 +140,17 @@ const char *const *const bootstd_get_prefixes(struct udevice *dev)
return std->prefixes ? std->prefixes : default_prefixes;
}
+struct bootstd_priv *bootstd_try_priv(void)
+{
+ struct udevice *dev;
+
+ dev = uclass_try_first_device(UCLASS_BOOTSTD);
+ if (!dev || !device_active(dev))
+ return NULL;
+
+ return dev_get_priv(dev);
+}
+
int bootstd_get_priv(struct bootstd_priv **stdp)
{
struct udevice *dev;
diff --git a/include/bootstd.h b/include/bootstd.h
index 4220ece785d..4535d91e2ad 100644
--- a/include/bootstd.h
+++ b/include/bootstd.h
@@ -89,6 +89,23 @@ const char *const *const bootstd_get_prefixes(struct udevice *dev);
*/
int bootstd_get_priv(struct bootstd_priv **stdp);
+/**
+ * bootstd_try_priv() - Try to get the (single) state for the bootstd system
+ *
+ * The state holds a global list of all bootflows that have been found. This
+ * function returns the state if available, but takes care not to create the
+ * device (or uclass) if it doesn't exist.
+ *
+ * This function is safe to use in the 'unbind' path. It will always return NULL
+ * unless the bootstd device is probed and ready, e.g. bootstd_get_priv() has
+ * previously been called.
+ *
+ * TODO(sjg@chromium.org): Consider adding a bootstd pointer to global_data
+ *
+ * Return: pointer if the device exists, else NULL
+ */
+struct bootstd_priv *bootstd_try_priv(void);
+
/**
* bootstd_clear_glob() - Clear the global list of bootflows
*
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 04/19] bootstd: Drop the bootdev-specific list of bootflows
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (2 preceding siblings ...)
2024-11-04 17:50 ` [PATCH v3 03/19] bootstd: Add a function to get bootstd only if available Simon Glass
@ 2024-11-04 17:50 ` Simon Glass
2024-11-04 17:50 ` [PATCH v3 05/19] bootstd: Move the bootflow list into an alist Simon Glass
` (15 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:50 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Caleb Connolly, Dragan Simic,
Guillaume La Roque, Heinrich Schuchardt, Igor Opaniuk,
Ilias Apalodimas, Julien Masson, Mattijs Korpershoek,
Maximilian Brune, Nam Cao, Peter Robinson, Quentin Schulz,
Shantur Rathore, Thomas Weißschuh, Tony Dinh
This list is only used by two functions, which can be updated to iterate
through the global list. Take this approach, which allows the bootdev
list to be dropped.
Overall this makes the code slightly more complicated, but will allow
moving the bootflow list into an alist
Signed-off-by: Simon Glass <sjg@chromium.org>
---
(no changes since v1)
boot/bootdev-uclass.c | 61 +++++++++++++++++++++++++++----------------
boot/bootflow.c | 2 --
boot/bootstd-uclass.c | 17 +++++-------
include/bootdev.h | 2 --
include/bootflow.h | 5 +---
include/bootstd.h | 2 +-
6 files changed, 48 insertions(+), 41 deletions(-)
diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c
index 26b003427ec..81adfb4cfb7 100644
--- a/boot/bootdev-uclass.c
+++ b/boot/bootdev-uclass.c
@@ -32,30 +32,57 @@ enum {
BOOT_TARGETS_MAX_LEN = 100,
};
+struct bootflow *bootdev_next_bootflow_(struct bootstd_priv *std,
+ struct udevice *dev,
+ struct bootflow *prev)
+{
+ struct bootflow *bflow = prev;
+
+ if (bflow) {
+ if (list_is_last(&bflow->glob_node, &std->glob_head))
+ return NULL;
+ bflow = list_entry(bflow->glob_node.next, struct bootflow,
+ glob_node);
+ } else {
+ if (list_empty(&std->glob_head))
+ return NULL;
+
+ bflow = list_first_entry(&std->glob_head, struct bootflow,
+ glob_node);
+ }
+
+ while (bflow->dev != dev) {
+ if (list_is_last(&bflow->glob_node, &std->glob_head))
+ return NULL;
+ bflow = list_entry(bflow->glob_node.next, struct bootflow,
+ glob_node);
+ }
+
+ return bflow;
+}
+
int bootdev_first_bootflow(struct udevice *dev, struct bootflow **bflowp)
{
- struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
+ struct bootstd_priv *std = bootstd_try_priv();
+ struct bootflow *bflow;
- if (list_empty(&ucp->bootflow_head))
+ bflow = bootdev_next_bootflow_(std, dev, NULL);
+ if (!bflow)
return -ENOENT;
-
- *bflowp = list_first_entry(&ucp->bootflow_head, struct bootflow,
- bm_node);
+ *bflowp = bflow;
return 0;
}
int bootdev_next_bootflow(struct bootflow **bflowp)
{
- struct bootflow *bflow = *bflowp;
- struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
-
- *bflowp = NULL;
+ struct bootstd_priv *std = bootstd_try_priv();
+ struct bootflow *bflow;
- if (list_is_last(&bflow->bm_node, &ucp->bootflow_head))
+ bflow = bootdev_next_bootflow_(std, (*bflowp)->dev, *bflowp);
+ if (!bflow)
return -ENOENT;
-
- *bflowp = list_entry(bflow->bm_node.next, struct bootflow, bm_node);
+ *bflowp = bflow;
return 0;
}
@@ -911,15 +938,6 @@ void bootdev_list_hunters(struct bootstd_priv *std)
printf("(total hunters: %d)\n", n_ent);
}
-static int bootdev_post_bind(struct udevice *dev)
-{
- struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
-
- INIT_LIST_HEAD(&ucp->bootflow_head);
-
- return 0;
-}
-
static int bootdev_pre_unbind(struct udevice *dev)
{
int ret;
@@ -936,6 +954,5 @@ UCLASS_DRIVER(bootdev) = {
.name = "bootdev",
.flags = DM_UC_FLAG_SEQ_ALIAS,
.per_device_plat_auto = sizeof(struct bootdev_uc_plat),
- .post_bind = bootdev_post_bind,
.pre_unbind = bootdev_pre_unbind,
};
diff --git a/boot/bootflow.c b/boot/bootflow.c
index d8807eb109d..804809dc100 100644
--- a/boot/bootflow.c
+++ b/boot/bootflow.c
@@ -476,8 +476,6 @@ void bootflow_free(struct bootflow *bflow)
void bootflow_remove(struct bootflow *bflow)
{
- if (bflow->dev)
- list_del(&bflow->bm_node);
list_del(&bflow->glob_node);
bootflow_free(bflow);
diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c
index b2f80808c85..91e90bdf43c 100644
--- a/boot/bootstd-uclass.c
+++ b/boot/bootstd-uclass.c
@@ -77,25 +77,22 @@ int bootstd_add_bootflow(struct bootflow *bflow)
memcpy(new, bflow, sizeof(*bflow));
list_add_tail(&new->glob_node, &std->glob_head);
- if (bflow->dev) {
- struct bootdev_uc_plat *ucp = dev_get_uclass_plat(bflow->dev);
-
- list_add_tail(&new->bm_node, &ucp->bootflow_head);
- }
return 0;
}
int bootstd_clear_bootflows_for_bootdev(struct udevice *dev)
{
- struct bootdev_uc_plat *ucp = dev_get_uclass_plat(dev);
+ struct bootstd_priv *std = bootstd_try_priv();
- while (!list_empty(&ucp->bootflow_head)) {
+ if (std) {
struct bootflow *bflow;
+ struct list_head *pos;
- bflow = list_first_entry(&ucp->bootflow_head, struct bootflow,
- bm_node);
- bootflow_remove(bflow);
+ list_for_each(pos, &std->glob_head) {
+ bflow = list_entry(pos, struct bootflow, glob_node);
+ bootflow_remove(bflow);
+ }
}
return 0;
diff --git a/include/bootdev.h b/include/bootdev.h
index f9cae2fd1fd..991b6229c1c 100644
--- a/include/bootdev.h
+++ b/include/bootdev.h
@@ -109,11 +109,9 @@ struct bootdev_hunter {
* This is attached to each device in the bootdev uclass and accessible via
* dev_get_uclass_plat(dev)
*
- * @bootflows: List of available bootflows for this bootdev
* @piro: Priority of this bootdev
*/
struct bootdev_uc_plat {
- struct list_head bootflow_head;
enum bootdev_prio_t prio;
};
diff --git a/include/bootflow.h b/include/bootflow.h
index 4d2fc7b69b5..64d1d6c3786 100644
--- a/include/bootflow.h
+++ b/include/bootflow.h
@@ -56,12 +56,10 @@ enum bootflow_flags_t {
/**
* struct bootflow - information about a bootflow
*
- * This is connected into two separate linked lists:
+ * This is connected into a linked list:
*
- * bm_sibling - links all bootflows in the same bootdev
* glob_sibling - links all bootflows in all bootdevs
*
- * @bm_node: Points to siblings in the same bootdev
* @glob_node: Points to siblings in the global list (all bootdev)
* @dev: Bootdev device which produced this bootflow, NULL for flows created by
* BOOTMETHF_GLOBAL bootmeths
@@ -92,7 +90,6 @@ enum bootflow_flags_t {
* @bootmeth_priv: Private data for the bootmeth
*/
struct bootflow {
- struct list_head bm_node;
struct list_head glob_node;
struct udevice *dev;
struct udevice *blk;
diff --git a/include/bootstd.h b/include/bootstd.h
index 4535d91e2ad..8aff536e3cb 100644
--- a/include/bootstd.h
+++ b/include/bootstd.h
@@ -123,7 +123,7 @@ void bootstd_clear_glob(void);
int bootstd_prog_boot(void);
/**
- * bootstd_add_bootflow() - Add a bootflow to the bootdev's and global list
+ * bootstd_add_bootflow() - Add a bootflow to the global list
*
* All fields in @bflow must be set up. Note that @bflow->dev is used to add the
* bootflow to that device.
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 05/19] bootstd: Move the bootflow list into an alist
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (3 preceding siblings ...)
2024-11-04 17:50 ` [PATCH v3 04/19] bootstd: Drop the bootdev-specific list of bootflows Simon Glass
@ 2024-11-04 17:50 ` Simon Glass
2024-11-04 17:50 ` [PATCH v3 06/19] bootstd: Maintain a list of images Simon Glass
` (14 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:50 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Caleb Connolly, Dragan Simic,
Guillaume La Roque, Heinrich Schuchardt, Igor Opaniuk,
Julien Masson, Mattijs Korpershoek, Maximilian Brune,
Moritz Fischer, Nam Cao, Peter Robinson, Quentin Schulz,
Shantur Rathore, Thomas Weißschuh, Tony Dinh
Use an alist for this data structure as it is somewhat simpler to
manage. This means that bootstd holds a simple list of bootflow structs
and can drop it at will, without chasing down lists.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Update bootstd_add_bootflow() to return the element number
boot/bootdev-uclass.c | 47 +++++++++++++------------------------------
boot/bootflow.c | 16 ++++-----------
boot/bootstd-uclass.c | 42 +++++++++++++++++++-------------------
cmd/bootdev.c | 2 +-
cmd/bootflow.c | 2 +-
include/bootflow.h | 11 +++++-----
include/bootstd.h | 8 +++++---
7 files changed, 51 insertions(+), 77 deletions(-)
diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c
index 81adfb4cfb7..a4e1d79ec9b 100644
--- a/boot/bootdev-uclass.c
+++ b/boot/bootdev-uclass.c
@@ -32,41 +32,17 @@ enum {
BOOT_TARGETS_MAX_LEN = 100,
};
-struct bootflow *bootdev_next_bootflow_(struct bootstd_priv *std,
- struct udevice *dev,
- struct bootflow *prev)
-{
- struct bootflow *bflow = prev;
-
- if (bflow) {
- if (list_is_last(&bflow->glob_node, &std->glob_head))
- return NULL;
- bflow = list_entry(bflow->glob_node.next, struct bootflow,
- glob_node);
- } else {
- if (list_empty(&std->glob_head))
- return NULL;
-
- bflow = list_first_entry(&std->glob_head, struct bootflow,
- glob_node);
- }
-
- while (bflow->dev != dev) {
- if (list_is_last(&bflow->glob_node, &std->glob_head))
- return NULL;
- bflow = list_entry(bflow->glob_node.next, struct bootflow,
- glob_node);
- }
-
- return bflow;
-}
-
int bootdev_first_bootflow(struct udevice *dev, struct bootflow **bflowp)
{
- struct bootstd_priv *std = bootstd_try_priv();
+ struct bootstd_priv *std;
struct bootflow *bflow;
+ int ret;
+
+ ret = bootstd_get_priv(&std);
+ if (ret)
+ return log_msg_ret("bff", ret);
- bflow = bootdev_next_bootflow_(std, dev, NULL);
+ bflow = alist_getw(&std->bootflows, 0, struct bootflow);
if (!bflow)
return -ENOENT;
*bflowp = bflow;
@@ -76,10 +52,15 @@ int bootdev_first_bootflow(struct udevice *dev, struct bootflow **bflowp)
int bootdev_next_bootflow(struct bootflow **bflowp)
{
- struct bootstd_priv *std = bootstd_try_priv();
+ struct bootstd_priv *std;
struct bootflow *bflow;
+ int ret;
+
+ ret = bootstd_get_priv(&std);
+ if (ret)
+ return log_msg_ret("bff", ret);
- bflow = bootdev_next_bootflow_(std, (*bflowp)->dev, *bflowp);
+ bflow = alist_nextw(&std->bootflows, *bflowp);
if (!bflow)
return -ENOENT;
*bflowp = bflow;
diff --git a/boot/bootflow.c b/boot/bootflow.c
index 804809dc100..7ce04fd92cd 100644
--- a/boot/bootflow.c
+++ b/boot/bootflow.c
@@ -55,11 +55,10 @@ int bootflow_first_glob(struct bootflow **bflowp)
if (ret)
return ret;
- if (list_empty(&std->glob_head))
+ if (!std->bootflows.count)
return -ENOENT;
- *bflowp = list_first_entry(&std->glob_head, struct bootflow,
- glob_node);
+ *bflowp = alist_getw(&std->bootflows, 0, struct bootflow);
return 0;
}
@@ -67,20 +66,16 @@ int bootflow_first_glob(struct bootflow **bflowp)
int bootflow_next_glob(struct bootflow **bflowp)
{
struct bootstd_priv *std;
- struct bootflow *bflow = *bflowp;
int ret;
ret = bootstd_get_priv(&std);
if (ret)
return ret;
- *bflowp = NULL;
-
- if (list_is_last(&bflow->glob_node, &std->glob_head))
+ *bflowp = alist_nextw(&std->bootflows, *bflowp);
+ if (!*bflowp)
return -ENOENT;
- *bflowp = list_entry(bflow->glob_node.next, struct bootflow, glob_node);
-
return 0;
}
@@ -476,10 +471,7 @@ void bootflow_free(struct bootflow *bflow)
void bootflow_remove(struct bootflow *bflow)
{
- list_del(&bflow->glob_node);
-
bootflow_free(bflow);
- free(bflow);
}
#if CONFIG_IS_ENABLED(BOOTSTD_FULL)
diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c
index 91e90bdf43c..8c0fd4e63c3 100644
--- a/boot/bootstd-uclass.c
+++ b/boot/bootstd-uclass.c
@@ -6,6 +6,7 @@
* Written by Simon Glass <sjg@chromium.org>
*/
+#include <alist.h>
#include <bootflow.h>
#include <bootstd.h>
#include <dm.h>
@@ -42,13 +43,11 @@ static int bootstd_of_to_plat(struct udevice *dev)
static void bootstd_clear_glob_(struct bootstd_priv *priv)
{
- while (!list_empty(&priv->glob_head)) {
- struct bootflow *bflow;
+ struct bootflow *bflow;
- bflow = list_first_entry(&priv->glob_head, struct bootflow,
- glob_node);
+ alist_for_each(bflow, &priv->bootflows)
bootflow_remove(bflow);
- }
+ alist_empty(&priv->bootflows);
}
void bootstd_clear_glob(void)
@@ -64,36 +63,37 @@ void bootstd_clear_glob(void)
int bootstd_add_bootflow(struct bootflow *bflow)
{
struct bootstd_priv *std;
- struct bootflow *new;
int ret;
ret = bootstd_get_priv(&std);
if (ret)
return ret;
- new = malloc(sizeof(*bflow));
- if (!new)
- return log_msg_ret("bflow", -ENOMEM);
- memcpy(new, bflow, sizeof(*bflow));
-
- list_add_tail(&new->glob_node, &std->glob_head);
+ ret = std->bootflows.count;
+ bflow = alist_add(&std->bootflows, *bflow);
+ if (!bflow)
+ return log_msg_ret("bf2", -ENOMEM);
- return 0;
+ return ret;
}
int bootstd_clear_bootflows_for_bootdev(struct udevice *dev)
{
struct bootstd_priv *std = bootstd_try_priv();
+ struct bootflow *from, *to;
- if (std) {
- struct bootflow *bflow;
- struct list_head *pos;
+ /* if bootstd does not exist we cannot have any bootflows */
+ if (!std)
+ return 0;
- list_for_each(pos, &std->glob_head) {
- bflow = list_entry(pos, struct bootflow, glob_node);
- bootflow_remove(bflow);
- }
+ /* Drop any bootflows that mention this dev */
+ alist_for_each_filter(from, to, &std->bootflows) {
+ if (from->dev == dev)
+ bootflow_remove(from);
+ else
+ *to++ = *from;
}
+ alist_update_end(&std->bootflows, to);
return 0;
}
@@ -165,7 +165,7 @@ static int bootstd_probe(struct udevice *dev)
{
struct bootstd_priv *std = dev_get_priv(dev);
- INIT_LIST_HEAD(&std->glob_head);
+ alist_init_struct(&std->bootflows, struct bootflow);
return 0;
}
diff --git a/cmd/bootdev.c b/cmd/bootdev.c
index fa7285ba25e..4bc229e809a 100644
--- a/cmd/bootdev.c
+++ b/cmd/bootdev.c
@@ -81,7 +81,7 @@ static int do_bootdev_info(struct cmd_tbl *cmdtp, int flag, int argc,
dev = priv->cur_bootdev;
- /* Count the number of bootflows, including how many are valid*/
+ /* Count the number of bootflows, including how many are valid */
num_valid = 0;
for (ret = bootdev_first_bootflow(dev, &bflow), i = 0;
!ret;
diff --git a/cmd/bootflow.c b/cmd/bootflow.c
index 1c1146ce11e..f88995a478f 100644
--- a/cmd/bootflow.c
+++ b/cmd/bootflow.c
@@ -208,7 +208,7 @@ static int do_bootflow_scan(struct cmd_tbl *cmdtp, int flag, int argc,
if (!ret)
num_valid++;
ret = bootstd_add_bootflow(&bflow);
- if (ret) {
+ if (ret < 0) {
printf("Out of memory\n");
return CMD_RET_FAILURE;
}
diff --git a/include/bootflow.h b/include/bootflow.h
index 64d1d6c3786..9b24fb5c3eb 100644
--- a/include/bootflow.h
+++ b/include/bootflow.h
@@ -56,11 +56,8 @@ enum bootflow_flags_t {
/**
* struct bootflow - information about a bootflow
*
- * This is connected into a linked list:
+ * All bootflows are listed in bootstd's bootflow alist in struct bootstd_priv
*
- * glob_sibling - links all bootflows in all bootdevs
- *
- * @glob_node: Points to siblings in the global list (all bootdev)
* @dev: Bootdev device which produced this bootflow, NULL for flows created by
* BOOTMETHF_GLOBAL bootmeths
* @blk: Block device which contains this bootflow, NULL if this is a network
@@ -90,7 +87,6 @@ enum bootflow_flags_t {
* @bootmeth_priv: Private data for the bootmeth
*/
struct bootflow {
- struct list_head glob_node;
struct udevice *dev;
struct udevice *blk;
int part;
@@ -390,7 +386,10 @@ const char *bootflow_state_get_name(enum bootflow_state_t state);
/**
* bootflow_remove() - Remove a bootflow and free its memory
*
- * This updates the linked lists containing the bootflow then frees it.
+ * This updates the 'global' linked list containing the bootflow, then frees it.
+ * It does not remove it from bootflows alist in struct bootstd_priv
+ *
+ * This does not free bflow itself, since this is assumed to be in an alist
*
* @bflow: Bootflow to remove
*/
diff --git a/include/bootstd.h b/include/bootstd.h
index 8aff536e3cb..3398e48e88b 100644
--- a/include/bootstd.h
+++ b/include/bootstd.h
@@ -9,6 +9,7 @@
#ifndef __bootstd_h
#define __bootstd_h
+#include <alist.h>
#include <dm/ofnode_decl.h>
#include <linux/list.h>
#include <linux/types.h>
@@ -30,7 +31,8 @@ struct udevice;
* terminated)
* @cur_bootdev: Currently selected bootdev (for commands)
* @cur_bootflow: Currently selected bootflow (for commands)
- * @glob_head: Head for the global list of all bootflows across all bootdevs
+ * @bootflows: (struct bootflow) Global list of all bootflows across all
+ * bootdevs
* @bootmeth_count: Number of bootmeth devices in @bootmeth_order
* @bootmeth_order: List of bootmeth devices to use, in order, NULL-terminated
* @vbe_bootmeth: Currently selected VBE bootmeth, NULL if none
@@ -44,7 +46,7 @@ struct bootstd_priv {
const char **env_order;
struct udevice *cur_bootdev;
struct bootflow *cur_bootflow;
- struct list_head glob_head;
+ struct alist bootflows;
int bootmeth_count;
struct udevice **bootmeth_order;
struct udevice *vbe_bootmeth;
@@ -135,7 +137,7 @@ int bootstd_prog_boot(void);
* since this function takes over ownership of these. This functions makes
* a copy of @bflow itself (without allocating its fields again), so the
* caller must dispose of the memory used by the @bflow pointer itself
- * Return: 0 if OK, -ENOMEM if out of memory
+ * Return: element number in the list, if OK, -ENOMEM if out of memory
*/
int bootstd_add_bootflow(struct bootflow *bflow);
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 06/19] bootstd: Maintain a list of images
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (4 preceding siblings ...)
2024-11-04 17:50 ` [PATCH v3 05/19] bootstd: Move the bootflow list into an alist Simon Glass
@ 2024-11-04 17:50 ` Simon Glass
2024-11-04 17:50 ` [PATCH v3 07/19] bootstd: Update bootmeth_alloc_file() to record images Simon Glass
` (13 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:50 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Guillaume La Roque, Heinrich Schuchardt,
Igor Opaniuk, Julien Masson, Mattijs Korpershoek,
Maximilian Brune, Nam Cao, Quentin Schulz, Shantur Rathore
We want to keep track of images which are loaded, or those which could
perhaps be loaded. This will make it easier to manage memory allocation,
as well as permit removal of the EFI set_efi_bootdev() feature.
Add a list of these, attached to the bootflow. For now the list is
empty.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
(no changes since v2)
Changes in v2:
- Add an image type extension in bootflow.h
- Use the word 'feature' instead of 'hack'
boot/bootflow.c | 26 +++++++++++++++++++++++++
include/bootflow.h | 48 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 74 insertions(+)
diff --git a/boot/bootflow.c b/boot/bootflow.c
index 7ce04fd92cd..94f34dcad0f 100644
--- a/boot/bootflow.c
+++ b/boot/bootflow.c
@@ -23,6 +23,13 @@ enum {
BF_NO_MORE_DEVICES = -ENODEV,
};
+static const char *const bootflow_img[BFI_COUNT - BFI_FIRST] = {
+ "extlinux_cfg",
+ "logo",
+ "efi",
+ "cmdline",
+};
+
/**
* bootflow_state - name for each state
*
@@ -455,10 +462,13 @@ void bootflow_init(struct bootflow *bflow, struct udevice *bootdev,
bflow->dev = bootdev;
bflow->method = meth;
bflow->state = BOOTFLOWST_BASE;
+ alist_init_struct(&bflow->images, struct bootflow_img);
}
void bootflow_free(struct bootflow *bflow)
{
+ struct bootflow_img *img;
+
free(bflow->name);
free(bflow->subdir);
free(bflow->fname);
@@ -467,6 +477,10 @@ void bootflow_free(struct bootflow *bflow)
free(bflow->os_name);
free(bflow->fdt_fname);
free(bflow->bootmeth_priv);
+
+ alist_for_each(img, &bflow->images)
+ free(img->fname);
+ alist_empty(&bflow->images);
}
void bootflow_remove(struct bootflow *bflow)
@@ -950,3 +964,15 @@ int bootflow_cmdline_auto(struct bootflow *bflow, const char *arg)
return 0;
}
+
+const char *bootflow_img_type_name(enum bootflow_img_t type)
+{
+ const char *name;
+
+ if (type >= BFI_FIRST && type < BFI_COUNT)
+ name = bootflow_img[type - BFI_FIRST];
+ else
+ name = genimg_get_type_short_name(type);
+
+ return name;
+}
diff --git a/include/bootflow.h b/include/bootflow.h
index 9b24fb5c3eb..f407bb356b4 100644
--- a/include/bootflow.h
+++ b/include/bootflow.h
@@ -7,7 +7,9 @@
#ifndef __bootflow_h
#define __bootflow_h
+#include <alist.h>
#include <bootdev.h>
+#include <image.h>
#include <dm/ofnode_decl.h>
#include <linux/list.h>
@@ -85,6 +87,7 @@ enum bootflow_flags_t {
* @cmdline: OS command line, or NULL if not known (allocated)
* @x86_setup: Pointer to x86 setup block inside @buf, NULL if not present
* @bootmeth_priv: Private data for the bootmeth
+ * @images: List of loaded images (struct bootstd_img)
*/
struct bootflow {
struct udevice *dev;
@@ -109,6 +112,44 @@ struct bootflow {
char *cmdline;
void *x86_setup;
void *bootmeth_priv;
+ struct alist images;
+};
+
+/**
+ * bootflow_img_t: Supported image types
+ *
+ * This uses image_type_t for most types, but extends it
+ *
+ * @BFI_EXTLINUX_CFG: extlinux configuration-file
+ * @BFI_LOGO: logo image
+ * @BFI_EFI: EFI PE image
+ * @BFI_CMDLINE: OS command-line string
+ */
+enum bootflow_img_t {
+ BFI_FIRST = IH_TYPE_COUNT,
+ BFI_EXTLINUX_CFG = BFI_FIRST,
+ BFI_LOGO,
+ BFI_EFI,
+ BFI_CMDLINE,
+
+ BFI_COUNT,
+};
+
+/**
+ * struct bootflow_img - Information about an image which has been loaded
+ *
+ * This keeps track of a single, loaded image.
+ *
+ * @fname: Filename used to load the image (allocated)
+ * @type: Image type (IH_TYPE_...)
+ * @addr: Address to which the image was loaded, 0 if not yet loaded
+ * @size: Size of the image
+ */
+struct bootflow_img {
+ char *fname;
+ enum bootflow_img_t type;
+ ulong addr;
+ ulong size;
};
/**
@@ -565,4 +606,11 @@ int bootflow_cmdline_get_arg(struct bootflow *bflow, const char *arg,
*/
int bootflow_cmdline_auto(struct bootflow *bflow, const char *arg);
+/**
+ * bootflow_img_type_name() - Get the name for an image type
+ *
+ * @type: Type to check (either enum bootflow_img_t or enum image_type_t
+ * Return: Image name, or "unknown" if not known
+ */
+const char *bootflow_img_type_name(enum bootflow_img_t type);
#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 07/19] bootstd: Update bootmeth_alloc_file() to record images
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (5 preceding siblings ...)
2024-11-04 17:50 ` [PATCH v3 06/19] bootstd: Maintain a list of images Simon Glass
@ 2024-11-04 17:50 ` Simon Glass
2024-11-04 17:50 ` [PATCH v3 08/19] boot: pxe: Drop the duplicate comment on get_pxe_file() Simon Glass
` (12 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:50 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Guillaume La Roque, Heinrich Schuchardt,
Igor Opaniuk, Ion Agorria, Julien Masson, Martyn Welch,
Mattijs Korpershoek, Maximilian Brune, Moritz Fischer, Nam Cao,
Quentin Schulz, Shantur Rathore, Svyatoslav Ryhel
As a first step to recording images and where they came from, update
this function to do so, since it is used by two bootmeths
Create a helper function in the bootflow system, since recorded
images are always associated with bootflows.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Add a helper in bootflow
Changes in v2:
- Update to use a new image-type enum in bootflow.h
boot/bootflow.c | 21 +++++++++++++++++++++
boot/bootmeth-uclass.c | 12 +++++++++++-
boot/bootmeth_extlinux.c | 2 +-
boot/bootmeth_script.c | 3 ++-
include/bootflow.h | 15 +++++++++++++++
include/bootmeth.h | 8 +++++---
6 files changed, 55 insertions(+), 6 deletions(-)
diff --git a/boot/bootflow.c b/boot/bootflow.c
index 94f34dcad0f..a10d3012b48 100644
--- a/boot/bootflow.c
+++ b/boot/bootflow.c
@@ -976,3 +976,24 @@ const char *bootflow_img_type_name(enum bootflow_img_t type)
return name;
}
+
+struct bootflow_img *bootflow_img_add(struct bootflow *bflow, const char *fname,
+ enum bootflow_img_t type, ulong addr,
+ ulong size)
+{
+ struct bootflow_img img, *ptr;
+
+ memset(&img, '\0', sizeof(struct bootflow_img));
+ img.fname = strdup(fname);
+ if (!img.fname)
+ return NULL;
+
+ img.type = type;
+ img.addr = addr;
+ img.size = size;
+ ptr = alist_add(&bflow->images, img);
+ if (!ptr)
+ return NULL;
+
+ return ptr;
+}
diff --git a/boot/bootmeth-uclass.c b/boot/bootmeth-uclass.c
index 5b5fea39b3b..c219631816f 100644
--- a/boot/bootmeth-uclass.c
+++ b/boot/bootmeth-uclass.c
@@ -6,6 +6,7 @@
#define LOG_CATEGORY UCLASS_BOOTSTD
+#include <alist.h>
#include <blk.h>
#include <bootflow.h>
#include <bootmeth.h>
@@ -326,8 +327,10 @@ int bootmeth_try_file(struct bootflow *bflow, struct blk_desc *desc,
return 0;
}
-int bootmeth_alloc_file(struct bootflow *bflow, uint size_limit, uint align)
+int bootmeth_alloc_file(struct bootflow *bflow, uint size_limit, uint align,
+ enum bootflow_img_t type)
{
+ struct blk_desc *desc = NULL;
void *buf;
uint size;
int ret;
@@ -344,6 +347,13 @@ int bootmeth_alloc_file(struct bootflow *bflow, uint size_limit, uint align)
bflow->state = BOOTFLOWST_READY;
bflow->buf = buf;
+ if (bflow->blk)
+ desc = dev_get_uclass_plat(bflow->blk);
+
+ if (!bootflow_img_add(bflow, bflow->fname, type, map_to_sysmem(buf),
+ size))
+ return log_msg_ret("bai", -ENOMEM);
+
return 0;
}
diff --git a/boot/bootmeth_extlinux.c b/boot/bootmeth_extlinux.c
index be8fbf4df63..6c158c2a6c6 100644
--- a/boot/bootmeth_extlinux.c
+++ b/boot/bootmeth_extlinux.c
@@ -159,7 +159,7 @@ static int extlinux_read_bootflow(struct udevice *dev, struct bootflow *bflow)
return log_msg_ret("try", ret);
size = bflow->size;
- ret = bootmeth_alloc_file(bflow, 0x10000, 1);
+ ret = bootmeth_alloc_file(bflow, 0x10000, 1, BFI_EXTLINUX_CFG);
if (ret)
return log_msg_ret("read", ret);
diff --git a/boot/bootmeth_script.c b/boot/bootmeth_script.c
index c5cbf18c2e6..a2fb2899885 100644
--- a/boot/bootmeth_script.c
+++ b/boot/bootmeth_script.c
@@ -98,7 +98,8 @@ static int script_read_bootflow_file(struct udevice *bootstd,
if (!bflow->subdir)
return log_msg_ret("prefix", -ENOMEM);
- ret = bootmeth_alloc_file(bflow, 0x10000, ARCH_DMA_MINALIGN);
+ ret = bootmeth_alloc_file(bflow, 0x10000, ARCH_DMA_MINALIGN,
+ (enum bootflow_img_t)IH_TYPE_SCRIPT);
if (ret)
return log_msg_ret("read", ret);
diff --git a/include/bootflow.h b/include/bootflow.h
index f407bb356b4..e09cff285e4 100644
--- a/include/bootflow.h
+++ b/include/bootflow.h
@@ -613,4 +613,19 @@ int bootflow_cmdline_auto(struct bootflow *bflow, const char *arg);
* Return: Image name, or "unknown" if not known
*/
const char *bootflow_img_type_name(enum bootflow_img_t type);
+
+/**
+ * bootflow_img_add() - Add a new image to a bootflow
+ *
+ * @bflow: Bootflow to add to
+ * @fname: Image filename (will be allocated)
+ * @type: Image type
+ * @addr: Address the image was loaded to, or 0 if not loaded
+ * @size: Image size
+ * Return: pointer to the added image, or NULL if out of memory
+ */
+struct bootflow_img *bootflow_img_add(struct bootflow *bflow, const char *fname,
+ enum bootflow_img_t type, ulong addr,
+ ulong size);
+
#endif
diff --git a/include/bootmeth.h b/include/bootmeth.h
index a08ebf005ad..e812974ec4d 100644
--- a/include/bootmeth.h
+++ b/include/bootmeth.h
@@ -7,11 +7,11 @@
#ifndef __bootmeth_h
#define __bootmeth_h
+#include <bootflow.h>
+#include <image.h>
#include <linux/bitops.h>
struct blk_desc;
-struct bootflow;
-struct bootflow_iter;
struct udevice;
/**
@@ -365,10 +365,12 @@ int bootmeth_try_file(struct bootflow *bflow, struct blk_desc *desc,
* @bflow: Information about file to read
* @size_limit: Maximum file size to permit
* @align: Allocation alignment (1 for unaligned)
+ * @type: File type (IH_TYPE_...)
* Return: 0 if OK, -E2BIG if file is too large, -ENOMEM if out of memory,
* other -ve on other error
*/
-int bootmeth_alloc_file(struct bootflow *bflow, uint size_limit, uint align);
+int bootmeth_alloc_file(struct bootflow *bflow, uint size_limit, uint align,
+ enum bootflow_img_t type);
/**
* bootmeth_alloc_other() - Allocate and read a file for a bootflow
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 08/19] boot: pxe: Drop the duplicate comment on get_pxe_file()
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (6 preceding siblings ...)
2024-11-04 17:50 ` [PATCH v3 07/19] bootstd: Update bootmeth_alloc_file() to record images Simon Glass
@ 2024-11-04 17:50 ` Simon Glass
2024-11-04 17:51 ` [PATCH v3 09/19] bootmeth_efi: Simplify reading files by using the common function Simon Glass
` (11 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:50 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Marek Vasut, Martyn Welch,
Michael Trimarchi, Michal Simek, Tim Harvey
This function is exported, so document it in the header file. Drop the
duplicate comment in the C file.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
(no changes since v1)
boot/pxe_utils.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c
index d6a4b2cb859..4fd26524286 100644
--- a/boot/pxe_utils.c
+++ b/boot/pxe_utils.c
@@ -133,16 +133,6 @@ static int get_relfile(struct pxe_context *ctx, const char *file_path,
return 1;
}
-/**
- * get_pxe_file() - read a file
- *
- * The file is read and nul-terminated
- *
- * @ctx: PXE context
- * @file_path: File path to read (relative to the PXE file)
- * @file_addr: Address to load file to
- * Returns 1 for success, or < 0 on error
- */
int get_pxe_file(struct pxe_context *ctx, const char *file_path,
ulong file_addr)
{
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 09/19] bootmeth_efi: Simplify reading files by using the common function
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (7 preceding siblings ...)
2024-11-04 17:50 ` [PATCH v3 08/19] boot: pxe: Drop the duplicate comment on get_pxe_file() Simon Glass
@ 2024-11-04 17:51 ` Simon Glass
2024-11-04 17:51 ` [PATCH v3 10/19] bootmeth: Update the read_file() method to include a type Simon Glass
` (10 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:51 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Ilias Apalodimas, AKASHI Takahiro,
Heinrich Schuchardt, Mattijs Korpershoek, Shantur Rathore
The efiload_read_file() does similar things to a common function, so
update it to use that instead.
Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
(no changes since v2)
Changes in v2:
- Change the tag to bootmeth_efi
boot/bootmeth_efi.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c
index 2ad6d3b4ace..f3ddbe71405 100644
--- a/boot/bootmeth_efi.c
+++ b/boot/bootmeth_efi.c
@@ -110,19 +110,14 @@ static void set_efi_bootdev(struct blk_desc *desc, struct bootflow *bflow)
static int efiload_read_file(struct bootflow *bflow, ulong addr)
{
struct blk_desc *desc = NULL;
- loff_t bytes_read;
+ ulong size;
int ret;
if (bflow->blk)
desc = dev_get_uclass_plat(bflow->blk);
- ret = bootmeth_setup_fs(bflow, desc);
- if (ret)
- return log_msg_ret("set", ret);
- ret = fs_read(bflow->fname, addr, 0, bflow->size, &bytes_read);
- if (ret)
- return log_msg_ret("read", ret);
- bflow->buf = map_sysmem(addr, bflow->size);
+ ret = bootmeth_common_read_file(bflow->method, bflow, bflow->fname,
+ addr, &size);
set_efi_bootdev(desc, bflow);
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 10/19] bootmeth: Update the read_file() method to include a type
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (8 preceding siblings ...)
2024-11-04 17:51 ` [PATCH v3 09/19] bootmeth_efi: Simplify reading files by using the common function Simon Glass
@ 2024-11-04 17:51 ` Simon Glass
2024-11-04 17:51 ` [PATCH v3 11/19] bootmeth_efi: Check the filename-allocation in the network path Simon Glass
` (9 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:51 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Mattijs Korpershoek, AKASHI Takahiro,
Guillaume La Roque, Heinrich Schuchardt, Ilias Apalodimas,
Ion Agorria, Julien Masson, Mark Kettenis, Martyn Welch,
Quentin Schulz, Shantur Rathore, Vincent Stehlé
We want to record the type of each file which is loaded. Add an new
parameter for this, to the read_file() method. Update all users.
Make bootmeth_common_read_file() store information about the image that
is read.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
---
Changes in v3:
- Use the helper function
Changes in v2:
- Update to use a new image-type enum in bootflow.h
boot/bootmeth-uclass.c | 11 ++++++++---
boot/bootmeth_android.c | 3 ++-
boot/bootmeth_cros.c | 3 ++-
boot/bootmeth_efi.c | 5 +++--
boot/bootmeth_efi_mgr.c | 3 ++-
boot/bootmeth_extlinux.c | 2 +-
boot/bootmeth_pxe.c | 6 +++---
boot/bootmeth_qfw.c | 3 ++-
boot/bootmeth_sandbox.c | 3 ++-
boot/vbe_simple.c | 5 +++--
include/bootmeth.h | 13 +++++++++----
11 files changed, 37 insertions(+), 20 deletions(-)
diff --git a/boot/bootmeth-uclass.c b/boot/bootmeth-uclass.c
index c219631816f..1f48d0c1f51 100644
--- a/boot/bootmeth-uclass.c
+++ b/boot/bootmeth-uclass.c
@@ -84,14 +84,15 @@ int bootmeth_boot(struct udevice *dev, struct bootflow *bflow)
}
int bootmeth_read_file(struct udevice *dev, struct bootflow *bflow,
- const char *file_path, ulong addr, ulong *sizep)
+ const char *file_path, ulong addr,
+ enum bootflow_img_t type, ulong *sizep)
{
const struct bootmeth_ops *ops = bootmeth_get_ops(dev);
if (!ops->read_file)
return -ENOSYS;
- return ops->read_file(dev, bflow, file_path, addr, sizep);
+ return ops->read_file(dev, bflow, file_path, addr, type, sizep);
}
int bootmeth_get_bootflow(struct udevice *dev, struct bootflow *bflow)
@@ -394,7 +395,8 @@ int bootmeth_alloc_other(struct bootflow *bflow, const char *fname,
}
int bootmeth_common_read_file(struct udevice *dev, struct bootflow *bflow,
- const char *file_path, ulong addr, ulong *sizep)
+ const char *file_path, ulong addr,
+ enum bootflow_img_t type, ulong *sizep)
{
struct blk_desc *desc = NULL;
loff_t len_read;
@@ -423,6 +425,9 @@ int bootmeth_common_read_file(struct udevice *dev, struct bootflow *bflow,
return ret;
*sizep = len_read;
+ if (!bootflow_img_add(bflow, bflow->fname, type, addr, size))
+ return log_msg_ret("bci", -ENOMEM);
+
return 0;
}
diff --git a/boot/bootmeth_android.c b/boot/bootmeth_android.c
index 19b1f2c377b..bd6c05ab8f9 100644
--- a/boot/bootmeth_android.c
+++ b/boot/bootmeth_android.c
@@ -298,7 +298,8 @@ static int android_read_bootflow(struct udevice *dev, struct bootflow *bflow)
}
static int android_read_file(struct udevice *dev, struct bootflow *bflow,
- const char *file_path, ulong addr, ulong *sizep)
+ const char *file_path, ulong addr,
+ enum bootflow_img_t type, ulong *sizep)
{
/*
* Reading individual files is not supported since we only
diff --git a/boot/bootmeth_cros.c b/boot/bootmeth_cros.c
index 676f550ca25..1825293d93d 100644
--- a/boot/bootmeth_cros.c
+++ b/boot/bootmeth_cros.c
@@ -400,7 +400,8 @@ static int cros_read_bootflow(struct udevice *dev, struct bootflow *bflow)
}
static int cros_read_file(struct udevice *dev, struct bootflow *bflow,
- const char *file_path, ulong addr, ulong *sizep)
+ const char *file_path, ulong addr,
+ enum bootflow_img_t type, ulong *sizep)
{
return -ENOSYS;
}
diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c
index f3ddbe71405..e8109e19bcb 100644
--- a/boot/bootmeth_efi.c
+++ b/boot/bootmeth_efi.c
@@ -117,7 +117,7 @@ static int efiload_read_file(struct bootflow *bflow, ulong addr)
desc = dev_get_uclass_plat(bflow->blk);
ret = bootmeth_common_read_file(bflow->method, bflow, bflow->fname,
- addr, &size);
+ addr, BFI_EFI, &size);
set_efi_bootdev(desc, bflow);
@@ -189,7 +189,8 @@ static int distro_efi_try_bootflow_files(struct udevice *dev,
/* Limit FDT files to 4MB */
size = SZ_4M;
ret = bootmeth_common_read_file(dev, bflow, fname,
- fdt_addr, &size);
+ fdt_addr, (enum bootflow_img_t)IH_TYPE_FLATDT,
+ &size);
}
}
diff --git a/boot/bootmeth_efi_mgr.c b/boot/bootmeth_efi_mgr.c
index 23ae1e610ac..42b8863815e 100644
--- a/boot/bootmeth_efi_mgr.c
+++ b/boot/bootmeth_efi_mgr.c
@@ -74,7 +74,8 @@ static int efi_mgr_read_bootflow(struct udevice *dev, struct bootflow *bflow)
}
static int efi_mgr_read_file(struct udevice *dev, struct bootflow *bflow,
- const char *file_path, ulong addr, ulong *sizep)
+ const char *file_path, ulong addr,
+ enum bootflow_img_t type, ulong *sizep)
{
/* Files are loaded by the 'bootefi bootmgr' command */
diff --git a/boot/bootmeth_extlinux.c b/boot/bootmeth_extlinux.c
index 6c158c2a6c6..ae5ae4dbb34 100644
--- a/boot/bootmeth_extlinux.c
+++ b/boot/bootmeth_extlinux.c
@@ -79,7 +79,7 @@ static int extlinux_getfile(struct pxe_context *ctx, const char *file_path,
/* Allow up to 1GB */
*sizep = 1 << 30;
ret = bootmeth_read_file(info->dev, info->bflow, file_path, addr,
- sizep);
+ (enum bootflow_img_t)IH_TYPE_INVALID, sizep);
if (ret)
return log_msg_ret("read", ret);
diff --git a/boot/bootmeth_pxe.c b/boot/bootmeth_pxe.c
index 05c6bece2c1..e64429f6857 100644
--- a/boot/bootmeth_pxe.c
+++ b/boot/bootmeth_pxe.c
@@ -23,7 +23,7 @@
#include <pxe_utils.h>
static int extlinux_pxe_getfile(struct pxe_context *ctx, const char *file_path,
- char *file_addr, ulong *sizep)
+ char *file_addr, ulong *sizep)
{
struct extlinux_info *info = ctx->userdata;
ulong addr;
@@ -34,7 +34,7 @@ static int extlinux_pxe_getfile(struct pxe_context *ctx, const char *file_path,
/* Allow up to 1GB */
*sizep = 1 << 30;
ret = bootmeth_read_file(info->dev, info->bflow, file_path, addr,
- sizep);
+ IH_TYPE_INVALID, sizep);
if (ret)
return log_msg_ret("read", ret);
@@ -113,7 +113,7 @@ static int extlinux_pxe_read_bootflow(struct udevice *dev,
static int extlinux_pxe_read_file(struct udevice *dev, struct bootflow *bflow,
const char *file_path, ulong addr,
- ulong *sizep)
+ enum bootflow_img_t type, ulong *sizep)
{
char *tftp_argv[] = {"tftp", NULL, NULL, NULL};
struct pxe_context *ctx = dev_get_priv(dev);
diff --git a/boot/bootmeth_qfw.c b/boot/bootmeth_qfw.c
index 2f8e00cf350..028c2481583 100644
--- a/boot/bootmeth_qfw.c
+++ b/boot/bootmeth_qfw.c
@@ -52,7 +52,8 @@ static int qfw_read_bootflow(struct udevice *dev, struct bootflow *bflow)
}
static int qfw_read_file(struct udevice *dev, struct bootflow *bflow,
- const char *file_path, ulong addr, ulong *sizep)
+ const char *file_path, ulong addr,
+ enum bootflow_img_t type, ulong *sizep)
{
return -ENOSYS;
}
diff --git a/boot/bootmeth_sandbox.c b/boot/bootmeth_sandbox.c
index 26c713bb5f3..92ba2e3f050 100644
--- a/boot/bootmeth_sandbox.c
+++ b/boot/bootmeth_sandbox.c
@@ -27,7 +27,8 @@ static int sandbox_read_bootflow(struct udevice *dev, struct bootflow *bflow)
}
static int sandbox_read_file(struct udevice *dev, struct bootflow *bflow,
- const char *file_path, ulong addr, ulong *sizep)
+ const char *file_path, ulong addr,
+ enum bootflow_img_t type, ulong *sizep)
{
return -ENOSYS;
}
diff --git a/boot/vbe_simple.c b/boot/vbe_simple.c
index 189e86d2a22..ed7b9598e38 100644
--- a/boot/vbe_simple.c
+++ b/boot/vbe_simple.c
@@ -160,13 +160,14 @@ static int vbe_simple_read_bootflow(struct udevice *dev, struct bootflow *bflow)
}
static int vbe_simple_read_file(struct udevice *dev, struct bootflow *bflow,
- const char *file_path, ulong addr, ulong *sizep)
+ const char *file_path, ulong addr,
+ enum bootflow_img_t type, ulong *sizep)
{
int ret;
if (vbe_phase() == VBE_PHASE_OS) {
ret = bootmeth_common_read_file(dev, bflow, file_path, addr,
- sizep);
+ type, sizep);
if (ret)
return log_msg_ret("os", ret);
}
diff --git a/include/bootmeth.h b/include/bootmeth.h
index e812974ec4d..788d4046ce9 100644
--- a/include/bootmeth.h
+++ b/include/bootmeth.h
@@ -8,7 +8,6 @@
#define __bootmeth_h
#include <bootflow.h>
-#include <image.h>
#include <linux/bitops.h>
struct blk_desc;
@@ -117,13 +116,15 @@ struct bootmeth_ops {
* @bflow: Bootflow providing info on where to read from
* @file_path: Path to file (may be absolute or relative)
* @addr: Address to load file
+ * @type: File type (IH_TYPE_...)
* @sizep: On entry provides the maximum permitted size; on exit
* returns the size of the file
* Return: 0 if OK, -ENOSPC if the file is too large for @sizep, other
* -ve value if something else goes wrong
*/
int (*read_file)(struct udevice *dev, struct bootflow *bflow,
- const char *file_path, ulong addr, ulong *sizep);
+ const char *file_path, ulong addr,
+ enum bootflow_img_t type, ulong *sizep);
#if CONFIG_IS_ENABLED(BOOTSTD_FULL)
/**
* readall() - read all files for a bootflow
@@ -245,13 +246,15 @@ int bootmeth_set_bootflow(struct udevice *dev, struct bootflow *bflow,
* @bflow: Bootflow providing info on where to read from
* @file_path: Path to file (may be absolute or relative)
* @addr: Address to load file
+ * @type: File type (IH_TYPE_...)
* @sizep: On entry provides the maximum permitted size; on exit
* returns the size of the file
* Return: 0 if OK, -ENOSPC if the file is too large for @sizep, other
* -ve value if something else goes wrong
*/
int bootmeth_read_file(struct udevice *dev, struct bootflow *bflow,
- const char *file_path, ulong addr, ulong *sizep);
+ const char *file_path, ulong addr,
+ enum bootflow_img_t type, ulong *sizep);
/**
* bootmeth_read_all() - read all bootflow files
@@ -397,11 +400,13 @@ int bootmeth_alloc_other(struct bootflow *bflow, const char *fname,
* @bflow: Bootflow information
* @file_path: Path to file
* @addr: Address to load file to
+ * @type: File type (IH_TYPE_...)
* @sizep: On entry, the maximum file size to accept, on exit the actual file
* size read
*/
int bootmeth_common_read_file(struct udevice *dev, struct bootflow *bflow,
- const char *file_path, ulong addr, ulong *sizep);
+ const char *file_path, ulong addr,
+ enum bootflow_img_t type, ulong *sizep);
/**
* bootmeth_get_bootflow() - Get a bootflow from a global bootmeth
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 11/19] bootmeth_efi: Check the filename-allocation in the network path
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (9 preceding siblings ...)
2024-11-04 17:51 ` [PATCH v3 10/19] bootmeth: Update the read_file() method to include a type Simon Glass
@ 2024-11-04 17:51 ` Simon Glass
2024-11-04 21:42 ` Heinrich Schuchardt
2024-11-04 17:51 ` [PATCH v3 12/19] boot: Update extlinux pxe_getfile_func() to include type Simon Glass
` (8 subsequent siblings)
19 siblings, 1 reply; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:51 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, AKASHI Takahiro, Heinrich Schuchardt,
Ilias Apalodimas, Mattijs Korpershoek, Shantur Rathore
If the filename cannot be set we should give up. Add the missing error
check.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
(no changes since v2)
Changes in v2:
- Change the tag to bootmeth_efi
boot/bootmeth_efi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c
index e8109e19bcb..1ff8788ebeb 100644
--- a/boot/bootmeth_efi.c
+++ b/boot/bootmeth_efi.c
@@ -269,6 +269,8 @@ static int distro_efi_read_bootflow_net(struct bootflow *bflow)
if (!bootfile_name)
return log_msg_ret("bootfile_name", ret);
bflow->fname = strdup(bootfile_name);
+ if (!bflow->fname)
+ return log_msg_ret("fi0", -ENOMEM);
/* do the hideous EFI hack */
efi_set_bootdev("Net", "", bflow->fname, map_sysmem(addr, 0),
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v3 11/19] bootmeth_efi: Check the filename-allocation in the network path
2024-11-04 17:51 ` [PATCH v3 11/19] bootmeth_efi: Check the filename-allocation in the network path Simon Glass
@ 2024-11-04 21:42 ` Heinrich Schuchardt
2024-11-15 23:19 ` Simon Glass
0 siblings, 1 reply; 41+ messages in thread
From: Heinrich Schuchardt @ 2024-11-04 21:42 UTC (permalink / raw)
To: Simon Glass
Cc: Tom Rini, AKASHI Takahiro, Ilias Apalodimas, Mattijs Korpershoek,
Shantur Rathore, U-Boot Mailing List
On 11/4/24 18:51, Simon Glass wrote:
> If the filename cannot be set we should give up. Add the missing error
> check.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Change the tag to bootmeth_efi
>
> boot/bootmeth_efi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c
> index e8109e19bcb..1ff8788ebeb 100644
> --- a/boot/bootmeth_efi.c
> +++ b/boot/bootmeth_efi.c
> @@ -269,6 +269,8 @@ static int distro_efi_read_bootflow_net(struct bootflow *bflow)
> if (!bootfile_name)
> return log_msg_ret("bootfile_name", ret);
> bflow->fname = strdup(bootfile_name);
> + if (!bflow->fname)
> + return log_msg_ret("fi0", -ENOMEM);
How could we hope that a user understands a cryptic message
"fi0: returning err=-12"?
Please, write a message that is user readable.
log_err("Out of memory");
Best regards
Heinrich
>
> /* do the hideous EFI hack */
> efi_set_bootdev("Net", "", bflow->fname, map_sysmem(addr, 0),
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH v3 11/19] bootmeth_efi: Check the filename-allocation in the network path
2024-11-04 21:42 ` Heinrich Schuchardt
@ 2024-11-15 23:19 ` Simon Glass
0 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-15 23:19 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Tom Rini, AKASHI Takahiro, Ilias Apalodimas, Mattijs Korpershoek,
Shantur Rathore, U-Boot Mailing List
Hi Heinrich,
On Mon, 4 Nov 2024 at 14:42, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 11/4/24 18:51, Simon Glass wrote:
> > If the filename cannot be set we should give up. Add the missing error
> > check.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> > (no changes since v2)
> >
> > Changes in v2:
> > - Change the tag to bootmeth_efi
> >
> > boot/bootmeth_efi.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c
> > index e8109e19bcb..1ff8788ebeb 100644
> > --- a/boot/bootmeth_efi.c
> > +++ b/boot/bootmeth_efi.c
> > @@ -269,6 +269,8 @@ static int distro_efi_read_bootflow_net(struct bootflow *bflow)
> > if (!bootfile_name)
> > return log_msg_ret("bootfile_name", ret);
> > bflow->fname = strdup(bootfile_name);
> > + if (!bflow->fname)
> > + return log_msg_ret("fi0", -ENOMEM);
>
> How could we hope that a user understands a cryptic message
> "fi0: returning err=-12"?
>
> Please, write a message that is user readable.
>
> log_err("Out of memory");
We cannot write to the screen here as it is in a driver. The log
message only appear if debugging is enabled and
CONFIG_LOG_ERROR_RETURN as well.
They are aimed at being enough for someone to grep the code, without
adding so much to the string space that U-Boot grows to Tianocore
dimensions.
[..]
Regards,
Simon
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v3 12/19] boot: Update extlinux pxe_getfile_func() to include type
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (10 preceding siblings ...)
2024-11-04 17:51 ` [PATCH v3 11/19] bootmeth_efi: Check the filename-allocation in the network path Simon Glass
@ 2024-11-04 17:51 ` Simon Glass
2024-11-04 17:51 ` [PATCH v3 13/19] boot: Update pxe bootmeth to record images Simon Glass
` (7 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:51 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Caleb Connolly, Heinrich Schuchardt,
Ilias Apalodimas, Ion Agorria, Marek Vasut, Martyn Welch,
Mattijs Korpershoek, Michael Trimarchi, Sean Edmond,
Svyatoslav Ryhel, Tim Harvey
Add a file-type parameter to this function and update all users. Add a
proper comment to the function which we are here.
This will allow tracking of the file types loaded by the extlinux
bootmeth.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
(no changes since v2)
Changes in v2:
- Update to use a new image-type enum in bootflow.h
boot/bootmeth_extlinux.c | 5 +++--
boot/bootmeth_pxe.c | 5 +++--
boot/pxe_utils.c | 26 ++++++++++++++++++--------
cmd/pxe.c | 2 +-
cmd/sysboot.c | 6 ++++--
include/pxe_utils.h | 14 +++++++++++++-
6 files changed, 42 insertions(+), 16 deletions(-)
diff --git a/boot/bootmeth_extlinux.c b/boot/bootmeth_extlinux.c
index ae5ae4dbb34..63cb9a4a8af 100644
--- a/boot/bootmeth_extlinux.c
+++ b/boot/bootmeth_extlinux.c
@@ -68,7 +68,8 @@ static int extlinux_get_state_desc(struct udevice *dev, char *buf, int maxsize)
}
static int extlinux_getfile(struct pxe_context *ctx, const char *file_path,
- char *file_addr, ulong *sizep)
+ char *file_addr, enum bootflow_img_t type,
+ ulong *sizep)
{
struct extlinux_info *info = ctx->userdata;
ulong addr;
@@ -79,7 +80,7 @@ static int extlinux_getfile(struct pxe_context *ctx, const char *file_path,
/* Allow up to 1GB */
*sizep = 1 << 30;
ret = bootmeth_read_file(info->dev, info->bflow, file_path, addr,
- (enum bootflow_img_t)IH_TYPE_INVALID, sizep);
+ type, sizep);
if (ret)
return log_msg_ret("read", ret);
diff --git a/boot/bootmeth_pxe.c b/boot/bootmeth_pxe.c
index e64429f6857..b2873075ba5 100644
--- a/boot/bootmeth_pxe.c
+++ b/boot/bootmeth_pxe.c
@@ -23,7 +23,8 @@
#include <pxe_utils.h>
static int extlinux_pxe_getfile(struct pxe_context *ctx, const char *file_path,
- char *file_addr, ulong *sizep)
+ char *file_addr, enum bootflow_img_t type,
+ ulong *sizep)
{
struct extlinux_info *info = ctx->userdata;
ulong addr;
@@ -34,7 +35,7 @@ static int extlinux_pxe_getfile(struct pxe_context *ctx, const char *file_path,
/* Allow up to 1GB */
*sizep = 1 << 30;
ret = bootmeth_read_file(info->dev, info->bflow, file_path, addr,
- IH_TYPE_INVALID, sizep);
+ type, sizep);
if (ret)
return log_msg_ret("read", ret);
diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c
index 4fd26524286..03d0ab8c578 100644
--- a/boot/pxe_utils.c
+++ b/boot/pxe_utils.c
@@ -6,6 +6,7 @@
#define LOG_CATEGORY LOGC_BOOT
+#include <bootflow.h>
#include <command.h>
#include <dm.h>
#include <env.h>
@@ -97,7 +98,8 @@ int format_mac_pxe(char *outbuf, size_t outbuf_len)
* Returns 1 for success, or < 0 on error
*/
static int get_relfile(struct pxe_context *ctx, const char *file_path,
- unsigned long file_addr, ulong *filesizep)
+ unsigned long file_addr, enum bootflow_img_t type,
+ ulong *filesizep)
{
size_t path_len;
char relfile[MAX_TFTP_PATH_LEN + 1];
@@ -124,7 +126,7 @@ static int get_relfile(struct pxe_context *ctx, const char *file_path,
sprintf(addr_buf, "%lx", file_addr);
- ret = ctx->getfile(ctx, relfile, addr_buf, &size);
+ ret = ctx->getfile(ctx, relfile, addr_buf, type, &size);
if (ret < 0)
return log_msg_ret("get", ret);
if (filesizep)
@@ -140,7 +142,8 @@ int get_pxe_file(struct pxe_context *ctx, const char *file_path,
int err;
char *buf;
- err = get_relfile(ctx, file_path, file_addr, &size);
+ err = get_relfile(ctx, file_path, file_addr, BFI_EXTLINUX_CFG,
+ &size);
if (err < 0)
return err;
@@ -189,13 +192,15 @@ int get_pxelinux_path(struct pxe_context *ctx, const char *file,
* @file_path: File path to read (relative to the PXE file)
* @envaddr_name: Name of environment variable which contains the address to
* load to
+ * @type: File type
* @filesizep: Returns the file size in bytes
* Returns 1 on success, -ENOENT if @envaddr_name does not exist as an
* environment variable, -EINVAL if its format is not valid hex, or other
* value < 0 on other error
*/
static int get_relfile_envaddr(struct pxe_context *ctx, const char *file_path,
- const char *envaddr_name, ulong *filesizep)
+ const char *envaddr_name,
+ enum bootflow_img_t type, ulong *filesizep)
{
unsigned long file_addr;
char *envaddr;
@@ -207,7 +212,7 @@ static int get_relfile_envaddr(struct pxe_context *ctx, const char *file_path,
if (strict_strtoul(envaddr, 16, &file_addr) < 0)
return -EINVAL;
- return get_relfile(ctx, file_path, file_addr, filesizep);
+ return get_relfile(ctx, file_path, file_addr, type, filesizep);
}
/**
@@ -395,6 +400,7 @@ static void label_boot_fdtoverlay(struct pxe_context *ctx,
/* Load overlay file */
err = get_relfile_envaddr(ctx, overlayfile, "fdtoverlay_addr_r",
+ (enum bootflow_img_t)IH_TYPE_FLATDT,
NULL);
if (err < 0) {
printf("Failed loading overlay %s\n", overlayfile);
@@ -480,7 +486,8 @@ static int label_boot(struct pxe_context *ctx, struct pxe_label *label)
}
if (get_relfile_envaddr(ctx, label->kernel, "kernel_addr_r",
- NULL) < 0) {
+ (enum bootflow_img_t)IH_TYPE_KERNEL, NULL)
+ < 0) {
printf("Skipping %s for failure retrieving kernel\n",
label->name);
return 1;
@@ -506,6 +513,7 @@ static int label_boot(struct pxe_context *ctx, struct pxe_label *label)
} else if (label->initrd) {
ulong size;
if (get_relfile_envaddr(ctx, label->initrd, "ramdisk_addr_r",
+ (enum bootflow_img_t)IH_TYPE_RAMDISK,
&size) < 0) {
printf("Skipping %s for failure retrieving initrd\n",
label->name);
@@ -651,7 +659,8 @@ static int label_boot(struct pxe_context *ctx, struct pxe_label *label)
if (fdtfile) {
int err = get_relfile_envaddr(ctx, fdtfile,
- "fdt_addr_r", NULL);
+ "fdt_addr_r",
+ (enum bootflow_img_t)IH_TYPE_FLATDT, NULL);
free(fdtfilefree);
if (err < 0) {
@@ -1538,7 +1547,8 @@ void handle_pxe_menu(struct pxe_context *ctx, struct pxe_menu *cfg)
if (IS_ENABLED(CONFIG_CMD_BMP)) {
/* display BMP if available */
if (cfg->bmp) {
- if (get_relfile(ctx, cfg->bmp, image_load_addr, NULL)) {
+ if (get_relfile(ctx, cfg->bmp, image_load_addr,
+ BFI_LOGO, NULL)) {
#if defined(CONFIG_VIDEO)
struct udevice *dev;
diff --git a/cmd/pxe.c b/cmd/pxe.c
index 982e2b1e7ea..37b8dea6ad6 100644
--- a/cmd/pxe.c
+++ b/cmd/pxe.c
@@ -27,7 +27,7 @@ const char *pxe_default_paths[] = {
};
static int do_get_tftp(struct pxe_context *ctx, const char *file_path,
- char *file_addr, ulong *sizep)
+ char *file_addr, enum bootflow_img_t type, ulong *sizep)
{
char *tftp_argv[] = {"tftp", NULL, NULL, NULL};
int ret;
diff --git a/cmd/sysboot.c b/cmd/sysboot.c
index 8a060780cab..93d4a400830 100644
--- a/cmd/sysboot.c
+++ b/cmd/sysboot.c
@@ -23,7 +23,8 @@ struct sysboot_info {
};
static int sysboot_read_file(struct pxe_context *ctx, const char *file_path,
- char *file_addr, ulong *sizep)
+ char *file_addr, enum bootflow_img_t type,
+ ulong *sizep)
{
struct sysboot_info *info = ctx->userdata;
loff_t len_read;
@@ -110,7 +111,8 @@ static int do_sysboot(struct cmd_tbl *cmdtp, int flag, int argc,
return CMD_RET_FAILURE;
}
- if (get_pxe_file(&ctx, filename, pxefile_addr_r) < 0) {
+ if (get_pxe_file(&ctx, filename, pxefile_addr_r)
+ < 0) {
printf("Error reading config file\n");
pxe_destroy_ctx(&ctx);
return 1;
diff --git a/include/pxe_utils.h b/include/pxe_utils.h
index 68ac40b64ad..0378f2889f7 100644
--- a/include/pxe_utils.h
+++ b/include/pxe_utils.h
@@ -3,6 +3,7 @@
#ifndef __PXE_UTILS_H
#define __PXE_UTILS_H
+#include <bootflow.h>
#include <linux/list.h>
/*
@@ -82,8 +83,19 @@ struct pxe_menu {
};
struct pxe_context;
+
+/**
+ * Read a file
+ *
+ * @ctx: PXE context
+ * @file_path: Full path to filename to read
+ * @file_addr: String containing the to which to read the file
+ * @type: File type
+ * @fileszeip: Returns file size
+ */
typedef int (*pxe_getfile_func)(struct pxe_context *ctx, const char *file_path,
- char *file_addr, ulong *filesizep);
+ char *file_addr, enum bootflow_img_t type,
+ ulong *filesizep);
/**
* struct pxe_context - context information for PXE parsing
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 13/19] boot: Update pxe bootmeth to record images
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (11 preceding siblings ...)
2024-11-04 17:51 ` [PATCH v3 12/19] boot: Update extlinux pxe_getfile_func() to include type Simon Glass
@ 2024-11-04 17:51 ` Simon Glass
2024-11-04 17:51 ` [PATCH v3 14/19] Update bootmeth_alloc_other() " Simon Glass
` (6 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:51 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Heinrich Schuchardt, Ilias Apalodimas,
Martyn Welch, Mattijs Korpershoek
Record images loaded by this bootmeth.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Use the helper function
boot/bootmeth_pxe.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/boot/bootmeth_pxe.c b/boot/bootmeth_pxe.c
index b2873075ba5..b91e61bcbc4 100644
--- a/boot/bootmeth_pxe.c
+++ b/boot/bootmeth_pxe.c
@@ -135,6 +135,9 @@ static int extlinux_pxe_read_file(struct udevice *dev, struct bootflow *bflow,
return log_msg_ret("spc", -ENOSPC);
*sizep = size;
+ if (!bootflow_img_add(bflow, file_path, type, addr, size))
+ return log_msg_ret("pxi", -ENOMEM);
+
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 14/19] Update bootmeth_alloc_other() to record images
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (12 preceding siblings ...)
2024-11-04 17:51 ` [PATCH v3 13/19] boot: Update pxe bootmeth to record images Simon Glass
@ 2024-11-04 17:51 ` Simon Glass
2024-11-04 17:51 ` [PATCH v3 15/19] bootstd: Update cros bootmeth " Simon Glass
` (5 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:51 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Guillaume La Roque, Heinrich Schuchardt,
Martyn Welch, Mattijs Korpershoek, Quentin Schulz
Update this function to add the image to the list.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Use the helper function
Changes in v2:
- Update to use a new image-type enum in bootflow.h
boot/bootmeth-uclass.c | 6 +++++-
boot/bootmeth_script.c | 4 ++--
include/bootmeth.h | 3 ++-
3 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/boot/bootmeth-uclass.c b/boot/bootmeth-uclass.c
index 1f48d0c1f51..014b7588e8d 100644
--- a/boot/bootmeth-uclass.c
+++ b/boot/bootmeth-uclass.c
@@ -359,7 +359,7 @@ int bootmeth_alloc_file(struct bootflow *bflow, uint size_limit, uint align,
}
int bootmeth_alloc_other(struct bootflow *bflow, const char *fname,
- void **bufp, uint *sizep)
+ enum bootflow_img_t type, void **bufp, uint *sizep)
{
struct blk_desc *desc = NULL;
char path[200];
@@ -388,6 +388,10 @@ int bootmeth_alloc_other(struct bootflow *bflow, const char *fname,
if (ret)
return log_msg_ret("all", ret);
+ if (!bootflow_img_add(bflow, bflow->fname, type, map_to_sysmem(buf),
+ size))
+ return log_msg_ret("boi", -ENOMEM);
+
*bufp = buf;
*sizep = size;
diff --git a/boot/bootmeth_script.c b/boot/bootmeth_script.c
index a2fb2899885..020cb8a7aec 100644
--- a/boot/bootmeth_script.c
+++ b/boot/bootmeth_script.c
@@ -107,8 +107,8 @@ static int script_read_bootflow_file(struct udevice *bootstd,
if (ret)
return log_msg_ret("inf", ret);
- ret = bootmeth_alloc_other(bflow, "boot.bmp", &bflow->logo,
- &bflow->logo_size);
+ ret = bootmeth_alloc_other(bflow, "boot.bmp", BFI_LOGO,
+ &bflow->logo, &bflow->logo_size);
/* ignore error */
return 0;
diff --git a/include/bootmeth.h b/include/bootmeth.h
index 788d4046ce9..26de593a9a4 100644
--- a/include/bootmeth.h
+++ b/include/bootmeth.h
@@ -384,12 +384,13 @@ int bootmeth_alloc_file(struct bootflow *bflow, uint size_limit, uint align,
*
* @bflow: Information about file to read
* @fname: Filename to read from (within bootflow->subdir)
+ * @type: File type (IH_TYPE_...)
* @bufp: Returns a pointer to the allocated buffer
* @sizep: Returns the size of the buffer
* Return: 0 if OK, -ENOMEM if out of memory, other -ve on other error
*/
int bootmeth_alloc_other(struct bootflow *bflow, const char *fname,
- void **bufp, uint *sizep);
+ enum bootflow_img_t type, void **bufp, uint *sizep);
/**
* bootmeth_common_read_file() - Common handler for reading a file
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 15/19] bootstd: Update cros bootmeth to record images
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (13 preceding siblings ...)
2024-11-04 17:51 ` [PATCH v3 14/19] Update bootmeth_alloc_other() " Simon Glass
@ 2024-11-04 17:51 ` Simon Glass
2024-11-04 17:51 ` [PATCH v3 16/19] bootstd: Add a simple command to list images Simon Glass
` (4 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:51 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Mattijs Korpershoek, Vincent Stehlé
Record images loaded by this bootmeth.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Use the helper function
Changes in v2:
- Update to use a new image-type enum in bootflow.h
boot/bootmeth_cros.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/boot/bootmeth_cros.c b/boot/bootmeth_cros.c
index 1825293d93d..c7b862e512a 100644
--- a/boot/bootmeth_cros.c
+++ b/boot/bootmeth_cros.c
@@ -243,8 +243,17 @@ static int cros_read_buf(struct bootflow *bflow, void *buf, ulong size,
ret = copy_cmdline(map_sysmem(cmdline, 0), uuid, &bflow->cmdline);
if (ret)
return log_msg_ret("cmd", ret);
+
+ if (!bootflow_img_add(bflow, "setup",
+ (enum bootflow_img_t)IH_TYPE_X86_SETUP,
+ setup, 0x3000))
+ return log_msg_ret("cri", -ENOMEM);
+
bflow->x86_setup = map_sysmem(setup, 0);
+ if (!bootflow_img_add(bflow, "cmdline", BFI_CMDLINE, cmdline, 0x1000))
+ return log_msg_ret("crc", -ENOMEM);
+
return 0;
}
@@ -306,6 +315,11 @@ static int cros_read_info(struct bootflow *bflow, const char *uuid,
}
priv->info_buf = buf;
+ if (!bootflow_img_add(bflow, "kernel",
+ (enum bootflow_img_t)IH_TYPE_KERNEL, 0,
+ priv->body_size))
+ return log_msg_ret("crk", -ENOMEM);
+
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 16/19] bootstd: Add a simple command to list images
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (14 preceding siblings ...)
2024-11-04 17:51 ` [PATCH v3 15/19] bootstd: Update cros bootmeth " Simon Glass
@ 2024-11-04 17:51 ` Simon Glass
2024-11-04 17:51 ` [PATCH v3 17/19] bootstd: Export bootdev_get_from_blk() Simon Glass
` (3 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:51 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, AKASHI Takahiro, Emil Kronborg,
Etienne Carriere, Francis Laniel, Guillaume La Roque,
Heinrich Schuchardt, Hou Zhiqiang, Igor Opaniuk, Ilias Apalodimas,
Jerome Forissier, Julien Masson, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune, Nam Cao,
Quentin Schulz, Shantur Rathore
Add a new 'bootstd images' command, which lists the images which have
been loaded.
Update some existing tests to use it. Provide some documentation about
images in general and this command in particular.
Use a more realistic kernel command-line to make the test easier to
follow.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
(no changes since v1)
boot/bootflow.c | 12 ++++
cmd/Kconfig | 9 +++
cmd/Makefile | 1 +
cmd/bootstd.c | 65 +++++++++++++++++++
doc/develop/bootstd/overview.rst | 21 +++++-
doc/usage/cmd/bootstd.rst | 79 +++++++++++++++++++++++
doc/usage/index.rst | 1 +
include/bootflow.h | 8 +++
test/boot/bootflow.c | 106 +++++++++++++++++++++++++++++++
test/py/tests/test_ut.py | 3 +-
10 files changed, 303 insertions(+), 2 deletions(-)
create mode 100644 cmd/bootstd.c
create mode 100644 doc/usage/cmd/bootstd.rst
diff --git a/boot/bootflow.c b/boot/bootflow.c
index a10d3012b48..58a1afa7a75 100644
--- a/boot/bootflow.c
+++ b/boot/bootflow.c
@@ -997,3 +997,15 @@ struct bootflow_img *bootflow_img_add(struct bootflow *bflow, const char *fname,
return ptr;
}
+
+int bootflow_get_seq(const struct bootflow *bflow)
+{
+ struct bootstd_priv *std;
+ int ret;
+
+ ret = bootstd_get_priv(&std);
+ if (ret)
+ return ret;
+
+ return alist_calc_index(&std->bootflows, bflow);
+}
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 636833646f6..6ed83b39b81 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -321,6 +321,15 @@ config CMD_BOOTMETH
This command is not necessary for bootstd to work.
+config CMD_BOOTSTD
+ bool "bootstd"
+ depends on BOOTSTD
+ default y if BOOTSTD_FULL
+ help
+ Provide general information and control for bootstd.
+
+ This command is not necessary for bootstd to work.
+
config BOOTM_EFI
bool "Support booting UEFI FIT images"
depends on EFI_BINARY_EXEC && CMD_BOOTM && FIT
diff --git a/cmd/Makefile b/cmd/Makefile
index d1f369deec0..c0b0ff8b742 100644
--- a/cmd/Makefile
+++ b/cmd/Makefile
@@ -23,6 +23,7 @@ obj-$(CONFIG_BLK) += blk_common.o
obj-$(CONFIG_CMD_BOOTDEV) += bootdev.o
obj-$(CONFIG_CMD_BOOTFLOW) += bootflow.o
obj-$(CONFIG_CMD_BOOTMETH) += bootmeth.o
+obj-$(CONFIG_CMD_BOOTSTD) += bootstd.o
obj-$(CONFIG_CMD_SOURCE) += source.o
obj-$(CONFIG_CMD_BCB) += bcb.o
obj-$(CONFIG_CMD_BDI) += bdinfo.o
diff --git a/cmd/bootstd.c b/cmd/bootstd.c
new file mode 100644
index 00000000000..e1d82744eb5
--- /dev/null
+++ b/cmd/bootstd.c
@@ -0,0 +1,65 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * 'bootstd' command
+ *
+ * Copyright 2024 Google LLC
+ * Written by Simon Glass <sjg@chromium.org>
+ */
+
+#include <bootdev.h>
+#include <bootflow.h>
+#include <bootmeth.h>
+#include <bootstd.h>
+#include <command.h>
+#include <dm.h>
+#include <malloc.h>
+#include <dm/uclass-internal.h>
+
+static int do_bootstd_images(struct cmd_tbl *cmdtp, int flag, int argc,
+ char *const argv[])
+{
+ const struct bootflow *bflow;
+ struct bootstd_priv *std;
+ int ret, i;
+
+ ret = bootstd_get_priv(&std);
+ if (ret) {
+ printf("Cannot get bootstd (err=%d)\n", ret);
+ return CMD_RET_FAILURE;
+ }
+
+ printf("Seq Bootflow Type At Size Filename\n");
+ printf("--- ------------------- -------------- -------- -------- ----------------\n");
+
+ /*
+ * Use the ordering if we have one, so long as we are not trying to list
+ * all bootmethds
+ */
+ i = 0;
+ alist_for_each(bflow, &std->bootflows) {
+ const struct bootflow_img *img;
+
+ alist_for_each(img, &bflow->images) {
+ printf("%3d %-20.20s %-15.15s ",
+ bootflow_get_seq(bflow), bflow->name,
+ bootflow_img_type_name(img->type));
+ if (img->addr)
+ printf("%8lx", img->addr);
+ else
+ printf("%8s", "-");
+ printf(" %8lx %s\n", img->size, img->fname);
+ i++;
+ }
+ }
+
+ printf("--- ------------------- -------------- -------- -------- ----------------\n");
+ printf("(%d image%s)\n", i, i != 1 ? "s" : "");
+
+ return 0;
+}
+
+U_BOOT_LONGHELP(bootstd,
+ "images - list loaded images");
+
+U_BOOT_CMD_WITH_SUBCMDS(bootstd, "Standard-boot operation", bootstd_help_text,
+ U_BOOT_SUBCMD_MKENT(images, 1, 1, do_bootstd_images));
diff --git a/doc/develop/bootstd/overview.rst b/doc/develop/bootstd/overview.rst
index a2913cd47be..e3ce97cc4f5 100644
--- a/doc/develop/bootstd/overview.rst
+++ b/doc/develop/bootstd/overview.rst
@@ -453,7 +453,7 @@ drivers are bound automatically.
Command interface
-----------------
-Three commands are available:
+Four commands are available:
`bootdev`
Allows listing of available bootdevs, selecting a particular one and
@@ -468,6 +468,25 @@ Three commands are available:
Allow listing of available bootmethds, setting the order in which they are
tried and bootmeth specific configuration. See :doc:`/usage/cmd/bootmeth`
+`bootstd`
+ Allow access to standard boot itself, so far only for listing images across
+ all bootflows. See :doc:`/usage/cmd/bootstd`
+
+Images
+------
+
+Standard boot keeps track of images which can or have been loaded. These are
+kept in a list attached to each bootflow. They can be listed using the
+``bootstd images`` command (see :doc:`/usage/cmd/bootstd`).
+
+For now most bootmeths load their images when scanning. Over time, some may
+adjust to load them only when needed, but in this case the images will still
+be visible.
+
+Once a bootflow has been selected, images for those that are not selected can
+potentially be dropped from the memory map. For now, this is not implemented.
+
+
.. _BootflowStates:
Bootflow states
diff --git a/doc/usage/cmd/bootstd.rst b/doc/usage/cmd/bootstd.rst
new file mode 100644
index 00000000000..7d933852a91
--- /dev/null
+++ b/doc/usage/cmd/bootstd.rst
@@ -0,0 +1,79 @@
+.. SPDX-License-Identifier: GPL-2.0+:
+
+.. index::
+ single: bootstd (command)
+
+bootstd command
+===============
+
+Synopsis
+--------
+
+::
+
+ bootstd images
+
+Description
+-----------
+
+The `bootstd` command is used to manage standard boot. At present the only
+functionality available is to look at the images which have been loaded, or
+could be loaded should a particular bootflow be selected.
+
+See :doc:`/develop/bootstd/index` for more information.
+
+bootflow images
+~~~~~~~~~~~~~~~
+
+Lists the available images and their location in memory.
+
+Example
+-------
+
+This shows listing images attached to various bootflows, then checking the
+content of a few of them::
+
+ => bootflow scan
+ => bootflow list
+ Showing all bootflows
+ Seq Method State Uclass Part Name Filename
+ --- ----------- ------ -------- ---- ------------------------ ----------------
+ 0 extlinux ready mmc 1 mmc1.bootdev.part_1 /extlinux/extlinux.conf
+ 1 script ready mmc 1 mmc4.bootdev.part_1 /boot/boot.scr
+ 2 cros ready mmc 2 mmc5.bootdev.part_2
+ 3 cros ready mmc 4 mmc5.bootdev.part_4
+ --- ----------- ------ -------- ---- ------------------------ ----------------
+ (4 bootflows, 4 valid)
+ =>
+ => bootstd images
+ Seq Bootflow Type At Size Filename
+ --- ------------------- -------------- -------- -------- ----------------
+ 0 mmc1.bootdev.part_1 extlinux_cfg 8ed5a70 253 /extlinux/extlinux.conf
+ 1 mmc4.bootdev.part_1 script 8ed9550 c73 /boot/boot.scr
+ 1 mmc4.bootdev.part_1 logo 8eda2a0 5d42 boot.bmp
+ 2 mmc5.bootdev.part_2 x86_setup 8ee84d0 3000 setup
+ 2 mmc5.bootdev.part_2 cmdline 8ee84d0 1000 cmdline
+ 2 mmc5.bootdev.part_2 kernel - 4000 kernel
+ 3 mmc5.bootdev.part_4 x86_setup 8eeb4e0 3000 setup
+ 3 mmc5.bootdev.part_4 cmdline 8eeb4e0 1000 cmdline
+ 3 mmc5.bootdev.part_4 kernel - 4000 kernel
+ --- ------------------- -------------- -------- -------- ----------------
+ (9 images)
+ => md 8eda2a0 10
+ 08eda2a0: 5d424d42 00000000 008a0000 007c0000 BMB]..........|.
+ 08eda2b0: 00ac0000 002e0000 00010000 00000018 ................
+ 08eda2c0: 5cb80000 0b130000 0b130000 00000000 ...\............
+ 08eda2d0: 00000000 00000000 ff0000ff 00ff0000 ................
+ => md 8ee84d0 10
+ 08ee84d0: 544f4f42 414d495f 2f3d4547 696c6d76 BOOT_IMAGE=/vmli
+ 08ee84e0: 2d7a756e 35312e35 312d302e 672d3132 nuz-5.15.0-121-g
+ 08ee84f0: 72656e65 72206369 3d746f6f 7665642f eneric root=/dev
+ 08ee8500: 6d766e2f 316e3065 72203170 7571206f /nvme0n1p1 ro qu
+
+Return value
+------------
+
+The return value $? is always 0 (true).
+
+
+.. BootflowStates_:
diff --git a/doc/usage/index.rst b/doc/usage/index.rst
index cb7a23f1170..71970d5f2b3 100644
--- a/doc/usage/index.rst
+++ b/doc/usage/index.rst
@@ -40,6 +40,7 @@ Shell commands
cmd/bootm
cmd/bootmenu
cmd/bootmeth
+ cmd/bootstd
cmd/bootz
cmd/button
cmd/cat
diff --git a/include/bootflow.h b/include/bootflow.h
index e09cff285e4..480cf8a5af1 100644
--- a/include/bootflow.h
+++ b/include/bootflow.h
@@ -627,5 +627,13 @@ const char *bootflow_img_type_name(enum bootflow_img_t type);
struct bootflow_img *bootflow_img_add(struct bootflow *bflow, const char *fname,
enum bootflow_img_t type, ulong addr,
ulong size);
+/**
+ * bootflow_get_seq() - Get the sequence number of a bootflow
+ *
+ * Bootflows are numbered by their position in the bootstd list.
+ *
+ * Return: Sequence number of bootflow (0 = first)
+ */
+int bootflow_get_seq(const struct bootflow *bflow);
#endif
diff --git a/test/boot/bootflow.c b/test/boot/bootflow.c
index 2f859c40adb..670b9253f61 100644
--- a/test/boot/bootflow.c
+++ b/test/boot/bootflow.c
@@ -14,6 +14,7 @@
#include <dm.h>
#include <efi_default_filename.h>
#include <expo.h>
+#include <mapmem.h>
#ifdef CONFIG_SANDBOX
#include <asm/test.h>
#endif
@@ -73,6 +74,14 @@ static int bootflow_cmd(struct unit_test_state *uts)
ut_assert_nextline("(1 bootflow, 1 valid)");
ut_assert_console_end();
+ ut_assertok(run_command("bootstd images", 0));
+ ut_assert_nextlinen("Seq");
+ ut_assert_nextlinen("---");
+ ut_assert_nextlinen(" 0 mmc1.bootdev.part_1 extlinux_cfg");
+ ut_assert_nextlinen("---");
+ ut_assert_nextline("(1 image)");
+ ut_assert_console_end();
+
return 0;
}
BOOTSTD_TEST(bootflow_cmd, UTF_DM | UTF_SCAN_FDT | UTF_CONSOLE);
@@ -1188,6 +1197,19 @@ static int bootflow_cros(struct unit_test_state *uts)
ut_assert_nextlinen("---");
ut_assert_skip_to_line("(3 bootflows, 3 valid)");
+ ut_assertok(run_command("bootstd images", 0));
+ ut_assert_nextlinen("Seq");
+ ut_assert_nextlinen("---");
+ ut_assert_nextlinen(" 0 mmc1.bootdev.part_1 extlinux_cfg");
+ ut_assert_nextlinen(" 1 mmc5.bootdev.part_2 x86_setup");
+ ut_assert_nextlinen(" 1 mmc5.bootdev.part_2 cmdline");
+ ut_assert_nextlinen(" 1 mmc5.bootdev.part_2 kernel - 4000 kernel");
+ ut_assert_nextlinen(" 2 mmc5.bootdev.part_4 x86_setup");
+ ut_assert_nextlinen(" 2 mmc5.bootdev.part_4 cmdline");
+ ut_assert_nextlinen(" 2 mmc5.bootdev.part_4 kernel - 4000 kernel");
+ ut_assert_nextlinen("---");
+ ut_assert_nextline("(7 images)");
+
ut_assert_console_end();
return 0;
@@ -1216,3 +1238,87 @@ static int bootflow_android(struct unit_test_state *uts)
return 0;
}
BOOTSTD_TEST(bootflow_android, UTF_CONSOLE);
+
+/* Check 'bootflow scan' provides a list of images */
+static int bootstd_images(struct unit_test_state *uts)
+{
+ static const char *order[] = {"mmc2", "mmc1", "mmc4", "mmc5", NULL};
+ const struct legacy_img_hdr *hdr;
+ const struct bootflow_img *img;
+ const struct bootflow *bflow;
+ struct bootstd_priv *std;
+ const char **old_order;
+ struct udevice *dev;
+ ofnode root, node;
+ ulong data, len;
+ char *ptr;
+
+ /* get access to the current bootflow */
+ ut_assertok(bootstd_get_priv(&std));
+
+ ut_assertok(prep_mmc_bootdev(uts, "mmc4", true, &old_order));
+
+ /* bind mmc5 too, for cros */
+ root = oftree_root(oftree_default());
+ node = ofnode_find_subnode(root, "mmc5");
+ ut_assert(ofnode_valid(node));
+ ut_assertok(lists_bind_fdt(gd->dm_root, node, &dev, NULL, false));
+
+ std->bootdev_order = order;
+ ut_assertok(run_command("bootflow scan", 0));
+ ut_assert_console_end();
+ std->bootdev_order = old_order;
+
+ ut_assertok(run_command("bootflow list", 0));
+ ut_assert_skip_to_line("(4 bootflows, 4 valid)");
+
+ ut_assertok(run_command("bootstd images", 0));
+ ut_assert_nextlinen("Seq");
+ ut_assert_nextlinen("---");
+ ut_assert_nextlinen(" 0 mmc1.bootdev.part_1 extlinux_cfg");
+ ut_assert_nextlinen(" 1 mmc4.bootdev.part_1 script");
+ ut_assert_nextlinen(" 1 mmc4.bootdev.part_1 logo");
+ ut_assert_nextlinen(" 2 mmc5.bootdev.part_2 x86_setup");
+ ut_assert_nextlinen(" 2 mmc5.bootdev.part_2 cmdline");
+ ut_assert_nextlinen(" 2 mmc5.bootdev.part_2 kernel -");
+ ut_assert_nextlinen(" 3 mmc5.bootdev.part_4 x86_setup");
+ ut_assert_nextlinen(" 3 mmc5.bootdev.part_4 cmdline");
+ ut_assert_nextlinen(" 3 mmc5.bootdev.part_4 kernel -");
+ ut_assert_nextlinen("---");
+ ut_assert_nextline("(9 images)");
+
+ /* check the first image */
+ bflow = alist_get(&std->bootflows, 0, struct bootflow);
+ img = alist_get(&bflow->images, 0, struct bootflow_img);
+ ut_asserteq_strn("# extlinux.conf", map_sysmem(img->addr, 0));
+
+ /* check the second image */
+ bflow = alist_get(&std->bootflows, 1, struct bootflow);
+ img = alist_get(&bflow->images, 0, struct bootflow_img);
+
+ /* this is the length of the script in bytes */
+ hdr = map_sysmem(img->addr, 0);
+ image_multi_getimg(hdr, 0, &data, &len);
+ ptr = (void *)data;
+ ut_asserteq_strn("# DO NOT EDIT THIS FILE", ptr);
+
+ /* check the ChromiumOS images */
+ bflow = alist_get(&std->bootflows, 2, struct bootflow);
+ img = alist_get(&bflow->images, 1, struct bootflow_img);
+ ptr = map_sysmem(img->addr, 0);
+ ut_asserteq_strn("BOOT_IMAGE=/vmlinuz-5.15.0-121-generic root=", ptr);
+
+ /*
+ * the x86 setup is not a real binary, so just check that it is empty,
+ * so that if this changes in the future someone will notice and update
+ * this test
+ */
+ img = alist_get(&bflow->images, 0, struct bootflow_img);
+ ptr = map_sysmem(img->addr, 0);
+ ut_asserteq(0, *(ulong *)ptr);
+
+ ut_assert_console_end();
+
+ return 0;
+}
+BOOTSTD_TEST(bootstd_images, UTF_CONSOLE);
diff --git a/test/py/tests/test_ut.py b/test/py/tests/test_ut.py
index 9166c8f6b6e..0508f933e3b 100644
--- a/test/py/tests/test_ut.py
+++ b/test/py/tests/test_ut.py
@@ -400,9 +400,10 @@ def setup_cros_image(cons):
start, size, num, name = line.split(maxsplit=3)
parts[int(num)] = Partition(int(start), int(size), name)
+ # Set up the kernel command-line
dummy = os.path.join(cons.config.result_dir, 'dummy.txt')
with open(dummy, 'wb') as outf:
- outf.write(b'dummy\n')
+ outf.write(b'BOOT_IMAGE=/vmlinuz-5.15.0-121-generic root=/dev/nvme0n1p1 ro quiet splash vt.handoff=7')
# For now we just use dummy kernels. This limits testing to just detecting
# a signed kernel. We could add support for the x86 data structures so that
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 17/19] bootstd: Export bootdev_get_from_blk()
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (15 preceding siblings ...)
2024-11-04 17:51 ` [PATCH v3 16/19] bootstd: Add a simple command to list images Simon Glass
@ 2024-11-04 17:51 ` Simon Glass
2024-11-04 17:51 ` [PATCH v3 18/19] bootstd: Add the concept of an ad-hoc bootflow Simon Glass
` (2 subsequent siblings)
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:51 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Caleb Connolly, Dragan Simic,
Ilias Apalodimas, Nam Cao, Thomas Weißschuh, Tony Dinh
Export this function so it can be used from other files.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Add new patch to export bootdev_get_from_blk()
boot/bootdev-uclass.c | 2 +-
include/bootdev.h | 9 +++++++++
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c
index a4e1d79ec9b..65a3b89e40c 100644
--- a/boot/bootdev-uclass.c
+++ b/boot/bootdev-uclass.c
@@ -319,7 +319,7 @@ int bootdev_get_sibling_blk(struct udevice *dev, struct udevice **blkp)
return 0;
}
-static int bootdev_get_from_blk(struct udevice *blk, struct udevice **bootdevp)
+int bootdev_get_from_blk(struct udevice *blk, struct udevice **bootdevp)
{
struct udevice *parent = dev_get_parent(blk);
struct udevice *bootdev;
diff --git a/include/bootdev.h b/include/bootdev.h
index 991b6229c1c..12c90c4ec1b 100644
--- a/include/bootdev.h
+++ b/include/bootdev.h
@@ -401,6 +401,15 @@ static int bootdev_setup_for_sibling_blk(struct udevice *blk,
*/
int bootdev_get_sibling_blk(struct udevice *dev, struct udevice **blkp);
+/**
+ * bootdev_get_from_blk() - Get the bootdev given a block device
+ *
+ * @blk: Block device to check
+ * @bootdebp: Returns the bootdev found, if any
+ * Return 0 if OK, -ve on error
+ */
+int bootdev_get_from_blk(struct udevice *blk, struct udevice **bootdevp);
+
/**
* bootdev_unbind_dev() - Unbind a bootdev device
*
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 18/19] bootstd: Add the concept of an ad-hoc bootflow
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (16 preceding siblings ...)
2024-11-04 17:51 ` [PATCH v3 17/19] bootstd: Export bootdev_get_from_blk() Simon Glass
@ 2024-11-04 17:51 ` Simon Glass
2024-11-04 17:51 ` [PATCH v3 19/19] fs: Record loaded files in " Simon Glass
2025-01-15 13:55 ` [PATCH v3 00/19] bootstd: Support recording images Simon Glass
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:51 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, Guillaume La Roque, Heinrich Schuchardt,
Mattijs Korpershoek, Nam Cao, Peter Robinson, Quentin Schulz,
Shantur Rathore
The normal situation with bootstd is that a bootflow is created from a
bootmeth. In some cases, a script or user-command may cause an image to
be loaded. To deal with this, add the concept of an ad-hoc bootflow.
This can be used to record information about manually loaded images.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Add a new patch supporting ad-hoc bootflows
boot/bootstd-uclass.c | 44 +++++++++++++++++++++++++++++++++++++++++++
cmd/bootflow.c | 5 +++--
include/bootflow.h | 3 ++-
include/bootstd.h | 19 +++++++++++++++++++
4 files changed, 68 insertions(+), 3 deletions(-)
diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c
index 8c0fd4e63c3..9bee73ead58 100644
--- a/boot/bootstd-uclass.c
+++ b/boot/bootstd-uclass.c
@@ -7,6 +7,8 @@
*/
#include <alist.h>
+#include <blk.h>
+#include <bootdev.h>
#include <bootflow.h>
#include <bootstd.h>
#include <dm.h>
@@ -161,11 +163,53 @@ int bootstd_get_priv(struct bootstd_priv **stdp)
return 0;
}
+int bootstd_img_add(struct blk_desc *desc, int part, const char *fname,
+ enum bootflow_img_t type, ulong addr, ulong size)
+{
+ struct udevice *bootdev = NULL;
+ struct bootstd_priv *std;
+ struct bootflow *bflow, bflow_s;
+ int ret;
+
+ ret = bootstd_get_priv(&std);
+ if (ret)
+ return ret;
+
+ if (desc) {
+ ret = bootdev_get_from_blk(desc->bdev, &bootdev);
+ if (ret)
+ return log_msg_ret("iad", ret);
+ }
+
+ bflow = alist_getw(&std->bootflows, std->adhoc_bflow, struct bootflow);
+ if (!bflow) {
+ bflow = &bflow_s;
+
+ bootflow_init(bflow, bootdev, NULL);
+ bflow->name = strdup("ad-hoc");
+ if (!bflow->name)
+ return log_msg_ret("ian", -ENOMEM);
+ }
+
+ if (!bootflow_img_add(bflow, fname, type, addr, size))
+ return log_msg_ret("iaf", -ENOMEM);
+
+ if (bflow == &bflow_s) {
+ ret = bootstd_add_bootflow(bflow);
+ if (ret < 0)
+ return log_msg_ret("iab", ret);
+ std->adhoc_bflow = ret;
+ }
+
+ return 0;
+}
+
static int bootstd_probe(struct udevice *dev)
{
struct bootstd_priv *std = dev_get_priv(dev);
alist_init_struct(&std->bootflows, struct bootflow);
+ std->adhoc_bflow = -1;
return 0;
}
diff --git a/cmd/bootflow.c b/cmd/bootflow.c
index f88995a478f..5668a0c9b19 100644
--- a/cmd/bootflow.c
+++ b/cmd/bootflow.c
@@ -68,7 +68,8 @@ static void report_bootflow_err(struct bootflow *bflow, int err)
static void show_bootflow(int index, struct bootflow *bflow, bool errors)
{
printf("%3x %-11s %-6s %-9.9s %4x %-25.25s %s\n", index,
- bflow->method->name, bootflow_state_get_name(bflow->state),
+ bflow->method ? bflow->method->name : "(none)",
+ bootflow_state_get_name(bflow->state),
bflow->dev ? dev_get_uclass_name(dev_get_parent(bflow->dev)) :
"(none)", bflow->part, bflow->name, bflow->fname ?: "");
if (errors)
@@ -388,7 +389,7 @@ static int do_bootflow_info(struct cmd_tbl *cmdtp, int flag, int argc,
printf("Name: %s\n", bflow->name);
printf("Device: %s\n", bflow->dev->name);
printf("Block dev: %s\n", bflow->blk ? bflow->blk->name : "(none)");
- printf("Method: %s\n", bflow->method->name);
+ printf("Method: %s\n", bflow->method ? bflow->method->name : "(none)");
printf("State: %s\n", bootflow_state_get_name(bflow->state));
printf("Partition: %d\n", bflow->part);
printf("Subdir: %s\n", bflow->subdir ? bflow->subdir : "(none)");
diff --git a/include/bootflow.h b/include/bootflow.h
index 480cf8a5af1..d9045bc3dae 100644
--- a/include/bootflow.h
+++ b/include/bootflow.h
@@ -68,7 +68,8 @@ enum bootflow_flags_t {
* @fs_type: Filesystem type (FS_TYPE...) if this is fixed by the media, else 0.
* For example, the sandbox host-filesystem bootdev sets this to
* FS_TYPE_SANDBOX
- * @method: Bootmethod device used to perform the boot and read files
+ * @method: Bootmethod device used to perform the boot and read files; NULL for
+ * ad-hoc bootflows
* @name: Name of bootflow (allocated)
* @state: Current state (enum bootflow_state_t)
* @subdir: Subdirectory to fetch files from (with trailing /), or NULL if none
diff --git a/include/bootstd.h b/include/bootstd.h
index 3398e48e88b..c39058c0787 100644
--- a/include/bootstd.h
+++ b/include/bootstd.h
@@ -10,10 +10,12 @@
#define __bootstd_h
#include <alist.h>
+#include <bootflow.h>
#include <dm/ofnode_decl.h>
#include <linux/list.h>
#include <linux/types.h>
+struct blk_desc;
struct udevice;
/**
@@ -33,6 +35,7 @@ struct udevice;
* @cur_bootflow: Currently selected bootflow (for commands)
* @bootflows: (struct bootflow) Global list of all bootflows across all
* bootdevs
+ * @adhoc_bflow: Index of ad-hoc bootflow in bootflows (-1 if none)
* @bootmeth_count: Number of bootmeth devices in @bootmeth_order
* @bootmeth_order: List of bootmeth devices to use, in order, NULL-terminated
* @vbe_bootmeth: Currently selected VBE bootmeth, NULL if none
@@ -47,6 +50,7 @@ struct bootstd_priv {
struct udevice *cur_bootdev;
struct bootflow *cur_bootflow;
struct alist bootflows;
+ int adhoc_bflow;
int bootmeth_count;
struct udevice **bootmeth_order;
struct udevice *vbe_bootmeth;
@@ -151,4 +155,19 @@ int bootstd_add_bootflow(struct bootflow *bflow);
*/
int bootstd_clear_bootflows_for_bootdev(struct udevice *dev);
+/**
+ * bootstd_img_add() - Add an image to the ad-hoc bootflow
+ *
+ * @desc: Block descriptor for the device from which the file was loaded, or
+ * NULL if not a block device
+ * @part: Partition number within the block device
+ * @fname: Filename of loaded file
+ * @type: File type, IH_TYPE_INVALID if not known
+ * @addr: Address where the file was loaded
+ * @size: Size of the file
+ * Return: 0 if OK, or -ve error code
+ */
+int bootstd_img_add(struct blk_desc *desc, int fs_type, const char *fname,
+ enum bootflow_img_t type, ulong addr, ulong size);
+
#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v3 19/19] fs: Record loaded files in an ad-hoc bootflow
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (17 preceding siblings ...)
2024-11-04 17:51 ` [PATCH v3 18/19] bootstd: Add the concept of an ad-hoc bootflow Simon Glass
@ 2024-11-04 17:51 ` Simon Glass
2025-01-15 13:55 ` [PATCH v3 00/19] bootstd: Support recording images Simon Glass
19 siblings, 0 replies; 41+ messages in thread
From: Simon Glass @ 2024-11-04 17:51 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, AKASHI Takahiro, Heinrich Schuchardt,
Ilias Apalodimas, Mattijs Korpershoek, Nam Cao, Quentin Schulz,
Sean Anderson, Sughosh Ganu
This makes a start on dealing with images loaded outside the context of
bootstd. For now, it just records these images. They can be listed using
the 'bootstd images' command.
Often, very little is known about these images, but future work could
perhaps use the filename or contents to detect the type.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v3:
- Add new patch to record loaded files in an ad-hoc bootflow
Changes in v2:
- Drop patches already applied
- Drop patches which add new image types
- Update to use a new image-type enum in bootflow.h
doc/develop/bootstd/overview.rst | 3 +++
fs/fs.c | 15 +++++++++++++++
test/boot/bootflow.c | 20 ++++++++++++++++++++
3 files changed, 38 insertions(+)
diff --git a/doc/develop/bootstd/overview.rst b/doc/develop/bootstd/overview.rst
index e3ce97cc4f5..c46bd7a5a90 100644
--- a/doc/develop/bootstd/overview.rst
+++ b/doc/develop/bootstd/overview.rst
@@ -486,6 +486,9 @@ be visible.
Once a bootflow has been selected, images for those that are not selected can
potentially be dropped from the memory map. For now, this is not implemented.
+In cases where images are loaded outside the context of standard boot, an ad-hoc
+bootflow is used to keep track of these. They is visible with the
+``bootstd images`` command (see :doc:`/usage/cmd/bootstd`).
.. _BootflowStates:
diff --git a/fs/fs.c b/fs/fs.c
index 1afa0fbeaed..d56c95c1b26 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -5,6 +5,7 @@
#define LOG_CATEGORY LOGC_CORE
+#include <bootstd.h>
#include <command.h>
#include <config.h>
#include <display_options.h>
@@ -734,12 +735,14 @@ int do_size(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[],
int do_load(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[],
int fstype)
{
+ struct blk_desc *dev_desc;
unsigned long addr;
const char *addr_str;
const char *filename;
loff_t bytes;
loff_t pos;
loff_t len_read;
+ int dev_part;
int ret;
unsigned long time;
char *ep;
@@ -783,6 +786,10 @@ int do_load(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[],
else
pos = 0;
+ /* save globals before they are cleared */
+ dev_desc = fs_dev_desc;
+ dev_part = fs_dev_part;
+
time = get_timer(0);
ret = _fs_read(filename, addr, pos, bytes, 1, &len_read);
time = get_timer(time);
@@ -806,6 +813,14 @@ int do_load(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[],
env_set_hex("fileaddr", addr);
env_set_hex("filesize", len_read);
+ if (IS_ENABLED(CONFIG_BOOTSTD) &&
+ bootstd_img_add(dev_desc, dev_part, filename,
+ (enum bootflow_img_t)IH_TYPE_INVALID, addr,
+ len_read)) {
+ log_err("Failed to record file\n");
+ return CMD_RET_FAILURE;
+ }
+
return 0;
}
diff --git a/test/boot/bootflow.c b/test/boot/bootflow.c
index 670b9253f61..8b11378a085 100644
--- a/test/boot/bootflow.c
+++ b/test/boot/bootflow.c
@@ -1322,3 +1322,23 @@ static int bootstd_images(struct unit_test_state *uts)
return 0;
}
BOOTSTD_TEST(bootstd_images, UTF_CONSOLE);
+
+/* Check creation of ad-hoc images */
+static int bootstd_adhoc(struct unit_test_state *uts)
+{
+ ut_assertok(run_command("load mmc 1:1 1000 /extlinux/extlinux.conf",
+ 0));
+ ut_assert_nextlinen("595 bytes read");
+ ut_assertok(run_command("bootstd images", 0));
+ ut_assert_nextlinen("Seq");
+ ut_assert_nextlinen("---");
+ ut_assert_nextline(
+ " 0 ad-hoc invalid 1000 253 /extlinux/extlinux.conf");
+ ut_assert_nextlinen("---");
+ ut_assert_nextline("(1 image)");
+
+ ut_assert_console_end();
+
+ return 0;
+}
+BOOTSTD_TEST(bootstd_adhoc, UTF_CONSOLE);
--
2.34.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v3 00/19] bootstd: Support recording images
2024-11-04 17:50 [PATCH v3 00/19] bootstd: Support recording images Simon Glass
` (18 preceding siblings ...)
2024-11-04 17:51 ` [PATCH v3 19/19] fs: Record loaded files in " Simon Glass
@ 2025-01-15 13:55 ` Simon Glass
2025-01-15 21:24 ` Tom Rini
19 siblings, 1 reply; 41+ messages in thread
From: Simon Glass @ 2025-01-15 13:55 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, AKASHI Takahiro, Caleb Connolly, Dragan Simic,
Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Tony Dinh, Vincent Stehlé
Hi,
On Mon, 4 Nov 2024 at 10:51, Simon Glass <sjg@chromium.org> wrote:
>
> This series provides a way to keep track of the images used in bootstd,
> including the type of each image.
>
> At present this is sort-of handled by struct bootflow but in quite an
> ad-hoc way. The structure has become quite large and is hard to query.
> Future work will be able to reduce its size.
>
> Ultimately the 'bootflow info' command may change to also show images as
> a list, but that is left for later, as this series is already fairly
> long. So for now, just introduce the concept and adjust bootstd to use
> it, with a simple command to list the images.
>
> This series includes various alist enhancements, to make use of this new
> data structure a little easier.
>
> Changes in v3:
> - Add a helper in bootflow
> - Add a new patch supporting ad-hoc bootflows
> - Add new patch to export bootdev_get_from_blk()
> - Add new patch to record loaded files in an ad-hoc bootflow
> - Update bootstd_add_bootflow() to return the element number
> - Use the helper function
>
> Changes in v2:
> - Add an image type extension in bootflow.h
> - Change the tag to bootmeth_efi
> - Drop patches already applied
> - Drop patches which add new image types
> - Update to use a new image-type enum in bootflow.h
> - Use the word 'feature' instead of 'hack'
>
> Simon Glass (19):
> bootstd: Move bootflow-adding to bootstd
> bootstd: Move bootflow-clearing to bootstd
> bootstd: Add a function to get bootstd only if available
> bootstd: Drop the bootdev-specific list of bootflows
> bootstd: Move the bootflow list into an alist
> bootstd: Maintain a list of images
> bootstd: Update bootmeth_alloc_file() to record images
> boot: pxe: Drop the duplicate comment on get_pxe_file()
> bootmeth_efi: Simplify reading files by using the common function
> bootmeth: Update the read_file() method to include a type
> bootmeth_efi: Check the filename-allocation in the network path
> boot: Update extlinux pxe_getfile_func() to include type
> boot: Update pxe bootmeth to record images
> Update bootmeth_alloc_other() to record images
> bootstd: Update cros bootmeth to record images
> bootstd: Add a simple command to list images
> bootstd: Export bootdev_get_from_blk()
> bootstd: Add the concept of an ad-hoc bootflow
> fs: Record loaded files in an ad-hoc bootflow
>
> boot/bootdev-uclass.c | 78 ++++++-------------
> boot/bootflow.c | 77 +++++++++++++++----
> boot/bootmeth-uclass.c | 29 +++++--
> boot/bootmeth_android.c | 3 +-
> boot/bootmeth_cros.c | 17 ++++-
> boot/bootmeth_efi.c | 16 ++--
> boot/bootmeth_efi_mgr.c | 3 +-
> boot/bootmeth_extlinux.c | 7 +-
> boot/bootmeth_pxe.c | 10 ++-
> boot/bootmeth_qfw.c | 3 +-
> boot/bootmeth_sandbox.c | 3 +-
> boot/bootmeth_script.c | 7 +-
> boot/bootstd-uclass.c | 104 +++++++++++++++++++++++--
> boot/pxe_utils.c | 36 ++++-----
> boot/vbe_simple.c | 5 +-
> cmd/Kconfig | 9 +++
> cmd/Makefile | 1 +
> cmd/bootdev.c | 2 +-
> cmd/bootflow.c | 11 +--
> cmd/bootstd.c | 65 ++++++++++++++++
> cmd/pxe.c | 2 +-
> cmd/sysboot.c | 6 +-
> doc/develop/bootstd/overview.rst | 24 +++++-
> doc/usage/cmd/bootstd.rst | 79 +++++++++++++++++++
> doc/usage/index.rst | 1 +
> fs/fs.c | 15 ++++
> include/bootdev.h | 36 +++------
> include/bootflow.h | 88 ++++++++++++++++++---
> include/bootmeth.h | 22 ++++--
> include/bootstd.h | 69 ++++++++++++++++-
> include/pxe_utils.h | 14 +++-
> test/boot/bootflow.c | 126 +++++++++++++++++++++++++++++++
> test/py/tests/test_ut.py | 3 +-
> 33 files changed, 788 insertions(+), 183 deletions(-)
> create mode 100644 cmd/bootstd.c
> create mode 100644 doc/usage/cmd/bootstd.rst
>
> --
> 2.34.1
>
patchwork link: https://patchwork.ozlabs.org/project/uboot/list/?series=433068
What is the status of this series please?
Regards,
Simon
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-15 13:55 ` [PATCH v3 00/19] bootstd: Support recording images Simon Glass
@ 2025-01-15 21:24 ` Tom Rini
2025-01-15 23:14 ` Simon Glass
0 siblings, 1 reply; 41+ messages in thread
From: Tom Rini @ 2025-01-15 21:24 UTC (permalink / raw)
To: Simon Glass
Cc: U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Tony Dinh, Vincent Stehlé
[-- Attachment #1: Type: text/plain, Size: 5339 bytes --]
On Wed, Jan 15, 2025 at 06:55:45AM -0700, Simon Glass wrote:
> Hi,
>
> On Mon, 4 Nov 2024 at 10:51, Simon Glass <sjg@chromium.org> wrote:
> >
> > This series provides a way to keep track of the images used in bootstd,
> > including the type of each image.
> >
> > At present this is sort-of handled by struct bootflow but in quite an
> > ad-hoc way. The structure has become quite large and is hard to query.
> > Future work will be able to reduce its size.
> >
> > Ultimately the 'bootflow info' command may change to also show images as
> > a list, but that is left for later, as this series is already fairly
> > long. So for now, just introduce the concept and adjust bootstd to use
> > it, with a simple command to list the images.
> >
> > This series includes various alist enhancements, to make use of this new
> > data structure a little easier.
> >
> > Changes in v3:
> > - Add a helper in bootflow
> > - Add a new patch supporting ad-hoc bootflows
> > - Add new patch to export bootdev_get_from_blk()
> > - Add new patch to record loaded files in an ad-hoc bootflow
> > - Update bootstd_add_bootflow() to return the element number
> > - Use the helper function
> >
> > Changes in v2:
> > - Add an image type extension in bootflow.h
> > - Change the tag to bootmeth_efi
> > - Drop patches already applied
> > - Drop patches which add new image types
> > - Update to use a new image-type enum in bootflow.h
> > - Use the word 'feature' instead of 'hack'
> >
> > Simon Glass (19):
> > bootstd: Move bootflow-adding to bootstd
> > bootstd: Move bootflow-clearing to bootstd
> > bootstd: Add a function to get bootstd only if available
> > bootstd: Drop the bootdev-specific list of bootflows
> > bootstd: Move the bootflow list into an alist
> > bootstd: Maintain a list of images
> > bootstd: Update bootmeth_alloc_file() to record images
> > boot: pxe: Drop the duplicate comment on get_pxe_file()
> > bootmeth_efi: Simplify reading files by using the common function
> > bootmeth: Update the read_file() method to include a type
> > bootmeth_efi: Check the filename-allocation in the network path
> > boot: Update extlinux pxe_getfile_func() to include type
> > boot: Update pxe bootmeth to record images
> > Update bootmeth_alloc_other() to record images
> > bootstd: Update cros bootmeth to record images
> > bootstd: Add a simple command to list images
> > bootstd: Export bootdev_get_from_blk()
> > bootstd: Add the concept of an ad-hoc bootflow
> > fs: Record loaded files in an ad-hoc bootflow
> >
> > boot/bootdev-uclass.c | 78 ++++++-------------
> > boot/bootflow.c | 77 +++++++++++++++----
> > boot/bootmeth-uclass.c | 29 +++++--
> > boot/bootmeth_android.c | 3 +-
> > boot/bootmeth_cros.c | 17 ++++-
> > boot/bootmeth_efi.c | 16 ++--
> > boot/bootmeth_efi_mgr.c | 3 +-
> > boot/bootmeth_extlinux.c | 7 +-
> > boot/bootmeth_pxe.c | 10 ++-
> > boot/bootmeth_qfw.c | 3 +-
> > boot/bootmeth_sandbox.c | 3 +-
> > boot/bootmeth_script.c | 7 +-
> > boot/bootstd-uclass.c | 104 +++++++++++++++++++++++--
> > boot/pxe_utils.c | 36 ++++-----
> > boot/vbe_simple.c | 5 +-
> > cmd/Kconfig | 9 +++
> > cmd/Makefile | 1 +
> > cmd/bootdev.c | 2 +-
> > cmd/bootflow.c | 11 +--
> > cmd/bootstd.c | 65 ++++++++++++++++
> > cmd/pxe.c | 2 +-
> > cmd/sysboot.c | 6 +-
> > doc/develop/bootstd/overview.rst | 24 +++++-
> > doc/usage/cmd/bootstd.rst | 79 +++++++++++++++++++
> > doc/usage/index.rst | 1 +
> > fs/fs.c | 15 ++++
> > include/bootdev.h | 36 +++------
> > include/bootflow.h | 88 ++++++++++++++++++---
> > include/bootmeth.h | 22 ++++--
> > include/bootstd.h | 69 ++++++++++++++++-
> > include/pxe_utils.h | 14 +++-
> > test/boot/bootflow.c | 126 +++++++++++++++++++++++++++++++
> > test/py/tests/test_ut.py | 3 +-
> > 33 files changed, 788 insertions(+), 183 deletions(-)
> > create mode 100644 cmd/bootstd.c
> > create mode 100644 doc/usage/cmd/bootstd.rst
> >
> > --
> > 2.34.1
> >
>
> patchwork link: https://patchwork.ozlabs.org/project/uboot/list/?series=433068
>
> What is the status of this series please?
So, for v4 of this series, most arm64 platforms grow by ~1KiB (a few are
2, a few are a bit less than 1). 32bit ARM is similar but now mx6sabresd
doesn't build in CI (there's some embedded path names that now overflow,
try make O=/tmp/1/2/3/4/5/6/7/8/9/10/mx6sabresd mx6sabresd_config all).
For size changes, really most architectures are like that, so perhaps
it's worth stepping back again and asking where this should be default
enabled. For the mx6sabresd part, if we drop the recording for ad-hoc
(which I think you had suggested at some point since I wasn't sure about
that direction), everything builds at least.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-15 21:24 ` Tom Rini
@ 2025-01-15 23:14 ` Simon Glass
2025-01-15 23:31 ` Tom Rini
0 siblings, 1 reply; 41+ messages in thread
From: Simon Glass @ 2025-01-15 23:14 UTC (permalink / raw)
To: Tom Rini
Cc: U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Tony Dinh, Vincent Stehlé
Hi Tom,
On Wed, 15 Jan 2025 at 14:24, Tom Rini <trini@konsulko.com> wrote:
>
> On Wed, Jan 15, 2025 at 06:55:45AM -0700, Simon Glass wrote:
> > Hi,
> >
> > On Mon, 4 Nov 2024 at 10:51, Simon Glass <sjg@chromium.org> wrote:
> > >
> > > This series provides a way to keep track of the images used in bootstd,
> > > including the type of each image.
> > >
> > > At present this is sort-of handled by struct bootflow but in quite an
> > > ad-hoc way. The structure has become quite large and is hard to query.
> > > Future work will be able to reduce its size.
> > >
> > > Ultimately the 'bootflow info' command may change to also show images as
> > > a list, but that is left for later, as this series is already fairly
> > > long. So for now, just introduce the concept and adjust bootstd to use
> > > it, with a simple command to list the images.
> > >
> > > This series includes various alist enhancements, to make use of this new
> > > data structure a little easier.
> > >
> > > Changes in v3:
> > > - Add a helper in bootflow
> > > - Add a new patch supporting ad-hoc bootflows
> > > - Add new patch to export bootdev_get_from_blk()
> > > - Add new patch to record loaded files in an ad-hoc bootflow
> > > - Update bootstd_add_bootflow() to return the element number
> > > - Use the helper function
> > >
> > > Changes in v2:
> > > - Add an image type extension in bootflow.h
> > > - Change the tag to bootmeth_efi
> > > - Drop patches already applied
> > > - Drop patches which add new image types
> > > - Update to use a new image-type enum in bootflow.h
> > > - Use the word 'feature' instead of 'hack'
> > >
> > > Simon Glass (19):
> > > bootstd: Move bootflow-adding to bootstd
> > > bootstd: Move bootflow-clearing to bootstd
> > > bootstd: Add a function to get bootstd only if available
> > > bootstd: Drop the bootdev-specific list of bootflows
> > > bootstd: Move the bootflow list into an alist
> > > bootstd: Maintain a list of images
> > > bootstd: Update bootmeth_alloc_file() to record images
> > > boot: pxe: Drop the duplicate comment on get_pxe_file()
> > > bootmeth_efi: Simplify reading files by using the common function
> > > bootmeth: Update the read_file() method to include a type
> > > bootmeth_efi: Check the filename-allocation in the network path
> > > boot: Update extlinux pxe_getfile_func() to include type
> > > boot: Update pxe bootmeth to record images
> > > Update bootmeth_alloc_other() to record images
> > > bootstd: Update cros bootmeth to record images
> > > bootstd: Add a simple command to list images
> > > bootstd: Export bootdev_get_from_blk()
> > > bootstd: Add the concept of an ad-hoc bootflow
> > > fs: Record loaded files in an ad-hoc bootflow
> > >
> > > boot/bootdev-uclass.c | 78 ++++++-------------
> > > boot/bootflow.c | 77 +++++++++++++++----
> > > boot/bootmeth-uclass.c | 29 +++++--
> > > boot/bootmeth_android.c | 3 +-
> > > boot/bootmeth_cros.c | 17 ++++-
> > > boot/bootmeth_efi.c | 16 ++--
> > > boot/bootmeth_efi_mgr.c | 3 +-
> > > boot/bootmeth_extlinux.c | 7 +-
> > > boot/bootmeth_pxe.c | 10 ++-
> > > boot/bootmeth_qfw.c | 3 +-
> > > boot/bootmeth_sandbox.c | 3 +-
> > > boot/bootmeth_script.c | 7 +-
> > > boot/bootstd-uclass.c | 104 +++++++++++++++++++++++--
> > > boot/pxe_utils.c | 36 ++++-----
> > > boot/vbe_simple.c | 5 +-
> > > cmd/Kconfig | 9 +++
> > > cmd/Makefile | 1 +
> > > cmd/bootdev.c | 2 +-
> > > cmd/bootflow.c | 11 +--
> > > cmd/bootstd.c | 65 ++++++++++++++++
> > > cmd/pxe.c | 2 +-
> > > cmd/sysboot.c | 6 +-
> > > doc/develop/bootstd/overview.rst | 24 +++++-
> > > doc/usage/cmd/bootstd.rst | 79 +++++++++++++++++++
> > > doc/usage/index.rst | 1 +
> > > fs/fs.c | 15 ++++
> > > include/bootdev.h | 36 +++------
> > > include/bootflow.h | 88 ++++++++++++++++++---
> > > include/bootmeth.h | 22 ++++--
> > > include/bootstd.h | 69 ++++++++++++++++-
> > > include/pxe_utils.h | 14 +++-
> > > test/boot/bootflow.c | 126 +++++++++++++++++++++++++++++++
> > > test/py/tests/test_ut.py | 3 +-
> > > 33 files changed, 788 insertions(+), 183 deletions(-)
> > > create mode 100644 cmd/bootstd.c
> > > create mode 100644 doc/usage/cmd/bootstd.rst
> > >
> > > --
> > > 2.34.1
> > >
> >
> > patchwork link: https://patchwork.ozlabs.org/project/uboot/list/?series=433068
> >
> > What is the status of this series please?
>
> So, for v4 of this series, most arm64 platforms grow by ~1KiB (a few are
> 2, a few are a bit less than 1). 32bit ARM is similar but now mx6sabresd
> doesn't build in CI (there's some embedded path names that now overflow,
> try make O=/tmp/1/2/3/4/5/6/7/8/9/10/mx6sabresd mx6sabresd_config all).
> For size changes, really most architectures are like that, so perhaps
> it's worth stepping back again and asking where this should be default
> enabled. For the mx6sabresd part, if we drop the recording for ad-hoc
> (which I think you had suggested at some point since I wasn't sure about
> that direction), everything builds at least.
Thanks for looking at it. So what do you think about dropping those
last two patches and applying the rest? The increase is about 416
bytes on pinecube (Thumb2). Quite a bit of this seems to be bringing
alist which is something of a one-off hit:
alist_ensure_ptr - 64 +64
alist_calc_index - 32 +32
alist_add_ptr - 26 +26
alist_update_end - 18 +18
alist_empty - 6 +6
alist_add_placeholder - 6 +6
Then I can use the final two patches as the start of the series to
finish off ad-hoc images.
As to default-enabled, moving bootflow to an alist isn't really
something we can disable.
Regards,
Simon
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-15 23:14 ` Simon Glass
@ 2025-01-15 23:31 ` Tom Rini
2025-01-16 15:52 ` Simon Glass
0 siblings, 1 reply; 41+ messages in thread
From: Tom Rini @ 2025-01-15 23:31 UTC (permalink / raw)
To: Simon Glass
Cc: U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Tony Dinh, Vincent Stehlé
[-- Attachment #1: Type: text/plain, Size: 7197 bytes --]
On Wed, Jan 15, 2025 at 04:14:27PM -0700, Simon Glass wrote:
> Hi Tom,
>
> On Wed, 15 Jan 2025 at 14:24, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Wed, Jan 15, 2025 at 06:55:45AM -0700, Simon Glass wrote:
> > > Hi,
> > >
> > > On Mon, 4 Nov 2024 at 10:51, Simon Glass <sjg@chromium.org> wrote:
> > > >
> > > > This series provides a way to keep track of the images used in bootstd,
> > > > including the type of each image.
> > > >
> > > > At present this is sort-of handled by struct bootflow but in quite an
> > > > ad-hoc way. The structure has become quite large and is hard to query.
> > > > Future work will be able to reduce its size.
> > > >
> > > > Ultimately the 'bootflow info' command may change to also show images as
> > > > a list, but that is left for later, as this series is already fairly
> > > > long. So for now, just introduce the concept and adjust bootstd to use
> > > > it, with a simple command to list the images.
> > > >
> > > > This series includes various alist enhancements, to make use of this new
> > > > data structure a little easier.
> > > >
> > > > Changes in v3:
> > > > - Add a helper in bootflow
> > > > - Add a new patch supporting ad-hoc bootflows
> > > > - Add new patch to export bootdev_get_from_blk()
> > > > - Add new patch to record loaded files in an ad-hoc bootflow
> > > > - Update bootstd_add_bootflow() to return the element number
> > > > - Use the helper function
> > > >
> > > > Changes in v2:
> > > > - Add an image type extension in bootflow.h
> > > > - Change the tag to bootmeth_efi
> > > > - Drop patches already applied
> > > > - Drop patches which add new image types
> > > > - Update to use a new image-type enum in bootflow.h
> > > > - Use the word 'feature' instead of 'hack'
> > > >
> > > > Simon Glass (19):
> > > > bootstd: Move bootflow-adding to bootstd
> > > > bootstd: Move bootflow-clearing to bootstd
> > > > bootstd: Add a function to get bootstd only if available
> > > > bootstd: Drop the bootdev-specific list of bootflows
> > > > bootstd: Move the bootflow list into an alist
> > > > bootstd: Maintain a list of images
> > > > bootstd: Update bootmeth_alloc_file() to record images
> > > > boot: pxe: Drop the duplicate comment on get_pxe_file()
> > > > bootmeth_efi: Simplify reading files by using the common function
> > > > bootmeth: Update the read_file() method to include a type
> > > > bootmeth_efi: Check the filename-allocation in the network path
> > > > boot: Update extlinux pxe_getfile_func() to include type
> > > > boot: Update pxe bootmeth to record images
> > > > Update bootmeth_alloc_other() to record images
> > > > bootstd: Update cros bootmeth to record images
> > > > bootstd: Add a simple command to list images
> > > > bootstd: Export bootdev_get_from_blk()
> > > > bootstd: Add the concept of an ad-hoc bootflow
> > > > fs: Record loaded files in an ad-hoc bootflow
> > > >
> > > > boot/bootdev-uclass.c | 78 ++++++-------------
> > > > boot/bootflow.c | 77 +++++++++++++++----
> > > > boot/bootmeth-uclass.c | 29 +++++--
> > > > boot/bootmeth_android.c | 3 +-
> > > > boot/bootmeth_cros.c | 17 ++++-
> > > > boot/bootmeth_efi.c | 16 ++--
> > > > boot/bootmeth_efi_mgr.c | 3 +-
> > > > boot/bootmeth_extlinux.c | 7 +-
> > > > boot/bootmeth_pxe.c | 10 ++-
> > > > boot/bootmeth_qfw.c | 3 +-
> > > > boot/bootmeth_sandbox.c | 3 +-
> > > > boot/bootmeth_script.c | 7 +-
> > > > boot/bootstd-uclass.c | 104 +++++++++++++++++++++++--
> > > > boot/pxe_utils.c | 36 ++++-----
> > > > boot/vbe_simple.c | 5 +-
> > > > cmd/Kconfig | 9 +++
> > > > cmd/Makefile | 1 +
> > > > cmd/bootdev.c | 2 +-
> > > > cmd/bootflow.c | 11 +--
> > > > cmd/bootstd.c | 65 ++++++++++++++++
> > > > cmd/pxe.c | 2 +-
> > > > cmd/sysboot.c | 6 +-
> > > > doc/develop/bootstd/overview.rst | 24 +++++-
> > > > doc/usage/cmd/bootstd.rst | 79 +++++++++++++++++++
> > > > doc/usage/index.rst | 1 +
> > > > fs/fs.c | 15 ++++
> > > > include/bootdev.h | 36 +++------
> > > > include/bootflow.h | 88 ++++++++++++++++++---
> > > > include/bootmeth.h | 22 ++++--
> > > > include/bootstd.h | 69 ++++++++++++++++-
> > > > include/pxe_utils.h | 14 +++-
> > > > test/boot/bootflow.c | 126 +++++++++++++++++++++++++++++++
> > > > test/py/tests/test_ut.py | 3 +-
> > > > 33 files changed, 788 insertions(+), 183 deletions(-)
> > > > create mode 100644 cmd/bootstd.c
> > > > create mode 100644 doc/usage/cmd/bootstd.rst
> > > >
> > > > --
> > > > 2.34.1
> > > >
> > >
> > > patchwork link: https://patchwork.ozlabs.org/project/uboot/list/?series=433068
> > >
> > > What is the status of this series please?
> >
> > So, for v4 of this series, most arm64 platforms grow by ~1KiB (a few are
> > 2, a few are a bit less than 1). 32bit ARM is similar but now mx6sabresd
> > doesn't build in CI (there's some embedded path names that now overflow,
> > try make O=/tmp/1/2/3/4/5/6/7/8/9/10/mx6sabresd mx6sabresd_config all).
> > For size changes, really most architectures are like that, so perhaps
> > it's worth stepping back again and asking where this should be default
> > enabled. For the mx6sabresd part, if we drop the recording for ad-hoc
> > (which I think you had suggested at some point since I wasn't sure about
> > that direction), everything builds at least.
>
> Thanks for looking at it. So what do you think about dropping those
> last two patches and applying the rest? The increase is about 416
> bytes on pinecube (Thumb2). Quite a bit of this seems to be bringing
> alist which is something of a one-off hit:
>
> alist_ensure_ptr - 64 +64
> alist_calc_index - 32 +32
> alist_add_ptr - 26 +26
> alist_update_end - 18 +18
> alist_empty - 6 +6
> alist_add_placeholder - 6 +6
>
> Then I can use the final two patches as the start of the series to
> finish off ad-hoc images.
I was thinking just patch #20, but we can drop 19 and 20 instead, sure.
> As to default-enabled, moving bootflow to an alist isn't really
> something we can disable.
I'm referring to the whole bootmeth/bootflow/etc thing. Is this going to
be put to use by anyone / anywhere on PowerPC? M68K? MIPS? 32bit ARM is
a harder question there, which is also where this particular overflow
was.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-15 23:31 ` Tom Rini
@ 2025-01-16 15:52 ` Simon Glass
2025-01-16 17:21 ` Tom Rini
0 siblings, 1 reply; 41+ messages in thread
From: Simon Glass @ 2025-01-16 15:52 UTC (permalink / raw)
To: Tom Rini
Cc: U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Tony Dinh, Vincent Stehlé
Hi Tom,
On Wed, 15 Jan 2025 at 16:32, Tom Rini <trini@konsulko.com> wrote:
>
> On Wed, Jan 15, 2025 at 04:14:27PM -0700, Simon Glass wrote:
> > Hi Tom,
> >
> > On Wed, 15 Jan 2025 at 14:24, Tom Rini <trini@konsulko.com> wrote:
> > >
> > > On Wed, Jan 15, 2025 at 06:55:45AM -0700, Simon Glass wrote:
> > > > Hi,
> > > >
> > > > On Mon, 4 Nov 2024 at 10:51, Simon Glass <sjg@chromium.org> wrote:
> > > > >
> > > > > This series provides a way to keep track of the images used in bootstd,
> > > > > including the type of each image.
> > > > >
> > > > > At present this is sort-of handled by struct bootflow but in quite an
> > > > > ad-hoc way. The structure has become quite large and is hard to query.
> > > > > Future work will be able to reduce its size.
> > > > >
> > > > > Ultimately the 'bootflow info' command may change to also show images as
> > > > > a list, but that is left for later, as this series is already fairly
> > > > > long. So for now, just introduce the concept and adjust bootstd to use
> > > > > it, with a simple command to list the images.
> > > > >
> > > > > This series includes various alist enhancements, to make use of this new
> > > > > data structure a little easier.
> > > > >
> > > > > Changes in v3:
> > > > > - Add a helper in bootflow
> > > > > - Add a new patch supporting ad-hoc bootflows
> > > > > - Add new patch to export bootdev_get_from_blk()
> > > > > - Add new patch to record loaded files in an ad-hoc bootflow
> > > > > - Update bootstd_add_bootflow() to return the element number
> > > > > - Use the helper function
> > > > >
> > > > > Changes in v2:
> > > > > - Add an image type extension in bootflow.h
> > > > > - Change the tag to bootmeth_efi
> > > > > - Drop patches already applied
> > > > > - Drop patches which add new image types
> > > > > - Update to use a new image-type enum in bootflow.h
> > > > > - Use the word 'feature' instead of 'hack'
> > > > >
> > > > > Simon Glass (19):
> > > > > bootstd: Move bootflow-adding to bootstd
> > > > > bootstd: Move bootflow-clearing to bootstd
> > > > > bootstd: Add a function to get bootstd only if available
> > > > > bootstd: Drop the bootdev-specific list of bootflows
> > > > > bootstd: Move the bootflow list into an alist
> > > > > bootstd: Maintain a list of images
> > > > > bootstd: Update bootmeth_alloc_file() to record images
> > > > > boot: pxe: Drop the duplicate comment on get_pxe_file()
> > > > > bootmeth_efi: Simplify reading files by using the common function
> > > > > bootmeth: Update the read_file() method to include a type
> > > > > bootmeth_efi: Check the filename-allocation in the network path
> > > > > boot: Update extlinux pxe_getfile_func() to include type
> > > > > boot: Update pxe bootmeth to record images
> > > > > Update bootmeth_alloc_other() to record images
> > > > > bootstd: Update cros bootmeth to record images
> > > > > bootstd: Add a simple command to list images
> > > > > bootstd: Export bootdev_get_from_blk()
> > > > > bootstd: Add the concept of an ad-hoc bootflow
> > > > > fs: Record loaded files in an ad-hoc bootflow
> > > > >
> > > > > boot/bootdev-uclass.c | 78 ++++++-------------
> > > > > boot/bootflow.c | 77 +++++++++++++++----
> > > > > boot/bootmeth-uclass.c | 29 +++++--
> > > > > boot/bootmeth_android.c | 3 +-
> > > > > boot/bootmeth_cros.c | 17 ++++-
> > > > > boot/bootmeth_efi.c | 16 ++--
> > > > > boot/bootmeth_efi_mgr.c | 3 +-
> > > > > boot/bootmeth_extlinux.c | 7 +-
> > > > > boot/bootmeth_pxe.c | 10 ++-
> > > > > boot/bootmeth_qfw.c | 3 +-
> > > > > boot/bootmeth_sandbox.c | 3 +-
> > > > > boot/bootmeth_script.c | 7 +-
> > > > > boot/bootstd-uclass.c | 104 +++++++++++++++++++++++--
> > > > > boot/pxe_utils.c | 36 ++++-----
> > > > > boot/vbe_simple.c | 5 +-
> > > > > cmd/Kconfig | 9 +++
> > > > > cmd/Makefile | 1 +
> > > > > cmd/bootdev.c | 2 +-
> > > > > cmd/bootflow.c | 11 +--
> > > > > cmd/bootstd.c | 65 ++++++++++++++++
> > > > > cmd/pxe.c | 2 +-
> > > > > cmd/sysboot.c | 6 +-
> > > > > doc/develop/bootstd/overview.rst | 24 +++++-
> > > > > doc/usage/cmd/bootstd.rst | 79 +++++++++++++++++++
> > > > > doc/usage/index.rst | 1 +
> > > > > fs/fs.c | 15 ++++
> > > > > include/bootdev.h | 36 +++------
> > > > > include/bootflow.h | 88 ++++++++++++++++++---
> > > > > include/bootmeth.h | 22 ++++--
> > > > > include/bootstd.h | 69 ++++++++++++++++-
> > > > > include/pxe_utils.h | 14 +++-
> > > > > test/boot/bootflow.c | 126 +++++++++++++++++++++++++++++++
> > > > > test/py/tests/test_ut.py | 3 +-
> > > > > 33 files changed, 788 insertions(+), 183 deletions(-)
> > > > > create mode 100644 cmd/bootstd.c
> > > > > create mode 100644 doc/usage/cmd/bootstd.rst
> > > > >
> > > > > --
> > > > > 2.34.1
> > > > >
> > > >
> > > > patchwork link: https://patchwork.ozlabs.org/project/uboot/list/?series=433068
> > > >
> > > > What is the status of this series please?
> > >
> > > So, for v4 of this series, most arm64 platforms grow by ~1KiB (a few are
> > > 2, a few are a bit less than 1). 32bit ARM is similar but now mx6sabresd
> > > doesn't build in CI (there's some embedded path names that now overflow,
> > > try make O=/tmp/1/2/3/4/5/6/7/8/9/10/mx6sabresd mx6sabresd_config all).
> > > For size changes, really most architectures are like that, so perhaps
> > > it's worth stepping back again and asking where this should be default
> > > enabled. For the mx6sabresd part, if we drop the recording for ad-hoc
> > > (which I think you had suggested at some point since I wasn't sure about
> > > that direction), everything builds at least.
> >
> > Thanks for looking at it. So what do you think about dropping those
> > last two patches and applying the rest? The increase is about 416
> > bytes on pinecube (Thumb2). Quite a bit of this seems to be bringing
> > alist which is something of a one-off hit:
> >
> > alist_ensure_ptr - 64 +64
> > alist_calc_index - 32 +32
> > alist_add_ptr - 26 +26
> > alist_update_end - 18 +18
> > alist_empty - 6 +6
> > alist_add_placeholder - 6 +6
> >
> > Then I can use the final two patches as the start of the series to
> > finish off ad-hoc images.
>
> I was thinking just patch #20, but we can drop 19 and 20 instead, sure.
May as well.
>
> > As to default-enabled, moving bootflow to an alist isn't really
> > something we can disable.
>
> I'm referring to the whole bootmeth/bootflow/etc thing. Is this going to
> be put to use by anyone / anywhere on PowerPC? M68K? MIPS? 32bit ARM is
> a harder question there, which is also where this particular overflow
> was.
I'm still not sure what you are saying. Are you wanting to disable
bootstd by default / go back to distro scripts / force everyone to use
EFI_LOADER / ?
Regards,
Simon
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-16 15:52 ` Simon Glass
@ 2025-01-16 17:21 ` Tom Rini
2025-01-18 4:32 ` Simon Glass
0 siblings, 1 reply; 41+ messages in thread
From: Tom Rini @ 2025-01-16 17:21 UTC (permalink / raw)
To: Simon Glass
Cc: U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Tony Dinh, Vincent Stehlé
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
On Thu, Jan 16, 2025 at 08:52:38AM -0700, Simon Glass wrote:
> Hi Tom,
>
> On Wed, 15 Jan 2025 at 16:32, Tom Rini <trini@konsulko.com> wrote:
[snip]
> > I'm referring to the whole bootmeth/bootflow/etc thing. Is this going to
> > be put to use by anyone / anywhere on PowerPC? M68K? MIPS? 32bit ARM is
> > a harder question there, which is also where this particular overflow
> > was.
>
> I'm still not sure what you are saying. Are you wanting to disable
> bootstd by default / go back to distro scripts / force everyone to use
> EFI_LOADER / ?
Yes, I'm asking where it's appropriate to enable this new functionality
by default. It certainly should be enabled on arm64 (there's new
designs) and riscv (there's new designs). It still ought to be enabled
on arm32 because we otherwise lack a easy way to say "new" arm32 (say
i.MX7) and not "old" arm32 (say i.MX23). What is the point of enabling
this on PowerPC for example? The active users there are (generally)
supporting legacy hardware and I have no idea how much they want to
change their boot process, once bootstd supports flash for example.
There's similar questions for everything else under arch/ as well.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-16 17:21 ` Tom Rini
@ 2025-01-18 4:32 ` Simon Glass
2025-01-18 5:49 ` Tony Dinh
0 siblings, 1 reply; 41+ messages in thread
From: Simon Glass @ 2025-01-18 4:32 UTC (permalink / raw)
To: Tom Rini
Cc: U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Tony Dinh, Vincent Stehlé
Hi Tom,
On Thu, 16 Jan 2025 at 10:22, Tom Rini <trini@konsulko.com> wrote:
>
> On Thu, Jan 16, 2025 at 08:52:38AM -0700, Simon Glass wrote:
> > Hi Tom,
> >
> > On Wed, 15 Jan 2025 at 16:32, Tom Rini <trini@konsulko.com> wrote:
> [snip]
> > > I'm referring to the whole bootmeth/bootflow/etc thing. Is this going
to
> > > be put to use by anyone / anywhere on PowerPC? M68K? MIPS? 32bit ARM
is
> > > a harder question there, which is also where this particular overflow
> > > was.
> >
> > I'm still not sure what you are saying. Are you wanting to disable
> > bootstd by default / go back to distro scripts / force everyone to use
> > EFI_LOADER / ?
>
> Yes, I'm asking where it's appropriate to enable this new functionality
> by default. It certainly should be enabled on arm64 (there's new
> designs) and riscv (there's new designs). It still ought to be enabled
> on arm32 because we otherwise lack a easy way to say "new" arm32 (say
> i.MX7) and not "old" arm32 (say i.MX23). What is the point of enabling
> this on PowerPC for example? The active users there are (generally)
> supporting legacy hardware and I have no idea how much they want to
> change their boot process, once bootstd supports flash for example.
> There's similar questions for everything else under arch/ as well.
To me this is in fact two different questions.
1. For PowerPC, m68k, MIPS, I suppose we can just disable BOOTSTD and wait
for them to go away, if you are saying that they are behind on migrations
will never catch up
2. As to the default, I believe BOOTSTD should be on by default, if we
intend to remove the distro scripts and support things that are not EFI
Regards,
Simon
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-18 4:32 ` Simon Glass
@ 2025-01-18 5:49 ` Tony Dinh
2025-01-18 14:41 ` Tom Rini
0 siblings, 1 reply; 41+ messages in thread
From: Tony Dinh @ 2025-01-18 5:49 UTC (permalink / raw)
To: Simon Glass
Cc: Tom Rini, U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Vincent Stehlé
On Fri, Jan 17, 2025 at 8:32 PM Simon Glass <sjg@chromium.org> wrote:
>
> Hi Tom,
>
> On Thu, 16 Jan 2025 at 10:22, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Thu, Jan 16, 2025 at 08:52:38AM -0700, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Wed, 15 Jan 2025 at 16:32, Tom Rini <trini@konsulko.com> wrote:
> > [snip]
> > > > I'm referring to the whole bootmeth/bootflow/etc thing. Is this going to
> > > > be put to use by anyone / anywhere on PowerPC? M68K? MIPS? 32bit ARM is
> > > > a harder question there, which is also where this particular overflow
> > > > was.
> > >
> > > I'm still not sure what you are saying. Are you wanting to disable
> > > bootstd by default / go back to distro scripts / force everyone to use
> > > EFI_LOADER / ?
> >
> > Yes, I'm asking where it's appropriate to enable this new functionality
> > by default. It certainly should be enabled on arm64 (there's new
> > designs) and riscv (there's new designs). It still ought to be enabled
> > on arm32 because we otherwise lack a easy way to say "new" arm32 (say
> > i.MX7) and not "old" arm32 (say i.MX23). What is the point of enabling
> > this on PowerPC for example? The active users there are (generally)
> > supporting legacy hardware and I have no idea how much they want to
> > change their boot process, once bootstd supports flash for example.
> > There's similar questions for everything else under arch/ as well.
>
> To me this is in fact two different questions.
>
> 1. For PowerPC, m68k, MIPS, I suppose we can just disable BOOTSTD and wait for them to go away, if you are saying that they are behind on migrations will never catch up
>
> 2. As to the default, I believe BOOTSTD should be on by default, if we intend to remove the distro scripts and support things that are not EFI
I'd agree with Simon on 2. Boards that have never been upgraded to
distro boot or standard boot usually have an internal envs script in
include/configs/xxx.h that boots the board the legacy way. Even if
bootstd is enabled by default, it won't hurt those.
All the best ,
Tony
>
> Regards,
> Simon
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-18 5:49 ` Tony Dinh
@ 2025-01-18 14:41 ` Tom Rini
2025-01-18 19:26 ` Tony Dinh
2025-01-23 14:38 ` Simon Glass
0 siblings, 2 replies; 41+ messages in thread
From: Tom Rini @ 2025-01-18 14:41 UTC (permalink / raw)
To: Tony Dinh
Cc: Simon Glass, U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Vincent Stehlé
[-- Attachment #1: Type: text/plain, Size: 2813 bytes --]
On Fri, Jan 17, 2025 at 09:49:43PM -0800, Tony Dinh wrote:
> On Fri, Jan 17, 2025 at 8:32 PM Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi Tom,
> >
> > On Thu, 16 Jan 2025 at 10:22, Tom Rini <trini@konsulko.com> wrote:
> > >
> > > On Thu, Jan 16, 2025 at 08:52:38AM -0700, Simon Glass wrote:
> > > > Hi Tom,
> > > >
> > > > On Wed, 15 Jan 2025 at 16:32, Tom Rini <trini@konsulko.com> wrote:
> > > [snip]
> > > > > I'm referring to the whole bootmeth/bootflow/etc thing. Is this going to
> > > > > be put to use by anyone / anywhere on PowerPC? M68K? MIPS? 32bit ARM is
> > > > > a harder question there, which is also where this particular overflow
> > > > > was.
> > > >
> > > > I'm still not sure what you are saying. Are you wanting to disable
> > > > bootstd by default / go back to distro scripts / force everyone to use
> > > > EFI_LOADER / ?
> > >
> > > Yes, I'm asking where it's appropriate to enable this new functionality
> > > by default. It certainly should be enabled on arm64 (there's new
> > > designs) and riscv (there's new designs). It still ought to be enabled
> > > on arm32 because we otherwise lack a easy way to say "new" arm32 (say
> > > i.MX7) and not "old" arm32 (say i.MX23). What is the point of enabling
> > > this on PowerPC for example? The active users there are (generally)
> > > supporting legacy hardware and I have no idea how much they want to
> > > change their boot process, once bootstd supports flash for example.
> > > There's similar questions for everything else under arch/ as well.
> >
> > To me this is in fact two different questions.
> >
> > 1. For PowerPC, m68k, MIPS, I suppose we can just disable BOOTSTD and wait for them to go away, if you are saying that they are behind on migrations will never catch up
On what migrations? A board that has a boot command is not some legacy
non-migrated case. That's a valid regular use case.
But yes, I'm suggesting we should put some default y if ... logic around
BOOTSTD.
> > 2. As to the default, I believe BOOTSTD should be on by default, if we intend to remove the distro scripts and support things that are not EFI
In case you missed it, EFI_LOADER is default for some ARM32, ARM64, X86,
RISC-V and sandbox. None of those are cases where I'm suggesting BOOTSTD
shouldn't be default.
> I'd agree with Simon on 2. Boards that have never been upgraded to
> distro boot or standard boot usually have an internal envs script in
> include/configs/xxx.h that boots the board the legacy way. Even if
> bootstd is enabled by default, it won't hurt those.
It hurts them because of the strong likelyhood that they do have
practical image size limitations (before they would then be leaking in
to U-Boot environment or some other part of flash).
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-18 14:41 ` Tom Rini
@ 2025-01-18 19:26 ` Tony Dinh
2025-01-23 14:38 ` Simon Glass
1 sibling, 0 replies; 41+ messages in thread
From: Tony Dinh @ 2025-01-18 19:26 UTC (permalink / raw)
To: Tom Rini
Cc: Simon Glass, U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Vincent Stehlé
Hi Tom,
On Sat, Jan 18, 2025 at 6:41 AM Tom Rini <trini@konsulko.com> wrote:
>
> On Fri, Jan 17, 2025 at 09:49:43PM -0800, Tony Dinh wrote:
> > On Fri, Jan 17, 2025 at 8:32 PM Simon Glass <sjg@chromium.org> wrote:
> > >
> > > Hi Tom,
> > >
> > > On Thu, 16 Jan 2025 at 10:22, Tom Rini <trini@konsulko.com> wrote:
> > > >
> > > > On Thu, Jan 16, 2025 at 08:52:38AM -0700, Simon Glass wrote:
> > > > > Hi Tom,
> > > > >
> > > > > On Wed, 15 Jan 2025 at 16:32, Tom Rini <trini@konsulko.com> wrote:
> > > > [snip]
> > > > > > I'm referring to the whole bootmeth/bootflow/etc thing. Is this going to
> > > > > > be put to use by anyone / anywhere on PowerPC? M68K? MIPS? 32bit ARM is
> > > > > > a harder question there, which is also where this particular overflow
> > > > > > was.
> > > > >
> > > > > I'm still not sure what you are saying. Are you wanting to disable
> > > > > bootstd by default / go back to distro scripts / force everyone to use
> > > > > EFI_LOADER / ?
> > > >
> > > > Yes, I'm asking where it's appropriate to enable this new functionality
> > > > by default. It certainly should be enabled on arm64 (there's new
> > > > designs) and riscv (there's new designs). It still ought to be enabled
> > > > on arm32 because we otherwise lack a easy way to say "new" arm32 (say
> > > > i.MX7) and not "old" arm32 (say i.MX23). What is the point of enabling
> > > > this on PowerPC for example? The active users there are (generally)
> > > > supporting legacy hardware and I have no idea how much they want to
> > > > change their boot process, once bootstd supports flash for example.
> > > > There's similar questions for everything else under arch/ as well.
> > >
> > > To me this is in fact two different questions.
> > >
> > > 1. For PowerPC, m68k, MIPS, I suppose we can just disable BOOTSTD and wait for them to go away, if you are saying that they are behind on migrations will never catch up
>
> On what migrations? A board that has a boot command is not some legacy
> non-migrated case. That's a valid regular use case.
>
> But yes, I'm suggesting we should put some default y if ... logic around
> BOOTSTD.
>
> > > 2. As to the default, I believe BOOTSTD should be on by default, if we intend to remove the distro scripts and support things that are not EFI
>
>
> In case you missed it, EFI_LOADER is default for some ARM32, ARM64, X86,
> RISC-V and sandbox. None of those are cases where I'm suggesting BOOTSTD
> shouldn't be default.
>
> > I'd agree with Simon on 2. Boards that have never been upgraded to
> > distro boot or standard boot usually have an internal envs script in
> > include/configs/xxx.h that boots the board the legacy way. Even if
> > bootstd is enabled by default, it won't hurt those.
>
> It hurts them because of the strong likelyhood that they do have
> practical image size limitations (before they would then be leaking in
> to U-Boot environment or some other part of flash).
Yes, indeed. The image size growth would be a problem.
Thanks,
Tony
>
> --
> Tom
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-18 14:41 ` Tom Rini
2025-01-18 19:26 ` Tony Dinh
@ 2025-01-23 14:38 ` Simon Glass
2025-01-23 17:17 ` Tom Rini
1 sibling, 1 reply; 41+ messages in thread
From: Simon Glass @ 2025-01-23 14:38 UTC (permalink / raw)
To: Tom Rini
Cc: Tony Dinh, U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Vincent Stehlé
Hi Tom,
On Sat, 18 Jan 2025 at 07:41, Tom Rini <trini@konsulko.com> wrote:
>
> On Fri, Jan 17, 2025 at 09:49:43PM -0800, Tony Dinh wrote:
> > On Fri, Jan 17, 2025 at 8:32 PM Simon Glass <sjg@chromium.org> wrote:
> > >
> > > Hi Tom,
> > >
> > > On Thu, 16 Jan 2025 at 10:22, Tom Rini <trini@konsulko.com> wrote:
> > > >
> > > > On Thu, Jan 16, 2025 at 08:52:38AM -0700, Simon Glass wrote:
> > > > > Hi Tom,
> > > > >
> > > > > On Wed, 15 Jan 2025 at 16:32, Tom Rini <trini@konsulko.com> wrote:
> > > > [snip]
> > > > > > I'm referring to the whole bootmeth/bootflow/etc thing. Is this going to
> > > > > > be put to use by anyone / anywhere on PowerPC? M68K? MIPS? 32bit ARM is
> > > > > > a harder question there, which is also where this particular overflow
> > > > > > was.
> > > > >
> > > > > I'm still not sure what you are saying. Are you wanting to disable
> > > > > bootstd by default / go back to distro scripts / force everyone to use
> > > > > EFI_LOADER / ?
> > > >
> > > > Yes, I'm asking where it's appropriate to enable this new functionality
> > > > by default. It certainly should be enabled on arm64 (there's new
> > > > designs) and riscv (there's new designs). It still ought to be enabled
> > > > on arm32 because we otherwise lack a easy way to say "new" arm32 (say
> > > > i.MX7) and not "old" arm32 (say i.MX23). What is the point of enabling
> > > > this on PowerPC for example? The active users there are (generally)
> > > > supporting legacy hardware and I have no idea how much they want to
> > > > change their boot process, once bootstd supports flash for example.
> > > > There's similar questions for everything else under arch/ as well.
> > >
> > > To me this is in fact two different questions.
> > >
> > > 1. For PowerPC, m68k, MIPS, I suppose we can just disable BOOTSTD and wait for them to go away, if you are saying that they are behind on migrations will never catch up
>
> On what migrations? A board that has a boot command is not some legacy
> non-migrated case. That's a valid regular use case.
I'm referring to a board that uses distro scripts.
>
> But yes, I'm suggesting we should put some default y if ... logic around
> BOOTSTD.
OK
>
> > > 2. As to the default, I believe BOOTSTD should be on by default, if we intend to remove the distro scripts and support things that are not EFI
>
>
> In case you missed it, EFI_LOADER is default for some ARM32, ARM64, X86,
> RISC-V and sandbox. None of those are cases where I'm suggesting BOOTSTD
> shouldn't be default.
OK
>
> > I'd agree with Simon on 2. Boards that have never been upgraded to
> > distro boot or standard boot usually have an internal envs script in
> > include/configs/xxx.h that boots the board the legacy way. Even if
> > bootstd is enabled by default, it won't hurt those.
>
> It hurts them because of the strong likelyhood that they do have
> practical image size limitations (before they would then be leaking in
> to U-Boot environment or some other part of flash).
OK
Regards,
Simon
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-23 14:38 ` Simon Glass
@ 2025-01-23 17:17 ` Tom Rini
2025-01-25 17:13 ` Simon Glass
0 siblings, 1 reply; 41+ messages in thread
From: Tom Rini @ 2025-01-23 17:17 UTC (permalink / raw)
To: Simon Glass
Cc: Tony Dinh, U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Vincent Stehlé
[-- Attachment #1: Type: text/plain, Size: 2418 bytes --]
On Thu, Jan 23, 2025 at 07:38:04AM -0700, Simon Glass wrote:
> Hi Tom,
>
> On Sat, 18 Jan 2025 at 07:41, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Fri, Jan 17, 2025 at 09:49:43PM -0800, Tony Dinh wrote:
> > > On Fri, Jan 17, 2025 at 8:32 PM Simon Glass <sjg@chromium.org> wrote:
> > > >
> > > > Hi Tom,
> > > >
> > > > On Thu, 16 Jan 2025 at 10:22, Tom Rini <trini@konsulko.com> wrote:
> > > > >
> > > > > On Thu, Jan 16, 2025 at 08:52:38AM -0700, Simon Glass wrote:
> > > > > > Hi Tom,
> > > > > >
> > > > > > On Wed, 15 Jan 2025 at 16:32, Tom Rini <trini@konsulko.com> wrote:
> > > > > [snip]
> > > > > > > I'm referring to the whole bootmeth/bootflow/etc thing. Is this going to
> > > > > > > be put to use by anyone / anywhere on PowerPC? M68K? MIPS? 32bit ARM is
> > > > > > > a harder question there, which is also where this particular overflow
> > > > > > > was.
> > > > > >
> > > > > > I'm still not sure what you are saying. Are you wanting to disable
> > > > > > bootstd by default / go back to distro scripts / force everyone to use
> > > > > > EFI_LOADER / ?
> > > > >
> > > > > Yes, I'm asking where it's appropriate to enable this new functionality
> > > > > by default. It certainly should be enabled on arm64 (there's new
> > > > > designs) and riscv (there's new designs). It still ought to be enabled
> > > > > on arm32 because we otherwise lack a easy way to say "new" arm32 (say
> > > > > i.MX7) and not "old" arm32 (say i.MX23). What is the point of enabling
> > > > > this on PowerPC for example? The active users there are (generally)
> > > > > supporting legacy hardware and I have no idea how much they want to
> > > > > change their boot process, once bootstd supports flash for example.
> > > > > There's similar questions for everything else under arch/ as well.
> > > >
> > > > To me this is in fact two different questions.
> > > >
> > > > 1. For PowerPC, m68k, MIPS, I suppose we can just disable BOOTSTD and wait for them to go away, if you are saying that they are behind on migrations will never catch up
> >
> > On what migrations? A board that has a boot command is not some legacy
> > non-migrated case. That's a valid regular use case.
>
> I'm referring to a board that uses distro scripts.
OK. Just FYI, "distro scripts" weren't a thing outside of ARM (and maybe
RISC-V, and just turris_1x_sdcard on PPC?).
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-23 17:17 ` Tom Rini
@ 2025-01-25 17:13 ` Simon Glass
2025-01-25 18:27 ` Tom Rini
0 siblings, 1 reply; 41+ messages in thread
From: Simon Glass @ 2025-01-25 17:13 UTC (permalink / raw)
To: Tom Rini
Cc: Tony Dinh, U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Vincent Stehlé
Hi Tom,
On Thu, 23 Jan 2025 at 10:17, Tom Rini <trini@konsulko.com> wrote:
>
> On Thu, Jan 23, 2025 at 07:38:04AM -0700, Simon Glass wrote:
> > Hi Tom,
> >
> > On Sat, 18 Jan 2025 at 07:41, Tom Rini <trini@konsulko.com> wrote:
> > >
> > > On Fri, Jan 17, 2025 at 09:49:43PM -0800, Tony Dinh wrote:
> > > > On Fri, Jan 17, 2025 at 8:32 PM Simon Glass <sjg@chromium.org> wrote:
> > > > >
> > > > > Hi Tom,
> > > > >
> > > > > On Thu, 16 Jan 2025 at 10:22, Tom Rini <trini@konsulko.com> wrote:
> > > > > >
> > > > > > On Thu, Jan 16, 2025 at 08:52:38AM -0700, Simon Glass wrote:
> > > > > > > Hi Tom,
> > > > > > >
> > > > > > > On Wed, 15 Jan 2025 at 16:32, Tom Rini <trini@konsulko.com> wrote:
> > > > > > [snip]
> > > > > > > > I'm referring to the whole bootmeth/bootflow/etc thing. Is this going to
> > > > > > > > be put to use by anyone / anywhere on PowerPC? M68K? MIPS? 32bit ARM is
> > > > > > > > a harder question there, which is also where this particular overflow
> > > > > > > > was.
> > > > > > >
> > > > > > > I'm still not sure what you are saying. Are you wanting to disable
> > > > > > > bootstd by default / go back to distro scripts / force everyone to use
> > > > > > > EFI_LOADER / ?
> > > > > >
> > > > > > Yes, I'm asking where it's appropriate to enable this new functionality
> > > > > > by default. It certainly should be enabled on arm64 (there's new
> > > > > > designs) and riscv (there's new designs). It still ought to be enabled
> > > > > > on arm32 because we otherwise lack a easy way to say "new" arm32 (say
> > > > > > i.MX7) and not "old" arm32 (say i.MX23). What is the point of enabling
> > > > > > this on PowerPC for example? The active users there are (generally)
> > > > > > supporting legacy hardware and I have no idea how much they want to
> > > > > > change their boot process, once bootstd supports flash for example.
> > > > > > There's similar questions for everything else under arch/ as well.
> > > > >
> > > > > To me this is in fact two different questions.
> > > > >
> > > > > 1. For PowerPC, m68k, MIPS, I suppose we can just disable BOOTSTD and wait for them to go away, if you are saying that they are behind on migrations will never catch up
> > >
> > > On what migrations? A board that has a boot command is not some legacy
> > > non-migrated case. That's a valid regular use case.
> >
> > I'm referring to a board that uses distro scripts.
>
> OK. Just FYI, "distro scripts" weren't a thing outside of ARM (and maybe
> RISC-V, and just turris_1x_sdcard on PPC?).
OK. If those boards don't boot distros then I suppose it doesn't
matter what they do. It would still be nice to get rid of/reduce the
scripts, but we shouldn't require it.
So where are we with bootstd migration?
Regards,
Simon
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v3 00/19] bootstd: Support recording images
2025-01-25 17:13 ` Simon Glass
@ 2025-01-25 18:27 ` Tom Rini
0 siblings, 0 replies; 41+ messages in thread
From: Tom Rini @ 2025-01-25 18:27 UTC (permalink / raw)
To: Simon Glass
Cc: Tony Dinh, U-Boot Mailing List, AKASHI Takahiro, Caleb Connolly,
Dragan Simic, Emil Kronborg, Etienne Carriere, Francis Laniel,
Guillaume La Roque, Heinrich Schuchardt, Hou Zhiqiang,
Igor Opaniuk, Ilias Apalodimas, Ion Agorria, Jerome Forissier,
Julien Masson, Marek Vasut, Mark Kettenis, Martyn Welch,
Mattijs Korpershoek, Maxim Moskalets, Maximilian Brune,
Michael Trimarchi, Michal Simek, Moritz Fischer, Nam Cao,
Peter Robinson, Quentin Schulz, Sean Anderson, Sean Edmond,
Shantur Rathore, Sughosh Ganu, Svyatoslav Ryhel,
Thomas Weißschuh, Tim Harvey, Vincent Stehlé
[-- Attachment #1: Type: text/plain, Size: 3372 bytes --]
On Sat, Jan 25, 2025 at 10:13:54AM -0700, Simon Glass wrote:
> Hi Tom,
>
> On Thu, 23 Jan 2025 at 10:17, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Thu, Jan 23, 2025 at 07:38:04AM -0700, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Sat, 18 Jan 2025 at 07:41, Tom Rini <trini@konsulko.com> wrote:
> > > >
> > > > On Fri, Jan 17, 2025 at 09:49:43PM -0800, Tony Dinh wrote:
> > > > > On Fri, Jan 17, 2025 at 8:32 PM Simon Glass <sjg@chromium.org> wrote:
> > > > > >
> > > > > > Hi Tom,
> > > > > >
> > > > > > On Thu, 16 Jan 2025 at 10:22, Tom Rini <trini@konsulko.com> wrote:
> > > > > > >
> > > > > > > On Thu, Jan 16, 2025 at 08:52:38AM -0700, Simon Glass wrote:
> > > > > > > > Hi Tom,
> > > > > > > >
> > > > > > > > On Wed, 15 Jan 2025 at 16:32, Tom Rini <trini@konsulko.com> wrote:
> > > > > > > [snip]
> > > > > > > > > I'm referring to the whole bootmeth/bootflow/etc thing. Is this going to
> > > > > > > > > be put to use by anyone / anywhere on PowerPC? M68K? MIPS? 32bit ARM is
> > > > > > > > > a harder question there, which is also where this particular overflow
> > > > > > > > > was.
> > > > > > > >
> > > > > > > > I'm still not sure what you are saying. Are you wanting to disable
> > > > > > > > bootstd by default / go back to distro scripts / force everyone to use
> > > > > > > > EFI_LOADER / ?
> > > > > > >
> > > > > > > Yes, I'm asking where it's appropriate to enable this new functionality
> > > > > > > by default. It certainly should be enabled on arm64 (there's new
> > > > > > > designs) and riscv (there's new designs). It still ought to be enabled
> > > > > > > on arm32 because we otherwise lack a easy way to say "new" arm32 (say
> > > > > > > i.MX7) and not "old" arm32 (say i.MX23). What is the point of enabling
> > > > > > > this on PowerPC for example? The active users there are (generally)
> > > > > > > supporting legacy hardware and I have no idea how much they want to
> > > > > > > change their boot process, once bootstd supports flash for example.
> > > > > > > There's similar questions for everything else under arch/ as well.
> > > > > >
> > > > > > To me this is in fact two different questions.
> > > > > >
> > > > > > 1. For PowerPC, m68k, MIPS, I suppose we can just disable BOOTSTD and wait for them to go away, if you are saying that they are behind on migrations will never catch up
> > > >
> > > > On what migrations? A board that has a boot command is not some legacy
> > > > non-migrated case. That's a valid regular use case.
> > >
> > > I'm referring to a board that uses distro scripts.
> >
> > OK. Just FYI, "distro scripts" weren't a thing outside of ARM (and maybe
> > RISC-V, and just turris_1x_sdcard on PPC?).
>
> OK. If those boards don't boot distros then I suppose it doesn't
> matter what they do. It would still be nice to get rid of/reduce the
> scripts, but we shouldn't require it.
The complex "distro boot" script should be phased out. Ad-hoc boot
commands are a valid regular use case.
> So where are we with bootstd migration?
Waiting on Heinrich to have time to post what he and I talked about for
how to untangle "here's how the EFI custodians want to handle starting
EFI payloads" so that the sunxi series can be rebased on top of master
(which now has the BLK related problem solved) and that.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 41+ messages in thread