Re: [cocci] possible regressions in 1.1.1 -> 1.2

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2025-02-06 at 10:53 +0100, Victor Gambier wrote:
> > With "spatch version 1.1.1 compiled with OCaml version 4.14.2" this
> > works just fine; however, we're trying to upgrade our dependencies and
> > now with "spatch version 1.2 compiled with OCaml version 5.2.0" it
> > doesn't match anything any more? I can't seem to figure out why, I
> > thought maybe the types didn't match - not sure why we had added type u8
> > to that, but pretty sure it was needed - but adding more types didn't
> > really help either.
> We don't officially support OCaml 5.2.0. Could you let me know how you 
> installed/built Coccinelle?

Heh, funny. I didn't even really think about it; it's the nix package
from their 2024.11 release:
https://github.com/NixOS/nixpkgs/blob/nixos-24.11/pkgs/development/tools/misc/coccinelle/default.nix

> > I stand corrected, I wasn't patient enough. On a machine _much_ faster
> > than my laptop (server CPU), it finished (with warnings about
> > inconsistent modifications) after a bit more than 10 minutes.
> 
> Glad to hear! We know there's been a performance regression in 1.2 and 
> we are looking into it. It's a little faster in 1.3.0, but still slower 
> than 1.1.1. It's unclear at the moment to what extent the performance 
> has been degraded because of necessary fixes that perform unavoidable 
> additional work.

OK. I guess we'll have to stick to 1.1.1 for the time being, it does
what we need, we check the output, and this probably more than triples
the overall runtime :)

johannes