All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>, cocci@inria.fr
Cc: Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [cocci] Checking SmPL test cases?
Date: Sat, 8 Feb 2025 15:28:55 +0100	[thread overview]
Message-ID: <e25d4a68-1ef5-4ceb-b3d8-b05dd9ed512c@web.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2502081257090.15422@hadrien>

> The matched if doesn't occur on every control-flow path.
Will further collateral evolution happen according to a test result like the following?

Markus_Elfring@Sonne:…/Projekte/Coccinelle/Probe> time spatch delete_statement3-Johannes_Berg.cocci test3-beacon_len-20250206.c
…
diff =
warning: deletion, node 22: for[1,2,4,5,7,8,10]* in my_beacon_len may be inconsistently modified
warning: deletion, node 23: [fortrue][1,2,4,5,7,8,10] in my_beacon_len may be inconsistently modified
warning: deletion, node 40: [fortrue][1,2,13,14,15] in my_beacon_len may be inconsistently modified
warning: deletion, node 26: statement[1,2,4,5,7,8,10,11] in my_beacon_len may be inconsistently modified
warning: deletion, node 39: for[1,2,13,14,15]* in my_beacon_len may be inconsistently modified
warning: deletion, node 43: statement[1,2,13,14,15,16] in my_beacon_len may be inconsistently modified
…
@@ -11,18 +11,8 @@ my_beacon_len(struct cfg80211_mbssid_ele

        if (i < elems->cnt) {
                len = elems->elem[i].len;
-               if (rnr_elems) {
-                       len += rnr_elems->elem[i].len;
-                       for (i = elems->cnt; i < rnr_elems->cnt; i++)
-                               len += rnr_elems->elem[i].len;
-               }
                return len;
        }

-       if (rnr_elems) {
-               for (i = 0; i < rnr_elems->cnt; i++)
-                       len += rnr_elems->elem[i].len;
-       }
-
        return len;
 }

real    0m2,146s
user    0m2,105s
sys     0m0,023s


Regards,
Markus

  parent reply	other threads:[~2025-02-08 14:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06  9:31 [cocci] possible regressions in 1.1.1 -> 1.2 Johannes Berg
2025-02-06  9:48 ` Johannes Berg
2025-02-06  9:53   ` Victor Gambier
2025-02-06 10:00     ` Johannes Berg
2025-02-06 12:36     ` Markus Elfring
2025-02-06  9:59   ` Julia Lawall
2025-02-06 10:07     ` Johannes Berg
2025-02-06 10:12       ` Johannes Berg
2025-02-06 13:34         ` Markus Elfring
2025-02-06 10:13       ` Julia Lawall
2025-02-06 10:17         ` Johannes Berg
2025-02-06 13:46           ` Markus Elfring
2025-02-06 13:00         ` Markus Elfring
2025-02-06 16:50       ` Markus Elfring
2025-02-08 11:26       ` [cocci] Checking SmPL test cases? Markus Elfring
2025-02-08 11:58         ` Julia Lawall
2025-02-08 12:51           ` Markus Elfring
2025-02-08 14:28           ` Markus Elfring [this message]
2025-02-08 15:43             ` Julia Lawall
2025-02-09  8:42               ` Markus Elfring
2025-02-07  7:43     ` [cocci] Checking software run time characteristics Markus Elfring
2025-02-07  7:55       ` Julia Lawall
2025-02-07  8:15         ` Markus Elfring
2025-02-07  8:59           ` Johannes Berg
2025-02-07  9:50             ` Markus Elfring
2025-02-11  9:58 ` [cocci] possible regressions in 1.1.1 -> 1.2 Victor Gambier
2025-02-11 10:33   ` [cocci] Comparing software run time characteristics Markus Elfring
2025-02-12  9:52   ` [cocci] Profiling of SmPL code? Markus Elfring
2026-03-27 10:43   ` [cocci] possible regressions in 1.1.1 -> 1.2 Victor Gambier
2026-03-27 10:49     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e25d4a68-1ef5-4ceb-b3d8-b05dd9ed512c@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@inria.fr \
    --cc=johannes@sipsolutions.net \
    --cc=julia.lawall@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.