Re: [cocci] Checking SmPL test cases?

[Julia Lawall <julia.lawall@inria.fr>]

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]



On Sat, 8 Feb 2025, Markus Elfring wrote:

> > The matched if doesn't occur on every control-flow path.
> Will further collateral evolution happen according to a test result like the following?

Now the pattern occurs on every control-flow path.

julia

>
> Markus_Elfring@Sonne:…/Projekte/Coccinelle/Probe> time spatch delete_statement3-Johannes_Berg.cocci test3-beacon_len-20250206.c
> …
> diff =
> warning: deletion, node 22: for[1,2,4,5,7,8,10]* in my_beacon_len may be inconsistently modified
> warning: deletion, node 23: [fortrue][1,2,4,5,7,8,10] in my_beacon_len may be inconsistently modified
> warning: deletion, node 40: [fortrue][1,2,13,14,15] in my_beacon_len may be inconsistently modified
> warning: deletion, node 26: statement[1,2,4,5,7,8,10,11] in my_beacon_len may be inconsistently modified
> warning: deletion, node 39: for[1,2,13,14,15]* in my_beacon_len may be inconsistently modified
> warning: deletion, node 43: statement[1,2,13,14,15,16] in my_beacon_len may be inconsistently modified
> …
> @@ -11,18 +11,8 @@ my_beacon_len(struct cfg80211_mbssid_ele
>
>         if (i < elems->cnt) {
>                 len = elems->elem[i].len;
> -               if (rnr_elems) {
> -                       len += rnr_elems->elem[i].len;
> -                       for (i = elems->cnt; i < rnr_elems->cnt; i++)
> -                               len += rnr_elems->elem[i].len;
> -               }
>                 return len;
>         }
>
> -       if (rnr_elems) {
> -               for (i = 0; i < rnr_elems->cnt; i++)
> -                       len += rnr_elems->elem[i].len;
> -       }
> -
>         return len;
>  }
>
> real    0m2,146s
> user    0m2,105s
> sys     0m0,023s
>
>
> Regards,
> Markus
>