From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Stefan Dösinger" <stefandoesinger@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Brian Masney <bmasney@redhat.com>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Russell King <linux@armlinux.org.uk>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH v7 02/13] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller
Date: Fri, 17 Jul 2026 10:15:58 +0200 [thread overview]
Message-ID: <06d11879-b305-422c-bef1-982c968ce899@kernel.org> (raw)
In-Reply-To: <20260717-berserk-faithful-cat-a34ad8@quoll>
On 17/07/2026 08:36, Krzysztof Kozlowski wrote:
> On Fri, Jul 17, 2026 at 12:35:38AM +0300, Stefan Dösinger wrote:
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index cb50c2e3b4ea..5f962b9947ab 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3878,10 +3878,13 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>> S: Odd fixes
>> F: Documentation/arch/arm/zte/
>> F: Documentation/devicetree/bindings/arm/zte.yaml
>> +F: Documentation/devicetree/bindings/clock/zte,zx297520v3-topcrm.yaml
>> F: Documentation/devicetree/bindings/phy/zte,zx297520v3-usb-phy.yaml
>> F: arch/arm/boot/dts/zte/
>> F: arch/arm/mach-zte/
>> +F: include/dt-bindings/clock/zte,zx297520v3-clk.h
>> F: include/dt-bindings/phy/phy-zte-zx297520v3-usb.h
>> +F: include/dt-bindings/reset/zte,zx297520v3-reset.h
>>
>> ARM/ZYNQ ARCHITECTURE
>> M: Michal Simek <michal.simek@amd.com>
>> diff --git a/include/dt-bindings/clock/zte,zx297520v3-clk.h b/include/dt-bindings/clock/zte,zx297520v3-clk.h
>
> Same mistake. Filename MUST match the compatible.
I did not notice that you combine here all the clock IDs from other
clock controllers. The header filename is therefore fine (also reset fine).
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Stefan Dösinger" <stefandoesinger@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Brian Masney <bmasney@redhat.com>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Russell King <linux@armlinux.org.uk>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH v7 02/13] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller
Date: Fri, 17 Jul 2026 10:15:58 +0200 [thread overview]
Message-ID: <06d11879-b305-422c-bef1-982c968ce899@kernel.org> (raw)
In-Reply-To: <20260717-berserk-faithful-cat-a34ad8@quoll>
On 17/07/2026 08:36, Krzysztof Kozlowski wrote:
> On Fri, Jul 17, 2026 at 12:35:38AM +0300, Stefan Dösinger wrote:
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index cb50c2e3b4ea..5f962b9947ab 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3878,10 +3878,13 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>> S: Odd fixes
>> F: Documentation/arch/arm/zte/
>> F: Documentation/devicetree/bindings/arm/zte.yaml
>> +F: Documentation/devicetree/bindings/clock/zte,zx297520v3-topcrm.yaml
>> F: Documentation/devicetree/bindings/phy/zte,zx297520v3-usb-phy.yaml
>> F: arch/arm/boot/dts/zte/
>> F: arch/arm/mach-zte/
>> +F: include/dt-bindings/clock/zte,zx297520v3-clk.h
>> F: include/dt-bindings/phy/phy-zte-zx297520v3-usb.h
>> +F: include/dt-bindings/reset/zte,zx297520v3-reset.h
>>
>> ARM/ZYNQ ARCHITECTURE
>> M: Michal Simek <michal.simek@amd.com>
>> diff --git a/include/dt-bindings/clock/zte,zx297520v3-clk.h b/include/dt-bindings/clock/zte,zx297520v3-clk.h
>
> Same mistake. Filename MUST match the compatible.
I did not notice that you combine here all the clock IDs from other
clock controllers. The header filename is therefore fine (also reset fine).
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-07-17 8:16 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 21:35 [PATCH v7 00/13] ZTE zx297520v3 clock bindings and driver Stefan Dösinger
2026-07-16 21:35 ` Stefan Dösinger
2026-07-16 21:35 ` [PATCH v7 01/13] dt-bindings: phy: Add zx297520v3 USB phy documentation Stefan Dösinger
2026-07-16 21:35 ` Stefan Dösinger
2026-07-16 22:24 ` sashiko-bot
2026-07-16 22:24 ` sashiko-bot
2026-07-17 0:05 ` Rob Herring (Arm)
2026-07-17 0:05 ` Rob Herring (Arm)
2026-07-17 6:32 ` Krzysztof Kozlowski
2026-07-17 6:32 ` Krzysztof Kozlowski
2026-07-16 21:35 ` [PATCH v7 02/13] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller Stefan Dösinger
2026-07-16 21:35 ` Stefan Dösinger
2026-07-17 0:05 ` Rob Herring (Arm)
2026-07-17 0:05 ` Rob Herring (Arm)
2026-07-17 6:36 ` Krzysztof Kozlowski
2026-07-17 6:36 ` Krzysztof Kozlowski
2026-07-17 8:15 ` Krzysztof Kozlowski [this message]
2026-07-17 8:15 ` Krzysztof Kozlowski
2026-07-16 21:35 ` [PATCH v7 03/13] dt-bindings: clk: zte: Add zx297520v3 matrix " Stefan Dösinger
2026-07-16 21:35 ` Stefan Dösinger
2026-07-16 22:25 ` sashiko-bot
2026-07-16 22:25 ` sashiko-bot
2026-07-16 21:35 ` [PATCH v7 04/13] dt-bindings: clk: zte: Add zx297520v3 LSP " Stefan Dösinger
2026-07-16 21:35 ` Stefan Dösinger
2026-07-17 8:23 ` Krzysztof Kozlowski
2026-07-17 8:23 ` Krzysztof Kozlowski
2026-07-16 21:35 ` [PATCH v7 05/13] mfd: zx297520v3: Add a clock and reset MFD driver Stefan Dösinger
2026-07-16 21:35 ` Stefan Dösinger
2026-07-16 22:24 ` sashiko-bot
2026-07-16 22:24 ` sashiko-bot
2026-07-16 21:35 ` [PATCH v7 06/13] clk: zte: Add Clock registration infrastructure Stefan Dösinger
2026-07-16 21:35 ` Stefan Dösinger
2026-07-16 22:26 ` sashiko-bot
2026-07-16 22:26 ` sashiko-bot
2026-07-16 21:35 ` [PATCH v7 07/13] clk: zte: Add regmap based clocks Stefan Dösinger
2026-07-16 21:35 ` Stefan Dösinger
2026-07-16 21:35 ` [PATCH v7 08/13] clk: zte: Add zx PLL support infrastructure Stefan Dösinger
2026-07-16 21:35 ` Stefan Dösinger
2026-07-16 22:34 ` sashiko-bot
2026-07-16 22:34 ` sashiko-bot
2026-07-16 21:35 ` [PATCH v7 09/13] clk: zte: Introduce a driver for zx297520v3 top clocks Stefan Dösinger
2026-07-16 21:35 ` Stefan Dösinger
2026-07-16 22:42 ` sashiko-bot
2026-07-16 22:42 ` sashiko-bot
2026-07-16 22:00 ` [PATCH v7 10/13] clk: zte: Introduce a driver for zx297520v3 matrix clocks Stefan Dösinger
2026-07-16 22:00 ` [PATCH v7 12/13] reset: zte: Add a zx297520v3 reset driver Stefan Dösinger
2026-07-16 22:00 ` [PATCH v7 13/13] ARM: dts: zte: Declare zx297520v3 CRM device nodes Stefan Dösinger
2026-07-16 22:17 ` [PATCH v7 11/13] clk: zte: Introduce a driver for zx297520v3 LSP clocks Stefan Dösinger
2026-07-17 6:37 ` [PATCH v7 00/13] ZTE zx297520v3 clock bindings and driver Krzysztof Kozlowski
2026-07-17 6:37 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06d11879-b305-422c-bef1-982c968ce899@kernel.org \
--to=krzk@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stefandoesinger@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.