Re: [Patch 10/18] fs/logfs/inode.c

[Arnd Bergmann <arnd@arndb.de>]

On Sunday 03 June 2007, Jörn Engel wrote:
> +struct inode *logfs_new_inode(struct inode *dir, int mode)
> +{
> +       struct super_block *sb = dir->i_sb;
> +       struct inode *inode;
> +
> +       inode = new_inode(sb);
> +       if (!inode)
> +               return ERR_PTR(-ENOMEM);
> +
> +       logfs_init_inode(inode);
> +
> +       inode->i_mode = mode;
> +       inode->i_ino = logfs_get_ino(sb);
> +
> +       insert_inode_hash(inode);
> +
> +       return inode;
> +}

I think this is missing code that sets the initial i_uid/i_gid,
but there may be more missing. Changing the uid value works,
but creating files as non-root user doesn't.

	Arnd <><