From: Andreas Schwab <schwab@suse.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: akpm@osdl.org, "David Weinehall" <tao@acc.umu.se>,
"Dongjun Shin" <djshin90@gmail.com>,
"Kyle Moffett" <mrmacman_g4@mac.com>,
linux-mtd@lists.infradead.org, "Pavel Machek" <pavel@ucw.cz>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Ulisses Furquim" <ulissesf@gmail.com>, CaT <cat@zip.com.au>,
"Evgeniy Polyakov" <johnpol@2ka.mipt.ru>,
"Segher Boessenkool" <segher@kernel.crashing.org>,
"Roland Dreier" <rdreier@cisco.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Jörn Engel" <joern@lazybastard.org>,
"Jamie Lokier" <jamie@shareable.org>,
"Pekka Enberg" <penberg@cs.helsinki.fi>,
"Jan Engelhardt" <jengelh@linux01.gwdg.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Bill Davidsen" <davidsen@tmr.com>,
"Albert Cahalan" <acahalan@gmail.com>,
"John Stoffel" <john@stoffel.org>,
linux-kernel@vger.kernel.org,
"Ondrej Zajicek" <santiago@crfreenet.org>,
linux-fsdevel@vger.kernel.org, "Willy Tarreau" <w@1wt.eu>
Subject: Re: [Patch 04/18] include/linux/logfs.h
Date: Wed, 06 Jun 2007 10:59:48 +0200 [thread overview]
Message-ID: <jemyzdpiez.fsf@sykes.suse.de> (raw)
In-Reply-To: <1181119820.25232.434.camel@pmac.infradead.org> (David Woodhouse's message of "Wed\, 06 Jun 2007 09\:50\:20 +0100")
David Woodhouse <dwmw2@infradead.org> writes:
> Won't a simple struct { uint16_t } get padded to a size of 4 bytes on
> ARM? Even if I'm misremembering that, I certainly can't guarantee that
> such a thing will _never_ happen on any newly-invented ABI. If you had
> 'nopadding' instead of 'packed', then there's no need to emit code to
> handle unaligned loads.
You can add aligned(N) to increase the alignment again.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Segher Boessenkool" <segher@kernel.crashing.org>,
"Kyle Moffett" <mrmacman_g4@mac.com>,
"John Stoffel" <john@stoffel.org>, "Willy Tarreau" <w@1wt.eu>,
"Evgeniy Polyakov" <johnpol@2ka.mipt.ru>, CaT <cat@zip.com.au>,
"Ondrej Zajicek" <santiago@crfreenet.org>,
linux-kernel@vger.kernel.org, "Bill Davidsen" <davidsen@tmr.com>,
"Jan Engelhardt" <jengelh@linux01.gwdg.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Dongjun Shin" <djshin90@gmail.com>,
"Pekka Enberg" <penberg@cs.helsinki.fi>,
"Arnd Bergmann" <arnd@arndb.de>,
"Albert Cahalan" <acahalan@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
"Artem Bityutskiy" <dedekind@infradead.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Jamie Lokier" <jamie@shareable.org>,
"Roland Dreier" <rdreier@cisco.com>,
"Jörn Engel" <joern@lazybastard.org>,
"Pavel Machek" <pavel@ucw.cz>,
"Ulisses Furquim" <ulissesf@gmail.com>,
akpm@osdl.org, "David Weinehall" <tao@acc.umu.se>
Subject: Re: [Patch 04/18] include/linux/logfs.h
Date: Wed, 06 Jun 2007 10:59:48 +0200 [thread overview]
Message-ID: <jemyzdpiez.fsf@sykes.suse.de> (raw)
In-Reply-To: <1181119820.25232.434.camel@pmac.infradead.org> (David Woodhouse's message of "Wed\, 06 Jun 2007 09\:50\:20 +0100")
David Woodhouse <dwmw2@infradead.org> writes:
> Won't a simple struct { uint16_t } get padded to a size of 4 bytes on
> ARM? Even if I'm misremembering that, I certainly can't guarantee that
> such a thing will _never_ happen on any newly-invented ABI. If you had
> 'nopadding' instead of 'packed', then there's no need to emit code to
> handle unaligned loads.
You can add aligned(N) to increase the alignment again.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Segher Boessenkool" <segher@kernel.crashing.org>,
"Kyle Moffett" <mrmacman_g4@mac.com>,
"John Stoffel" <john@stoffel.org>, "Willy Tarreau" <w@1wt.eu>,
"Evgeniy Polyakov" <johnpol@2ka.mipt.ru>, CaT <cat@zip.com.au>,
"Ondrej Zajicek" <santiago@crfreenet.org>,
linux-kernel@vger.kernel.org, "Bill Davidsen" <davidsen@tmr.com>,
"Jan Engelhardt" <jengelh@linux01.gwdg.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Dongjun Shin" <djshin90@gmail.com>,
"Pekka Enberg" <penberg@cs.helsinki.fi>,
"Arnd Bergmann" <arnd@arndb.de>,
"Albert Cahalan" <acahalan@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
"Artem Bityutskiy" <dedekind@infradead.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Jamie Lokier" <jamie@shareable.org>,
"Roland Dreier" <rdreier@cisco.com>,
"Jörn Engel" <joern@lazybastard.org>,
"Pavel Machek" <pavel@ucw.cz>,
"Ulisses Furquim" <ulissesf@gmail.com>,
akpm@osdl.org
Subject: Re: [Patch 04/18] include/linux/logfs.h
Date: Wed, 06 Jun 2007 10:59:48 +0200 [thread overview]
Message-ID: <jemyzdpiez.fsf@sykes.suse.de> (raw)
In-Reply-To: <1181119820.25232.434.camel@pmac.infradead.org> (David Woodhouse's message of "Wed\, 06 Jun 2007 09\:50\:20 +0100")
David Woodhouse <dwmw2@infradead.org> writes:
> Won't a simple struct { uint16_t } get padded to a size of 4 bytes on
> ARM? Even if I'm misremembering that, I certainly can't guarantee that
> such a thing will _never_ happen on any newly-invented ABI. If you had
> 'nopadding' instead of 'packed', then there's no need to emit code to
> handle unaligned loads.
You can add aligned(N) to increase the alignment again.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-06-06 9:01 UTC|newest]
Thread overview: 161+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 18:38 LogFS take four Jörn Engel
2007-06-03 18:38 ` Jörn Engel
2007-06-03 18:38 ` Jörn Engel
2007-06-03 18:40 ` [Patch 01/18] fs/Kconfig Jörn Engel
2007-06-03 18:49 ` Jörn Engel
2007-06-03 18:40 ` [Patch 02/18] fs/Makefile Jörn Engel
2007-06-03 18:49 ` Jörn Engel
2007-06-03 18:41 ` [Patch 03/18] fs/logfs/Makefile Jörn Engel
2007-06-03 20:21 ` Jörn Engel
2007-06-03 18:42 ` [Patch 04/18] include/linux/logfs.h Jörn Engel
2007-06-03 21:58 ` Jörn Engel
2007-06-03 21:42 ` Arnd Bergmann
2007-06-03 21:42 ` Arnd Bergmann
2007-06-03 21:42 ` Arnd Bergmann
2007-06-04 9:12 ` Jörn Engel
2007-06-04 9:12 ` Jörn Engel
2007-06-04 9:12 ` Jörn Engel
2007-06-04 13:38 ` David Woodhouse
2007-06-04 13:38 ` David Woodhouse
2007-06-04 13:38 ` David Woodhouse
2007-06-04 14:02 ` Jörn Engel
2007-06-04 14:02 ` Jörn Engel
2007-06-04 14:02 ` Jörn Engel
2007-06-05 15:49 ` Segher Boessenkool
2007-06-05 15:49 ` Segher Boessenkool
2007-06-05 15:53 ` David Woodhouse
2007-06-05 15:53 ` David Woodhouse
2007-06-05 18:49 ` Segher Boessenkool
2007-06-05 18:49 ` Segher Boessenkool
2007-06-06 8:50 ` David Woodhouse
2007-06-06 8:50 ` David Woodhouse
2007-06-06 8:59 ` Andreas Schwab [this message]
2007-06-06 8:59 ` Andreas Schwab
2007-06-06 8:59 ` Andreas Schwab
2007-06-06 12:42 ` Arnd Bergmann
2007-06-06 12:42 ` Arnd Bergmann
2007-06-06 12:42 ` Arnd Bergmann
2007-06-05 20:39 ` Bill Davidsen
2007-06-05 20:39 ` Bill Davidsen
2007-06-03 18:43 ` [Patch 05/18] fs/logfs/logfs.h Jörn Engel
2007-06-03 20:01 ` Jörn Engel
2007-06-03 21:50 ` Arnd Bergmann
2007-06-03 21:50 ` Arnd Bergmann
2007-06-04 8:17 ` Jan Engelhardt
2007-06-04 8:17 ` Jan Engelhardt
2007-06-04 8:17 ` Jan Engelhardt
2007-06-04 9:11 ` Jörn Engel
2007-06-04 9:11 ` Jörn Engel
2007-06-04 9:11 ` Jörn Engel
2007-06-06 11:29 ` Paulo Marques
2007-06-06 11:29 ` Paulo Marques
2007-06-06 11:29 ` Paulo Marques
2007-06-06 11:29 ` Jörn Engel
2007-06-06 11:29 ` Jörn Engel
2007-06-06 11:29 ` Jörn Engel
2007-06-03 18:43 ` [Patch 06/18] fs/logfs/compr.c Jörn Engel
2007-06-03 20:14 ` Jörn Engel
2007-06-03 21:58 ` Arnd Bergmann
2007-06-03 21:58 ` Arnd Bergmann
2007-06-03 21:58 ` Arnd Bergmann
2007-06-04 8:54 ` Jörn Engel
2007-06-04 8:54 ` Jörn Engel
2007-06-04 8:54 ` Jörn Engel
2007-06-04 13:53 ` David Woodhouse
2007-06-04 13:53 ` David Woodhouse
2007-06-04 13:53 ` David Woodhouse
2007-06-03 18:44 ` [Patch 07/18] fs/logfs/dir.c Jörn Engel
2007-06-03 19:43 ` Jörn Engel
2007-06-15 8:59 ` Evgeniy Polyakov
2007-06-15 8:59 ` Evgeniy Polyakov
2007-06-15 8:59 ` Evgeniy Polyakov
2007-06-15 11:57 ` Jörn Engel
2007-06-15 11:57 ` Jörn Engel
2007-06-15 11:57 ` Jörn Engel
2007-06-03 18:45 ` [Patch 08/18] fs/logfs/file.c Jörn Engel
2007-06-03 20:30 ` Jörn Engel
2007-06-03 18:46 ` [Patch 09/18] fs/logfs/gc.c Jörn Engel
2007-06-03 20:46 ` Jörn Engel
2007-06-03 22:07 ` Arnd Bergmann
2007-06-03 22:07 ` Arnd Bergmann
2007-06-04 9:01 ` Jörn Engel
2007-06-04 9:01 ` Jörn Engel
2007-06-04 9:01 ` Jörn Engel
2007-06-15 9:03 ` Evgeniy Polyakov
2007-06-15 9:03 ` Evgeniy Polyakov
2007-06-15 9:03 ` Evgeniy Polyakov
2007-06-15 11:14 ` Jörn Engel
2007-06-15 11:14 ` Jörn Engel
2007-06-15 11:14 ` Jörn Engel
2007-06-15 13:03 ` Evgeniy Polyakov
2007-06-15 13:03 ` Evgeniy Polyakov
2007-06-15 13:03 ` Evgeniy Polyakov
2007-06-03 18:46 ` [Patch 10/18] fs/logfs/inode.c Jörn Engel
2007-06-03 21:27 ` Jörn Engel
2007-06-10 17:24 ` Arnd Bergmann
2007-06-10 17:24 ` Arnd Bergmann
2007-06-10 17:40 ` Jörn Engel
2007-06-10 17:40 ` Jörn Engel
2007-06-10 17:40 ` Jörn Engel
2007-06-11 23:28 ` Jörn Engel
2007-06-11 23:28 ` Jörn Engel
2007-06-11 23:28 ` Jörn Engel
2007-06-11 23:51 ` Arnd Bergmann
2007-06-11 23:51 ` Arnd Bergmann
2007-06-11 23:51 ` Arnd Bergmann
2007-06-11 23:57 ` Jörn Engel
2007-06-11 23:57 ` Jörn Engel
2007-06-03 18:47 ` [Patch 11/18] fs/logfs/journal.c Jörn Engel
2007-06-03 20:00 ` Jörn Engel
2007-06-03 18:47 ` [Patch 12/18] fs/logfs/memtree.c Jörn Engel
2007-06-03 20:43 ` Jörn Engel
2007-06-03 18:48 ` [Patch 13/18] fs/logfs/readwrite.c Jörn Engel
2007-06-03 20:57 ` Jörn Engel
2007-06-03 18:48 ` [Patch 14/18] fs/logfs/segment.c Jörn Engel
2007-06-03 20:14 ` Jörn Engel
2007-06-03 22:21 ` Arnd Bergmann
2007-06-03 22:21 ` Arnd Bergmann
2007-06-03 22:21 ` Arnd Bergmann
2007-06-04 9:07 ` Jörn Engel
2007-06-04 9:07 ` Jörn Engel
2007-06-04 9:07 ` Jörn Engel
2007-06-03 18:49 ` [Patch 15/18] fs/logfs/super.c Jörn Engel
2007-06-03 20:42 ` Jörn Engel
2007-06-10 16:27 ` Arnd Bergmann
2007-06-10 16:27 ` Arnd Bergmann
2007-06-10 16:27 ` Arnd Bergmann
2007-06-10 17:38 ` Jörn Engel
2007-06-10 17:38 ` Jörn Engel
2007-06-10 17:38 ` Jörn Engel
2007-06-10 18:33 ` Arnd Bergmann
2007-06-10 18:33 ` Arnd Bergmann
2007-06-10 18:33 ` Arnd Bergmann
2007-06-10 19:10 ` Jörn Engel
2007-06-10 19:10 ` Jörn Engel
2007-06-10 19:20 ` Willy Tarreau
2007-06-10 19:20 ` Willy Tarreau
2007-06-10 19:20 ` Willy Tarreau
2007-06-03 18:50 ` [Patch 16/18] fs/logfs/progs/fsck.c Jörn Engel
2007-06-03 19:00 ` Jörn Engel
2007-06-03 18:50 ` [Patch 17/18] fs/logfs/progs/mkfs.c Jörn Engel
2007-06-03 19:01 ` Jörn Engel
2007-06-03 18:51 ` [Patch 18/18] fs/logfs/Locking Jörn Engel
2007-06-03 21:21 ` Jörn Engel
2007-06-03 19:17 ` LogFS take four Jan-Benedict Glaw
2007-06-03 19:20 ` Jan-Benedict Glaw
2007-06-03 19:19 ` Jörn Engel
2007-06-03 19:19 ` Jörn Engel
2007-06-03 22:18 ` Arnd Bergmann
2007-06-03 22:18 ` Arnd Bergmann
2007-06-03 22:18 ` Arnd Bergmann
2007-06-04 9:05 ` Jörn Engel
2007-06-04 9:05 ` Jörn Engel
2007-06-04 9:05 ` Jörn Engel
2007-06-06 13:50 ` Alexander Belyakov
2007-06-06 13:58 ` Jörn Engel
2007-06-15 8:37 ` Evgeniy Polyakov
2007-06-15 8:37 ` Evgeniy Polyakov
2007-06-15 8:37 ` Evgeniy Polyakov
2007-06-15 11:10 ` Jörn Engel
2007-06-15 11:10 ` Jörn Engel
2007-06-15 11:10 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jemyzdpiez.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=acahalan@gmail.com \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=cat@zip.com.au \
--cc=davidsen@tmr.com \
--cc=djshin90@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jamie@shareable.org \
--cc=jengelh@linux01.gwdg.de \
--cc=joern@lazybastard.org \
--cc=john@stoffel.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mrmacman_g4@mac.com \
--cc=pavel@ucw.cz \
--cc=penberg@cs.helsinki.fi \
--cc=rdreier@cisco.com \
--cc=sam@ravnborg.org \
--cc=santiago@crfreenet.org \
--cc=segher@kernel.crashing.org \
--cc=tao@acc.umu.se \
--cc=tglx@linutronix.de \
--cc=ulissesf@gmail.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.