From: Paulo Marques <pmarques@grupopie.com>
To: "Jörn Engel" <joern@lazybastard.org>
Cc: akpm@osdl.org, David Weinehall <tao@acc.umu.se>,
Dongjun Shin <djshin90@gmail.com>,
Kyle Moffett <mrmacman_g4@mac.com>,
linux-mtd@lists.infradead.org, Pavel Machek <pavel@ucw.cz>,
Sam Ravnborg <sam@ravnborg.org>,
Ulisses Furquim <ulissesf@gmail.com>, CaT <cat@zip.com.au>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
Roland Dreier <rdreier@cisco.com>, Arnd Bergmann <arnd@arndb.de>,
Jamie Lokier <jamie@shareable.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Thomas Gleixner <tglx@linutronix.de>,
Bill Davidsen <davidsen@tmr.com>,
Albert Cahalan <acahalan@gmail.com>,
John Stoffel <john@stoffel.org>,
linux-kernel@vger.kernel.org,
Ondrej Zajicek <santiago@crfreenet.org>,
linux-fsdevel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>, Willy Tarreau <w@1wt.eu>
Subject: Re: [Patch 05/18] fs/logfs/logfs.h
Date: Wed, 06 Jun 2007 12:29:13 +0100 [thread overview]
Message-ID: <46669A89.3010500@grupopie.com> (raw)
In-Reply-To: <20070603184303.GF8952@lazybastard.org>
Jörn Engel wrote:
> --- /dev/null 2007-03-13 19:15:28.862769062 +0100
> +++ linux-2.6.21logfs/fs/logfs/logfs.h 2007-06-03 19:34:07.000000000 +0200
> @@ -0,0 +1,398 @@
> +/*
> + * fs/logfs/logfs.h
> + *
> + * As should be obvious for Linux kernel code, license is GPLv2
> + *
> + * Copyright (c) 2005-2007 Joern Engel
> + *
> + * Private header for logfs.
> + */
> +#ifndef fs_logfs_logfs_h
> +#define fs_logfs_logfs_h
> +
> +#define __CHECK_ENDIAN__
> +
> +
> +#include <linux/crc32.h>
> +#include <linux/fs.h>
> +#include <linux/kallsyms.h>
Including kallsyms.h is not really needed in this header file, is it?
I don't have time / knowledge to review the rest of the code, but I
always keep an eye out for kallsyms usage...
--
Paulo Marques - www.grupopie.com
"Very funny Scotty. Now beam up my clothes."
WARNING: multiple messages have this Message-ID (diff)
From: Paulo Marques <pmarques@grupopie.com>
To: "Jörn Engel" <joern@lazybastard.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, akpm@osdl.org,
Sam Ravnborg <sam@ravnborg.org>, John Stoffel <john@stoffel.org>,
David Woodhouse <dwmw2@infradead.org>,
Jamie Lokier <jamie@shareable.org>,
Artem Bityutskiy <dedekind@infradead.org>, CaT <cat@zip.com.au>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
David Weinehall <tao@acc.umu.se>, Arnd Bergmann <arnd@arndb.de>,
Willy Tarreau <w@1wt.eu>, Kyle Moffett <mrmacman_g4@mac.com>,
Dongjun Shin <djshin90@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Bill Davidsen <davidsen@tmr.com>,
Thomas Gleixner <tglx@linutronix.de>,
Albert Cahalan <acahalan@gmail.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Roland Dreier <rdreier@cisco.com>,
Ondrej Zajicek <santiago@crfreenet.org>,
Ulisses Furquim <ulissesf@gmail.com>
Subject: Re: [Patch 05/18] fs/logfs/logfs.h
Date: Wed, 06 Jun 2007 12:29:13 +0100 [thread overview]
Message-ID: <46669A89.3010500@grupopie.com> (raw)
In-Reply-To: <20070603184303.GF8952@lazybastard.org>
Jörn Engel wrote:
> --- /dev/null 2007-03-13 19:15:28.862769062 +0100
> +++ linux-2.6.21logfs/fs/logfs/logfs.h 2007-06-03 19:34:07.000000000 +0200
> @@ -0,0 +1,398 @@
> +/*
> + * fs/logfs/logfs.h
> + *
> + * As should be obvious for Linux kernel code, license is GPLv2
> + *
> + * Copyright (c) 2005-2007 Joern Engel
> + *
> + * Private header for logfs.
> + */
> +#ifndef fs_logfs_logfs_h
> +#define fs_logfs_logfs_h
> +
> +#define __CHECK_ENDIAN__
> +
> +
> +#include <linux/crc32.h>
> +#include <linux/fs.h>
> +#include <linux/kallsyms.h>
Including kallsyms.h is not really needed in this header file, is it?
I don't have time / knowledge to review the rest of the code, but I
always keep an eye out for kallsyms usage...
--
Paulo Marques - www.grupopie.com
"Very funny Scotty. Now beam up my clothes."
WARNING: multiple messages have this Message-ID (diff)
From: Paulo Marques <pmarques@grupopie.com>
To: "Jörn Engel" <joern@lazybastard.org>
Cc: akpm@osdl.org, David Weinehall <tao@acc.umu.se>,
Dongjun Shin <djshin90@gmail.com>,
Kyle Moffett <mrmacman_g4@mac.com>,
linux-mtd@lists.infradead.org, Pavel Machek <pavel@ucw.cz>,
Sam Ravnborg <sam@ravnborg.org>,
Ulisses Furquim <ulissesf@gmail.com>, CaT <cat@zip.com.au>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
Roland Dreier <rdreier@cisco.com>, Arnd Bergmann <arnd@arndb.de>,
Jamie Lokier <jamie@shareable.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Thomas Gleixner <tglx@linutronix.de>,
Bill Davidsen <davidsen@tmr.com>,
Albert Cahalan <acahalan@gmail.com>,
John Stoffel <john@stoffel.org>,
linux-kernel@vger.kernel.org,
Ondrej Zajicek <santiago@crfreenet.org>,
linux-fsdevel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>, Willy Tarreau <w@1wt.eu>
Subject: Re: [Patch 05/18] fs/logfs/logfs.h
Date: Wed, 06 Jun 2007 12:29:13 +0100 [thread overview]
Message-ID: <46669A89.3010500@grupopie.com> (raw)
In-Reply-To: <20070603184303.GF8952@lazybastard.org>
Jörn Engel wrote:
> --- /dev/null 2007-03-13 19:15:28.862769062 +0100
> +++ linux-2.6.21logfs/fs/logfs/logfs.h 2007-06-03 19:34:07.000000000 +0200
> @@ -0,0 +1,398 @@
> +/*
> + * fs/logfs/logfs.h
> + *
> + * As should be obvious for Linux kernel code, license is GPLv2
> + *
> + * Copyright (c) 2005-2007 Joern Engel
> + *
> + * Private header for logfs.
> + */
> +#ifndef fs_logfs_logfs_h
> +#define fs_logfs_logfs_h
> +
> +#define __CHECK_ENDIAN__
> +
> +
> +#include <linux/crc32.h>
> +#include <linux/fs.h>
> +#include <linux/kallsyms.h>
Including kallsyms.h is not really needed in this header file, is it?
I don't have time / knowledge to review the rest of the code, but I
always keep an eye out for kallsyms usage...
--
Paulo Marques - www.grupopie.com
"Very funny Scotty. Now beam up my clothes."
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2007-06-06 11:29 UTC|newest]
Thread overview: 161+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 18:38 LogFS take four Jörn Engel
2007-06-03 18:38 ` Jörn Engel
2007-06-03 18:38 ` Jörn Engel
2007-06-03 18:40 ` [Patch 01/18] fs/Kconfig Jörn Engel
2007-06-03 18:49 ` Jörn Engel
2007-06-03 18:40 ` [Patch 02/18] fs/Makefile Jörn Engel
2007-06-03 18:49 ` Jörn Engel
2007-06-03 18:41 ` [Patch 03/18] fs/logfs/Makefile Jörn Engel
2007-06-03 20:21 ` Jörn Engel
2007-06-03 18:42 ` [Patch 04/18] include/linux/logfs.h Jörn Engel
2007-06-03 21:58 ` Jörn Engel
2007-06-03 21:42 ` Arnd Bergmann
2007-06-03 21:42 ` Arnd Bergmann
2007-06-03 21:42 ` Arnd Bergmann
2007-06-04 9:12 ` Jörn Engel
2007-06-04 9:12 ` Jörn Engel
2007-06-04 9:12 ` Jörn Engel
2007-06-04 13:38 ` David Woodhouse
2007-06-04 13:38 ` David Woodhouse
2007-06-04 13:38 ` David Woodhouse
2007-06-04 14:02 ` Jörn Engel
2007-06-04 14:02 ` Jörn Engel
2007-06-04 14:02 ` Jörn Engel
2007-06-05 15:49 ` Segher Boessenkool
2007-06-05 15:49 ` Segher Boessenkool
2007-06-05 15:53 ` David Woodhouse
2007-06-05 15:53 ` David Woodhouse
2007-06-05 18:49 ` Segher Boessenkool
2007-06-05 18:49 ` Segher Boessenkool
2007-06-06 8:50 ` David Woodhouse
2007-06-06 8:50 ` David Woodhouse
2007-06-06 8:59 ` Andreas Schwab
2007-06-06 8:59 ` Andreas Schwab
2007-06-06 8:59 ` Andreas Schwab
2007-06-06 12:42 ` Arnd Bergmann
2007-06-06 12:42 ` Arnd Bergmann
2007-06-06 12:42 ` Arnd Bergmann
2007-06-05 20:39 ` Bill Davidsen
2007-06-05 20:39 ` Bill Davidsen
2007-06-03 18:43 ` [Patch 05/18] fs/logfs/logfs.h Jörn Engel
2007-06-03 20:01 ` Jörn Engel
2007-06-03 21:50 ` Arnd Bergmann
2007-06-03 21:50 ` Arnd Bergmann
2007-06-04 8:17 ` Jan Engelhardt
2007-06-04 8:17 ` Jan Engelhardt
2007-06-04 8:17 ` Jan Engelhardt
2007-06-04 9:11 ` Jörn Engel
2007-06-04 9:11 ` Jörn Engel
2007-06-04 9:11 ` Jörn Engel
2007-06-06 11:29 ` Paulo Marques [this message]
2007-06-06 11:29 ` Paulo Marques
2007-06-06 11:29 ` Paulo Marques
2007-06-06 11:29 ` Jörn Engel
2007-06-06 11:29 ` Jörn Engel
2007-06-06 11:29 ` Jörn Engel
2007-06-03 18:43 ` [Patch 06/18] fs/logfs/compr.c Jörn Engel
2007-06-03 20:14 ` Jörn Engel
2007-06-03 21:58 ` Arnd Bergmann
2007-06-03 21:58 ` Arnd Bergmann
2007-06-03 21:58 ` Arnd Bergmann
2007-06-04 8:54 ` Jörn Engel
2007-06-04 8:54 ` Jörn Engel
2007-06-04 8:54 ` Jörn Engel
2007-06-04 13:53 ` David Woodhouse
2007-06-04 13:53 ` David Woodhouse
2007-06-04 13:53 ` David Woodhouse
2007-06-03 18:44 ` [Patch 07/18] fs/logfs/dir.c Jörn Engel
2007-06-03 19:43 ` Jörn Engel
2007-06-15 8:59 ` Evgeniy Polyakov
2007-06-15 8:59 ` Evgeniy Polyakov
2007-06-15 8:59 ` Evgeniy Polyakov
2007-06-15 11:57 ` Jörn Engel
2007-06-15 11:57 ` Jörn Engel
2007-06-15 11:57 ` Jörn Engel
2007-06-03 18:45 ` [Patch 08/18] fs/logfs/file.c Jörn Engel
2007-06-03 20:30 ` Jörn Engel
2007-06-03 18:46 ` [Patch 09/18] fs/logfs/gc.c Jörn Engel
2007-06-03 20:46 ` Jörn Engel
2007-06-03 22:07 ` Arnd Bergmann
2007-06-03 22:07 ` Arnd Bergmann
2007-06-04 9:01 ` Jörn Engel
2007-06-04 9:01 ` Jörn Engel
2007-06-04 9:01 ` Jörn Engel
2007-06-15 9:03 ` Evgeniy Polyakov
2007-06-15 9:03 ` Evgeniy Polyakov
2007-06-15 9:03 ` Evgeniy Polyakov
2007-06-15 11:14 ` Jörn Engel
2007-06-15 11:14 ` Jörn Engel
2007-06-15 11:14 ` Jörn Engel
2007-06-15 13:03 ` Evgeniy Polyakov
2007-06-15 13:03 ` Evgeniy Polyakov
2007-06-15 13:03 ` Evgeniy Polyakov
2007-06-03 18:46 ` [Patch 10/18] fs/logfs/inode.c Jörn Engel
2007-06-03 21:27 ` Jörn Engel
2007-06-10 17:24 ` Arnd Bergmann
2007-06-10 17:24 ` Arnd Bergmann
2007-06-10 17:40 ` Jörn Engel
2007-06-10 17:40 ` Jörn Engel
2007-06-10 17:40 ` Jörn Engel
2007-06-11 23:28 ` Jörn Engel
2007-06-11 23:28 ` Jörn Engel
2007-06-11 23:28 ` Jörn Engel
2007-06-11 23:51 ` Arnd Bergmann
2007-06-11 23:51 ` Arnd Bergmann
2007-06-11 23:51 ` Arnd Bergmann
2007-06-11 23:57 ` Jörn Engel
2007-06-11 23:57 ` Jörn Engel
2007-06-03 18:47 ` [Patch 11/18] fs/logfs/journal.c Jörn Engel
2007-06-03 20:00 ` Jörn Engel
2007-06-03 18:47 ` [Patch 12/18] fs/logfs/memtree.c Jörn Engel
2007-06-03 20:43 ` Jörn Engel
2007-06-03 18:48 ` [Patch 13/18] fs/logfs/readwrite.c Jörn Engel
2007-06-03 20:57 ` Jörn Engel
2007-06-03 18:48 ` [Patch 14/18] fs/logfs/segment.c Jörn Engel
2007-06-03 20:14 ` Jörn Engel
2007-06-03 22:21 ` Arnd Bergmann
2007-06-03 22:21 ` Arnd Bergmann
2007-06-03 22:21 ` Arnd Bergmann
2007-06-04 9:07 ` Jörn Engel
2007-06-04 9:07 ` Jörn Engel
2007-06-04 9:07 ` Jörn Engel
2007-06-03 18:49 ` [Patch 15/18] fs/logfs/super.c Jörn Engel
2007-06-03 20:42 ` Jörn Engel
2007-06-10 16:27 ` Arnd Bergmann
2007-06-10 16:27 ` Arnd Bergmann
2007-06-10 16:27 ` Arnd Bergmann
2007-06-10 17:38 ` Jörn Engel
2007-06-10 17:38 ` Jörn Engel
2007-06-10 17:38 ` Jörn Engel
2007-06-10 18:33 ` Arnd Bergmann
2007-06-10 18:33 ` Arnd Bergmann
2007-06-10 18:33 ` Arnd Bergmann
2007-06-10 19:10 ` Jörn Engel
2007-06-10 19:10 ` Jörn Engel
2007-06-10 19:20 ` Willy Tarreau
2007-06-10 19:20 ` Willy Tarreau
2007-06-10 19:20 ` Willy Tarreau
2007-06-03 18:50 ` [Patch 16/18] fs/logfs/progs/fsck.c Jörn Engel
2007-06-03 19:00 ` Jörn Engel
2007-06-03 18:50 ` [Patch 17/18] fs/logfs/progs/mkfs.c Jörn Engel
2007-06-03 19:01 ` Jörn Engel
2007-06-03 18:51 ` [Patch 18/18] fs/logfs/Locking Jörn Engel
2007-06-03 21:21 ` Jörn Engel
2007-06-03 19:17 ` LogFS take four Jan-Benedict Glaw
2007-06-03 19:20 ` Jan-Benedict Glaw
2007-06-03 19:19 ` Jörn Engel
2007-06-03 19:19 ` Jörn Engel
2007-06-03 22:18 ` Arnd Bergmann
2007-06-03 22:18 ` Arnd Bergmann
2007-06-03 22:18 ` Arnd Bergmann
2007-06-04 9:05 ` Jörn Engel
2007-06-04 9:05 ` Jörn Engel
2007-06-04 9:05 ` Jörn Engel
2007-06-06 13:50 ` Alexander Belyakov
2007-06-06 13:58 ` Jörn Engel
2007-06-15 8:37 ` Evgeniy Polyakov
2007-06-15 8:37 ` Evgeniy Polyakov
2007-06-15 8:37 ` Evgeniy Polyakov
2007-06-15 11:10 ` Jörn Engel
2007-06-15 11:10 ` Jörn Engel
2007-06-15 11:10 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46669A89.3010500@grupopie.com \
--to=pmarques@grupopie.com \
--cc=acahalan@gmail.com \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=cat@zip.com.au \
--cc=davidsen@tmr.com \
--cc=djshin90@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jamie@shareable.org \
--cc=jengelh@linux01.gwdg.de \
--cc=joern@lazybastard.org \
--cc=john@stoffel.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mrmacman_g4@mac.com \
--cc=pavel@ucw.cz \
--cc=penberg@cs.helsinki.fi \
--cc=rdreier@cisco.com \
--cc=sam@ravnborg.org \
--cc=santiago@crfreenet.org \
--cc=tao@acc.umu.se \
--cc=tglx@linutronix.de \
--cc=ulissesf@gmail.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.