From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)
Date: Thu, 26 Jul 2007 21:28:00 +0200 [thread overview]
Message-ID: <200707262128.00777.bzolnier@gmail.com> (raw)
In-Reply-To: <20070725165318.5331.23795.stgit@localhost.localdomain>
Hi,
On Wednesday 25 July 2007, Vitaly Bordug wrote:
>
> This is now very similar to pata_platform.c, they both use
> same platform data structure and same resources.
>
> To achieve that, byte_lanes_swapping platform data variable
> and platform specified iops removed from that driver. It's fine,
> since those were never used anyway.
>
> pata_platform and ide_platform are carrying same driver names,
> to easily switch between these drivers, without need to touch
> platform code.
Looks really good, thanks for working on this.
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Signed-off-by: Vitaly Bordug <vitb@kernel.crashing.org>
applied but it would be also nice to fix minor issues found by Sergei
(please just send a new version of the patch and I will replace this
version with the newer one in my tree)
patch #2/2 also looks fine and when issues raised by Sergei gets
addressed it will be merged
Thanks,
Bart
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)
Date: Thu, 26 Jul 2007 21:28:00 +0200 [thread overview]
Message-ID: <200707262128.00777.bzolnier@gmail.com> (raw)
In-Reply-To: <20070725165318.5331.23795.stgit@localhost.localdomain>
Hi,
On Wednesday 25 July 2007, Vitaly Bordug wrote:
>
> This is now very similar to pata_platform.c, they both use
> same platform data structure and same resources.
>
> To achieve that, byte_lanes_swapping platform data variable
> and platform specified iops removed from that driver. It's fine,
> since those were never used anyway.
>
> pata_platform and ide_platform are carrying same driver names,
> to easily switch between these drivers, without need to touch
> platform code.
Looks really good, thanks for working on this.
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Signed-off-by: Vitaly Bordug <vitb@kernel.crashing.org>
applied but it would be also nice to fix minor issues found by Sergei
(please just send a new version of the patch and I will replace this
version with the newer one in my tree)
patch #2/2 also looks fine and when issues raised by Sergei gets
addressed it will be merged
Thanks,
Bart
next prev parent reply other threads:[~2007-07-26 19:59 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 16:53 [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver) Vitaly Bordug
2007-07-25 16:53 ` Vitaly Bordug
2007-07-25 16:53 ` Vitaly Bordug
2007-07-25 16:53 ` [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface Vitaly Bordug
2007-07-25 16:53 ` Vitaly Bordug
2007-07-25 16:53 ` Vitaly Bordug
2007-07-25 17:06 ` Sergei Shtylyov
2007-07-25 17:06 ` Sergei Shtylyov
2007-07-25 17:54 ` Sergei Shtylyov
2007-07-25 18:01 ` Scott Wood
2007-07-25 18:01 ` Scott Wood
2007-07-25 18:19 ` Sergei Shtylyov
2007-07-25 18:19 ` Sergei Shtylyov
2007-07-25 18:39 ` Scott Wood
2007-07-25 18:39 ` Scott Wood
2007-07-25 19:30 ` Sergei Shtylyov
2007-07-25 19:30 ` Sergei Shtylyov
2007-07-26 16:24 ` Sergei Shtylyov
2007-07-26 16:24 ` Sergei Shtylyov
2007-07-31 22:47 ` Segher Boessenkool
2007-07-31 22:47 ` Segher Boessenkool
2007-07-25 18:29 ` Sergei Shtylyov
2007-07-25 18:29 ` Sergei Shtylyov
2007-07-25 18:46 ` Scott Wood
2007-07-25 18:46 ` Scott Wood
2007-07-26 17:21 ` Vitaly Bordug
2007-07-26 17:21 ` Vitaly Bordug
2007-07-26 17:45 ` Sergei Shtylyov
2007-07-26 17:45 ` Sergei Shtylyov
2007-07-31 22:36 ` Segher Boessenkool
2007-07-31 22:36 ` Segher Boessenkool
2007-07-31 23:56 ` Alan Cox
2007-07-31 23:56 ` Alan Cox
2007-08-06 17:19 ` Segher Boessenkool
2007-08-06 17:19 ` Segher Boessenkool
2007-08-01 13:11 ` Sergei Shtylyov
2007-08-01 13:11 ` Sergei Shtylyov
2007-07-26 17:12 ` Vitaly Bordug
2007-07-26 17:12 ` Vitaly Bordug
2007-07-25 17:29 ` Scott Wood
2007-07-25 17:29 ` Scott Wood
2007-07-25 17:43 ` [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver) Alan Cox
2007-07-25 17:43 ` Alan Cox
2007-07-26 19:28 ` Bartlomiej Zolnierkiewicz
2007-07-26 19:28 ` Bartlomiej Zolnierkiewicz
2007-07-25 17:59 ` Kumar Gala
2007-07-25 17:59 ` Kumar Gala
2007-07-25 19:00 ` Sergei Shtylyov
2007-07-25 19:00 ` Sergei Shtylyov
2007-07-25 19:05 ` Scott Wood
2007-07-25 19:05 ` Scott Wood
2007-07-25 19:16 ` Sergei Shtylyov
2007-07-25 19:16 ` Sergei Shtylyov
2007-07-25 19:17 ` [PATCH 1/2] [IDE] Platform IDE driver Scott Wood
2007-07-25 19:17 ` Scott Wood
2007-07-25 19:35 ` Sergei Shtylyov
2007-07-25 19:35 ` Sergei Shtylyov
2007-07-31 22:31 ` Segher Boessenkool
2007-07-31 22:31 ` Segher Boessenkool
2007-08-01 12:39 ` Sergei Shtylyov
2007-08-01 12:39 ` Sergei Shtylyov
2007-08-06 17:16 ` Segher Boessenkool
2007-08-06 17:16 ` Segher Boessenkool
2007-07-25 19:37 ` [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver) Guennadi Liakhovetski
2007-07-25 19:37 ` Guennadi Liakhovetski
2007-07-25 19:48 ` Sergei Shtylyov
2007-07-25 19:48 ` Sergei Shtylyov
2007-07-25 19:54 ` Guennadi Liakhovetski
2007-07-25 19:54 ` Guennadi Liakhovetski
2007-07-25 20:01 ` Sergei Shtylyov
2007-07-25 20:01 ` Sergei Shtylyov
2007-07-25 20:09 ` Guennadi Liakhovetski
2007-07-25 20:09 ` Guennadi Liakhovetski
2007-07-25 20:39 ` Alan Cox
2007-07-25 20:39 ` Alan Cox
2007-07-26 19:41 ` Guennadi Liakhovetski
2007-07-26 19:41 ` Guennadi Liakhovetski
2007-07-26 19:52 ` Sergei Shtylyov
2007-07-26 19:52 ` Sergei Shtylyov
2007-07-26 20:13 ` Guennadi Liakhovetski
2007-07-26 20:11 ` Bartlomiej Zolnierkiewicz
2007-07-26 20:11 ` Bartlomiej Zolnierkiewicz
2007-07-26 19:28 ` Bartlomiej Zolnierkiewicz [this message]
2007-07-26 19:28 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707262128.00777.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=vitb@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.