From: Segher Boessenkool <segher@kernel.crashing.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface
Date: Wed, 1 Aug 2007 00:36:14 +0200 [thread overview]
Message-ID: <a414f3b506b7802a717e6e2c08befd1e@kernel.crashing.org> (raw)
In-Reply-To: <46A78E3F.1030904@ru.mvista.com>
>>> + ide@f0000000 {
>>> + compatible = "mmio-ide";
>>> + device_type = "ide";
>
>> Why not "ata"?
The hardware is called (E)IDE, the protocol is called ATA.
Or that's what I was told -- I think there's some historic
revisionism involved, too.
> Also, what mmio-ide in the compat properly means in the context of
> ide_platform which is able to handle both port and memory mapped IDE.
> I think
> we must get rid with this crap, and since this IDE register mapping is
> pretty
> much board specific, call it something like "mpc8349emitx-ide" instead.
"mmio-ide" simply is not specific enough. The device_type
should go, too.
If this IDE interface is board-specific, thee "compatible"
property should include the board vendor name and board
name. Oh, that's what "emitx" tries to do -- it could be
a bit clearer perhaps ;-)
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Vitaly Bordug <vitb@kernel.crashing.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface
Date: Wed, 1 Aug 2007 00:36:14 +0200 [thread overview]
Message-ID: <a414f3b506b7802a717e6e2c08befd1e@kernel.crashing.org> (raw)
In-Reply-To: <46A78E3F.1030904@ru.mvista.com>
>>> + ide@f0000000 {
>>> + compatible = "mmio-ide";
>>> + device_type = "ide";
>
>> Why not "ata"?
The hardware is called (E)IDE, the protocol is called ATA.
Or that's what I was told -- I think there's some historic
revisionism involved, too.
> Also, what mmio-ide in the compat properly means in the context of
> ide_platform which is able to handle both port and memory mapped IDE.
> I think
> we must get rid with this crap, and since this IDE register mapping is
> pretty
> much board specific, call it something like "mpc8349emitx-ide" instead.
"mmio-ide" simply is not specific enough. The device_type
should go, too.
If this IDE interface is board-specific, thee "compatible"
property should include the board vendor name and board
name. Oh, that's what "emitx" tries to do -- it could be
a bit clearer perhaps ;-)
Segher
next prev parent reply other threads:[~2007-07-31 22:36 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 16:53 [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver) Vitaly Bordug
2007-07-25 16:53 ` Vitaly Bordug
2007-07-25 16:53 ` Vitaly Bordug
2007-07-25 16:53 ` [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface Vitaly Bordug
2007-07-25 16:53 ` Vitaly Bordug
2007-07-25 16:53 ` Vitaly Bordug
2007-07-25 17:06 ` Sergei Shtylyov
2007-07-25 17:06 ` Sergei Shtylyov
2007-07-25 17:54 ` Sergei Shtylyov
2007-07-25 18:01 ` Scott Wood
2007-07-25 18:01 ` Scott Wood
2007-07-25 18:19 ` Sergei Shtylyov
2007-07-25 18:19 ` Sergei Shtylyov
2007-07-25 18:39 ` Scott Wood
2007-07-25 18:39 ` Scott Wood
2007-07-25 19:30 ` Sergei Shtylyov
2007-07-25 19:30 ` Sergei Shtylyov
2007-07-26 16:24 ` Sergei Shtylyov
2007-07-26 16:24 ` Sergei Shtylyov
2007-07-31 22:47 ` Segher Boessenkool
2007-07-31 22:47 ` Segher Boessenkool
2007-07-25 18:29 ` Sergei Shtylyov
2007-07-25 18:29 ` Sergei Shtylyov
2007-07-25 18:46 ` Scott Wood
2007-07-25 18:46 ` Scott Wood
2007-07-26 17:21 ` Vitaly Bordug
2007-07-26 17:21 ` Vitaly Bordug
2007-07-26 17:45 ` Sergei Shtylyov
2007-07-26 17:45 ` Sergei Shtylyov
2007-07-31 22:36 ` Segher Boessenkool [this message]
2007-07-31 22:36 ` Segher Boessenkool
2007-07-31 23:56 ` Alan Cox
2007-07-31 23:56 ` Alan Cox
2007-08-06 17:19 ` Segher Boessenkool
2007-08-06 17:19 ` Segher Boessenkool
2007-08-01 13:11 ` Sergei Shtylyov
2007-08-01 13:11 ` Sergei Shtylyov
2007-07-26 17:12 ` Vitaly Bordug
2007-07-26 17:12 ` Vitaly Bordug
2007-07-25 17:29 ` Scott Wood
2007-07-25 17:29 ` Scott Wood
2007-07-25 17:43 ` [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver) Alan Cox
2007-07-25 17:43 ` Alan Cox
2007-07-26 19:28 ` Bartlomiej Zolnierkiewicz
2007-07-26 19:28 ` Bartlomiej Zolnierkiewicz
2007-07-25 17:59 ` Kumar Gala
2007-07-25 17:59 ` Kumar Gala
2007-07-25 19:00 ` Sergei Shtylyov
2007-07-25 19:00 ` Sergei Shtylyov
2007-07-25 19:05 ` Scott Wood
2007-07-25 19:05 ` Scott Wood
2007-07-25 19:16 ` Sergei Shtylyov
2007-07-25 19:16 ` Sergei Shtylyov
2007-07-25 19:17 ` [PATCH 1/2] [IDE] Platform IDE driver Scott Wood
2007-07-25 19:17 ` Scott Wood
2007-07-25 19:35 ` Sergei Shtylyov
2007-07-25 19:35 ` Sergei Shtylyov
2007-07-31 22:31 ` Segher Boessenkool
2007-07-31 22:31 ` Segher Boessenkool
2007-08-01 12:39 ` Sergei Shtylyov
2007-08-01 12:39 ` Sergei Shtylyov
2007-08-06 17:16 ` Segher Boessenkool
2007-08-06 17:16 ` Segher Boessenkool
2007-07-25 19:37 ` [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver) Guennadi Liakhovetski
2007-07-25 19:37 ` Guennadi Liakhovetski
2007-07-25 19:48 ` Sergei Shtylyov
2007-07-25 19:48 ` Sergei Shtylyov
2007-07-25 19:54 ` Guennadi Liakhovetski
2007-07-25 19:54 ` Guennadi Liakhovetski
2007-07-25 20:01 ` Sergei Shtylyov
2007-07-25 20:01 ` Sergei Shtylyov
2007-07-25 20:09 ` Guennadi Liakhovetski
2007-07-25 20:09 ` Guennadi Liakhovetski
2007-07-25 20:39 ` Alan Cox
2007-07-25 20:39 ` Alan Cox
2007-07-26 19:41 ` Guennadi Liakhovetski
2007-07-26 19:41 ` Guennadi Liakhovetski
2007-07-26 19:52 ` Sergei Shtylyov
2007-07-26 19:52 ` Sergei Shtylyov
2007-07-26 20:13 ` Guennadi Liakhovetski
2007-07-26 20:11 ` Bartlomiej Zolnierkiewicz
2007-07-26 20:11 ` Bartlomiej Zolnierkiewicz
2007-07-26 19:28 ` Bartlomiej Zolnierkiewicz
2007-07-26 19:28 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a414f3b506b7802a717e6e2c08befd1e@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.