[PATCH] Home-End keys in menu

[PATCH] Home-End keys in menu

[Carles Pina i Estany]

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]



Hello,

Last weekend we talked about "menu loop" (wrapping):
http://lists.gnu.org/archive/html/grub-devel/2008-07/msg00319.html

Conclusion: people here don't like it (we could discuss for ages, I
think :-) )

Second proposal that maybe was hidden in so much text: to make it to
work Home and End keys. Patch is attached. Do you need a more formal
changelog for this? Adds Home and End key moving.
Comments are welcomed.

Commend: I think that would be possible to change "case 14" by "case
GRUB_TERM_DOWN"; and "case 16" by "case GRUB_TERM_UP" in normal/menu.c
line 400 aprox. These constants are defined in include/grub/term.h. I
don't send a patch because it's in the same "zone" than attached patch
and it's easy-easy.

Thanks for your patience,

-- 
Carles Pina i Estany		GPG id: 0x8CBDAE64
	http://pinux.info	Manresa - Barcelona

[-- Attachment #2: home_end.patch --]
[-- Type: text/x-diff, Size: 675 bytes --]

Index: normal/menu.c
===================================================================
--- normal/menu.c	(revision 1718)
+++ normal/menu.c	(working copy)
@@ -405,6 +405,22 @@
 	  
 	  switch (c)
 	    {
+            case GRUB_TERM_HOME:
+	       first=0;
+	       offset=0;
+	       print_entries (menu, first, offset);
+	       break;
+
+	    case GRUB_TERM_END:
+	      offset = menu->size - 1;
+	      if (offset > GRUB_TERM_NUM_ENTRIES - 1)
+		{
+                  first = offset - (GRUB_TERM_NUM_ENTRIES - 1);
+		  offset = GRUB_TERM_NUM_ENTRIES - 1;
+		}
+		print_entries (menu, first, offset);
+	      break;
+
 	    case 16:
 	    case '^':
 	      if (offset > 0)

Re: [PATCH] Home-End keys in menu

[Carles Pina i Estany]

[-- Attachment #1: Type: text/plain, Size: 2341 bytes --]


Hello,

Some weeks ago I sent a patch that didn't have any discussion. I'm
sending it again, maybe everybody was in holidays :-)

Actually I updated the patch (added some spaces to comply with the
coding style).

* menu/normal.c: Add Home and End keys in grub-menu

Also, I added a comment that would be nice to change some magic numbers
to constants that already exists.

(I feel that it's a insignifcant patch compared with what I have seen
here!)

Thank you,

On Jul/21/2008, Carles Pina i Estany wrote:
> 
> 
> Hello,
> 
> Last weekend we talked about "menu loop" (wrapping):
> http://lists.gnu.org/archive/html/grub-devel/2008-07/msg00319.html
> 
> Conclusion: people here don't like it (we could discuss for ages, I
> think :-) )
> 
> Second proposal that maybe was hidden in so much text: to make it to
> work Home and End keys. Patch is attached. Do you need a more formal
> changelog for this? Adds Home and End key moving.
> Comments are welcomed.
> 
> Commend: I think that would be possible to change "case 14" by "case
> GRUB_TERM_DOWN"; and "case 16" by "case GRUB_TERM_UP" in normal/menu.c
> line 400 aprox. These constants are defined in include/grub/term.h. I
> don't send a patch because it's in the same "zone" than attached patch
> and it's easy-easy.
> 
> Thanks for your patience,
> 
> -- 
> Carles Pina i Estany		GPG id: 0x8CBDAE64
> 	http://pinux.info	Manresa - Barcelona

> Index: normal/menu.c
> ===================================================================
> --- normal/menu.c	(revision 1718)
> +++ normal/menu.c	(working copy)
> @@ -405,6 +405,22 @@
>  	  
>  	  switch (c)
>  	    {
> +            case GRUB_TERM_HOME:
> +	       first=0;
> +	       offset=0;
> +	       print_entries (menu, first, offset);
> +	       break;
> +
> +	    case GRUB_TERM_END:
> +	      offset = menu->size - 1;
> +	      if (offset > GRUB_TERM_NUM_ENTRIES - 1)
> +		{
> +                  first = offset - (GRUB_TERM_NUM_ENTRIES - 1);
> +		  offset = GRUB_TERM_NUM_ENTRIES - 1;
> +		}
> +		print_entries (menu, first, offset);
> +	      break;
> +
>  	    case 16:
>  	    case '^':
>  	      if (offset > 0)

> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel

-- 
Carles Pina i Estany		GPG id: 0x17756391
	http://pinux.info

[-- Attachment #2: home_end2.patch --]
[-- Type: text/x-diff, Size: 679 bytes --]

Index: normal/menu.c
===================================================================
--- normal/menu.c	(revision 1774)
+++ normal/menu.c	(working copy)
@@ -405,6 +405,22 @@
 	  
 	  switch (c)
 	    {
+            case GRUB_TERM_HOME:
+	       first = 0;
+	       offset = 0;
+	       print_entries (menu, first, offset);
+	       break;
+
+	    case GRUB_TERM_END:
+	      offset = menu->size - 1;
+	      if (offset > GRUB_TERM_NUM_ENTRIES - 1)
+		{
+                  first = offset - (GRUB_TERM_NUM_ENTRIES - 1);
+		  offset = GRUB_TERM_NUM_ENTRIES - 1;
+		}
+		print_entries (menu, first, offset);
+	      break;
+
 	    case 16:
 	    case '^':
 	      if (offset > 0)

Re: [PATCH] Home-End keys in menu

[Marco Gerards]

Hi,

Carles Pina i Estany <carles@pina.cat> writes:

> Some weeks ago I sent a patch that didn't have any discussion. I'm
> sending it again, maybe everybody was in holidays :-)
>
> Actually I updated the patch (added some spaces to comply with the
> coding style).
>
> * menu/normal.c: Add Home and End keys in grub-menu

The first line of the changelog entry is missing (name + e-mail
address).  Please mention the function you change like:

 * menu/normal.c (foo): Blah blah.

And end a sentence with a "."

>> Index: normal/menu.c
>> ===================================================================
>> --- normal/menu.c	(revision 1718)
>> +++ normal/menu.c	(working copy)
>> @@ -405,6 +405,22 @@
>>  	  
>>  	  switch (c)
>>  	    {
>> +            case GRUB_TERM_HOME:
>> +	       first=0;
>> +	       offset=0;
>> +	       print_entries (menu, first, offset);
>> +	       break;

The indentation of the case statement doesn't seem right...

>> +	    case GRUB_TERM_END:
>> +	      offset = menu->size - 1;
>> +	      if (offset > GRUB_TERM_NUM_ENTRIES - 1)
>> +		{
>> +                  first = offset - (GRUB_TERM_NUM_ENTRIES - 1);
>> +		  offset = GRUB_TERM_NUM_ENTRIES - 1;

This indentation also looks funny...

>> +		}
>> +		print_entries (menu, first, offset);
>> +	      break;
>> +
>>  	    case 16:
>>  	    case '^':
>>  	      if (offset > 0)
>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>
> -- 
> Carles Pina i Estany		GPG id: 0x17756391
> 	http://pinux.info
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Home-End keys in menu

[Carles Pina i Estany]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]



Hello,

On Aug/05/2008, Marco Gerards wrote:

> > Some weeks ago I sent a patch that didn't have any discussion. I'm
> > sending it again, maybe everybody was in holidays :-)
> >
> > Actually I updated the patch (added some spaces to comply with the
> > coding style).
> >
> > * menu/normal.c: Add Home and End keys in grub-menu
> 
> The first line of the changelog entry is missing (name + e-mail
> address).  Please mention the function you change like:

done! (see below)

[...]

> The indentation of the case statement doesn't seem right...

[...]

> This indentation also looks funny...

was not right (not a problem, it's fixed now).

Also, the indentation got worst in the mail :-)

Changelog:
-------
2008-08-06  Carles Pina i Estany  <carles@pina.cat>

	* menu/normal.c (run_menu): Add Home and End keys in grub-menu.
-------

Patch is attached.

Thank you,

-- 
Carles Pina i Estany		GPG id: 0x17756391
	http://pinux.info

[-- Attachment #2: home_end3.patch --]
[-- Type: text/x-diff, Size: 654 bytes --]

Index: normal/menu.c
===================================================================
--- normal/menu.c	(revision 1786)
+++ normal/menu.c	(working copy)
@@ -405,6 +405,22 @@
 	  
 	  switch (c)
 	    {
+	    case GRUB_TERM_HOME:
+	      first = 0;
+	      offset = 0;
+	      print_entries (menu, first, offset);
+	      break;
+
+	    case GRUB_TERM_END:
+	      offset = menu->size - 1;
+	      if (offset > GRUB_TERM_NUM_ENTRIES - 1)
+		{
+		  first = offset - (GRUB_TERM_NUM_ENTRIES - 1);
+		  offset = GRUB_TERM_NUM_ENTRIES - 1;
+		}
+		print_entries (menu, first, offset);
+	      break;
+
 	    case 16:
 	    case '^':
 	      if (offset > 0)

Re: [PATCH] Home-End keys in menu

[Marco Gerards]

Hi,

Carles Pina i Estany <carles@pina.cat> writes:

[...]

> 2008-08-06  Carles Pina i Estany  <carles@pina.cat>
>
> 	* menu/normal.c (run_menu): Add Home and End keys in grub-menu.


This looks fine to me at first sight.  Do others have problems with
this?  Otherwise it can be committed.

--
Marco

Re: [PATCH] Home-End keys in menu

[Robert Millan]

On Wed, Aug 13, 2008 at 12:15:37PM +0200, Marco Gerards wrote:
> Hi,
> 
> Carles Pina i Estany <carles@pina.cat> writes:
> 
> [...]
> 
> > 2008-08-06  Carles Pina i Estany  <carles@pina.cat>
> >
> > 	* menu/normal.c (run_menu): Add Home and End keys in grub-menu.
> 
> 
> This looks fine to me at first sight.  Do others have problems with
> this?  Otherwise it can be committed.

Why don't we use PgUp / PgDn instead?  That's more intuitive.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

Re: [PATCH] Home-End keys in menu

[Marco Gerards]

Robert Millan <rmh@aybabtu.com> writes:

> On Wed, Aug 13, 2008 at 12:15:37PM +0200, Marco Gerards wrote:
>> Hi,
>> 
>> Carles Pina i Estany <carles@pina.cat> writes:
>> 
>> [...]
>> 
>> > 2008-08-06  Carles Pina i Estany  <carles@pina.cat>
>> >
>> > 	* menu/normal.c (run_menu): Add Home and End keys in grub-menu.
>> 
>> 
>> This looks fine to me at first sight.  Do others have problems with
>> this?  Otherwise it can be committed.
>
> Why don't we use PgUp / PgDn instead?  That's more intuitive.

Or both?

--
Marco

Re: [PATCH] Home-End keys in menu

[Javier Martín]

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

El mié, 13-08-2008 a las 12:50 +0200, Robert Millan escribió:
> On Wed, Aug 13, 2008 at 12:15:37PM +0200, Marco Gerards wrote:
> > Hi,
> > 
> > Carles Pina i Estany <carles@pina.cat> writes:
> > 
> > [...]
> > 
> > > 2008-08-06  Carles Pina i Estany  <carles@pina.cat>
> > >
> > > 	* menu/normal.c (run_menu): Add Home and End keys in grub-menu.
> > 
> > 
> > This looks fine to me at first sight.  Do others have problems with
> > this?  Otherwise it can be committed.
> 
> Why don't we use PgUp / PgDn instead?  That's more intuitive.
> 
Users with long menu lists may expect PgUp/PgDn to take them exactly
_one_ page up or down, not the whole list... I personally think that
Home/End are more intuitive for this particular UI interaction.

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: [PATCH] Home-End keys in menu

[Robert Millan]

On Wed, Aug 13, 2008 at 01:38:27PM +0200, Javier Martín wrote:
> El mié, 13-08-2008 a las 12:50 +0200, Robert Millan escribió:
> > On Wed, Aug 13, 2008 at 12:15:37PM +0200, Marco Gerards wrote:
> > > Hi,
> > > 
> > > Carles Pina i Estany <carles@pina.cat> writes:
> > > 
> > > [...]
> > > 
> > > > 2008-08-06  Carles Pina i Estany  <carles@pina.cat>
> > > >
> > > > 	* menu/normal.c (run_menu): Add Home and End keys in grub-menu.
> > > 
> > > 
> > > This looks fine to me at first sight.  Do others have problems with
> > > this?  Otherwise it can be committed.
> > 
> > Why don't we use PgUp / PgDn instead?  That's more intuitive.
> > 
> Users with long menu lists may expect PgUp/PgDn to take them exactly
> _one_ page up or down, not the whole list... I personally think that
> Home/End are more intuitive for this particular UI interaction.

Uhm you're right.  Also, I notice this behaviour is consistent with `less'
(and since I love consistency, I must agree with you!)

I think the patch is fine in its current state.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

Re: [PATCH] Home-End keys in menu

[Carles Pina i Estany]

Hello,

I reply in this message a different things.

On Aug/13/2008, Robert Millan wrote:
> On Wed, Aug 13, 2008 at 01:38:27PM +0200, Javier Martín wrote:
> > El mié, 13-08-2008 a las 12:50 +0200, Robert Millan escribió:
> > > On Wed, Aug 13, 2008 at 12:15:37PM +0200, Marco Gerards wrote:
> > > > Hi,
> > > > 
> > > > Carles Pina i Estany <carles@pina.cat> writes:
> > > > 
> > > > [...]
> > > > 
> > > > > 2008-08-06  Carles Pina i Estany  <carles@pina.cat>
> > > > >
> > > > > 	* menu/normal.c (run_menu): Add Home and End keys in grub-menu.
> > > > 
> > > > 
> > > > This looks fine to me at first sight.  Do others have problems with
> > > > this?  Otherwise it can be committed.
> > > 
> > > Why don't we use PgUp / PgDn instead?  That's more intuitive.

I think that we should use Home/End and PgUp/PgDn for different things:

-Home/End: go straight to the first and last entry (this is done)

-PgUp/PgDn: it moves one page (I mean, selected item = selected item +
number of items)

I've implemented only Home/End key (by the moment, we can talk about
PgUp/PgDn later please :-) )

> > Users with long menu lists may expect PgUp/PgDn to take them exactly
> > _one_ page up or down, not the whole list... I personally think that
> > Home/End are more intuitive for this particular UI interaction.
> 
> Uhm you're right.  Also, I notice this behaviour is consistent with
> `less' (and since I love consistency, I must agree with you!)
> 
> I think the patch is fine in its current state.

me too ;-)

-- 
Carles Pina i Estany		GPG id: 0x17756391
	http://pinux.info

Re: [PATCH] Home-End keys in menu

[Carles Pina i Estany]

Hi,

On Aug/13/2008, Marco Gerards wrote:
> Hi,
> 
> Carles Pina i Estany <carles@pina.cat> writes:
> 
> [...]
> 
> > 2008-08-06  Carles Pina i Estany  <carles@pina.cat>
> >
> > 	* menu/normal.c (run_menu): Add Home and End keys in grub-menu.
> 
> 
> This looks fine to me at first sight.  Do others have problems with
> this?  Otherwise it can be committed.

after this comment, Robert and Javier comments, feel free (somebody) to
commit it (I cannot commit, so I will not commmit :-) -just in case
somebody is expecting that I commit myself)

The message with the patch:

http://lists.gnu.org/archive/html/grub-devel/2008-08/msg00171.html

Thanks,

-- 
Carles Pina i Estany		GPG id: 0x17756391
	http://pinux.info

Re: [PATCH] Home-End keys in menu

[Felix Zielcke]

Commited.

Am Samstag, den 16.08.2008, 20:51 +0200 schrieb Carles Pina i Estany:
> 
> Hi,
> 
> On Aug/13/2008, Marco Gerards wrote:
> > Hi,
> > 
> > Carles Pina i Estany <carles@pina.cat> writes:
> > 
> > [...]
> > 
> > > 2008-08-06  Carles Pina i Estany  <carles@pina.cat>
> > >
> > > 	* menu/normal.c (run_menu): Add Home and End keys in grub-menu.
> > 
> > 
> > This looks fine to me at first sight.  Do others have problems with
> > this?  Otherwise it can be committed.
> 
> after this comment, Robert and Javier comments, feel free (somebody) to
> commit it (I cannot commit, so I will not commmit :-) -just in case
> somebody is expecting that I commit myself)
> 
> The message with the patch:
> 
> http://lists.gnu.org/archive/html/grub-devel/2008-08/msg00171.html
> 
> Thanks,
>