All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Gleb Natapov <gleb@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] Re: virtio-serial: An interface for host-guest communication
Date: Wed, 5 Aug 2009 19:00:49 +0100	[thread overview]
Message-ID: <20090805180049.GC28738@shareable.org> (raw)
In-Reply-To: <20090729074827.GJ30449@redhat.com>

Gleb Natapov wrote:
> On Wed, Jul 29, 2009 at 01:14:18PM +0530, Amit Shah wrote:
> > But why do we want to limit the device to only one port? It's not too
> > complex supporting additional ones.
> > 
> > As I see it qemu and the kernel should provide the basic abstraction for
> > the userspace to go do its job. Why create unnecessary barriers?
> > 
> I agree. If userspace wants it may use only one channel and demultiplex
> messages by itself, but we shouldn't force it to. Also one of the
> requirements for virtio-serial is to have connect disconnect
> notifications. It is not possible with demultiplexing in the userspace.

I agree too, for all those reasons.

However it would be useful if the devices provided a simpler way to be
found by guest applications than /dev/vmch0, vmch1, vmch2...

On Linux udev provides a sane way to find devices according to roles,
subtypes, serial numbers, whatever you want, if the appropriate id
codes are available from the devices and put into /sys/* by the kernel
driver.  That would make the devices much more useful to independent
applications, imho.

-- Jamie

WARNING: multiple messages have this Message-ID (diff)
From: Jamie Lokier <jamie@shareable.org>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
	virtualization@lists.linux-foundation.org,
	Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] Re: virtio-serial: An interface for host-guest communication
Date: Wed, 5 Aug 2009 19:00:49 +0100	[thread overview]
Message-ID: <20090805180049.GC28738@shareable.org> (raw)
In-Reply-To: <20090729074827.GJ30449@redhat.com>

Gleb Natapov wrote:
> On Wed, Jul 29, 2009 at 01:14:18PM +0530, Amit Shah wrote:
> > But why do we want to limit the device to only one port? It's not too
> > complex supporting additional ones.
> > 
> > As I see it qemu and the kernel should provide the basic abstraction for
> > the userspace to go do its job. Why create unnecessary barriers?
> > 
> I agree. If userspace wants it may use only one channel and demultiplex
> messages by itself, but we shouldn't force it to. Also one of the
> requirements for virtio-serial is to have connect disconnect
> notifications. It is not possible with demultiplexing in the userspace.

I agree too, for all those reasons.

However it would be useful if the devices provided a simpler way to be
found by guest applications than /dev/vmch0, vmch1, vmch2...

On Linux udev provides a sane way to find devices according to roles,
subtypes, serial numbers, whatever you want, if the appropriate id
codes are available from the devices and put into /sys/* by the kernel
driver.  That would make the devices much more useful to independent
applications, imho.

-- Jamie

  parent reply	other threads:[~2009-08-05 18:00 UTC|newest]

Thread overview: 175+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-27 18:04 virtio-serial: An interface for host-guest communication Amit Shah
2009-07-27 18:04 ` [Qemu-devel] " Amit Shah
2009-07-27 18:04 ` [PATCH 1/1] virtio_serial: A char device for simple guest <-> host communication Amit Shah
2009-07-27 18:04 ` Amit Shah
2009-07-27 18:04   ` [Qemu-devel] " Amit Shah
2009-07-27 18:04   ` [PATCH 1/3] virtio-serial: virtio device for simple host <-> guest communication Amit Shah
2009-07-27 18:04   ` Amit Shah
2009-07-27 18:04     ` [Qemu-devel] " Amit Shah
2009-07-27 18:04     ` [PATCH 2/3] vnc: add a is_vnc_active() helper Amit Shah
2009-07-27 18:04       ` [Qemu-devel] " Amit Shah
2009-07-27 18:04       ` [PATCH 3/3] virtio-serial: vnc: support for sending / receiving guest clipboard Amit Shah
2009-07-27 18:04         ` [Qemu-devel] " Amit Shah
2009-07-27 18:04       ` Amit Shah
2009-07-27 18:04     ` [PATCH 2/3] vnc: add a is_vnc_active() helper Amit Shah
2009-08-05  0:03   ` [PATCH 1/1] virtio_serial: A char device for simple guest <-> host communication Rusty Russell
2009-08-05  0:03   ` Rusty Russell
2009-08-05  0:03     ` [Qemu-devel] " Rusty Russell
2009-08-05  5:12     ` Amit Shah
2009-08-05  5:12       ` [Qemu-devel] " Amit Shah
2009-08-05  9:58     ` Amit Shah
2009-08-05  9:58     ` Amit Shah
2009-08-05  9:58       ` [Qemu-devel] " Amit Shah
2009-07-27 20:22 ` virtio-serial: An interface for host-guest communication Anthony Liguori
2009-07-27 20:22   ` [Qemu-devel] " Anthony Liguori
2009-07-27 20:32   ` Daniel P. Berrange
2009-07-27 20:32   ` Daniel P. Berrange
2009-07-27 20:37     ` Anthony Liguori
2009-07-27 20:37     ` Anthony Liguori
2009-07-27 20:46     ` Jamie Lokier
2009-07-27 20:46     ` Jamie Lokier
2009-07-27 20:46       ` Jamie Lokier
2009-07-27 23:44       ` Anthony Liguori
2009-07-27 23:44       ` Anthony Liguori
2009-07-27 23:44         ` Anthony Liguori
2009-07-28 10:36         ` Amit Shah
2009-07-28 10:36         ` Amit Shah
2009-07-28 10:36           ` Amit Shah
2009-07-28 13:42           ` Anthony Liguori
2009-07-28 13:42           ` Anthony Liguori
2009-07-29  7:44             ` Amit Shah
2009-07-29  7:44               ` Amit Shah
2009-07-29  7:48               ` Gleb Natapov
2009-07-29  7:48               ` Gleb Natapov
2009-07-29  7:48                 ` Gleb Natapov
2009-08-05 18:00                 ` Jamie Lokier
2009-08-05 18:00                 ` Jamie Lokier [this message]
2009-08-05 18:00                   ` Jamie Lokier
2009-07-29  7:44             ` Amit Shah
2009-07-28 14:00         ` Richard W.M. Jones
2009-07-28 14:48           ` Anthony Liguori
2009-07-28 14:48           ` Anthony Liguori
2009-07-28 14:55             ` Richard W.M. Jones
2009-07-28 15:00               ` Anthony Liguori
2009-07-28 15:00               ` Anthony Liguori
2009-07-28 14:55             ` Richard W.M. Jones
2009-08-03 19:57           ` Anthony Liguori
2009-08-05 17:57             ` Jamie Lokier
2009-08-05 17:57             ` Jamie Lokier
2009-08-05 17:57               ` Jamie Lokier
2009-08-05 18:00               ` Anthony Liguori
2009-08-05 18:00               ` Anthony Liguori
2009-08-05 18:00                 ` Anthony Liguori
2009-08-06 10:38                 ` Amit Shah
2009-08-06 10:38                 ` Amit Shah
2009-08-06 10:38                   ` Amit Shah
2009-08-06 13:29                   ` Anthony Liguori
2009-08-06 13:29                   ` Anthony Liguori
2009-08-06 13:29                     ` Anthony Liguori
2009-08-06 13:41                     ` Amit Shah
2009-08-06 13:41                       ` Amit Shah
2009-08-06 13:58                       ` Anthony Liguori
2009-08-06 13:58                       ` Anthony Liguori
2009-08-06 13:58                         ` Anthony Liguori
2009-08-06 14:04                         ` Amit Shah
2009-08-06 14:04                         ` Amit Shah
2009-08-06 14:04                           ` Amit Shah
2009-08-06 17:37                           ` Jamie Lokier
2009-08-06 17:37                           ` Jamie Lokier
2009-08-06 17:37                             ` Jamie Lokier
2009-08-07  6:38                             ` Amit Shah
2009-08-07  6:38                               ` Amit Shah
2009-08-07 14:14                               ` Anthony Liguori
2009-08-07 14:14                                 ` Anthony Liguori
2009-08-10  6:55                                 ` Amit Shah
2009-08-10  6:55                                   ` Amit Shah
2009-08-10  9:47                                   ` Gerd Hoffmann
2009-08-10  9:47                                     ` Gerd Hoffmann
2009-08-10 13:02                                     ` Anthony Liguori
2009-08-10 13:02                                     ` Anthony Liguori
2009-08-10 13:02                                       ` Anthony Liguori
2009-08-10 14:02                                       ` Gerd Hoffmann
2009-08-10 14:02                                         ` Gerd Hoffmann
2009-08-10 14:20                                         ` Anthony Liguori
2009-08-10 14:20                                           ` Anthony Liguori
2009-08-10 15:34                                           ` Gerd Hoffmann
2009-08-10 15:34                                             ` Gerd Hoffmann
2009-08-10 16:59                                             ` Anthony Liguori
2009-08-10 16:59                                               ` Anthony Liguori
2009-08-10 17:27                                               ` Anthony Liguori
2009-08-10 17:27                                               ` Anthony Liguori
2009-08-10 17:27                                                 ` Anthony Liguori
2009-08-12 18:27                                               ` Paul Brook
2009-08-12 18:27                                               ` Paul Brook
2009-08-12 18:27                                                 ` Paul Brook
2009-08-14  8:15                                               ` Amit Shah
2009-08-14  8:15                                                 ` Amit Shah
2009-08-14 13:29                                                 ` Anthony Liguori
2009-08-14 13:29                                                 ` Anthony Liguori
2009-08-14 13:29                                                   ` Anthony Liguori
2009-08-14 13:41                                                   ` Amit Shah
2009-08-14 13:41                                                     ` Amit Shah
2009-08-14 13:41                                                   ` Amit Shah
2009-08-20 13:42                                                   ` Amit Shah
2009-08-20 13:42                                                   ` Amit Shah
2009-08-20 13:42                                                     ` Amit Shah
2009-08-20 14:25                                                     ` Daniel P. Berrange
2009-08-20 14:25                                                       ` Daniel P. Berrange
2009-08-20 14:38                                                       ` Amit Shah
2009-08-20 14:38                                                         ` Amit Shah
2009-08-20 14:42                                                         ` Amit Shah
2009-08-20 14:42                                                         ` Amit Shah
2009-08-20 14:42                                                           ` Amit Shah
2009-08-14 13:49                                                 ` Gerd Hoffmann
2009-08-14 13:49                                                   ` Gerd Hoffmann
2009-08-14 16:25                                                   ` Anthony Liguori
2009-08-14 16:25                                                     ` Anthony Liguori
2009-08-20  7:31                                                     ` Rusty Russell
2009-08-20  7:31                                                     ` Rusty Russell
2009-08-20  7:31                                                       ` Rusty Russell
2009-08-20  7:44                                                       ` Gerd Hoffmann
2009-08-20  7:44                                                         ` Gerd Hoffmann
2009-08-20  7:55                                                         ` Amit Shah
2009-08-20  7:55                                                           ` Amit Shah
2009-08-20 17:10                                                           ` Jamie Lokier
2009-08-20 17:10                                                           ` Jamie Lokier
2009-08-20 17:10                                                             ` Jamie Lokier
2009-08-20  7:55                                                         ` Amit Shah
2009-08-25 12:43                                                         ` Rusty Russell
2009-08-25 12:43                                                           ` Rusty Russell
2009-08-25 13:00                                                           ` Gerd Hoffmann
2009-08-25 13:00                                                             ` Gerd Hoffmann
2009-08-25 13:00                                                           ` Gerd Hoffmann
2009-08-25 12:43                                                         ` Rusty Russell
2009-08-20  7:44                                                       ` Gerd Hoffmann
2009-08-14 16:25                                                   ` Anthony Liguori
2009-08-14  8:15                                               ` Amit Shah
2009-08-10 16:59                                             ` Anthony Liguori
2009-08-10 15:34                                           ` Gerd Hoffmann
2009-08-10 14:20                                         ` Anthony Liguori
2009-08-10 14:20                                         ` Anthony Liguori
2009-08-10 14:20                                         ` Anthony Liguori
2009-08-10 14:20                                           ` Anthony Liguori
2009-08-10 14:02                                       ` Gerd Hoffmann
2009-08-10 23:09                                     ` Rusty Russell
2009-08-10 23:09                                     ` Rusty Russell
2009-08-10 23:09                                       ` Rusty Russell
2009-08-11  0:16                                       ` Anthony Liguori
2009-08-11  0:16                                       ` Anthony Liguori
2009-08-11  0:16                                         ` Anthony Liguori
2009-08-10  9:47                                   ` Gerd Hoffmann
2009-08-10 14:27                                   ` Anthony Liguori
2009-08-10 14:27                                     ` Anthony Liguori
2009-08-10 15:57                                     ` Gerd Hoffmann
2009-08-10 15:57                                     ` Gerd Hoffmann
2009-08-10 15:57                                       ` Gerd Hoffmann
2009-08-07  6:38                             ` Amit Shah
2009-08-06 13:41                     ` Amit Shah
2009-08-06 10:35               ` Amit Shah
2009-08-06 10:35               ` Amit Shah
2009-08-06 10:35                 ` Amit Shah
2009-08-05 18:32             ` Richard W.M. Jones
2009-08-05 18:32             ` Richard W.M. Jones
2009-08-03 19:57           ` Anthony Liguori
2009-07-28 14:00         ` Richard W.M. Jones
2009-07-27 20:22 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090805180049.GC28738@shareable.org \
    --to=jamie@shareable.org \
    --cc=amit.shah@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=berrange@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.