From: Jamie Lokier <jamie@shareable.org>
To: Adam Litke <agl@us.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2)
Date: Mon, 9 Nov 2009 19:00:01 +0000 [thread overview]
Message-ID: <20091109190001.GA3808@shareable.org> (raw)
In-Reply-To: <1257782838.2835.5.camel@aglitke>
Adam Litke wrote:
> + s->stats.pswapin = has_feature(dev, VIRTIO_BALLOON_F_RPT_SWAP_OUT) ?
> + dev->stats.pswapin : -1;
(etc.)
Why not simply have the guest fill in the unused fields with -1, and
say that's how "no meaningful value" is represented in the ABI?
All guests have to know about all those fields anyway, for the
structure layout. Is there any benefit to specifying feature bits in
advance over simply storing -1 there?
-- Jamie
next prev parent reply other threads:[~2009-11-09 19:00 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 16:07 [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2) Adam Litke
2009-11-09 16:32 ` virtio: Add memory statistics reporting to the balloon driver Adam Litke
2009-11-09 16:32 ` [Qemu-devel] " Adam Litke
2009-11-10 2:42 ` Rusty Russell
2009-11-10 2:42 ` [Qemu-devel] " Rusty Russell
2009-11-10 2:42 ` Rusty Russell
2009-11-10 2:42 ` [Qemu-devel] " Rusty Russell
2009-11-10 14:36 ` Anthony Liguori
2009-11-10 14:36 ` Anthony Liguori
2009-11-10 14:43 ` Avi Kivity
2009-11-10 14:43 ` Avi Kivity
2009-11-10 14:43 ` Avi Kivity
2009-11-10 14:58 ` Anthony Liguori
2009-11-10 14:58 ` Anthony Liguori
2009-11-10 14:58 ` Anthony Liguori
2009-11-11 9:24 ` Jamie Lokier
2009-11-11 9:24 ` Jamie Lokier
2009-11-11 9:24 ` Jamie Lokier
2009-11-11 10:12 ` Daniel P. Berrange
2009-11-11 10:12 ` Daniel P. Berrange
2009-11-11 13:26 ` Adam Litke
2009-11-11 13:26 ` Adam Litke
2009-11-11 13:26 ` Adam Litke
2009-11-11 15:00 ` Avi Kivity
2009-11-11 15:00 ` Avi Kivity
2009-11-11 15:00 ` Avi Kivity
2009-11-11 10:12 ` Daniel P. Berrange
2009-11-10 23:59 ` Rusty Russell
2009-11-10 23:59 ` Rusty Russell
2009-11-10 23:59 ` Rusty Russell
2009-11-10 14:36 ` Anthony Liguori
2009-11-10 21:52 ` Anthony Liguori
2009-11-10 21:52 ` [Qemu-devel] " Anthony Liguori
2009-11-11 0:02 ` Rusty Russell
2009-11-11 0:02 ` [Qemu-devel] " Rusty Russell
2009-11-11 0:07 ` Anthony Liguori
2009-11-11 0:07 ` Anthony Liguori
2009-11-11 0:07 ` [Qemu-devel] " Anthony Liguori
2009-11-11 2:43 ` Rusty Russell
2009-11-11 2:43 ` [Qemu-devel] " Rusty Russell
2009-11-11 15:08 ` Adam Litke
2009-11-11 15:08 ` Adam Litke
2009-11-11 15:08 ` [Qemu-devel] " Adam Litke
2009-11-12 2:29 ` Rusty Russell
2009-11-12 2:29 ` Rusty Russell
2009-11-12 2:29 ` [Qemu-devel] " Rusty Russell
2009-11-11 2:43 ` Rusty Russell
2009-11-11 0:02 ` Rusty Russell
2009-11-10 21:52 ` Anthony Liguori
2009-11-10 2:42 ` [Qemu-devel] " Rusty Russell
2009-11-09 16:32 ` Adam Litke
2009-11-09 19:00 ` Jamie Lokier [this message]
2009-11-09 19:16 ` [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2) Adam Litke
2009-11-09 21:15 ` Anthony Liguori
2009-11-10 13:23 ` Jamie Lokier
2009-11-09 19:01 ` Jamie Lokier
2009-11-09 19:23 ` Adam Litke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109190001.GA3808@shareable.org \
--to=jamie@shareable.org \
--cc=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.