All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Adam Litke <agl@us.ibm.com>
Cc: qemu-devel@nongnu.org, "Anthony Liguori" <aliguori@us.ibm.com>,
	Avi Kivity <avi@redhat.com>,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: virtio: Add memory statistics reporting to the balloon driver
Date: Tue, 10 Nov 2009 13:12:02 +1030	[thread overview]
Message-ID: <200911101312.02650.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1257784326.2835.16.camel@aglitke>

On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote:
> A simpler approach is to collect memory statistics in the virtio
> balloon driver and communicate them to the host via the device config space.

There are two issues I see with this.  First, there's an atomicity problem
since you can't tell when the stats are consistent.  Second, polling is
ugly.

A stats vq might solve this more cleanly?
Rusty.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-kernel@vger.kernel.org,
	Anthony Liguori <aliguori@us.ibm.com>,
	virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org,
	Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver
Date: Tue, 10 Nov 2009 13:12:02 +1030	[thread overview]
Message-ID: <200911101312.02650.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1257784326.2835.16.camel@aglitke>

On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote:
> A simpler approach is to collect memory statistics in the virtio
> balloon driver and communicate them to the host via the device config space.

There are two issues I see with this.  First, there's an atomicity problem
since you can't tell when the stats are consistent.  Second, polling is
ugly.

A stats vq might solve this more cleanly?
Rusty.

  parent reply	other threads:[~2009-11-10  2:42 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09 16:07 [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2) Adam Litke
2009-11-09 16:32 ` virtio: Add memory statistics reporting to the balloon driver Adam Litke
2009-11-09 16:32   ` [Qemu-devel] " Adam Litke
2009-11-10  2:42   ` Rusty Russell
2009-11-10  2:42   ` [Qemu-devel] " Rusty Russell
2009-11-10  2:42   ` Rusty Russell [this message]
2009-11-10  2:42     ` Rusty Russell
2009-11-10 14:36     ` Anthony Liguori
2009-11-10 14:36     ` Anthony Liguori
2009-11-10 14:36       ` Anthony Liguori
2009-11-10 14:43       ` Avi Kivity
2009-11-10 14:43         ` Avi Kivity
2009-11-10 14:58         ` Anthony Liguori
2009-11-10 14:58         ` Anthony Liguori
2009-11-10 14:58           ` Anthony Liguori
2009-11-11  9:24           ` Jamie Lokier
2009-11-11  9:24             ` Jamie Lokier
2009-11-11 10:12             ` Daniel P. Berrange
2009-11-11 10:12               ` Daniel P. Berrange
2009-11-11 13:26               ` Adam Litke
2009-11-11 13:26               ` Adam Litke
2009-11-11 13:26                 ` Adam Litke
2009-11-11 15:00                 ` Avi Kivity
2009-11-11 15:00                 ` Avi Kivity
2009-11-11 15:00                   ` Avi Kivity
2009-11-11 10:12             ` Daniel P. Berrange
2009-11-11  9:24           ` Jamie Lokier
2009-11-10 14:43       ` Avi Kivity
2009-11-10 23:59       ` Rusty Russell
2009-11-10 23:59         ` Rusty Russell
2009-11-10 23:59       ` Rusty Russell
2009-11-10 21:52     ` Anthony Liguori
2009-11-10 21:52     ` Anthony Liguori
2009-11-10 21:52       ` [Qemu-devel] " Anthony Liguori
2009-11-11  0:02       ` Rusty Russell
2009-11-11  0:02       ` Rusty Russell
2009-11-11  0:02         ` [Qemu-devel] " Rusty Russell
2009-11-11  0:07         ` Anthony Liguori
2009-11-11  0:07           ` [Qemu-devel] " Anthony Liguori
2009-11-11  2:43           ` Rusty Russell
2009-11-11  2:43             ` [Qemu-devel] " Rusty Russell
2009-11-11 15:08             ` Adam Litke
2009-11-11 15:08             ` Adam Litke
2009-11-11 15:08               ` [Qemu-devel] " Adam Litke
2009-11-12  2:29               ` Rusty Russell
2009-11-12  2:29               ` Rusty Russell
2009-11-12  2:29                 ` [Qemu-devel] " Rusty Russell
2009-11-11  2:43           ` Rusty Russell
2009-11-11  0:07         ` Anthony Liguori
2009-11-10  2:42   ` [Qemu-devel] " Rusty Russell
2009-11-09 16:32 ` Adam Litke
2009-11-09 19:00 ` [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2) Jamie Lokier
2009-11-09 19:16   ` Adam Litke
2009-11-09 21:15   ` Anthony Liguori
2009-11-10 13:23     ` Jamie Lokier
2009-11-09 19:01 ` Jamie Lokier
2009-11-09 19:23   ` Adam Litke
  -- strict thread matches above, loose matches on Subject: below --
2009-11-05 22:50 [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning Adam Litke
2009-11-05 23:02 ` [Qemu-devel] virtio: Add memory statistics reporting to the balloon driver Adam Litke
2009-11-05 23:39   ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911101312.02650.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=agl@us.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.