From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Adam Litke <agl@us.ibm.com>,
linux-kernel@vger.kernel.org,
Anthony Liguori <aliguori@us.ibm.com>,
virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver
Date: Tue, 10 Nov 2009 16:43:38 +0200 [thread overview]
Message-ID: <4AF97C1A.2080609@redhat.com> (raw)
In-Reply-To: <4AF97A5E.1070801@codemonkey.ws>
On 11/10/2009 04:36 PM, Anthony Liguori wrote:
>
>> A stats vq might solve this more cleanly?
>
> actual and target are both really just stats. Had we implemented
> those with a vq, I'd be inclined to agree with you but since they're
> implemented in the config space, it seems natural to extend the config
> space with other stats.
>
There is in fact a difference; actual and target are very rarely
updated, while the stats are updated very often. Using a vq means a
constant number of exits per batch instead of one exit per statistic.
If the vq is host-driven, it also allows the host to control the update
frequency dynamically (i.e. stop polling when there is no memory pressure).
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
Adam Litke <agl@us.ibm.com>
Subject: Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver
Date: Tue, 10 Nov 2009 16:43:38 +0200 [thread overview]
Message-ID: <4AF97C1A.2080609@redhat.com> (raw)
In-Reply-To: <4AF97A5E.1070801@codemonkey.ws>
On 11/10/2009 04:36 PM, Anthony Liguori wrote:
>
>> A stats vq might solve this more cleanly?
>
> actual and target are both really just stats. Had we implemented
> those with a vq, I'd be inclined to agree with you but since they're
> implemented in the config space, it seems natural to extend the config
> space with other stats.
>
There is in fact a difference; actual and target are very rarely
updated, while the stats are updated very often. Using a vq means a
constant number of exits per batch instead of one exit per statistic.
If the vq is host-driven, it also allows the host to control the update
frequency dynamically (i.e. stop polling when there is no memory pressure).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-11-10 14:43 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 16:07 [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2) Adam Litke
2009-11-09 16:32 ` virtio: Add memory statistics reporting to the balloon driver Adam Litke
2009-11-09 16:32 ` [Qemu-devel] " Adam Litke
2009-11-10 2:42 ` Rusty Russell
2009-11-10 2:42 ` [Qemu-devel] " Rusty Russell
2009-11-10 2:42 ` Rusty Russell
2009-11-10 2:42 ` [Qemu-devel] " Rusty Russell
2009-11-10 14:36 ` Anthony Liguori
2009-11-10 14:36 ` Anthony Liguori
2009-11-10 14:36 ` Anthony Liguori
2009-11-10 14:43 ` Avi Kivity [this message]
2009-11-10 14:43 ` Avi Kivity
2009-11-10 14:58 ` Anthony Liguori
2009-11-10 14:58 ` Anthony Liguori
2009-11-11 9:24 ` Jamie Lokier
2009-11-11 9:24 ` Jamie Lokier
2009-11-11 10:12 ` Daniel P. Berrange
2009-11-11 10:12 ` Daniel P. Berrange
2009-11-11 13:26 ` Adam Litke
2009-11-11 13:26 ` Adam Litke
2009-11-11 13:26 ` Adam Litke
2009-11-11 15:00 ` Avi Kivity
2009-11-11 15:00 ` Avi Kivity
2009-11-11 15:00 ` Avi Kivity
2009-11-11 10:12 ` Daniel P. Berrange
2009-11-11 9:24 ` Jamie Lokier
2009-11-10 14:58 ` Anthony Liguori
2009-11-10 14:43 ` Avi Kivity
2009-11-10 23:59 ` Rusty Russell
2009-11-10 23:59 ` Rusty Russell
2009-11-10 23:59 ` Rusty Russell
2009-11-10 21:52 ` Anthony Liguori
2009-11-10 21:52 ` Anthony Liguori
2009-11-10 21:52 ` [Qemu-devel] " Anthony Liguori
2009-11-11 0:02 ` Rusty Russell
2009-11-11 0:02 ` [Qemu-devel] " Rusty Russell
2009-11-11 0:07 ` Anthony Liguori
2009-11-11 0:07 ` [Qemu-devel] " Anthony Liguori
2009-11-11 2:43 ` Rusty Russell
2009-11-11 2:43 ` Rusty Russell
2009-11-11 2:43 ` [Qemu-devel] " Rusty Russell
2009-11-11 15:08 ` Adam Litke
2009-11-11 15:08 ` Adam Litke
2009-11-11 15:08 ` [Qemu-devel] " Adam Litke
2009-11-12 2:29 ` Rusty Russell
2009-11-12 2:29 ` Rusty Russell
2009-11-12 2:29 ` [Qemu-devel] " Rusty Russell
2009-11-11 0:07 ` Anthony Liguori
2009-11-11 0:02 ` Rusty Russell
2009-11-10 2:42 ` [Qemu-devel] " Rusty Russell
2009-11-09 16:32 ` Adam Litke
2009-11-09 19:00 ` [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2) Jamie Lokier
2009-11-09 19:16 ` Adam Litke
2009-11-09 21:15 ` Anthony Liguori
2009-11-10 13:23 ` Jamie Lokier
2009-11-09 19:01 ` Jamie Lokier
2009-11-09 19:23 ` Adam Litke
-- strict thread matches above, loose matches on Subject: below --
2009-11-05 22:50 [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning Adam Litke
2009-11-05 23:02 ` [Qemu-devel] virtio: Add memory statistics reporting to the balloon driver Adam Litke
2009-11-05 23:39 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF97C1A.2080609@redhat.com \
--to=avi@redhat.com \
--cc=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.