From: Avi Kivity <avi@redhat.com>
To: Adam Litke <agl@us.ibm.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
Jamie Lokier <jamie@shareable.org>,
Anthony Liguori <aliguori@us.ibm.com>,
agl@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver
Date: Wed, 11 Nov 2009 17:00:02 +0200 [thread overview]
Message-ID: <4AFAD172.4090003@redhat.com> (raw)
In-Reply-To: <1257945984.2876.1.camel@aglitke>
On 11/11/2009 03:26 PM, Adam Litke wrote:
> On Wed, 2009-11-11 at 10:12 +0000, Daniel P. Berrange wrote:
>
>> This all suggests that we should only update the stats from the guest
>> when something on the host actually asks for them by issuing the QEMU
>> monitor command. We don't want any kind of continuous polling of stats
>> at any frequency, if nothing is using these stats on the host.
>>
> Agreed. The next version of the patch will remove the timer completely.
> We'll wake up in response to config change notifications only.
>
A vq with its own interrupt would be much nicer.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Adam Litke <agl@us.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
agl@linux.vnet.ibm.com,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver
Date: Wed, 11 Nov 2009 17:00:02 +0200 [thread overview]
Message-ID: <4AFAD172.4090003@redhat.com> (raw)
In-Reply-To: <1257945984.2876.1.camel@aglitke>
On 11/11/2009 03:26 PM, Adam Litke wrote:
> On Wed, 2009-11-11 at 10:12 +0000, Daniel P. Berrange wrote:
>
>> This all suggests that we should only update the stats from the guest
>> when something on the host actually asks for them by issuing the QEMU
>> monitor command. We don't want any kind of continuous polling of stats
>> at any frequency, if nothing is using these stats on the host.
>>
> Agreed. The next version of the patch will remove the timer completely.
> We'll wake up in response to config change notifications only.
>
A vq with its own interrupt would be much nicer.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-11-11 15:00 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 16:07 [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2) Adam Litke
2009-11-09 16:32 ` virtio: Add memory statistics reporting to the balloon driver Adam Litke
2009-11-09 16:32 ` Adam Litke
2009-11-09 16:32 ` [Qemu-devel] " Adam Litke
2009-11-10 2:42 ` Rusty Russell
2009-11-10 2:42 ` Rusty Russell
2009-11-10 2:42 ` [Qemu-devel] " Rusty Russell
2009-11-10 14:36 ` Anthony Liguori
2009-11-10 14:36 ` Anthony Liguori
2009-11-10 14:43 ` Avi Kivity
2009-11-10 14:43 ` Avi Kivity
2009-11-10 14:58 ` Anthony Liguori
2009-11-10 14:58 ` Anthony Liguori
2009-11-10 14:58 ` Anthony Liguori
2009-11-11 9:24 ` Jamie Lokier
2009-11-11 9:24 ` Jamie Lokier
2009-11-11 9:24 ` Jamie Lokier
2009-11-11 10:12 ` Daniel P. Berrange
2009-11-11 10:12 ` Daniel P. Berrange
2009-11-11 10:12 ` Daniel P. Berrange
2009-11-11 13:26 ` Adam Litke
2009-11-11 13:26 ` Adam Litke
2009-11-11 15:00 ` Avi Kivity [this message]
2009-11-11 15:00 ` Avi Kivity
2009-11-11 15:00 ` Avi Kivity
2009-11-11 13:26 ` Adam Litke
2009-11-10 14:43 ` Avi Kivity
2009-11-10 23:59 ` Rusty Russell
2009-11-10 23:59 ` Rusty Russell
2009-11-10 23:59 ` Rusty Russell
2009-11-10 14:36 ` Anthony Liguori
2009-11-10 21:52 ` Anthony Liguori
2009-11-10 21:52 ` [Qemu-devel] " Anthony Liguori
2009-11-11 0:02 ` Rusty Russell
2009-11-11 0:02 ` [Qemu-devel] " Rusty Russell
2009-11-11 0:07 ` Anthony Liguori
2009-11-11 0:07 ` Anthony Liguori
2009-11-11 0:07 ` [Qemu-devel] " Anthony Liguori
2009-11-11 2:43 ` Rusty Russell
2009-11-11 2:43 ` Rusty Russell
2009-11-11 2:43 ` [Qemu-devel] " Rusty Russell
2009-11-11 15:08 ` Adam Litke
2009-11-11 15:08 ` [Qemu-devel] " Adam Litke
2009-11-12 2:29 ` Rusty Russell
2009-11-12 2:29 ` [Qemu-devel] " Rusty Russell
2009-11-12 2:29 ` Rusty Russell
2009-11-11 15:08 ` Adam Litke
2009-11-11 0:02 ` Rusty Russell
2009-11-10 21:52 ` Anthony Liguori
2009-11-10 2:42 ` [Qemu-devel] " Rusty Russell
2009-11-10 2:42 ` Rusty Russell
2009-11-09 19:00 ` [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2) Jamie Lokier
2009-11-09 19:16 ` Adam Litke
2009-11-09 21:15 ` Anthony Liguori
2009-11-10 13:23 ` Jamie Lokier
2009-11-09 19:01 ` Jamie Lokier
2009-11-09 19:23 ` Adam Litke
-- strict thread matches above, loose matches on Subject: below --
2009-11-05 22:50 [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning Adam Litke
2009-11-05 23:02 ` [Qemu-devel] virtio: Add memory statistics reporting to the balloon driver Adam Litke
2009-11-05 23:39 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFAD172.4090003@redhat.com \
--to=avi@redhat.com \
--cc=agl@linux.vnet.ibm.com \
--cc=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=berrange@redhat.com \
--cc=jamie@shareable.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.