From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rafael Aquini <aquini@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Rusty Russell <rusty@rustcorp.com.au>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages
Date: Tue, 14 Aug 2012 23:31:23 +0300 [thread overview]
Message-ID: <20120814203123.GC28990@redhat.com> (raw)
In-Reply-To: <20120814201113.GE22133@t510.redhat.com>
On Tue, Aug 14, 2012 at 05:11:13PM -0300, Rafael Aquini wrote:
> On Tue, Aug 14, 2012 at 10:51:39PM +0300, Michael S. Tsirkin wrote:
> > What I think you should do is use rcu for access.
> > And here sync rcu before freeing.
> > Maybe an overkill but at least a documented synchronization
> > primitive, and it is very light weight.
> >
>
> I liked your suggestion on barriers, as well.
>
> Rik, Mel ?
Further instead of simple assignment I would add an api
in mm to set/clear the balloon mapping, with proper locking.
This could fail if already set, and thus fix crash with
many ballons.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rafael Aquini <aquini@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Rusty Russell <rusty@rustcorp.com.au>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages
Date: Tue, 14 Aug 2012 23:31:23 +0300 [thread overview]
Message-ID: <20120814203123.GC28990@redhat.com> (raw)
In-Reply-To: <20120814201113.GE22133@t510.redhat.com>
On Tue, Aug 14, 2012 at 05:11:13PM -0300, Rafael Aquini wrote:
> On Tue, Aug 14, 2012 at 10:51:39PM +0300, Michael S. Tsirkin wrote:
> > What I think you should do is use rcu for access.
> > And here sync rcu before freeing.
> > Maybe an overkill but at least a documented synchronization
> > primitive, and it is very light weight.
> >
>
> I liked your suggestion on barriers, as well.
>
> Rik, Mel ?
Further instead of simple assignment I would add an api
in mm to set/clear the balloon mapping, with proper locking.
This could fail if already set, and thus fix crash with
many ballons.
next prev parent reply other threads:[~2012-08-14 20:30 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 17:55 [PATCH v7 0/4] make balloon pages movable by compaction Rafael Aquini
2012-08-10 17:55 ` Rafael Aquini
2012-08-10 17:55 ` [PATCH v7 1/4] mm: introduce compaction and migration for virtio ballooned pages Rafael Aquini
2012-08-10 17:55 ` Rafael Aquini
2012-08-10 17:55 ` Rafael Aquini
2012-08-12 23:14 ` Minchan Kim
2012-08-12 23:14 ` Minchan Kim
2012-08-12 23:14 ` Minchan Kim
2012-08-13 8:26 ` Michael S. Tsirkin
2012-08-13 8:26 ` Michael S. Tsirkin
2012-08-14 17:44 ` Rafael Aquini
2012-08-14 17:44 ` Rafael Aquini
2012-08-14 17:44 ` Rafael Aquini
2012-08-14 19:35 ` Michael S. Tsirkin
2012-08-14 19:35 ` Michael S. Tsirkin
2012-08-14 19:35 ` Michael S. Tsirkin
2012-08-14 19:48 ` Michael S. Tsirkin
2012-08-14 19:48 ` Michael S. Tsirkin
2012-08-14 20:03 ` Rafael Aquini
2012-08-14 20:03 ` Rafael Aquini
2012-08-14 20:03 ` Rafael Aquini
2012-08-14 19:48 ` Michael S. Tsirkin
2012-08-14 20:00 ` Rafael Aquini
2012-08-14 20:00 ` Rafael Aquini
2012-08-14 20:00 ` Rafael Aquini
2012-08-14 20:23 ` Michael S. Tsirkin
2012-08-14 20:23 ` Michael S. Tsirkin
2012-08-14 20:23 ` Michael S. Tsirkin
2012-08-15 8:52 ` Mel Gorman
2012-08-15 8:52 ` Mel Gorman
2012-08-15 8:52 ` Mel Gorman
2012-08-14 19:52 ` Michael S. Tsirkin
2012-08-14 19:52 ` Michael S. Tsirkin
2012-08-14 19:52 ` Michael S. Tsirkin
2012-08-13 8:26 ` Michael S. Tsirkin
2012-08-10 17:55 ` [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages Rafael Aquini
2012-08-10 17:55 ` Rafael Aquini
2012-08-10 17:55 ` Rafael Aquini
2012-08-13 8:41 ` Michael S. Tsirkin
2012-08-13 8:41 ` Michael S. Tsirkin
2012-08-13 23:59 ` Rusty Russell
2012-08-13 23:59 ` Rusty Russell
2012-08-14 8:33 ` Michael S. Tsirkin
2012-08-14 8:33 ` Michael S. Tsirkin
2012-08-14 18:44 ` Rafael Aquini
2012-08-14 18:44 ` Rafael Aquini
2012-08-14 18:44 ` Rafael Aquini
2012-08-14 19:31 ` Michael S. Tsirkin
2012-08-14 19:31 ` Michael S. Tsirkin
2012-08-15 12:34 ` Rafael Aquini
2012-08-15 12:34 ` Rafael Aquini
2012-08-15 12:34 ` Rafael Aquini
2012-08-15 14:40 ` Michael S. Tsirkin
2012-08-15 14:40 ` Michael S. Tsirkin
2012-08-15 14:40 ` Michael S. Tsirkin
2012-08-20 2:29 ` Rusty Russell
2012-08-20 2:29 ` Rusty Russell
2012-08-20 5:12 ` Michael S. Tsirkin
2012-08-20 5:12 ` Michael S. Tsirkin
2012-08-20 5:12 ` Michael S. Tsirkin
2012-08-20 2:29 ` Rusty Russell
2012-08-14 19:31 ` Michael S. Tsirkin
2012-08-15 3:13 ` Rusty Russell
2012-08-15 3:13 ` Rusty Russell
2012-08-15 3:13 ` Rusty Russell
2012-08-14 8:33 ` Michael S. Tsirkin
2012-08-13 23:59 ` Rusty Russell
2012-08-14 18:22 ` Rafael Aquini
2012-08-14 18:22 ` Rafael Aquini
2012-08-14 19:51 ` Michael S. Tsirkin
2012-08-14 19:51 ` Michael S. Tsirkin
2012-08-14 19:51 ` Michael S. Tsirkin
2012-08-14 19:59 ` Michael S. Tsirkin
2012-08-14 19:59 ` Michael S. Tsirkin
2012-08-14 19:59 ` Michael S. Tsirkin
2012-08-14 20:08 ` Rafael Aquini
2012-08-14 20:08 ` Rafael Aquini
2012-08-14 20:08 ` Rafael Aquini
2012-08-14 20:24 ` Michael S. Tsirkin
2012-08-14 20:24 ` Michael S. Tsirkin
2012-08-14 20:29 ` Rafael Aquini
2012-08-14 20:29 ` Rafael Aquini
2012-08-14 20:49 ` Michael S. Tsirkin
2012-08-14 20:49 ` Michael S. Tsirkin
2012-08-14 20:54 ` Michael S. Tsirkin
2012-08-14 20:54 ` Michael S. Tsirkin
2012-08-14 20:54 ` Michael S. Tsirkin
2012-08-14 20:56 ` Rik van Riel
2012-08-14 20:56 ` Rik van Riel
2012-08-14 21:38 ` Michael S. Tsirkin
2012-08-14 21:38 ` Michael S. Tsirkin
2012-08-15 15:30 ` Rik van Riel
2012-08-15 15:30 ` Rik van Riel
2012-08-15 15:30 ` Rik van Riel
2012-08-14 21:38 ` Michael S. Tsirkin
2012-08-14 20:56 ` Rik van Riel
2012-08-14 21:34 ` Rafael Aquini
2012-08-14 21:34 ` Rafael Aquini
2012-08-14 21:34 ` Rafael Aquini
2012-08-14 22:48 ` Michael S. Tsirkin
2012-08-14 22:48 ` Michael S. Tsirkin
2012-08-14 22:48 ` Michael S. Tsirkin
2012-08-14 20:49 ` Michael S. Tsirkin
2012-08-14 20:29 ` Rafael Aquini
2012-08-14 20:24 ` Michael S. Tsirkin
2012-08-14 20:11 ` Rafael Aquini
2012-08-14 20:11 ` Rafael Aquini
2012-08-14 20:11 ` Rafael Aquini
2012-08-14 20:31 ` Michael S. Tsirkin [this message]
2012-08-14 20:31 ` Michael S. Tsirkin
2012-08-14 20:31 ` Michael S. Tsirkin
2012-08-15 9:05 ` Mel Gorman
2012-08-15 9:05 ` Mel Gorman
2012-08-15 9:05 ` Mel Gorman
2012-08-15 9:25 ` Michael S. Tsirkin
2012-08-15 9:25 ` Michael S. Tsirkin
2012-08-15 9:25 ` Michael S. Tsirkin
2012-08-15 9:48 ` Mel Gorman
2012-08-15 9:48 ` Mel Gorman
2012-08-15 10:01 ` Michael S. Tsirkin
2012-08-15 10:01 ` Michael S. Tsirkin
2012-08-15 10:01 ` Michael S. Tsirkin
2012-08-15 11:16 ` Mel Gorman
2012-08-15 11:16 ` Mel Gorman
2012-08-15 11:16 ` Mel Gorman
2012-08-15 11:28 ` Michael S. Tsirkin
2012-08-15 11:28 ` Michael S. Tsirkin
2012-08-15 11:28 ` Michael S. Tsirkin
2012-08-21 5:31 ` Rusty Russell
2012-08-21 5:31 ` Rusty Russell
2012-08-22 0:37 ` Michael S. Tsirkin
2012-08-22 0:37 ` Michael S. Tsirkin
2012-08-22 0:37 ` Michael S. Tsirkin
2012-08-21 5:31 ` Rusty Russell
2012-08-15 9:48 ` Mel Gorman
2012-08-14 18:22 ` Rafael Aquini
2012-08-13 8:41 ` Michael S. Tsirkin
2012-08-10 17:55 ` [PATCH v7 3/4] mm: introduce putback_movable_pages() Rafael Aquini
2012-08-10 17:55 ` Rafael Aquini
2012-08-12 23:26 ` Minchan Kim
2012-08-12 23:26 ` Minchan Kim
2012-08-12 23:26 ` Minchan Kim
2012-08-10 17:55 ` Rafael Aquini
2012-08-10 17:55 ` [PATCH v7 4/4] mm: add vm event counters for balloon pages compaction Rafael Aquini
2012-08-10 17:55 ` Rafael Aquini
2012-08-10 17:55 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814203123.GC28990@redhat.com \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=aquini@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.