All of lore.kernel.org
 help / color / mirror / Atom feed
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 10/12] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes
Date: Tue, 18 Jun 2013 19:09:30 -0300	[thread overview]
Message-ID: <20130618220929.GA24056@localhost> (raw)
In-Reply-To: <201306181816.26530.arnd@arndb.de>

On Tue, Jun 18, 2013 at 06:16:26PM +0200, Arnd Bergmann wrote:
> On Tuesday 18 June 2013, Ezequiel Garcia wrote:
> > 
> > +               devbus-bootcs {
> > +                       compatible = "marvell,mvebu-devbus";
> > +                       reg = <0xffff0001 0x10400 0x8>;
> > +                       ranges = <0 MBUS_ID(0x01, 0x2f) 0 0xffffffff>;
> > +                       #address-cells = <1>;
> > +                       #size-cells = <1>;
> > +                       clocks = <&coreclk 0>;
> > +                       status = "disabled";
> > +               };
> 
> This is a violation of the binding as far as I can tell, since you don't specify ranges
> to access the 0xffff0001 0x10400 address. However, as I explained in my comment for
> the binding, I think you should clarify the binding and leave the implementation
> as you have it here.
> 

Mmm... again I got lost here. Which 'ranges' you say I don't specify to
access the (formerly) 0xffff0001?

AFAIK, 'ranges' are only for children translation, which means I don't
need to specify a ranges for that in the devbus node, but in its parent,
right?

This ranges thing can be very tricky, so please correct me if I'm
mistaken.

-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	Maen Suleiman <maen-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Sebastian Hesselbarth
	<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3 10/12] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes
Date: Tue, 18 Jun 2013 19:09:30 -0300	[thread overview]
Message-ID: <20130618220929.GA24056@localhost> (raw)
In-Reply-To: <201306181816.26530.arnd-r2nGTMty4D4@public.gmane.org>

On Tue, Jun 18, 2013 at 06:16:26PM +0200, Arnd Bergmann wrote:
> On Tuesday 18 June 2013, Ezequiel Garcia wrote:
> > 
> > +               devbus-bootcs {
> > +                       compatible = "marvell,mvebu-devbus";
> > +                       reg = <0xffff0001 0x10400 0x8>;
> > +                       ranges = <0 MBUS_ID(0x01, 0x2f) 0 0xffffffff>;
> > +                       #address-cells = <1>;
> > +                       #size-cells = <1>;
> > +                       clocks = <&coreclk 0>;
> > +                       status = "disabled";
> > +               };
> 
> This is a violation of the binding as far as I can tell, since you don't specify ranges
> to access the 0xffff0001 0x10400 address. However, as I explained in my comment for
> the binding, I think you should clarify the binding and leave the implementation
> as you have it here.
> 

Mmm... again I got lost here. Which 'ranges' you say I don't specify to
access the (formerly) 0xffff0001?

AFAIK, 'ranges' are only for children translation, which means I don't
need to specify a ranges for that in the devbus node, but in its parent,
right?

This ranges thing can be very tricky, so please correct me if I'm
mistaken.

-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

  reply	other threads:[~2013-06-18 22:09 UTC|newest]

Thread overview: 136+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18 11:25 [PATCH v3 00/12] MBus device tree binding Ezequiel Garcia
2013-06-18 11:25 ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 01/12] bus: mvebu-mbus: Factor out initialization details Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 02/12] bus: mvebu-mbus: Introduce device tree binding Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 03/12] bus: mvebu-mbus: Add static window allocation to the DT binding Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 16:14   ` Arnd Bergmann
2013-06-18 16:14     ` Arnd Bergmann
2013-06-18 17:12     ` Thomas Petazzoni
2013-06-18 17:12       ` Thomas Petazzoni
2013-06-18 17:16       ` Arnd Bergmann
2013-06-18 17:16         ` Arnd Bergmann
2013-06-18 21:34     ` Ezequiel Garcia
2013-06-18 21:34       ` Ezequiel Garcia
2013-06-18 21:45       ` Arnd Bergmann
2013-06-18 21:45         ` Arnd Bergmann
2013-06-19 18:52         ` Ezequiel Garcia
2013-06-19 18:52           ` Ezequiel Garcia
2013-06-19 19:08           ` Arnd Bergmann
2013-06-19 19:08             ` Arnd Bergmann
2013-06-19 19:29             ` Ezequiel Garcia
2013-06-19 19:29               ` Ezequiel Garcia
2013-06-19 19:37               ` Jason Cooper
2013-06-19 19:37                 ` Jason Cooper
2013-06-18 17:46   ` Jason Gunthorpe
2013-06-18 17:46     ` Jason Gunthorpe
2013-06-18 18:24     ` Sebastian Hesselbarth
2013-06-18 18:24       ` Sebastian Hesselbarth
2013-06-18 18:39       ` Arnd Bergmann
2013-06-18 18:39         ` Arnd Bergmann
2013-06-18 18:44         ` Sebastian Hesselbarth
2013-06-18 18:44           ` Sebastian Hesselbarth
2013-06-18 18:47           ` Jason Gunthorpe
2013-06-18 18:47             ` Jason Gunthorpe
2013-06-18 18:59             ` Sebastian Hesselbarth
2013-06-18 18:59               ` Sebastian Hesselbarth
2013-06-18 19:10               ` Jason Gunthorpe
2013-06-18 19:10                 ` Jason Gunthorpe
2013-06-18 19:27                 ` Sebastian Hesselbarth
2013-06-18 19:27                   ` Sebastian Hesselbarth
2013-06-18 20:49                   ` Ezequiel Garcia
2013-06-18 20:49                     ` Ezequiel Garcia
2013-06-18 20:55                     ` Jason Gunthorpe
2013-06-18 20:55                       ` Jason Gunthorpe
2013-06-18 21:10                       ` Ezequiel Garcia
2013-06-18 21:10                         ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 04/12] ARM: mvebu: Initialize MBus using " Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 05/12] ARM: mvebu: Remove the harcoded BootROM window allocation Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 17:39   ` Jason Gunthorpe
2013-06-18 17:39     ` Jason Gunthorpe
2013-06-18 19:43     ` Ezequiel Garcia
2013-06-18 19:43       ` Ezequiel Garcia
2013-06-18 19:51       ` Jason Gunthorpe
2013-06-18 19:51         ` Jason Gunthorpe
2013-06-18 20:02         ` Ezequiel Garcia
2013-06-18 20:02           ` Ezequiel Garcia
2013-06-18 20:10           ` Jason Gunthorpe
2013-06-18 20:10             ` Jason Gunthorpe
2013-06-18 20:39             ` Ezequiel Garcia
2013-06-18 20:39               ` Ezequiel Garcia
2013-06-19 10:02     ` Ezequiel Garcia
2013-06-19 10:02       ` Ezequiel Garcia
2013-06-19 16:58       ` Jason Gunthorpe
2013-06-19 16:58         ` Jason Gunthorpe
2013-06-19 17:58         ` Ezequiel Garcia
2013-06-19 17:58           ` Ezequiel Garcia
2013-06-19 18:03           ` Jason Gunthorpe
2013-06-19 18:03             ` Jason Gunthorpe
2013-06-19 18:17             ` Ezequiel Garcia
2013-06-19 18:17               ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 06/12] memory: mvebu-devbus: Remove address decoding window workaround Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 11:39   ` Jason Cooper
2013-06-18 11:39     ` Jason Cooper
2013-06-18 12:17     ` Thomas Petazzoni
2013-06-18 12:17       ` Thomas Petazzoni
2013-06-18 12:33       ` Jason Cooper
2013-06-18 12:33         ` Jason Cooper
2013-06-18 12:48         ` Ezequiel Garcia
2013-06-18 12:48           ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 07/12] ARM: mvebu: Use the preprocessor on Armada 370/XP device tree files Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 08/12] ARM: mvebu: Add MBus to Armada 370/XP device tree Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 09/12] ARM: mvebu: Add BootROM " Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 10/12] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 16:16   ` Arnd Bergmann
2013-06-18 16:16     ` Arnd Bergmann
2013-06-18 22:09     ` Ezequiel Garcia [this message]
2013-06-18 22:09       ` Ezequiel Garcia
2013-06-18 22:14       ` Ezequiel Garcia
2013-06-18 22:14         ` Ezequiel Garcia
2013-06-19 12:03       ` Arnd Bergmann
2013-06-19 12:03         ` Arnd Bergmann
2013-06-18 11:25 ` [PATCH v3 11/12] ARM: mvebu: Relocate Armada 370 PCIe " Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 16:29   ` Arnd Bergmann
2013-06-18 16:29     ` Arnd Bergmann
2013-06-18 17:15     ` Thomas Petazzoni
2013-06-18 17:15       ` Thomas Petazzoni
2013-06-18 17:18       ` Arnd Bergmann
2013-06-18 17:18         ` Arnd Bergmann
2013-06-18 17:21         ` Thomas Petazzoni
2013-06-18 17:21           ` Thomas Petazzoni
2013-06-18 18:22           ` Arnd Bergmann
2013-06-18 18:22             ` Arnd Bergmann
2013-06-18 19:02             ` Jason Gunthorpe
2013-06-18 19:02               ` Jason Gunthorpe
2013-06-18 21:20               ` Arnd Bergmann
2013-06-18 21:20                 ` Arnd Bergmann
2013-06-18 21:40                 ` Ezequiel Garcia
2013-06-18 21:40                   ` Ezequiel Garcia
2013-06-19 12:06                   ` Arnd Bergmann
2013-06-19 12:06                     ` Arnd Bergmann
2013-06-18 21:35   ` Arnd Bergmann
2013-06-18 21:35     ` Arnd Bergmann
2013-06-19 11:12     ` Ezequiel Garcia
2013-06-19 11:12       ` Ezequiel Garcia
2013-06-19 12:11       ` Arnd Bergmann
2013-06-19 12:11         ` Arnd Bergmann
2013-06-19 16:53         ` Jason Gunthorpe
2013-06-19 16:53           ` Jason Gunthorpe
2013-06-19 18:55           ` Arnd Bergmann
2013-06-19 18:55             ` Arnd Bergmann
2013-06-18 11:25 ` [PATCH v3 12/12] ARM: mvebu: Relocate Armada XP " Ezequiel Garcia
2013-06-18 11:25   ` Ezequiel Garcia
2013-06-18 11:33 ` [PATCH v3 00/12] MBus device tree binding Sebastian Hesselbarth
2013-06-18 11:33   ` Sebastian Hesselbarth
2013-06-18 13:07   ` Ezequiel Garcia
2013-06-18 13:07     ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130618220929.GA24056@localhost \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.