[lm-sensors] i8k: move driver from char to hwmon

[lm-sensors] i8k: move driver from char to hwmon

[Pali Rohár]

[-- Attachment #1.1: Type: Text/Plain, Size: 1446 bytes --]

Hello,

currently i8k driver for DELLDIAG SMM operations (charger, 
battery, hotkeys, temperature and fan control) supports two 
interfaces:

1) old /proc/i8k char device
2) new hwmon interface

Driver now lives in char subsystem, but nowadays I think lot of 
people are interested only in hwmon interface which provides 
temperature & fan control. Power management and hotkeys support 
(which is missing in 2) but provided by 1)) is already handled by 
ACPI or input subsystem for new laptops.

Also name "i8k" is really non intuitive what it means and 
supports... (I was told it is abbreviation for Inspirion 8000 
model which was probably first dell model supported by that 
DELLDIAG interface). Now driver is used on Vostro, Latitude and 
also Precision and XPS models. I think at least "dell" should be 
part of driver name and config option.

So I have idea for some changes:

1) Move driver from char subsystem to hwmon

2) Rename driver from i8k to something like delldiag or dellsmm

3) Add new CONFIG_ option to enable/disable /proc/i8k device and 
compile only hwmon interface support

What do you think about it?

I do not want to delete /proc/i8k interface (or break support for 
it) as there are still userspace applications which use this old 
interface and for old models it is probably only way how to 
detect power supply and multimedia hotkeys...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

i8k: move driver from char to hwmon

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 1446 bytes --]

Hello,

currently i8k driver for DELLDIAG SMM operations (charger, 
battery, hotkeys, temperature and fan control) supports two 
interfaces:

1) old /proc/i8k char device
2) new hwmon interface

Driver now lives in char subsystem, but nowadays I think lot of 
people are interested only in hwmon interface which provides 
temperature & fan control. Power management and hotkeys support 
(which is missing in 2) but provided by 1)) is already handled by 
ACPI or input subsystem for new laptops.

Also name "i8k" is really non intuitive what it means and 
supports... (I was told it is abbreviation for Inspirion 8000 
model which was probably first dell model supported by that 
DELLDIAG interface). Now driver is used on Vostro, Latitude and 
also Precision and XPS models. I think at least "dell" should be 
part of driver name and config option.

So I have idea for some changes:

1) Move driver from char subsystem to hwmon

2) Rename driver from i8k to something like delldiag or dellsmm

3) Add new CONFIG_ option to enable/disable /proc/i8k device and 
compile only hwmon interface support

What do you think about it?

I do not want to delete /proc/i8k interface (or break support for 
it) as there are still userspace applications which use this old 
interface and for old models it is probably only way how to 
detect power supply and multimedia hotkeys...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [lm-sensors] i8k: move driver from char to hwmon

[Guenter Roeck]

T24gMDIvMjIvMjAxNSAwMzo1MCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gSGVsbG8sCj4KPiBj
dXJyZW50bHkgaThrIGRyaXZlciBmb3IgREVMTERJQUcgU01NIG9wZXJhdGlvbnMgKGNoYXJnZXIs
Cj4gYmF0dGVyeSwgaG90a2V5cywgdGVtcGVyYXR1cmUgYW5kIGZhbiBjb250cm9sKSBzdXBwb3J0
cyB0d28KPiBpbnRlcmZhY2VzOgo+Cj4gMSkgb2xkIC9wcm9jL2k4ayBjaGFyIGRldmljZQo+IDIp
IG5ldyBod21vbiBpbnRlcmZhY2UKPgo+IERyaXZlciBub3cgbGl2ZXMgaW4gY2hhciBzdWJzeXN0
ZW0sIGJ1dCBub3dhZGF5cyBJIHRoaW5rIGxvdCBvZgo+IHBlb3BsZSBhcmUgaW50ZXJlc3RlZCBv
bmx5IGluIGh3bW9uIGludGVyZmFjZSB3aGljaCBwcm92aWRlcwo+IHRlbXBlcmF0dXJlICYgZmFu
IGNvbnRyb2wuIFBvd2VyIG1hbmFnZW1lbnQgYW5kIGhvdGtleXMgc3VwcG9ydAo+ICh3aGljaCBp
cyBtaXNzaW5nIGluIDIpIGJ1dCBwcm92aWRlZCBieSAxKSkgaXMgYWxyZWFkeSBoYW5kbGVkIGJ5
Cj4gQUNQSSBvciBpbnB1dCBzdWJzeXN0ZW0gZm9yIG5ldyBsYXB0b3BzLgo+Cj4gQWxzbyBuYW1l
ICJpOGsiIGlzIHJlYWxseSBub24gaW50dWl0aXZlIHdoYXQgaXQgbWVhbnMgYW5kCj4gc3VwcG9y
dHMuLi4gKEkgd2FzIHRvbGQgaXQgaXMgYWJicmV2aWF0aW9uIGZvciBJbnNwaXJpb24gODAwMAo+
IG1vZGVsIHdoaWNoIHdhcyBwcm9iYWJseSBmaXJzdCBkZWxsIG1vZGVsIHN1cHBvcnRlZCBieSB0
aGF0Cj4gREVMTERJQUcgaW50ZXJmYWNlKS4gTm93IGRyaXZlciBpcyB1c2VkIG9uIFZvc3Rybywg
TGF0aXR1ZGUgYW5kCj4gYWxzbyBQcmVjaXNpb24gYW5kIFhQUyBtb2RlbHMuIEkgdGhpbmsgYXQg
bGVhc3QgImRlbGwiIHNob3VsZCBiZQo+IHBhcnQgb2YgZHJpdmVyIG5hbWUgYW5kIGNvbmZpZyBv
cHRpb24uCj4KPiBTbyBJIGhhdmUgaWRlYSBmb3Igc29tZSBjaGFuZ2VzOgo+Cj4gMSkgTW92ZSBk
cml2ZXIgZnJvbSBjaGFyIHN1YnN5c3RlbSB0byBod21vbgo+CkkgYW0gb2sgd2l0aCB0aGlzIG9u
ZS4KCj4gMikgUmVuYW1lIGRyaXZlciBmcm9tIGk4ayB0byBzb21ldGhpbmcgbGlrZSBkZWxsZGlh
ZyBvciBkZWxsc21tCj4KTWlnaHQgYmUgcHJvYmxlbWF0aWMsIGFzIGl0IHdvdWxkIGJyZWFrIGV4
aXN0aW5nIGNvbmZpZ3VyYXRpb25zCnVubGVzcyB5b3Uga2VlcCB0aGUgQ09ORklHX0k4SyBidXQg
cmVuYW1lIHRoZSBkcml2ZXIuIERyaXZlciBuYW1lcwphcmUgbmV2ZXIgcGVyZmVjdCwgc28gSSB3
b3VsZCBqdXN0IGxlYXZlIGl0IGFzIGlzLgoKPiAzKSBBZGQgbmV3IENPTkZJR18gb3B0aW9uIHRv
IGVuYWJsZS9kaXNhYmxlIC9wcm9jL2k4ayBkZXZpY2UgYW5kCj4gY29tcGlsZSBvbmx5IGh3bW9u
IGludGVyZmFjZSBzdXBwb3J0CgpNYWtlcyBzZW5zZS4gSSB3b3VsZCBzdWdnZXN0IHRvIG1ha2Ug
aHdtb24gc3VwcHBvcnQgdGhlIGRlZmF1bHQKYW5kIG1hbmRhdG9yeSBpZiB0aGUgZHJpdmVyIGlz
IGVuYWJsZWQgYW5kIGFkZCBhIG5ldyBDT05GSUdfSThLX1BST0NJRgpvciBzaW1pbGFyIHdoaWNo
IHNob3VsZCBiZSBlbmFibGVkIGJ5IGRlZmF1bHQuCgpBcmUgeW91IGludGVyZXN0ZWQgaW4gYWRk
aW5nIHlvdXJzZWxmIGFzIG1haW50YWluZXIgZm9yIHRoaXMgZHJpdmVyID8KClRoYW5rcywKR3Vl
bnRlcgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxt
LXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xp
c3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw=

Re: i8k: move driver from char to hwmon

[Guenter Roeck]

On 02/22/2015 03:50 AM, Pali Rohár wrote:
> Hello,
>
> currently i8k driver for DELLDIAG SMM operations (charger,
> battery, hotkeys, temperature and fan control) supports two
> interfaces:
>
> 1) old /proc/i8k char device
> 2) new hwmon interface
>
> Driver now lives in char subsystem, but nowadays I think lot of
> people are interested only in hwmon interface which provides
> temperature & fan control. Power management and hotkeys support
> (which is missing in 2) but provided by 1)) is already handled by
> ACPI or input subsystem for new laptops.
>
> Also name "i8k" is really non intuitive what it means and
> supports... (I was told it is abbreviation for Inspirion 8000
> model which was probably first dell model supported by that
> DELLDIAG interface). Now driver is used on Vostro, Latitude and
> also Precision and XPS models. I think at least "dell" should be
> part of driver name and config option.
>
> So I have idea for some changes:
>
> 1) Move driver from char subsystem to hwmon
>
I am ok with this one.

> 2) Rename driver from i8k to something like delldiag or dellsmm
>
Might be problematic, as it would break existing configurations
unless you keep the CONFIG_I8K but rename the driver. Driver names
are never perfect, so I would just leave it as is.

> 3) Add new CONFIG_ option to enable/disable /proc/i8k device and
> compile only hwmon interface support

Makes sense. I would suggest to make hwmon suppport the default
and mandatory if the driver is enabled and add a new CONFIG_I8K_PROCIF
or similar which should be enabled by default.

Are you interested in adding yourself as maintainer for this driver ?

Thanks,
Guenter

Re: [lm-sensors] i8k: move driver from char to hwmon

[Pali Rohár]

[-- Attachment #1.1: Type: Text/Plain, Size: 2141 bytes --]

On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote:
> On 02/22/2015 03:50 AM, Pali Rohár wrote:
> > Hello,
> > 
> > currently i8k driver for DELLDIAG SMM operations (charger,
> > battery, hotkeys, temperature and fan control) supports two
> > interfaces:
> > 
> > 1) old /proc/i8k char device
> > 2) new hwmon interface
> > 
> > Driver now lives in char subsystem, but nowadays I think lot
> > of people are interested only in hwmon interface which
> > provides temperature & fan control. Power management and
> > hotkeys support (which is missing in 2) but provided by 1))
> > is already handled by ACPI or input subsystem for new
> > laptops.
> > 
> > Also name "i8k" is really non intuitive what it means and
> > supports... (I was told it is abbreviation for Inspirion
> > 8000 model which was probably first dell model supported by
> > that DELLDIAG interface). Now driver is used on Vostro,
> > Latitude and also Precision and XPS models. I think at
> > least "dell" should be part of driver name and config
> > option.
> > 
> > So I have idea for some changes:
> > 
> > 1) Move driver from char subsystem to hwmon
> 
> I am ok with this one.
> 
> > 2) Rename driver from i8k to something like delldiag or
> > dellsmm
> 
> Might be problematic, as it would break existing
> configurations unless you keep the CONFIG_I8K but rename the
> driver. Driver names are never perfect, so I would just leave
> it as is.
> 
> > 3) Add new CONFIG_ option to enable/disable /proc/i8k device
> > and compile only hwmon interface support
> 
> Makes sense. I would suggest to make hwmon suppport the
> default and mandatory if the driver is enabled and add a new
> CONFIG_I8K_PROCIF or similar which should be enabled by
> default.
> 

What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for 
mandatory core & hwmon code and (keep existing) CONFIG_I8K for 
/proc/i8k?

> Are you interested in adding yourself as maintainer for this
> driver ?
> 

Ok I could. But I do not know how much time will have in future.

> Thanks,
> Guenter

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: i8k: move driver from char to hwmon

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 2141 bytes --]

On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote:
> On 02/22/2015 03:50 AM, Pali Rohár wrote:
> > Hello,
> > 
> > currently i8k driver for DELLDIAG SMM operations (charger,
> > battery, hotkeys, temperature and fan control) supports two
> > interfaces:
> > 
> > 1) old /proc/i8k char device
> > 2) new hwmon interface
> > 
> > Driver now lives in char subsystem, but nowadays I think lot
> > of people are interested only in hwmon interface which
> > provides temperature & fan control. Power management and
> > hotkeys support (which is missing in 2) but provided by 1))
> > is already handled by ACPI or input subsystem for new
> > laptops.
> > 
> > Also name "i8k" is really non intuitive what it means and
> > supports... (I was told it is abbreviation for Inspirion
> > 8000 model which was probably first dell model supported by
> > that DELLDIAG interface). Now driver is used on Vostro,
> > Latitude and also Precision and XPS models. I think at
> > least "dell" should be part of driver name and config
> > option.
> > 
> > So I have idea for some changes:
> > 
> > 1) Move driver from char subsystem to hwmon
> 
> I am ok with this one.
> 
> > 2) Rename driver from i8k to something like delldiag or
> > dellsmm
> 
> Might be problematic, as it would break existing
> configurations unless you keep the CONFIG_I8K but rename the
> driver. Driver names are never perfect, so I would just leave
> it as is.
> 
> > 3) Add new CONFIG_ option to enable/disable /proc/i8k device
> > and compile only hwmon interface support
> 
> Makes sense. I would suggest to make hwmon suppport the
> default and mandatory if the driver is enabled and add a new
> CONFIG_I8K_PROCIF or similar which should be enabled by
> default.
> 

What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for 
mandatory core & hwmon code and (keep existing) CONFIG_I8K for 
/proc/i8k?

> Are you interested in adding yourself as maintainer for this
> driver ?
> 

Ok I could. But I do not know how much time will have in future.

> Thanks,
> Guenter

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [lm-sensors] i8k: move driver from char to hwmon

[Guenter Roeck]

T24gMDIvMjIvMjAxNSAwOTo0NCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gT24gU3VuZGF5IDIy
IEZlYnJ1YXJ5IDIwMTUgMTg6MzM6MTYgR3VlbnRlciBSb2VjayB3cm90ZToKPj4gT24gMDIvMjIv
MjAxNSAwMzo1MCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4+PiBIZWxsbywKPj4+Cj4+PiBjdXJy
ZW50bHkgaThrIGRyaXZlciBmb3IgREVMTERJQUcgU01NIG9wZXJhdGlvbnMgKGNoYXJnZXIsCj4+
PiBiYXR0ZXJ5LCBob3RrZXlzLCB0ZW1wZXJhdHVyZSBhbmQgZmFuIGNvbnRyb2wpIHN1cHBvcnRz
IHR3bwo+Pj4gaW50ZXJmYWNlczoKPj4+Cj4+PiAxKSBvbGQgL3Byb2MvaThrIGNoYXIgZGV2aWNl
Cj4+PiAyKSBuZXcgaHdtb24gaW50ZXJmYWNlCj4+Pgo+Pj4gRHJpdmVyIG5vdyBsaXZlcyBpbiBj
aGFyIHN1YnN5c3RlbSwgYnV0IG5vd2FkYXlzIEkgdGhpbmsgbG90Cj4+PiBvZiBwZW9wbGUgYXJl
IGludGVyZXN0ZWQgb25seSBpbiBod21vbiBpbnRlcmZhY2Ugd2hpY2gKPj4+IHByb3ZpZGVzIHRl
bXBlcmF0dXJlICYgZmFuIGNvbnRyb2wuIFBvd2VyIG1hbmFnZW1lbnQgYW5kCj4+PiBob3RrZXlz
IHN1cHBvcnQgKHdoaWNoIGlzIG1pc3NpbmcgaW4gMikgYnV0IHByb3ZpZGVkIGJ5IDEpKQo+Pj4g
aXMgYWxyZWFkeSBoYW5kbGVkIGJ5IEFDUEkgb3IgaW5wdXQgc3Vic3lzdGVtIGZvciBuZXcKPj4+
IGxhcHRvcHMuCj4+Pgo+Pj4gQWxzbyBuYW1lICJpOGsiIGlzIHJlYWxseSBub24gaW50dWl0aXZl
IHdoYXQgaXQgbWVhbnMgYW5kCj4+PiBzdXBwb3J0cy4uLiAoSSB3YXMgdG9sZCBpdCBpcyBhYmJy
ZXZpYXRpb24gZm9yIEluc3Bpcmlvbgo+Pj4gODAwMCBtb2RlbCB3aGljaCB3YXMgcHJvYmFibHkg
Zmlyc3QgZGVsbCBtb2RlbCBzdXBwb3J0ZWQgYnkKPj4+IHRoYXQgREVMTERJQUcgaW50ZXJmYWNl
KS4gTm93IGRyaXZlciBpcyB1c2VkIG9uIFZvc3RybywKPj4+IExhdGl0dWRlIGFuZCBhbHNvIFBy
ZWNpc2lvbiBhbmQgWFBTIG1vZGVscy4gSSB0aGluayBhdAo+Pj4gbGVhc3QgImRlbGwiIHNob3Vs
ZCBiZSBwYXJ0IG9mIGRyaXZlciBuYW1lIGFuZCBjb25maWcKPj4+IG9wdGlvbi4KPj4+Cj4+PiBT
byBJIGhhdmUgaWRlYSBmb3Igc29tZSBjaGFuZ2VzOgo+Pj4KPj4+IDEpIE1vdmUgZHJpdmVyIGZy
b20gY2hhciBzdWJzeXN0ZW0gdG8gaHdtb24KPj4KPj4gSSBhbSBvayB3aXRoIHRoaXMgb25lLgo+
Pgo+Pj4gMikgUmVuYW1lIGRyaXZlciBmcm9tIGk4ayB0byBzb21ldGhpbmcgbGlrZSBkZWxsZGlh
ZyBvcgo+Pj4gZGVsbHNtbQo+Pgo+PiBNaWdodCBiZSBwcm9ibGVtYXRpYywgYXMgaXQgd291bGQg
YnJlYWsgZXhpc3RpbmcKPj4gY29uZmlndXJhdGlvbnMgdW5sZXNzIHlvdSBrZWVwIHRoZSBDT05G
SUdfSThLIGJ1dCByZW5hbWUgdGhlCj4+IGRyaXZlci4gRHJpdmVyIG5hbWVzIGFyZSBuZXZlciBw
ZXJmZWN0LCBzbyBJIHdvdWxkIGp1c3QgbGVhdmUKPj4gaXQgYXMgaXMuCj4+Cj4+PiAzKSBBZGQg
bmV3IENPTkZJR18gb3B0aW9uIHRvIGVuYWJsZS9kaXNhYmxlIC9wcm9jL2k4ayBkZXZpY2UKPj4+
IGFuZCBjb21waWxlIG9ubHkgaHdtb24gaW50ZXJmYWNlIHN1cHBvcnQKPj4KPj4gTWFrZXMgc2Vu
c2UuIEkgd291bGQgc3VnZ2VzdCB0byBtYWtlIGh3bW9uIHN1cHBwb3J0IHRoZQo+PiBkZWZhdWx0
IGFuZCBtYW5kYXRvcnkgaWYgdGhlIGRyaXZlciBpcyBlbmFibGVkIGFuZCBhZGQgYSBuZXcKPj4g
Q09ORklHX0k4S19QUk9DSUYgb3Igc2ltaWxhciB3aGljaCBzaG91bGQgYmUgZW5hYmxlZCBieQo+
PiBkZWZhdWx0Lgo+Pgo+Cj4gV2hhdCBhYm91dCBDT05GSUdfREVMTERJQUcgKG9yIERFTExTTU0g
b3IgQ09ORklHX1NFTlNPUlNfKikgZm9yCj4gbWFuZGF0b3J5IGNvcmUgJiBod21vbiBjb2RlIGFu
ZCAoa2VlcCBleGlzdGluZykgQ09ORklHX0k4SyBmb3IKPiAvcHJvYy9pOGs/Cj4KQ09ORklHX1NF
TlNPUlNfREVMTCB3b3VsZCBwcm9iYWJseSBiZSBiZXN0LCBidXQgdGhhdCB3b3VsZCBzdGlsbApi
cmVhayBiYWNrd2FyZCBjb21wYXRpYmlsaXR5IGZvciBleGlzdGluZyBjb25maWd1cmF0aW9ucyB1
bmxlc3MKeW91IGVuYWJsZSBDT05GSUdfU0VOU09SU19ERUxMIGJ5IGRlZmF1bHQgd2hpY2ggd291
bGQgbm90IGJlCmEgZ29vZCBpZGVhLgoKR3VlbnRlcgoKCl9fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNv
cnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlz
dGluZm8vbG0tc2Vuc29ycw=

Re: i8k: move driver from char to hwmon

[Guenter Roeck]

On 02/22/2015 09:44 AM, Pali Rohár wrote:
> On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote:
>> On 02/22/2015 03:50 AM, Pali Rohár wrote:
>>> Hello,
>>>
>>> currently i8k driver for DELLDIAG SMM operations (charger,
>>> battery, hotkeys, temperature and fan control) supports two
>>> interfaces:
>>>
>>> 1) old /proc/i8k char device
>>> 2) new hwmon interface
>>>
>>> Driver now lives in char subsystem, but nowadays I think lot
>>> of people are interested only in hwmon interface which
>>> provides temperature & fan control. Power management and
>>> hotkeys support (which is missing in 2) but provided by 1))
>>> is already handled by ACPI or input subsystem for new
>>> laptops.
>>>
>>> Also name "i8k" is really non intuitive what it means and
>>> supports... (I was told it is abbreviation for Inspirion
>>> 8000 model which was probably first dell model supported by
>>> that DELLDIAG interface). Now driver is used on Vostro,
>>> Latitude and also Precision and XPS models. I think at
>>> least "dell" should be part of driver name and config
>>> option.
>>>
>>> So I have idea for some changes:
>>>
>>> 1) Move driver from char subsystem to hwmon
>>
>> I am ok with this one.
>>
>>> 2) Rename driver from i8k to something like delldiag or
>>> dellsmm
>>
>> Might be problematic, as it would break existing
>> configurations unless you keep the CONFIG_I8K but rename the
>> driver. Driver names are never perfect, so I would just leave
>> it as is.
>>
>>> 3) Add new CONFIG_ option to enable/disable /proc/i8k device
>>> and compile only hwmon interface support
>>
>> Makes sense. I would suggest to make hwmon suppport the
>> default and mandatory if the driver is enabled and add a new
>> CONFIG_I8K_PROCIF or similar which should be enabled by
>> default.
>>
>
> What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for
> mandatory core & hwmon code and (keep existing) CONFIG_I8K for
> /proc/i8k?
>
CONFIG_SENSORS_DELL would probably be best, but that would still
break backward compatibility for existing configurations unless
you enable CONFIG_SENSORS_DELL by default which would not be
a good idea.

Guenter

Re: [lm-sensors] i8k: move driver from char to hwmon

[Guenter Roeck]

T24gMDIvMjIvMjAxNSAwOTo0NCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gT24gU3VuZGF5IDIy
IEZlYnJ1YXJ5IDIwMTUgMTg6MzM6MTYgR3VlbnRlciBSb2VjayB3cm90ZToKPj4KPj4+IDIpIFJl
bmFtZSBkcml2ZXIgZnJvbSBpOGsgdG8gc29tZXRoaW5nIGxpa2UgZGVsbGRpYWcgb3IKPj4+IGRl
bGxzbW0KPj4KPj4gTWlnaHQgYmUgcHJvYmxlbWF0aWMsIGFzIGl0IHdvdWxkIGJyZWFrIGV4aXN0
aW5nCj4+IGNvbmZpZ3VyYXRpb25zIHVubGVzcyB5b3Uga2VlcCB0aGUgQ09ORklHX0k4SyBidXQg
cmVuYW1lIHRoZQo+PiBkcml2ZXIuIERyaXZlciBuYW1lcyBhcmUgbmV2ZXIgcGVyZmVjdCwgc28g
SSB3b3VsZCBqdXN0IGxlYXZlCj4+IGl0IGFzIGlzLgo+Pgo+Pj4gMykgQWRkIG5ldyBDT05GSUdf
IG9wdGlvbiB0byBlbmFibGUvZGlzYWJsZSAvcHJvYy9pOGsgZGV2aWNlCj4+PiBhbmQgY29tcGls
ZSBvbmx5IGh3bW9uIGludGVyZmFjZSBzdXBwb3J0Cj4+Cj4+IE1ha2VzIHNlbnNlLiBJIHdvdWxk
IHN1Z2dlc3QgdG8gbWFrZSBod21vbiBzdXBwcG9ydCB0aGUKPj4gZGVmYXVsdCBhbmQgbWFuZGF0
b3J5IGlmIHRoZSBkcml2ZXIgaXMgZW5hYmxlZCBhbmQgYWRkIGEgbmV3Cj4+IENPTkZJR19JOEtf
UFJPQ0lGIG9yIHNpbWlsYXIgd2hpY2ggc2hvdWxkIGJlIGVuYWJsZWQgYnkKPj4gZGVmYXVsdC4K
Pj4KPgo+IFdoYXQgYWJvdXQgQ09ORklHX0RFTExESUFHIChvciBERUxMU01NIG9yIENPTkZJR19T
RU5TT1JTXyopIGZvcgo+IG1hbmRhdG9yeSBjb3JlICYgaHdtb24gY29kZSBhbmQgKGtlZXAgZXhp
c3RpbmcpIENPTkZJR19JOEsgZm9yCj4gL3Byb2MvaThrPwo+CgpPbmUgb3B0aW9uIG1pZ2h0IGJl
IHRvIGxlYXZlIENPTkZJR19JOEsgbW9yZSBvciBsZXNzIGFsb25lCihpdCBpcyBpbiBhcmNoL3g4
Ni9LY29uZmlnIGFueXdheSwgd2hpY2ggaXMgb2RkIGJ5IGl0c2VsZiksCmJ1dCBhZGQgc29tZXRo
aW5nIGxpa2UKCXNlbGVjdCBTRU5TT1JTX0RFTEwKCXNlbGVjdCBJOEtfUFJPQwp0byBpdC4gVGhl
biBhZGQgbmV3IGNvbmZpZyBvcHRpb25zIFNFTlNPUlNfREVMTCBhbmQKSThLX1BST0MgdG8gZHJp
dmVycy9od21vbi9LY29uZmlnLgoKSSB3b3VsZCBzdGlsbCBsZWF2ZSB0aGUgZHJpdmVyIG5hbWUg
YWxvbmUsIHRob3VnaDsgdGhlIHByb2JsZW0KaXMgdGhhdCAibW9kcHJvYmUgaThrIiBpcyBtZW50
aW9uZWQgaW4gcHJldHR5IG11Y2ggYWxsIHJlZmVyZW5jZXMKdG8gdGhlIGRyaXZlci4KCldlIGNv
dWxkIHRyeSB0byBtYWtlIGl0IHR3byBzZXBhcmF0ZSBkcml2ZXJzLCBvbmUgZm9yIHRoZSBod21v
bgppbnRlcmZhY2UgYW5kIG9uZSBmb3IgdGhlIHByb2MgaW50ZXJmYWNlICh3aGljaCB3b3VsZCBk
ZXBlbmQgb24KdGhlIGh3bW9uIGRyaXZlciksIGJ1dCBJIGFtIG5vdCBzdXJlIGlmIHRoYXQgaXMg
d29ydGggaXQgb3IgZXZlbgpmZWFzaWJsZS4gSXQgd291bGQgc2F2ZSB1cyBhIGJ1bmNoIG9mIGlm
ZGVmcyBpbiB0aGUgY29kZSwgdGhvdWdoLApzbyBpdCBtaWdodCBiZSB3b3J0aCBsb29raW5nIGlu
dG8uIEluIHRoYXQgY2FzZSB5b3Ugd291bGQgaGF2ZSBhCmRlbGwgaHdtb24gZHJpdmVyIGFuZCBh
IGRlbGwgaThrIGRyaXZlciAod2hpY2ggd291bGQgb25seSBleGlzdCBpZgpJOEtfUFJPQyBpcyBj
b25maWd1cmVkKS4KCkd1ZW50ZXIKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNv
cnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNl
bnNvcnM

Re: i8k: move driver from char to hwmon

[Guenter Roeck]

On 02/22/2015 09:44 AM, Pali Rohár wrote:
> On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote:
>>
>>> 2) Rename driver from i8k to something like delldiag or
>>> dellsmm
>>
>> Might be problematic, as it would break existing
>> configurations unless you keep the CONFIG_I8K but rename the
>> driver. Driver names are never perfect, so I would just leave
>> it as is.
>>
>>> 3) Add new CONFIG_ option to enable/disable /proc/i8k device
>>> and compile only hwmon interface support
>>
>> Makes sense. I would suggest to make hwmon suppport the
>> default and mandatory if the driver is enabled and add a new
>> CONFIG_I8K_PROCIF or similar which should be enabled by
>> default.
>>
>
> What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for
> mandatory core & hwmon code and (keep existing) CONFIG_I8K for
> /proc/i8k?
>

One option might be to leave CONFIG_I8K more or less alone
(it is in arch/x86/Kconfig anyway, which is odd by itself),
but add something like
	select SENSORS_DELL
	select I8K_PROC
to it. Then add new config options SENSORS_DELL and
I8K_PROC to drivers/hwmon/Kconfig.

I would still leave the driver name alone, though; the problem
is that "modprobe i8k" is mentioned in pretty much all references
to the driver.

We could try to make it two separate drivers, one for the hwmon
interface and one for the proc interface (which would depend on
the hwmon driver), but I am not sure if that is worth it or even
feasible. It would save us a bunch of ifdefs in the code, though,
so it might be worth looking into. In that case you would have a
dell hwmon driver and a dell i8k driver (which would only exist if
I8K_PROC is configured).

Guenter

Re: [lm-sensors] i8k: move driver from char to hwmon

[Jean Delvare]

On Sun, 22 Feb 2015 10:11:16 -0800, Guenter Roeck wrote:
> I would still leave the driver name alone, though; the problem
> is that "modprobe i8k" is mentioned in pretty much all references
> to the driver.

This might be solved with a module alias? You can pass any arbitrary
string to MODULE_ALIAS(). This would still break insmod but pretty much
everyone is calling modprobe to load kernel modules anyway.

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: i8k: move driver from char to hwmon

[Jean Delvare]

On Sun, 22 Feb 2015 10:11:16 -0800, Guenter Roeck wrote:
> I would still leave the driver name alone, though; the problem
> is that "modprobe i8k" is mentioned in pretty much all references
> to the driver.

This might be solved with a module alias? You can pass any arbitrary
string to MODULE_ALIAS(). This would still break insmod but pretty much
everyone is calling modprobe to load kernel modules anyway.

-- 
Jean Delvare
SUSE L3 Support

Re: [lm-sensors] i8k: move driver from char to hwmon

[Guenter Roeck]

On 02/22/2015 02:07 PM, Jean Delvare wrote:
> On Sun, 22 Feb 2015 10:11:16 -0800, Guenter Roeck wrote:
>> I would still leave the driver name alone, though; the problem
>> is that "modprobe i8k" is mentioned in pretty much all references
>> to the driver.
>
> This might be solved with a module alias? You can pass any arbitrary
> string to MODULE_ALIAS(). This would still break insmod but pretty much
> everyone is calling modprobe to load kernel modules anyway.
>

You are right, that might work.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: i8k: move driver from char to hwmon

[Guenter Roeck]

On 02/22/2015 02:07 PM, Jean Delvare wrote:
> On Sun, 22 Feb 2015 10:11:16 -0800, Guenter Roeck wrote:
>> I would still leave the driver name alone, though; the problem
>> is that "modprobe i8k" is mentioned in pretty much all references
>> to the driver.
>
> This might be solved with a module alias? You can pass any arbitrary
> string to MODULE_ALIAS(). This would still break insmod but pretty much
> everyone is calling modprobe to load kernel modules anyway.
>

You are right, that might work.

Thanks,
Guenter

Re: [lm-sensors] i8k: move driver from char to hwmon

[Jean Delvare]

T24gU3VuLCAyMiBGZWIgMjAxNSAxMDoxMToxNiAtMDgwMCwgR3VlbnRlciBSb2VjayB3cm90ZToK
PiBPbiAwMi8yMi8yMDE1IDA5OjQ0IEFNLCBQYWxpIFJvaMOhciB3cm90ZToKPiA+IFdoYXQgYWJv
dXQgQ09ORklHX0RFTExESUFHIChvciBERUxMU01NIG9yIENPTkZJR19TRU5TT1JTXyopIGZvcgo+
ID4gbWFuZGF0b3J5IGNvcmUgJiBod21vbiBjb2RlIGFuZCAoa2VlcCBleGlzdGluZykgQ09ORklH
X0k4SyBmb3IKPiA+IC9wcm9jL2k4az8KPiAKPiBPbmUgb3B0aW9uIG1pZ2h0IGJlIHRvIGxlYXZl
IENPTkZJR19JOEsgbW9yZSBvciBsZXNzIGFsb25lCj4gKGl0IGlzIGluIGFyY2gveDg2L0tjb25m
aWcgYW55d2F5LCB3aGljaCBpcyBvZGQgYnkgaXRzZWxmKSwKPiBidXQgYWRkIHNvbWV0aGluZyBs
aWtlCj4gCXNlbGVjdCBTRU5TT1JTX0RFTEwKPiAJc2VsZWN0IEk4S19QUk9DCj4gdG8gaXQuIFRo
ZW4gYWRkIG5ldyBjb25maWcgb3B0aW9ucyBTRU5TT1JTX0RFTEwgYW5kCj4gSThLX1BST0MgdG8g
ZHJpdmVycy9od21vbi9LY29uZmlnLgoKT24gYSByZWxhdGVkIG5vdGUuLi4KCkNoYW5naW5nIEtj
b25maWcgc3ltYm9sIG5hbWVzIGlzIGFsbG93ZWQsIGl0IGhhcyBoYXBwZW5lZCBhIGxvdCBpbiB0
aGUKcGFzdCwgYWx0aG91Z2ggd2Ugc2hvdWxkIG1ha2UgaXQgdGhlIGxlYXN0IHBhaW5mdWwgcG9z
c2libGUgZm9yIHRoZQp1c2Vycy4KCkkgdGhvdWdodCBhYm91dCBpdCBlYXJsaWVyIGFzIEkgY29u
c2lkZXJlZCBzZXZlcmFsIHRpbWVzIHRoZQpwb3NzaWJpbGl0eSB0byByZW5hbWUgYWxsIENPTkZJ
R19TRU5TT1JTXyogc3ltYm9scyB0byBDT05GSUdfSFdNT05fKgpmb3IgY29uc2lzdGVuY3kuIEkg
bmV2ZXIgYWN0dWFsbHkgdG9vayB0aGUgdGltZSB0byBkbyBpdCwgYnV0IGhlcmUncwpob3cgSSB3
b3VsZCBkbyBpdCwgdGFraW5nIHRoZSBsbTc1IGRyaXZlciBhcyBhbiBleGFtcGxlLgoKQXMgYSBm
aXJzdCBzdGVwLCBJIHdvdWxkIGludHJvZHVjZSBhIGhpZGRlbiBzeW1ib2wgdGhhdCB3b3VsZCBi
ZQpzZWxlY3RlZCBhdXRvbWF0aWNhbGx5IGJ5IHRoZSBleGlzdGluZyBzeW1ib2w6CgogZHJpdmVy
cy9od21vbi9LY29uZmlnICB8ICAgIDQgKysrKwogZHJpdmVycy9od21vbi9NYWtlZmlsZSB8ICAg
IDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgot
LS0gbGludXgtNC4xLXJjMC5vcmlnL2RyaXZlcnMvaHdtb24vS2NvbmZpZwkyMDE1LTA0LTIyIDA5
OjU0OjIxLjk2NTk3NDk0NCArMDIwMAorKysgbGludXgtNC4xLXJjMC9kcml2ZXJzL2h3bW9uL0tj
b25maWcJMjAxNS0wNC0yMiAxMDoxMDoxNi45NzQ1NTE5MzYgKzAyMDAKQEAgLTkwOSwxMCArOTA5
LDE0IEBAIGNvbmZpZyBTRU5TT1JTX0xNNzMKIAkgIFRoaXMgZHJpdmVyIGNhbiBhbHNvIGJlIGJ1
aWx0IGFzIGEgbW9kdWxlLiAgSWYgc28sIHRoZSBtb2R1bGUKIAkgIHdpbGwgYmUgY2FsbGVkIGxt
NzMuCiAKK2NvbmZpZyBIV01PTl9MTTc1CisJdHJpc3RhdGUKKwogY29uZmlnIFNFTlNPUlNfTE03
NQogCXRyaXN0YXRlICJOYXRpb25hbCBTZW1pY29uZHVjdG9yIExNNzUgYW5kIGNvbXBhdGlibGVz
IgogCWRlcGVuZHMgb24gSTJDCiAJZGVwZW5kcyBvbiBUSEVSTUFMIHx8ICFUSEVSTUFMX09GCisJ
c2VsZWN0IEhXTU9OX0xNNzUKIAloZWxwCiAJICBJZiB5b3Ugc2F5IHllcyBoZXJlIHlvdSBnZXQg
c3VwcG9ydCBmb3Igb25lIGNvbW1vbiB0eXBlIG9mCiAJICB0ZW1wZXJhdHVyZSBzZW5zb3IgY2hp
cCwgd2l0aCBtb2RlbHMgaW5jbHVkaW5nOgotLS0gbGludXgtNC4xLXJjMC5vcmlnL2RyaXZlcnMv
aHdtb24vTWFrZWZpbGUJMjAxNS0wNC0yMiAwOTo1NDoyMS45NjU5NzQ5NDQgKzAyMDAKKysrIGxp
bnV4LTQuMS1yYzAvZHJpdmVycy9od21vbi9NYWtlZmlsZQkyMDE1LTA0LTIyIDEwOjA5OjAzLjcx
MjA0ODg0OSArMDIwMApAQCAtODUsNyArODUsNyBAQCBvYmotJChDT05GSUdfU0VOU09SU19MSU5F
QUdFKQkrPSBsaW5lYWdlCiBvYmotJChDT05GSUdfU0VOU09SU19MTTYzKQkrPSBsbTYzLm8KIG9i
ai0kKENPTkZJR19TRU5TT1JTX0xNNzApCSs9IGxtNzAubwogb2JqLSQoQ09ORklHX1NFTlNPUlNf
TE03MykJKz0gbG03My5vCi1vYmotJChDT05GSUdfU0VOU09SU19MTTc1KQkrPSBsbTc1Lm8KK29i
ai0kKENPTkZJR19IV01PTl9MTTc1KQkrPSBsbTc1Lm8KIG9iai0kKENPTkZJR19TRU5TT1JTX0xN
NzcpCSs9IGxtNzcubwogb2JqLSQoQ09ORklHX1NFTlNPUlNfTE03OCkJKz0gbG03OC5vCiBvYmot
JChDT05GSUdfU0VOU09SU19MTTgwKQkrPSBsbTgwLm8KClJ1bm5pbmcgIm1ha2Ugb2xkY29uZmln
IiBhZnRlciB0aGF0IHNpbGVudGx5IHNlbGVjdHMgdGhlIG5ldyBzeW1ib2wgYXMKbmVlZGVkOgoK
LS0tIC5jb25maWcub2xkCTIwMTUtMDQtMjAgMTA6MTY6NDIuNjQ1MzU5MzEzICswMjAwCisrKyAu
Y29uZmlnCTIwMTUtMDQtMjIgMTA6MDk6MDkuMzU4MTY0NTk5ICswMjAwCkBAIC0yODA1LDYgKzI4
MDUsNyBAQAogQ09ORklHX1NFTlNPUlNfTE02Mz1tCiAjIENPTkZJR19TRU5TT1JTX0xNNzAgaXMg
bm90IHNldAogQ09ORklHX1NFTlNPUlNfTE03Mz1tCitDT05GSUdfSFdNT05fTE03NT1tCiBDT05G
SUdfU0VOU09SU19MTTc1PW0KIENPTkZJR19TRU5TT1JTX0xNNzc9bQogQ09ORklHX1NFTlNPUlNf
TE03OD1tCgpUaGVuIEkgd291bGQgbGV0IHNldmVyYWwga2VybmVsIHZlcnNpb25zIHBhc3MuIEFm
dGVyIGEgeWVhciBtYXliZSwgb3IgNQprZXJuZWwgdmVyc2lvbnMsIHdlIGNvdWxkIGdldCByaWQg
b2YgdGhlIG9yaWdpbmFsIHN5bWJvbDoKCiBkcml2ZXJzL2h3bW9uL0tjb25maWcgfCAgICA0IC0t
LS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGRlbGV0aW9ucygtKQoKLS0tIGxpbnV4LTQuMS1yYzAub3Jp
Zy9kcml2ZXJzL2h3bW9uL0tjb25maWcJMjAxNS0wNC0yMiAxMDowODozOS4wMTc1NDI3NzEgKzAy
MDAKKysrIGxpbnV4LTQuMS1yYzAvZHJpdmVycy9od21vbi9LY29uZmlnCTIwMTUtMDQtMjIgMTA6
MDk6NTcuMzc2MTQ5NjAzICswMjAwCkBAIC05MTAsMTMgKzkxMCw5IEBAIGNvbmZpZyBTRU5TT1JT
X0xNNzMKIAkgIHdpbGwgYmUgY2FsbGVkIGxtNzMuCiAKIGNvbmZpZyBIV01PTl9MTTc1Ci0JdHJp
c3RhdGUKLQotY29uZmlnIFNFTlNPUlNfTE03NQogCXRyaXN0YXRlICJOYXRpb25hbCBTZW1pY29u
ZHVjdG9yIExNNzUgYW5kIGNvbXBhdGlibGVzIgogCWRlcGVuZHMgb24gSTJDCiAJZGVwZW5kcyBv
biBUSEVSTUFMIHx8ICFUSEVSTUFMX09GCi0Jc2VsZWN0IEhXTU9OX0xNNzUKIAloZWxwCiAJICBJ
ZiB5b3Ugc2F5IHllcyBoZXJlIHlvdSBnZXQgc3VwcG9ydCBmb3Igb25lIGNvbW1vbiB0eXBlIG9m
CiAJICB0ZW1wZXJhdHVyZSBzZW5zb3IgY2hpcCwgd2l0aCBtb2RlbHMgaW5jbHVkaW5nOgoKQWdh
aW4gcnVubmluZyAibWFrZSBvbGRjb25maWciIHdpbGwgZG8gdGhlIHJpZ2h0IHRoaW5nIHNpbGVu
dGx5OgoKLS0tIC5jb25maWcub2xkCTIwMTUtMDQtMjIgMTA6MDk6MDkuMzU4MTY0NTk5ICswMjAw
CisrKyAuY29uZmlnCTIwMTUtMDQtMjIgMTA6MTA6MDIuOTQyMjYzODUxICswMjAwCkBAIC0yODA2
LDcgKzI4MDYsNiBAQAogIyBDT05GSUdfU0VOU09SU19MTTcwIGlzIG5vdCBzZXQKIENPTkZJR19T
RU5TT1JTX0xNNzM9bQogQ09ORklHX0hXTU9OX0xNNzU9bQotQ09ORklHX1NFTlNPUlNfTE03NT1t
CiBDT05GSUdfU0VOU09SU19MTTc3PW0KIENPTkZJR19TRU5TT1JTX0xNNzg9bQogQ09ORklHX1NF
TlNPUlNfTE04MD1tCgpUaGlzIGFsbG93cyBmb3IgYSB0cmFuc3BhcmVudCBtaWdyYXRpb24gdG8g
dGhlIG5ldyBuYW1lcyBmcm9tIGEgdXNlcidzCnBlcnNwZWN0aXZlLCBhcyBsb25nIGFzIHRoZXkg
ZG8gbm90IGp1bXAgZGlyZWN0bHkgZnJvbSB0aGUgb3JpZ2luYWwKc3RhdGUgdG8gdGhlIGZpbmFs
IHN0YXRlLiBNYXliZSBzb21ldGhpbmcgbGlrZSB0aGF0IGNhbiBiZSBkb25lIGZvcgpDT05GSUdf
SThLIGlmIHlvdSB3YW50IHRvIHJlbmFtZSBpdC4KCi0tIApKZWFuIERlbHZhcmUKU1VTRSBMMyBT
dXBwb3J0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps
bS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCmh0dHA6Ly9s
aXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM

Re: i8k: move driver from char to hwmon

[Jean Delvare]

On Sun, 22 Feb 2015 10:11:16 -0800, Guenter Roeck wrote:
> On 02/22/2015 09:44 AM, Pali Rohár wrote:
> > What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for
> > mandatory core & hwmon code and (keep existing) CONFIG_I8K for
> > /proc/i8k?
> 
> One option might be to leave CONFIG_I8K more or less alone
> (it is in arch/x86/Kconfig anyway, which is odd by itself),
> but add something like
> 	select SENSORS_DELL
> 	select I8K_PROC
> to it. Then add new config options SENSORS_DELL and
> I8K_PROC to drivers/hwmon/Kconfig.

On a related note...

Changing Kconfig symbol names is allowed, it has happened a lot in the
past, although we should make it the least painful possible for the
users.

I thought about it earlier as I considered several times the
possibility to rename all CONFIG_SENSORS_* symbols to CONFIG_HWMON_*
for consistency. I never actually took the time to do it, but here's
how I would do it, taking the lm75 driver as an example.

As a first step, I would introduce a hidden symbol that would be
selected automatically by the existing symbol:

 drivers/hwmon/Kconfig  |    4 ++++
 drivers/hwmon/Makefile |    2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

--- linux-4.1-rc0.orig/drivers/hwmon/Kconfig	2015-04-22 09:54:21.965974944 +0200
+++ linux-4.1-rc0/drivers/hwmon/Kconfig	2015-04-22 10:10:16.974551936 +0200
@@ -909,10 +909,14 @@ config SENSORS_LM73
 	  This driver can also be built as a module.  If so, the module
 	  will be called lm73.
 
+config HWMON_LM75
+	tristate
+
 config SENSORS_LM75
 	tristate "National Semiconductor LM75 and compatibles"
 	depends on I2C
 	depends on THERMAL || !THERMAL_OF
+	select HWMON_LM75
 	help
 	  If you say yes here you get support for one common type of
 	  temperature sensor chip, with models including:
--- linux-4.1-rc0.orig/drivers/hwmon/Makefile	2015-04-22 09:54:21.965974944 +0200
+++ linux-4.1-rc0/drivers/hwmon/Makefile	2015-04-22 10:09:03.712048849 +0200
@@ -85,7 +85,7 @@ obj-$(CONFIG_SENSORS_LINEAGE)	+= lineage
 obj-$(CONFIG_SENSORS_LM63)	+= lm63.o
 obj-$(CONFIG_SENSORS_LM70)	+= lm70.o
 obj-$(CONFIG_SENSORS_LM73)	+= lm73.o
-obj-$(CONFIG_SENSORS_LM75)	+= lm75.o
+obj-$(CONFIG_HWMON_LM75)	+= lm75.o
 obj-$(CONFIG_SENSORS_LM77)	+= lm77.o
 obj-$(CONFIG_SENSORS_LM78)	+= lm78.o
 obj-$(CONFIG_SENSORS_LM80)	+= lm80.o

Running "make oldconfig" after that silently selects the new symbol as
needed:

--- .config.old	2015-04-20 10:16:42.645359313 +0200
+++ .config	2015-04-22 10:09:09.358164599 +0200
@@ -2805,6 +2805,7 @@
 CONFIG_SENSORS_LM63=m
 # CONFIG_SENSORS_LM70 is not set
 CONFIG_SENSORS_LM73=m
+CONFIG_HWMON_LM75=m
 CONFIG_SENSORS_LM75=m
 CONFIG_SENSORS_LM77=m
 CONFIG_SENSORS_LM78=m

Then I would let several kernel versions pass. After a year maybe, or 5
kernel versions, we could get rid of the original symbol:

 drivers/hwmon/Kconfig |    4 ----
 1 file changed, 4 deletions(-)

--- linux-4.1-rc0.orig/drivers/hwmon/Kconfig	2015-04-22 10:08:39.017542771 +0200
+++ linux-4.1-rc0/drivers/hwmon/Kconfig	2015-04-22 10:09:57.376149603 +0200
@@ -910,13 +910,9 @@ config SENSORS_LM73
 	  will be called lm73.
 
 config HWMON_LM75
-	tristate
-
-config SENSORS_LM75
 	tristate "National Semiconductor LM75 and compatibles"
 	depends on I2C
 	depends on THERMAL || !THERMAL_OF
-	select HWMON_LM75
 	help
 	  If you say yes here you get support for one common type of
 	  temperature sensor chip, with models including:

Again running "make oldconfig" will do the right thing silently:

--- .config.old	2015-04-22 10:09:09.358164599 +0200
+++ .config	2015-04-22 10:10:02.942263851 +0200
@@ -2806,7 +2806,6 @@
 # CONFIG_SENSORS_LM70 is not set
 CONFIG_SENSORS_LM73=m
 CONFIG_HWMON_LM75=m
-CONFIG_SENSORS_LM75=m
 CONFIG_SENSORS_LM77=m
 CONFIG_SENSORS_LM78=m
 CONFIG_SENSORS_LM80=m

This allows for a transparent migration to the new names from a user's
perspective, as long as they do not jump directly from the original
state to the final state. Maybe something like that can be done for
CONFIG_I8K if you want to rename it.

-- 
Jean Delvare
SUSE L3 Support

Re: [lm-sensors] i8k: move driver from char to hwmon

[Pali Rohár]

T24gV2VkbmVzZGF5IDIyIEFwcmlsIDIwMTUgMTA6MjM6MDQgSmVhbiBEZWx2YXJlIHdyb3RlOgo+
IE9uIFN1biwgMjIgRmViIDIwMTUgMTA6MTE6MTYgLTA4MDAsIEd1ZW50ZXIgUm9lY2sgd3JvdGU6
Cj4gPiBPbiAwMi8yMi8yMDE1IDA5OjQ0IEFNLCBQYWxpIFJvaMOhciB3cm90ZToKPiA+ID4gV2hh
dCBhYm91dCBDT05GSUdfREVMTERJQUcgKG9yIERFTExTTU0gb3IgQ09ORklHX1NFTlNPUlNfKikg
Zm9yCj4gPiA+IG1hbmRhdG9yeSBjb3JlICYgaHdtb24gY29kZSBhbmQgKGtlZXAgZXhpc3Rpbmcp
IENPTkZJR19JOEsgZm9yCj4gPiA+IC9wcm9jL2k4az8KPiA+IAo+ID4gT25lIG9wdGlvbiBtaWdo
dCBiZSB0byBsZWF2ZSBDT05GSUdfSThLIG1vcmUgb3IgbGVzcyBhbG9uZQo+ID4gKGl0IGlzIGlu
IGFyY2gveDg2L0tjb25maWcgYW55d2F5LCB3aGljaCBpcyBvZGQgYnkgaXRzZWxmKSwKPiA+IGJ1
dCBhZGQgc29tZXRoaW5nIGxpa2UKPiA+IAlzZWxlY3QgU0VOU09SU19ERUxMCj4gPiAJc2VsZWN0
IEk4S19QUk9DCj4gPiB0byBpdC4gVGhlbiBhZGQgbmV3IGNvbmZpZyBvcHRpb25zIFNFTlNPUlNf
REVMTCBhbmQKPiA+IEk4S19QUk9DIHRvIGRyaXZlcnMvaHdtb24vS2NvbmZpZy4KPiAKPiBPbiBh
IHJlbGF0ZWQgbm90ZS4uLgo+IAo+IENoYW5naW5nIEtjb25maWcgc3ltYm9sIG5hbWVzIGlzIGFs
bG93ZWQsIGl0IGhhcyBoYXBwZW5lZCBhIGxvdCBpbiB0aGUKPiBwYXN0LCBhbHRob3VnaCB3ZSBz
aG91bGQgbWFrZSBpdCB0aGUgbGVhc3QgcGFpbmZ1bCBwb3NzaWJsZSBmb3IgdGhlCj4gdXNlcnMu
Cj4gCj4gSSB0aG91Z2h0IGFib3V0IGl0IGVhcmxpZXIgYXMgSSBjb25zaWRlcmVkIHNldmVyYWwg
dGltZXMgdGhlCj4gcG9zc2liaWxpdHkgdG8gcmVuYW1lIGFsbCBDT05GSUdfU0VOU09SU18qIHN5
bWJvbHMgdG8gQ09ORklHX0hXTU9OXyoKPiBmb3IgY29uc2lzdGVuY3kuIEkgbmV2ZXIgYWN0dWFs
bHkgdG9vayB0aGUgdGltZSB0byBkbyBpdCwgYnV0IGhlcmUncwo+IGhvdyBJIHdvdWxkIGRvIGl0
LCB0YWtpbmcgdGhlIGxtNzUgZHJpdmVyIGFzIGFuIGV4YW1wbGUuCj4gCj4gQXMgYSBmaXJzdCBz
dGVwLCBJIHdvdWxkIGludHJvZHVjZSBhIGhpZGRlbiBzeW1ib2wgdGhhdCB3b3VsZCBiZQo+IHNl
bGVjdGVkIGF1dG9tYXRpY2FsbHkgYnkgdGhlIGV4aXN0aW5nIHN5bWJvbDoKPiAKPiAgZHJpdmVy
cy9od21vbi9LY29uZmlnICB8ICAgIDQgKysrKwo+ICBkcml2ZXJzL2h3bW9uL01ha2VmaWxlIHwg
ICAgMiArLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt
KQo+IAo+IC0tLSBsaW51eC00LjEtcmMwLm9yaWcvZHJpdmVycy9od21vbi9LY29uZmlnCTIwMTUt
MDQtMjIgMDk6NTQ6MjEuOTY1OTc0OTQ0ICswMjAwCj4gKysrIGxpbnV4LTQuMS1yYzAvZHJpdmVy
cy9od21vbi9LY29uZmlnCTIwMTUtMDQtMjIgMTA6MTA6MTYuOTc0NTUxOTM2ICswMjAwCj4gQEAg
LTkwOSwxMCArOTA5LDE0IEBAIGNvbmZpZyBTRU5TT1JTX0xNNzMKPiAgCSAgVGhpcyBkcml2ZXIg
Y2FuIGFsc28gYmUgYnVpbHQgYXMgYSBtb2R1bGUuICBJZiBzbywgdGhlIG1vZHVsZQo+ICAJICB3
aWxsIGJlIGNhbGxlZCBsbTczLgo+ICAKPiArY29uZmlnIEhXTU9OX0xNNzUKPiArCXRyaXN0YXRl
Cj4gKwo+ICBjb25maWcgU0VOU09SU19MTTc1Cj4gIAl0cmlzdGF0ZSAiTmF0aW9uYWwgU2VtaWNv
bmR1Y3RvciBMTTc1IGFuZCBjb21wYXRpYmxlcyIKPiAgCWRlcGVuZHMgb24gSTJDCj4gIAlkZXBl
bmRzIG9uIFRIRVJNQUwgfHwgIVRIRVJNQUxfT0YKPiArCXNlbGVjdCBIV01PTl9MTTc1Cj4gIAlo
ZWxwCj4gIAkgIElmIHlvdSBzYXkgeWVzIGhlcmUgeW91IGdldCBzdXBwb3J0IGZvciBvbmUgY29t
bW9uIHR5cGUgb2YKPiAgCSAgdGVtcGVyYXR1cmUgc2Vuc29yIGNoaXAsIHdpdGggbW9kZWxzIGlu
Y2x1ZGluZzoKPiAtLS0gbGludXgtNC4xLXJjMC5vcmlnL2RyaXZlcnMvaHdtb24vTWFrZWZpbGUJ
MjAxNS0wNC0yMiAwOTo1NDoyMS45NjU5NzQ5NDQgKzAyMDAKPiArKysgbGludXgtNC4xLXJjMC9k
cml2ZXJzL2h3bW9uL01ha2VmaWxlCTIwMTUtMDQtMjIgMTA6MDk6MDMuNzEyMDQ4ODQ5ICswMjAw
Cj4gQEAgLTg1LDcgKzg1LDcgQEAgb2JqLSQoQ09ORklHX1NFTlNPUlNfTElORUFHRSkJKz0gbGlu
ZWFnZQo+ICBvYmotJChDT05GSUdfU0VOU09SU19MTTYzKQkrPSBsbTYzLm8KPiAgb2JqLSQoQ09O
RklHX1NFTlNPUlNfTE03MCkJKz0gbG03MC5vCj4gIG9iai0kKENPTkZJR19TRU5TT1JTX0xNNzMp
CSs9IGxtNzMubwo+IC1vYmotJChDT05GSUdfU0VOU09SU19MTTc1KQkrPSBsbTc1Lm8KPiArb2Jq
LSQoQ09ORklHX0hXTU9OX0xNNzUpCSs9IGxtNzUubwo+ICBvYmotJChDT05GSUdfU0VOU09SU19M
TTc3KQkrPSBsbTc3Lm8KPiAgb2JqLSQoQ09ORklHX1NFTlNPUlNfTE03OCkJKz0gbG03OC5vCj4g
IG9iai0kKENPTkZJR19TRU5TT1JTX0xNODApCSs9IGxtODAubwo+IAo+IFJ1bm5pbmcgIm1ha2Ug
b2xkY29uZmlnIiBhZnRlciB0aGF0IHNpbGVudGx5IHNlbGVjdHMgdGhlIG5ldyBzeW1ib2wgYXMK
PiBuZWVkZWQ6Cj4gCj4gLS0tIC5jb25maWcub2xkCTIwMTUtMDQtMjAgMTA6MTY6NDIuNjQ1MzU5
MzEzICswMjAwCj4gKysrIC5jb25maWcJMjAxNS0wNC0yMiAxMDowOTowOS4zNTgxNjQ1OTkgKzAy
MDAKPiBAQCAtMjgwNSw2ICsyODA1LDcgQEAKPiAgQ09ORklHX1NFTlNPUlNfTE02Mz1tCj4gICMg
Q09ORklHX1NFTlNPUlNfTE03MCBpcyBub3Qgc2V0Cj4gIENPTkZJR19TRU5TT1JTX0xNNzM9bQo+
ICtDT05GSUdfSFdNT05fTE03NT1tCj4gIENPTkZJR19TRU5TT1JTX0xNNzU9bQo+ICBDT05GSUdf
U0VOU09SU19MTTc3PW0KPiAgQ09ORklHX1NFTlNPUlNfTE03OD1tCj4gCj4gVGhlbiBJIHdvdWxk
IGxldCBzZXZlcmFsIGtlcm5lbCB2ZXJzaW9ucyBwYXNzLiBBZnRlciBhIHllYXIgbWF5YmUsIG9y
IDUKPiBrZXJuZWwgdmVyc2lvbnMsIHdlIGNvdWxkIGdldCByaWQgb2YgdGhlIG9yaWdpbmFsIHN5
bWJvbDoKPiAKPiAgZHJpdmVycy9od21vbi9LY29uZmlnIHwgICAgNCAtLS0tCj4gIDEgZmlsZSBj
aGFuZ2VkLCA0IGRlbGV0aW9ucygtKQo+IAo+IC0tLSBsaW51eC00LjEtcmMwLm9yaWcvZHJpdmVy
cy9od21vbi9LY29uZmlnCTIwMTUtMDQtMjIgMTA6MDg6MzkuMDE3NTQyNzcxICswMjAwCj4gKysr
IGxpbnV4LTQuMS1yYzAvZHJpdmVycy9od21vbi9LY29uZmlnCTIwMTUtMDQtMjIgMTA6MDk6NTcu
Mzc2MTQ5NjAzICswMjAwCj4gQEAgLTkxMCwxMyArOTEwLDkgQEAgY29uZmlnIFNFTlNPUlNfTE03
Mwo+ICAJICB3aWxsIGJlIGNhbGxlZCBsbTczLgo+ICAKPiAgY29uZmlnIEhXTU9OX0xNNzUKPiAt
CXRyaXN0YXRlCj4gLQo+IC1jb25maWcgU0VOU09SU19MTTc1Cj4gIAl0cmlzdGF0ZSAiTmF0aW9u
YWwgU2VtaWNvbmR1Y3RvciBMTTc1IGFuZCBjb21wYXRpYmxlcyIKPiAgCWRlcGVuZHMgb24gSTJD
Cj4gIAlkZXBlbmRzIG9uIFRIRVJNQUwgfHwgIVRIRVJNQUxfT0YKPiAtCXNlbGVjdCBIV01PTl9M
TTc1Cj4gIAloZWxwCj4gIAkgIElmIHlvdSBzYXkgeWVzIGhlcmUgeW91IGdldCBzdXBwb3J0IGZv
ciBvbmUgY29tbW9uIHR5cGUgb2YKPiAgCSAgdGVtcGVyYXR1cmUgc2Vuc29yIGNoaXAsIHdpdGgg
bW9kZWxzIGluY2x1ZGluZzoKPiAKPiBBZ2FpbiBydW5uaW5nICJtYWtlIG9sZGNvbmZpZyIgd2ls
bCBkbyB0aGUgcmlnaHQgdGhpbmcgc2lsZW50bHk6Cj4gCj4gLS0tIC5jb25maWcub2xkCTIwMTUt
MDQtMjIgMTA6MDk6MDkuMzU4MTY0NTk5ICswMjAwCj4gKysrIC5jb25maWcJMjAxNS0wNC0yMiAx
MDoxMDowMi45NDIyNjM4NTEgKzAyMDAKPiBAQCAtMjgwNiw3ICsyODA2LDYgQEAKPiAgIyBDT05G
SUdfU0VOU09SU19MTTcwIGlzIG5vdCBzZXQKPiAgQ09ORklHX1NFTlNPUlNfTE03Mz1tCj4gIENP
TkZJR19IV01PTl9MTTc1PW0KPiAtQ09ORklHX1NFTlNPUlNfTE03NT1tCj4gIENPTkZJR19TRU5T
T1JTX0xNNzc9bQo+ICBDT05GSUdfU0VOU09SU19MTTc4PW0KPiAgQ09ORklHX1NFTlNPUlNfTE04
MD1tCj4gCj4gVGhpcyBhbGxvd3MgZm9yIGEgdHJhbnNwYXJlbnQgbWlncmF0aW9uIHRvIHRoZSBu
ZXcgbmFtZXMgZnJvbSBhIHVzZXIncwo+IHBlcnNwZWN0aXZlLCBhcyBsb25nIGFzIHRoZXkgZG8g
bm90IGp1bXAgZGlyZWN0bHkgZnJvbSB0aGUgb3JpZ2luYWwKPiBzdGF0ZSB0byB0aGUgZmluYWwg
c3RhdGUuIE1heWJlIHNvbWV0aGluZyBsaWtlIHRoYXQgY2FuIGJlIGRvbmUgZm9yCj4gQ09ORklH
X0k4SyBpZiB5b3Ugd2FudCB0byByZW5hbWUgaXQuCj4gCgpIaSwgSSBhbHJlYWR5IHNlbnQgcmVu
YW1lIHBhdGNoIHNlcmllcywgc2VlIFsxXS4gQW5kIEdyZWcgd2lsbCBtZXJnZSBpdAppbnRvIDQu
MS1yYzIsIHNlZSBbMl0uCgpbMV0gLSBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxNS8zLzI5LzM1
ClsyXSAtIGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE1LzQvMjEvNDI5CgotLSAKUGFsaSBSb2jD
oXIKcGFsaS5yb2hhckBnbWFpbC5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vu
c29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0t
c2Vuc29ycw=

Re: i8k: move driver from char to hwmon

[Pali Rohár]

On Wednesday 22 April 2015 10:23:04 Jean Delvare wrote:
> On Sun, 22 Feb 2015 10:11:16 -0800, Guenter Roeck wrote:
> > On 02/22/2015 09:44 AM, Pali Rohár wrote:
> > > What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for
> > > mandatory core & hwmon code and (keep existing) CONFIG_I8K for
> > > /proc/i8k?
> > 
> > One option might be to leave CONFIG_I8K more or less alone
> > (it is in arch/x86/Kconfig anyway, which is odd by itself),
> > but add something like
> > 	select SENSORS_DELL
> > 	select I8K_PROC
> > to it. Then add new config options SENSORS_DELL and
> > I8K_PROC to drivers/hwmon/Kconfig.
> 
> On a related note...
> 
> Changing Kconfig symbol names is allowed, it has happened a lot in the
> past, although we should make it the least painful possible for the
> users.
> 
> I thought about it earlier as I considered several times the
> possibility to rename all CONFIG_SENSORS_* symbols to CONFIG_HWMON_*
> for consistency. I never actually took the time to do it, but here's
> how I would do it, taking the lm75 driver as an example.
> 
> As a first step, I would introduce a hidden symbol that would be
> selected automatically by the existing symbol:
> 
>  drivers/hwmon/Kconfig  |    4 ++++
>  drivers/hwmon/Makefile |    2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> --- linux-4.1-rc0.orig/drivers/hwmon/Kconfig	2015-04-22 09:54:21.965974944 +0200
> +++ linux-4.1-rc0/drivers/hwmon/Kconfig	2015-04-22 10:10:16.974551936 +0200
> @@ -909,10 +909,14 @@ config SENSORS_LM73
>  	  This driver can also be built as a module.  If so, the module
>  	  will be called lm73.
>  
> +config HWMON_LM75
> +	tristate
> +
>  config SENSORS_LM75
>  	tristate "National Semiconductor LM75 and compatibles"
>  	depends on I2C
>  	depends on THERMAL || !THERMAL_OF
> +	select HWMON_LM75
>  	help
>  	  If you say yes here you get support for one common type of
>  	  temperature sensor chip, with models including:
> --- linux-4.1-rc0.orig/drivers/hwmon/Makefile	2015-04-22 09:54:21.965974944 +0200
> +++ linux-4.1-rc0/drivers/hwmon/Makefile	2015-04-22 10:09:03.712048849 +0200
> @@ -85,7 +85,7 @@ obj-$(CONFIG_SENSORS_LINEAGE)	+= lineage
>  obj-$(CONFIG_SENSORS_LM63)	+= lm63.o
>  obj-$(CONFIG_SENSORS_LM70)	+= lm70.o
>  obj-$(CONFIG_SENSORS_LM73)	+= lm73.o
> -obj-$(CONFIG_SENSORS_LM75)	+= lm75.o
> +obj-$(CONFIG_HWMON_LM75)	+= lm75.o
>  obj-$(CONFIG_SENSORS_LM77)	+= lm77.o
>  obj-$(CONFIG_SENSORS_LM78)	+= lm78.o
>  obj-$(CONFIG_SENSORS_LM80)	+= lm80.o
> 
> Running "make oldconfig" after that silently selects the new symbol as
> needed:
> 
> --- .config.old	2015-04-20 10:16:42.645359313 +0200
> +++ .config	2015-04-22 10:09:09.358164599 +0200
> @@ -2805,6 +2805,7 @@
>  CONFIG_SENSORS_LM63=m
>  # CONFIG_SENSORS_LM70 is not set
>  CONFIG_SENSORS_LM73=m
> +CONFIG_HWMON_LM75=m
>  CONFIG_SENSORS_LM75=m
>  CONFIG_SENSORS_LM77=m
>  CONFIG_SENSORS_LM78=m
> 
> Then I would let several kernel versions pass. After a year maybe, or 5
> kernel versions, we could get rid of the original symbol:
> 
>  drivers/hwmon/Kconfig |    4 ----
>  1 file changed, 4 deletions(-)
> 
> --- linux-4.1-rc0.orig/drivers/hwmon/Kconfig	2015-04-22 10:08:39.017542771 +0200
> +++ linux-4.1-rc0/drivers/hwmon/Kconfig	2015-04-22 10:09:57.376149603 +0200
> @@ -910,13 +910,9 @@ config SENSORS_LM73
>  	  will be called lm73.
>  
>  config HWMON_LM75
> -	tristate
> -
> -config SENSORS_LM75
>  	tristate "National Semiconductor LM75 and compatibles"
>  	depends on I2C
>  	depends on THERMAL || !THERMAL_OF
> -	select HWMON_LM75
>  	help
>  	  If you say yes here you get support for one common type of
>  	  temperature sensor chip, with models including:
> 
> Again running "make oldconfig" will do the right thing silently:
> 
> --- .config.old	2015-04-22 10:09:09.358164599 +0200
> +++ .config	2015-04-22 10:10:02.942263851 +0200
> @@ -2806,7 +2806,6 @@
>  # CONFIG_SENSORS_LM70 is not set
>  CONFIG_SENSORS_LM73=m
>  CONFIG_HWMON_LM75=m
> -CONFIG_SENSORS_LM75=m
>  CONFIG_SENSORS_LM77=m
>  CONFIG_SENSORS_LM78=m
>  CONFIG_SENSORS_LM80=m
> 
> This allows for a transparent migration to the new names from a user's
> perspective, as long as they do not jump directly from the original
> state to the final state. Maybe something like that can be done for
> CONFIG_I8K if you want to rename it.
> 

Hi, I already sent rename patch series, see [1]. And Greg will merge it
into 4.1-rc2, see [2].

[1] - https://lkml.org/lkml/2015/3/29/35
[2] - https://lkml.org/lkml/2015/4/21/429

-- 
Pali Rohár
pali.rohar@gmail.com