* [PATCH] Staging: sm750fb: ddk750_help: Included KERN_ facility level
@ 2015-10-08 10:00 Shivani Bhardwaj
2015-10-09 4:14 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Shivani Bhardwaj @ 2015-10-08 10:00 UTC (permalink / raw)
To: outreachy-kernel
Fixed the warning : printk() should include KERN_ facility level
generated by checkpatch by using the function pr_info() instead of
printk().
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
drivers/staging/sm750fb/ddk750_help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..e72a29c 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
devId750 = devId;
revId750 = revId;
if (revId == 0xfe)
- printk("found sm750le\n");
+ pr_info("found sm750le\n");
}
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: sm750fb: ddk750_help: Included KERN_ facility level
2015-10-08 10:00 [PATCH] Staging: sm750fb: ddk750_help: Included KERN_ facility level Shivani Bhardwaj
@ 2015-10-09 4:14 ` Greg KH
2015-10-09 6:28 ` Shivani Bhardwaj
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2015-10-09 4:14 UTC (permalink / raw)
To: Shivani Bhardwaj; +Cc: outreachy-kernel
On Thu, Oct 08, 2015 at 03:30:54PM +0530, Shivani Bhardwaj wrote:
> Fixed the warning : printk() should include KERN_ facility level
> generated by checkpatch by using the function pr_info() instead of
> printk().
>
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_help.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
> index 9637dd3..e72a29c 100644
> --- a/drivers/staging/sm750fb/ddk750_help.c
> +++ b/drivers/staging/sm750fb/ddk750_help.c
> @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
> devId750 = devId;
> revId750 = revId;
> if (revId == 0xfe)
> - printk("found sm750le\n");
> + pr_info("found sm750le\n");
Can you use dev_info() here instead?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: sm750fb: ddk750_help: Included KERN_ facility level
2015-10-09 4:14 ` [Outreachy kernel] " Greg KH
@ 2015-10-09 6:28 ` Shivani Bhardwaj
0 siblings, 0 replies; 3+ messages in thread
From: Shivani Bhardwaj @ 2015-10-09 6:28 UTC (permalink / raw)
To: outreachy-kernel
On Thu, Oct 08, 2015 at 09:14:02PM -0700, Greg KH wrote:
> On Thu, Oct 08, 2015 at 03:30:54PM +0530, Shivani Bhardwaj wrote:
> > Fixed the warning : printk() should include KERN_ facility level
> > generated by checkpatch by using the function pr_info() instead of
> > printk().
> >
> > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_help.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
> > index 9637dd3..e72a29c 100644
> > --- a/drivers/staging/sm750fb/ddk750_help.c
> > +++ b/drivers/staging/sm750fb/ddk750_help.c
> > @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
> > devId750 = devId;
> > revId750 = revId;
> > if (revId == 0xfe)
> > - printk("found sm750le\n");
> > + pr_info("found sm750le\n");
>
> Can you use dev_info() here instead?
Yes, OK. I'm sending version 2. :)
Thank you
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-09 6:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-08 10:00 [PATCH] Staging: sm750fb: ddk750_help: Included KERN_ facility level Shivani Bhardwaj
2015-10-09 4:14 ` [Outreachy kernel] " Greg KH
2015-10-09 6:28 ` Shivani Bhardwaj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.