All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 09/15] log: Add a console driver
Date: Mon,  4 Dec 2017 13:48:25 -0700	[thread overview]
Message-ID: <20171204204831.98915-10-sjg@chromium.org> (raw)
In-Reply-To: <20171204204831.98915-1-sjg@chromium.org>

It is useful to display log messages on the console. Add a simple driver
to handle this.

Note that this driver outputs to the console, which may be serial or
video. It does not specifically select serial output.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v4: None
Changes in v3: None
Changes in v2:
- Update commit message to explain that this is not just for serial output

 common/Kconfig       | 20 ++++++++++++++++++++
 common/Makefile      |  1 +
 common/log_console.c | 23 +++++++++++++++++++++++
 3 files changed, 44 insertions(+)
 create mode 100644 common/log_console.c

diff --git a/common/Kconfig b/common/Kconfig
index 9747443feb..1b157e47c3 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -474,6 +474,26 @@ config SPL_LOG_MAX_LEVEL
 	    6 - detail
 	    7 - debug
 
+config LOG_CONSOLE
+	bool "Allow log output to the console"
+	depends on LOG
+	default y
+	help
+	  Enables a log driver which writes log records to the console.
+	  Generally the console is the serial port or LCD display. Only the
+	  log message is shown - other details like level, category, file and
+	  line number are omitted.
+
+config LOG_SPL_CONSOLE
+	bool "Allow log output to the console in SPL"
+	depends on LOG_SPL
+	default y
+	help
+	  Enables a log driver which writes log records to the console.
+	  Generally the console is the serial port or LCD display. Only the
+	  log message is shown - other details like level, category, file and
+	  line number are omitted.
+
 endmenu
 
 config DEFAULT_FDT_FILE
diff --git a/common/Makefile b/common/Makefile
index f4b632761f..14166209fe 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -129,5 +129,6 @@ obj-$(CONFIG_FSL_DDR_INTERACTIVE) += cli_simple.o cli_readline.o
 obj-$(CONFIG_CMD_DFU) += dfu.o
 obj-y += command.o
 obj-$(CONFIG_$(SPL_)LOG) += log.o
+obj-$(CONFIG_$(SPL_)LOG_CONSOLE) += log_console.o
 obj-y += s_record.o
 obj-y += xyzModem.o
diff --git a/common/log_console.c b/common/log_console.c
new file mode 100644
index 0000000000..5af73bd8be
--- /dev/null
+++ b/common/log_console.c
@@ -0,0 +1,23 @@
+/*
+ * Logging support
+ *
+ * Copyright (c) 2017 Google, Inc
+ * Written by Simon Glass <sjg@chromium.org>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#include <common.h>
+#include <log.h>
+
+static int log_console_emit(struct log_device *ldev, struct log_rec *rec)
+{
+	puts(rec->msg);
+
+	return 0;
+}
+
+LOG_DRIVER(console) = {
+	.name	= "console",
+	.emit	= log_console_emit,
+};
-- 
2.15.0.531.g2ccb3012c9-goog

  parent reply	other threads:[~2017-12-04 20:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04 20:48 [U-Boot] [PATCH v4 00/15] log: Add a new logging feature Simon Glass
2017-12-04 20:48 ` [U-Boot] [PATCH v4 01/15] Revert "sandbox: remove os_putc() and os_puts()" Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 02/15] sandbox: Adjust pre-console address to avoid conflict Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 03/15] Revert "sandbox: Drop special case console code for sandbox" Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 04/15] Move debug and logging support to a separate header Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 05/15] mtdparts: Correct use of debug() Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot,v4,05/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 06/15] usb: " Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot,v4,06/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 07/15] Drop the log buffer Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot,v4,07/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 08/15] log: Add an implementation of logging Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` Simon Glass [this message]
2017-12-07 22:54   ` [U-Boot] [U-Boot,v4,09/15] log: Add a console driver Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 10/15] log: Add a 'log level' command Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot,v4,10/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 11/15] log: Add a test command Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot,v4,11/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 12/15] log: Plumb logging into the init sequence Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 13/15] log: sandbox: Enable logging Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot,v4,13/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 14/15] log: test: Add a pytest for logging Simon Glass
2017-12-07 22:54   ` [U-Boot] [U-Boot,v4,14/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 15/15] log: Add documentation Simon Glass
2017-12-07 22:55   ` [U-Boot] [U-Boot,v4,15/15] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204204831.98915-10-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.