From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 14/15] log: test: Add a pytest for logging
Date: Mon, 4 Dec 2017 13:48:30 -0700 [thread overview]
Message-ID: <20171204204831.98915-15-sjg@chromium.org> (raw)
In-Reply-To: <20171204204831.98915-1-sjg@chromium.org>
Add a test which tries out various filters and options to make sure that
logging works as expected.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v4: None
Changes in v3: None
Changes in v2:
- Change log levels to match new header
- Only execute log tests if CONFIG_LOG is enabled
- Rename LOGL_WARN to LOGL_WARNING
MAINTAINERS | 1 +
test/py/tests/test_log.py | 101 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 102 insertions(+)
create mode 100644 test/py/tests/test_log.py
diff --git a/MAINTAINERS b/MAINTAINERS
index 9d8a82eaa9..e1227f847c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -317,6 +317,7 @@ T: git git://git.denx.de/u-boot.git
F: common/log.c
F: cmd/log.c
F: test/log/log_test.c
+F: test/py/tests/test_log.py
MICROBLAZE
M: Michal Simek <monstr@monstr.eu>
diff --git a/test/py/tests/test_log.py b/test/py/tests/test_log.py
new file mode 100644
index 0000000000..fa9a25e8dc
--- /dev/null
+++ b/test/py/tests/test_log.py
@@ -0,0 +1,101 @@
+# Copyright (c) 2016, Google Inc.
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+# U-Boot Verified Boot Test
+
+"""
+This tests U-Boot logging. It uses the 'log test' command with various options
+and checks that the output is correct.
+"""
+
+import pytest
+
+LOGL_FIRST, LOGL_WARNING, LOGL_INFO = (0, 4, 6)
+
+ at pytest.mark.buildconfigspec('log')
+def test_log(u_boot_console):
+ """Test that U-Boot logging works correctly."""
+ def check_log_entries(lines, mask, max_level=LOGL_INFO):
+ """Check that the expected log records appear in the output
+
+ Args:
+ lines: iterator containing lines to check
+ mask: bit mask to select which lines to check for:
+ bit 0: standard log line
+ bit 1: _log line
+ max_level: maximum log level to expect in the output
+ """
+ for i in range(max_level):
+ if mask & 1:
+ assert 'log %d' % i == lines.next()
+ if mask & 3:
+ assert '_log %d' % i == lines.next()
+
+ def run_test(testnum):
+ """Run a particular test number (the 'log test' command)
+
+ Args:
+ testnum: Test number to run
+ Returns:
+ iterator containing the lines output from the command
+ """
+
+ with cons.log.section('basic'):
+ output = u_boot_console.run_command('log test %d' % testnum)
+ split = output.replace('\r', '').splitlines()
+ lines = iter(split)
+ assert 'test %d' % testnum == lines.next()
+ return lines
+
+ def test0():
+ lines = run_test(0)
+ check_log_entries(lines, 3)
+
+ def test1():
+ lines = run_test(1)
+ check_log_entries(lines, 3)
+
+ def test2():
+ lines = run_test(2)
+
+ def test3():
+ lines = run_test(3)
+ check_log_entries(lines, 2)
+
+ def test4():
+ lines = run_test(4)
+ assert next(lines, None) == None
+
+ def test5():
+ lines = run_test(5)
+ check_log_entries(lines, 2)
+
+ def test6():
+ lines = run_test(6)
+ check_log_entries(lines, 3)
+
+ def test7():
+ lines = run_test(7)
+ check_log_entries(lines, 3, LOGL_WARNING)
+
+ def test8():
+ lines = run_test(8)
+ check_log_entries(lines, 3)
+
+ def test9():
+ lines = run_test(9)
+ check_log_entries(lines, 3)
+
+ # TODO(sjg at chromium.org): Consider structuring this as separate tests
+ cons = u_boot_console
+ test0()
+ test1()
+ test2()
+ test3()
+ test4()
+ test5()
+ test6()
+ test7()
+ test8()
+ test9()
--
2.15.0.531.g2ccb3012c9-goog
next prev parent reply other threads:[~2017-12-04 20:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 20:48 [U-Boot] [PATCH v4 00/15] log: Add a new logging feature Simon Glass
2017-12-04 20:48 ` [U-Boot] [PATCH v4 01/15] Revert "sandbox: remove os_putc() and os_puts()" Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 02/15] sandbox: Adjust pre-console address to avoid conflict Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 03/15] Revert "sandbox: Drop special case console code for sandbox" Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 04/15] Move debug and logging support to a separate header Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 05/15] mtdparts: Correct use of debug() Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,05/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 06/15] usb: " Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,06/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 07/15] Drop the log buffer Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,07/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 08/15] log: Add an implementation of logging Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 09/15] log: Add a console driver Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,09/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 10/15] log: Add a 'log level' command Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,10/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 11/15] log: Add a test command Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,11/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 12/15] log: Plumb logging into the init sequence Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 13/15] log: sandbox: Enable logging Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,13/15] " Tom Rini
2017-12-04 20:48 ` Simon Glass [this message]
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,14/15] log: test: Add a pytest for logging Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 15/15] log: Add documentation Simon Glass
2017-12-07 22:55 ` [U-Boot] [U-Boot,v4,15/15] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204204831.98915-15-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.