From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 10/15] log: Add a 'log level' command
Date: Mon, 4 Dec 2017 13:48:26 -0700 [thread overview]
Message-ID: <20171204204831.98915-11-sjg@chromium.org> (raw)
In-Reply-To: <20171204204831.98915-1-sjg@chromium.org>
Add a command for adjusting the log level.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
cmd/Kconfig | 7 +++++++
cmd/Makefile | 1 +
cmd/log.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 63 insertions(+)
create mode 100644 cmd/log.c
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 5a6afab99b..b745a7e977 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1502,6 +1502,13 @@ config CMD_KGDB
single-stepping, inspecting variables, etc. This is supported only
on PowerPC at present.
+config CMD_LOG
+ bool "log - Generation, control and access to logging"
+ help
+ This provides access to logging features. It allows the output of
+ log data to be controlled to a limited extent (setting up the default
+ maximum log level for emitting of records).
+
config CMD_TRACE
bool "trace - Support tracing of function calls and timing"
help
diff --git a/cmd/Makefile b/cmd/Makefile
index f9eb76090d..00e38696da 100644
--- a/cmd/Makefile
+++ b/cmd/Makefile
@@ -76,6 +76,7 @@ obj-$(CONFIG_LED_STATUS_CMD) += legacy_led.o
obj-$(CONFIG_CMD_LED) += led.o
obj-$(CONFIG_CMD_LICENSE) += license.o
obj-y += load.o
+obj-$(CONFIG_CMD_LOG) += log.o
obj-$(CONFIG_ID_EEPROM) += mac.o
obj-$(CONFIG_CMD_MD5SUM) += md5sum.o
obj-$(CONFIG_CMD_MEMORY) += mem.o
diff --git a/cmd/log.c b/cmd/log.c
new file mode 100644
index 0000000000..44e04ab16a
--- /dev/null
+++ b/cmd/log.c
@@ -0,0 +1,55 @@
+/*
+ * Copyright (c) 2017 Google, Inc
+ * Written by Simon Glass <sjg@chromium.org>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include <common.h>
+#include <command.h>
+#include <dm.h>
+#include <log.h>
+
+static int do_log_level(cmd_tbl_t *cmdtp, int flag, int argc,
+ char * const argv[])
+{
+ if (argc > 1)
+ gd->default_log_level = simple_strtol(argv[1], NULL, 10);
+ else
+ printf("Default log level: %d\n", gd->default_log_level);
+
+ return 0;
+}
+
+static cmd_tbl_t log_sub[] = {
+ U_BOOT_CMD_MKENT(level, CONFIG_SYS_MAXARGS, 1, do_log_level, "", ""),
+};
+
+static int do_log(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+{
+ cmd_tbl_t *cp;
+
+ if (argc < 2)
+ return CMD_RET_USAGE;
+
+ /* drop initial "log" arg */
+ argc--;
+ argv++;
+
+ cp = find_cmd_tbl(argv[0], log_sub, ARRAY_SIZE(log_sub));
+ if (cp)
+ return cp->cmd(cmdtp, flag, argc, argv);
+
+ return CMD_RET_USAGE;
+}
+
+#ifdef CONFIG_SYS_LONGHELP
+static char log_help_text[] =
+ "level - get/set log level\n"
+ ;
+#endif
+
+U_BOOT_CMD(
+ log, CONFIG_SYS_MAXARGS, 1, do_log,
+ "log system", log_help_text
+);
--
2.15.0.531.g2ccb3012c9-goog
next prev parent reply other threads:[~2017-12-04 20:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 20:48 [U-Boot] [PATCH v4 00/15] log: Add a new logging feature Simon Glass
2017-12-04 20:48 ` [U-Boot] [PATCH v4 01/15] Revert "sandbox: remove os_putc() and os_puts()" Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 02/15] sandbox: Adjust pre-console address to avoid conflict Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 03/15] Revert "sandbox: Drop special case console code for sandbox" Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 04/15] Move debug and logging support to a separate header Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 05/15] mtdparts: Correct use of debug() Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,05/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 06/15] usb: " Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,06/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 07/15] Drop the log buffer Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,07/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 08/15] log: Add an implementation of logging Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 09/15] log: Add a console driver Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,09/15] " Tom Rini
2017-12-04 20:48 ` Simon Glass [this message]
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,10/15] log: Add a 'log level' command Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 11/15] log: Add a test command Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,11/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 12/15] log: Plumb logging into the init sequence Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 13/15] log: sandbox: Enable logging Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,13/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 14/15] log: test: Add a pytest for logging Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,14/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 15/15] log: Add documentation Simon Glass
2017-12-07 22:55 ` [U-Boot] [U-Boot,v4,15/15] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204204831.98915-11-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.