From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 06/15] usb: Correct use of debug()
Date: Mon, 4 Dec 2017 13:48:22 -0700 [thread overview]
Message-ID: <20171204204831.98915-7-sjg@chromium.org> (raw)
In-Reply-To: <20171204204831.98915-1-sjg@chromium.org>
With clang this gives a warning because hubsts appears to be used before
it is set, even if ultimately it is not used. Simplify the code to avoid
this problem.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v4:
- Add new patch to correct use of debug() in usb_hub.c
Changes in v3: None
Changes in v2: None
common/usb_hub.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/common/usb_hub.c b/common/usb_hub.c
index 024dadb277..b46dfa16cc 100644
--- a/common/usb_hub.c
+++ b/common/usb_hub.c
@@ -625,7 +625,7 @@ static int usb_hub_configure(struct usb_device *dev)
short hubCharacteristics;
struct usb_hub_descriptor *descriptor;
struct usb_hub_device *hub;
- __maybe_unused struct usb_hub_status *hubsts;
+ struct usb_hub_status *hubsts;
int ret;
hub = usb_get_hub_device(dev);
@@ -779,9 +779,7 @@ static int usb_hub_configure(struct usb_device *dev)
return ret;
}
-#ifdef DEBUG
hubsts = (struct usb_hub_status *)buffer;
-#endif
debug("get_hub_status returned status %X, change %X\n",
le16_to_cpu(hubsts->wHubStatus),
--
2.15.0.531.g2ccb3012c9-goog
next prev parent reply other threads:[~2017-12-04 20:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 20:48 [U-Boot] [PATCH v4 00/15] log: Add a new logging feature Simon Glass
2017-12-04 20:48 ` [U-Boot] [PATCH v4 01/15] Revert "sandbox: remove os_putc() and os_puts()" Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 02/15] sandbox: Adjust pre-console address to avoid conflict Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 03/15] Revert "sandbox: Drop special case console code for sandbox" Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 04/15] Move debug and logging support to a separate header Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 05/15] mtdparts: Correct use of debug() Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,05/15] " Tom Rini
2017-12-04 20:48 ` Simon Glass [this message]
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,06/15] usb: " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 07/15] Drop the log buffer Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,07/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 08/15] log: Add an implementation of logging Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 09/15] log: Add a console driver Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,09/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 10/15] log: Add a 'log level' command Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,10/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 11/15] log: Add a test command Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,11/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 12/15] log: Plumb logging into the init sequence Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 13/15] log: sandbox: Enable logging Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,13/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 14/15] log: test: Add a pytest for logging Simon Glass
2017-12-07 22:54 ` [U-Boot] [U-Boot,v4,14/15] " Tom Rini
2017-12-04 20:48 ` [U-Boot] [PATCH v4 15/15] log: Add documentation Simon Glass
2017-12-07 22:55 ` [U-Boot] [U-Boot,v4,15/15] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204204831.98915-7-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.