Re: [PATCH 01/15] cxl/core: Add CXL.cache device struct

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] cxl: unused 'attach' parameter in __devm_cxl_add_cachedev()
--

commit 16ca3df82e8ba8b03985c5445d288c9759b9ba65
Author: Ben Cheatham <Benjamin.Cheatham@amd.com>

cxl/core: Add CXL.cache device struct

Add a new CXL.cache device (struct cxl_cachedev) that is the cache
analogue to struct cxl_memdev. This device will be created by CXL type
1 & 2 endpoint drivers to enable and manage the cache capabilities of
the underlying PCIe device via the CXL core.

> diff --git a/drivers/cxl/core/cachedev.c b/drivers/cxl/core/cachedev.c
> new file mode 100644
> index 0000000000000..3a7a60165f621
> --- /dev/null
> +++ b/drivers/cxl/core/cachedev.c
[ ... ]
> +struct cxl_cachedev *__devm_cxl_add_cachedev(struct cxl_dev_state *cxlds,
> +					     void *attach)

[Severity: Low]
Is it intentional that the attach parameter is completely ignored in the
implementation of __devm_cxl_add_cachedev() in drivers/cxl/core/cachedev.c?
Any data passed to it is silently discarded, which might cause API confusion.
Does it perhaps stem from an incomplete copy of __devm_cxl_add_memdev()?

> +{
> +	struct device *dev;
> +	int rc;
> +
> +	struct cxl_cachedev *cxlcd __free(put_cxlcd) =
> +		cxl_cachedev_alloc(cxlds);
[ ... ]
> diff --git a/drivers/cxl/cxlcache.h b/drivers/cxl/cxlcache.h
> new file mode 100644
> index 0000000000000..6ca887e078a1e
> --- /dev/null
> +++ b/drivers/cxl/cxlcache.h
[ ... ]
> +struct cxl_cachedev {
> +	struct device dev;
> +	struct cxl_dev_state *cxlds;
> +	struct cxl_port *endpoint;
> +	int id;
> +	int depth;
> +};

[Severity: Low]
Should struct cxl_cachedev in drivers/cxl/cxlcache.h have an attach member
to store the attachment data provided to __devm_cxl_add_cachedev()?

> +
> +bool is_cxl_cachedev(const struct device *dev);
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923173342.5584-1-Benjamin.Cheatham@amd.com?part=1