Re: [PATCH 02/15] PCI: Add an offset-indexed store for saved capability registers

[sashiko-bot@kernel.org]

> Add a per-device store for saved capability registers that is indexed by
> the offset of the register in configuration space, and whose values are
> allocated in one piece during device setup.
> 
> The store holds capability registers only. The configuration space header
> continues to be saved in pci_dev.saved_config_space, which is embedded in
> struct pci_dev so that saving it cannot fail.
> 
> Today each capability that has state to preserve across a reset owns a
> separate save buffer, allocated by pci_add_cap_save_buffer() and found
> by capability ID. The layout of each buffer is private to the code that
> saves and restores that capability: a dense array of whichever registers
> that code happens to save, in whichever order it saves them.
> 
> That has a few consequences:
> [ ... ]
> No capability uses this yet. Subsequent patches convert them one at a
> time, after which the per-capability buffers are removed.
> 
> Assisted-by: LLM
> Signed-off-by: David Matlack <dmatlack@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924173501.856380-1-dmatlack@google.com?part=2