Re: [PATCH 14/15] PCI: Save reserved capability registers in a single pass

[sashiko-bot@kernel.org]

> Every capability that the PCI core saves now reserves room for its
> registers during device setup, so the reservation bitmap already records
> exactly which configuration space DWORDs pci_save_state() has to read.
> Walk the bitmap once instead of dispatching to a save function per
> capability.
> 
> Values in the store are kept in ascending offset order, the same order
> that for_each_set_bit() visits the bitmap, so the generic pass fills
> slots sequentially and never has to look one up.
> 
> Delete pci_save_pcie_state(), pci_save_pcix_state(), pci_save_ltr_state(),
> pci_save_aer_state(), pci_save_ptm_state(), pci_save_tph_state(),
> pci_save_dpc_state() and pci_save_vc_state(), along with the PCI_VC_SAVE
> arm of the Virtual Channel walker and pci_save_cap_word(), which loses
> its last caller. Each of them existed only to rediscover offsets the
> [ ... ]
> was enabled. Restore keeps those guards, so the extra reads only make the
> store a more faithful snapshot.
> 
> Assisted-by: LLM
> Signed-off-by: David Matlack <dmatlack@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924173501.856380-1-dmatlack@google.com?part=14