Re: [PATCH 13/15] PCI/VC: Save VC state in the saved capability store

[sashiko-bot@kernel.org]

> Save and restore the Virtual Channel registers, including the VC and Port
> Arbitration Tables, through the per-device saved capability store instead
> of a private pci_cap_saved_state buffer.
> 
> Walking VC configuration space is complicated, so sizing, saving and
> restoring it were all folded into pci_vc_do_save_buffer() to guarantee they
> agreed on the buffer layout. Keep the walk shared: because the store is
> addressed by configuration space offset, the three passes now only have
> to agree on which registers exist, not on where each one lands in a
> buffer. Drop pci_vc_do_save_buffer()'s dual size/save/restore return
> value, its running length, its buffer cursor, and the sanity check that
> compared the two against each other, and rename it to
> pci_vc_do_saved_caps().
> 
> Rename pci_allocate_vc_save_buffers() to pci_vc_reserve_saved_caps() and
> make pci_save_vc_state() void, since neither allocates anything now.
> 
> The arbitration table offsets and sizes come from the device, so what it
> reports later need not match what was reserved during setup. Save or
> restore a table only if all of it was reserved, which keeps the request
> for hardware to re-load the VC Arbitration Table tied to having actually
> restored it, as the old code did by only walking the tables that were
> present in the buffer.
> 
> No functional change intended.
> 
> Assisted-by: LLM
> Signed-off-by: David Matlack <dmatlack@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924173501.856380-1-dmatlack@google.com?part=13