Re: [PATCH 03/15] PCI: Lay out struct pci_saved_state by configuration space offset

[sashiko-bot@kernel.org]

> Store a device's saved state as a bitmap of the configuration space DWORDs
> that were saved plus their values, instead of a copy of the configuration
> space header followed by a list of pci_cap_saved_data records.
> 
> The old layout is described entirely by the kernel: which capabilities have
> a record, how large each record is, and what each word within a record
> means are all properties of the code that happens to be saving them. That
> makes the blob impossible to interpret outside the kernel that produced it,
> which is a problem for VFIO, which needs to carry a device's saved state
> across a Live Update kexec. The new layout is described by the device: a
> value's position is the offset of its register in the device's own
> configuration space.
> 
> Keep refusing state that the device has nowhere to put in
> pci_load_saved_state(), the equivalent of the old check that the
> [ ... ]
> struct pci_saved_state is opaque to everything outside drivers/pci, so no
> caller needs to change.
> 
> Assisted-by: LLM
> Signed-off-by: David Matlack <dmatlack@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924173501.856380-1-dmatlack@google.com?part=3