Re: [PATCH v5 4/6] ASoC: SDCA: Create DAPM widgets and routes from DisCo

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

On 5/15/25 16:50, Charles Keepax wrote:
> On Wed, May 14, 2025 at 02:30:00PM +0100, Charles Keepax wrote:
>> On Wed, May 14, 2025 at 02:15:01PM +0200, Pierre-Louis Bossart wrote:
>>> Humm, that one doesn't seem right. There could be cases
>>> where the DETECTED_MODE is inconclusive, or that additional
>>> vendor-specific steps are needed to decide which SELECTED_MODE
>>> makes sense. I don't think we should assume everything is
>>> handled internally, or we have to define what 'internally'
>>> means. This cannot be generic SDCA stuff, it has to be
>>> configurable for specific implementations/vendors.
>>
>> Ok yeah I see, the current code reads the DETECTED_MODE in
>> the IRQ handler and then updates the selected mode. I guess
>> currently what is missing is the handling for the JACK_UNKNOWN
>> case, which could probably require user-space. I think it would
>> be pretty easy to export the DETECTED_MODE as well I will have a
>> look.
> 
> Should hopefully be able to send a new spin tomorrow. I have
> managed to include all the comments I think.
> 
> I started being a little more unsure on this DETECTED_MODE again,
> but I am going to go with forcing the export of DETECTED_MODE
> for now and we can revise later if we have a better plan.
> 
> My concerns really are most custom handling will actually
> want to live in the kernel, except the case where the system
> wants to present a dialog to the user to select the jack device
> manually. In that manual case I also can't see any reason why
> just setting the selected mode to unknown would not make the
> most sense, but the spec does not say the device should do that.

I am fine with a TODO on the DETECTED/SELECTED mode handling for now. I do recall discussions in the Audio Subgroup for the Retaskable Jack where there are just too many options and a basic driver would probably give up and say "undefined" for the DETECTED_MODE. For the UAJ mirroring the DETECTED_MODE and/or asking the user for input are probably the two most likely options.