Re: [PATCH v5 5/6] ASoC: SDCA: Create ALSA controls from DisCo

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

> +static bool exported_control(struct sdca_control *control)
> +{
> +	/* No need to export control for something that only has one value */
> +	if (control->has_fixed)
> +		return false;

why is that? It'd simplify userspace if there was always a way to get a value, even if it's fixed?

> +
> +	return control->layers & (SDCA_ACCESS_LAYER_USER |
> +				  SDCA_ACCESS_LAYER_APPLICATION);

That filter on access layer does make sense however.

> +}
> +
>  /**
>   * sdca_asoc_count_component - count the various component parts
>   * @function: Pointer to the Function information.
> @@ -76,6 +87,8 @@ static struct sdca_control_range *selector_find_range(struct device *dev,
>   * required number of DAPM widgets for the Function.
>   * @num_routes: Output integer pointer, will be filled with the
>   * required number of DAPM routes for the Function.
> + * @num_controls: Output integer pointer, will be filled with the
> + * required number of ALSA controls for the Function.
>   *
>   * This function counts various things within the SDCA Function such
>   * that the calling driver can allocate appropriate space before
> @@ -84,12 +97,13 @@ static struct sdca_control_range *selector_find_range(struct device *dev,
>   * Return: Returns zero on success, and a negative error code on failure.
>   */
>  int sdca_asoc_count_component(struct device *dev, struct sdca_function_data *function,
> -			      int *num_widgets, int *num_routes)
> +			      int *num_widgets, int *num_routes, int *num_controls)
>  {
> -	int i;
> +	int i, j;
>  
>  	*num_widgets = function->num_entities - 1;
>  	*num_routes = 0;
> +	*num_controls = 0;
>  
>  	for (i = 0; i < function->num_entities - 1; i++) {
>  		struct sdca_entity *entity = &function->entities[i];
> @@ -99,6 +113,7 @@ int sdca_asoc_count_component(struct device *dev, struct sdca_function_data *fun
>  		case SDCA_ENTITY_TYPE_OT:
>  			*num_routes += !!entity->iot.clock;
>  			*num_routes += !!entity->iot.is_dataport;
> +			*num_controls += !entity->iot.is_dataport;

shouldn't the same line be added for TYPE_IT?

>  			break;
>  		case SDCA_ENTITY_TYPE_PDE:
>  			*num_routes += entity->pde.num_managed;
> @@ -111,6 +126,11 @@ int sdca_asoc_count_component(struct device *dev, struct sdca_function_data *fun
>  
>  		if (entity->group)
>  			(*num_routes)++;
> +
> +		for (j = 0; j < entity->num_controls; j++) {
> +			if (exported_control(&entity->controls[j]))
> +				(*num_controls)++;
> +		}
>  	}
>  
>  	return 0;