Re: [PATCH v5 4/6] ASoC: SDCA: Create DAPM widgets and routes from DisCo

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Wed, May 14, 2025 at 02:33:23PM +0200, Pierre-Louis Bossart wrote:
> On 5/13/25 11:56, Charles Keepax wrote:
> > On Mon, May 12, 2025 at 03:46:40PM +0200, Pierre-Louis Bossart wrote:
> >> On 5/12/25 14:42, Charles Keepax wrote:
> > But as you can see the correlation to the function diagrams is
> > the spec is pretty good. As I noted with a few minor exceptions,
> > like the GE having more paths, since it must connect to all the
> > widgets it controls separately. And the DAI widgets that are
> > created by the DAPM core.
> 
> Thanks for the diagram, very useful indeed.
> 
> The only comment I'd have is that all SUs are represented
> as MUXes in this DAPM graph, but in practice most of them
> are simple on/off switches. The case of SU35 is one of the
> exceptions to the rule where it can have multiple inputs. I
> don't really mind if all SUs are represented as MUX, but it's
> not a direct mapping from the SDCA spec.

I mean I think we could special case 1 input versions as
switches but a) I am slightly concerned it might make sharing
them across a GE harder and b) I am not sure I see what it
really buys us.  Generally I prefer the code to not require
special casing for certain situations and there shouldn't be
any difference in the behaviour from switches or muxes.

Thanks,
Charles